<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>212438</bug_id>
          
          <creation_ts>2020-05-27 15:13:39 -0700</creation_ts>
          <short_desc>Improve comments about OS/PLATFORM(IOS) and friends</short_desc>
          <delta_ts>2020-05-27 16:15:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1656614</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-05-27 15:13:39 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1656615</commentid>
    <comment_count>1</comment_count>
      <attachid>400387</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-05-27 15:18:05 -0700</bug_when>
    <thetext>Created attachment 400387
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1656616</commentid>
    <comment_count>2</comment_count>
      <attachid>400387</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-05-27 15:19:47 -0700</bug_when>
    <thetext>Comment on attachment 400387
patch

Technically it should probably say &quot;iOS and iPadOS only&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1656631</commentid>
    <comment_count>3</comment_count>
      <attachid>400392</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-05-27 15:32:45 -0700</bug_when>
    <thetext>Created attachment 400392
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1656666</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-05-27 16:14:32 -0700</bug_when>
    <thetext>Committed r262223: &lt;https://trac.webkit.org/changeset/262223&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400392.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1656667</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-05-27 16:15:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/63694969&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>400387</attachid>
            <date>2020-05-27 15:18:05 -0700</date>
            <delta_ts>2020-05-27 15:32:45 -0700</delta_ts>
            <desc>patch</desc>
            <filename>b-backup.diff</filename>
            <type>text/plain</type>
            <size>1749</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyNjIyMTkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA1LTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJh
dGlAYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgY29tbWVudHMgYWJvdXQgT1MvUExBVEZP
Uk0oSU9TKSBhbmQgZnJpZW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MjEyNDM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1MZWdhY3kuaDoKKyAgICAgICAgKiB3dGYvUGxhdGZv
cm1PUy5oOgorCiAyMDIwLTA1LTI3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+
CiAKICAgICAgICAgQWRkIE9wdGlvblNldFRyYWl0czw+IGFuZCB1c2Ugd2l0aCBXZWJDb3JlOjpE
cmFnRGVzdGluYXRpb25BY3Rpb24KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtTGVnYWN5
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm1MZWdhY3kuaAkocmV2aXNp
b24gMjYyMjE5KQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm1MZWdhY3kuaAkod29ya2luZyBj
b3B5KQpAQCAtNTYsOCArNTYsMTAgQEAKICNkZWZpbmUgV1RGX1BMQVRGT1JNX01BQyAxCiAjZWxp
ZiBPUyhJT1NfRkFNSUxZKQogI2lmIE9TKElPUykKKy8qIFBMQVRGT1JNKElPUykgLSBpT1Mgb25s
eSAoaVBhZCBhbmQgaVBob25lKSwgbm90IGluY2x1ZGluZyBtYWNDYXRhbHlzdCwgbm90IGluY2x1
ZGluZyB3YXRjaE9TLCBub3QgaW5jbHVkaW5nIHR2T1MgKi8KICNkZWZpbmUgV1RGX1BMQVRGT1JN
X0lPUyAxCiAjZW5kaWYKKy8qIFBMQVRGT1JNKElPU19GQU1JTFkpIC0gaU9TIGZhbWlseSwgaW5j
bHVkaW5nIGlPUywgbWFjQ2F0YWx5c3QsIHR2T1MsIHdhdGNoT1MgKi8KICNkZWZpbmUgV1RGX1BM
QVRGT1JNX0lPU19GQU1JTFkgMQogI2lmIFRBUkdFVF9PU19TSU1VTEFUT1IKICNpZiBPUyhJT1Mp
CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybU9TLmgKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dURi93dGYvUGxhdGZvcm1PUy5oCShyZXZpc2lvbiAyNjIyMTkpCisrKyBTb3VyY2UvV1RGL3d0
Zi9QbGF0Zm9ybU9TLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcgKzYzLDcgQEAKICNkZWZpbmUg
V1RGX09TX0lPU19GQU1JTFkgMQogI2VuZGlmCiAKLS8qIE9TKElPUykgLSBpT1Mgb25seSwgbm90
IGluY2x1ZGluZyBtYWNDYXRhbHlzdCAqLworLyogT1MoSU9TKSAtIGlPUyBvbmx5IChpUGFkIGFu
ZCBpUGhvbmUpLCBub3QgaW5jbHVkaW5nIG1hY0NhdGFseXN0LCBub3QgaW5jbHVkaW5nIHdhdGNo
T1MsIG5vdCBpbmNsdWRpbmcgdHZPUyAqLwogI2lmIE9TKERBUldJTikgJiYgKFRBUkdFVF9PU19J
T1MgJiYgIShkZWZpbmVkKFRBUkdFVF9PU19NQUNDQVRBTFlTVCkgJiYgVEFSR0VUX09TX01BQ0NB
VEFMWVNUKSkKICNkZWZpbmUgV1RGX09TX0lPUyAxCiAjZW5kaWYK
</data>
<flag name="review"
          id="415799"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>400392</attachid>
            <date>2020-05-27 15:32:45 -0700</date>
            <delta_ts>2020-05-27 16:14:33 -0700</delta_ts>
            <desc>patch for landing</desc>
            <filename>b-backup.diff</filename>
            <type>text/plain</type>
            <size>2012</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyNjIyMTkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA1LTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJh
dGlAYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgY29tbWVudHMgYWJvdXQgT1MvUExBVEZP
Uk0oSU9TKSBhbmQgZnJpZW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MjEyNDM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKwor
ICAgICAgICAqIHd0Zi9QbGF0Zm9ybUxlZ2FjeS5oOgorICAgICAgICAqIHd0Zi9QbGF0Zm9ybU9T
Lmg6CisKIDIwMjAtMDUtMjcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAog
ICAgICAgICBBZGQgT3B0aW9uU2V0VHJhaXRzPD4gYW5kIHVzZSB3aXRoIFdlYkNvcmU6OkRyYWdE
ZXN0aW5hdGlvbkFjdGlvbgpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm1MZWdhY3kuaAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUxlZ2FjeS5oCShyZXZpc2lvbiAy
NjIyMTkpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUxlZ2FjeS5oCSh3b3JraW5nIGNvcHkp
CkBAIC01Niw4ICs1NiwxMCBAQAogI2RlZmluZSBXVEZfUExBVEZPUk1fTUFDIDEKICNlbGlmIE9T
KElPU19GQU1JTFkpCiAjaWYgT1MoSU9TKQorLyogUExBVEZPUk0oSU9TKSAtIGlPUyBhbmQgaVBh
ZE9TIG9ubHkgKGlQaG9uZSBhbmQgaVBhZCksIG5vdCBpbmNsdWRpbmcgbWFjQ2F0YWx5c3QsIG5v
dCBpbmNsdWRpbmcgd2F0Y2hPUywgbm90IGluY2x1ZGluZyB0dk9TICovCiAjZGVmaW5lIFdURl9Q
TEFURk9STV9JT1MgMQogI2VuZGlmCisvKiBQTEFURk9STShJT1NfRkFNSUxZKSAtIGlPUyBmYW1p
bHksIGluY2x1ZGluZyBpT1MsIGlQYWRPUywgbWFjQ2F0YWx5c3QsIHR2T1MsIHdhdGNoT1MgKi8K
ICNkZWZpbmUgV1RGX1BMQVRGT1JNX0lPU19GQU1JTFkgMQogI2lmIFRBUkdFVF9PU19TSU1VTEFU
T1IKICNpZiBPUyhJT1MpCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybU9TLmgKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm1PUy5oCShyZXZpc2lvbiAyNjIyMTkpCisr
KyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybU9TLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDEyICs1
OCwxMiBAQAogI2RlZmluZSBXVEZfT1NfREFSV0lOIDEKICNlbmRpZgogCi0vKiBPUyhJT1NfRkFN
SUxZKSAtIGlPUyBmYW1pbHksIGluY2x1ZGluZyBpT1MsIG1hY0NhdGFseXN0LCB0dk9TLCB3YXRj
aE9TICovCisvKiBPUyhJT1NfRkFNSUxZKSAtIGlPUyBmYW1pbHksIGluY2x1ZGluZyBpT1MsIGlQ
YWRPUywgbWFjQ2F0YWx5c3QsIHR2T1MsIHdhdGNoT1MgKi8KICNpZiBPUyhEQVJXSU4pICYmIFRB
UkdFVF9PU19JUEhPTkUKICNkZWZpbmUgV1RGX09TX0lPU19GQU1JTFkgMQogI2VuZGlmCiAKLS8q
IE9TKElPUykgLSBpT1Mgb25seSwgbm90IGluY2x1ZGluZyBtYWNDYXRhbHlzdCAqLworLyogT1Mo
SU9TKSAtIGlPUyBhbmQgaVBhZE9TIG9ubHkgKGlQaG9uZSBhbmQgaVBhZCksIG5vdCBpbmNsdWRp
bmcgbWFjQ2F0YWx5c3QsIG5vdCBpbmNsdWRpbmcgd2F0Y2hPUywgbm90IGluY2x1ZGluZyB0dk9T
ICovCiAjaWYgT1MoREFSV0lOKSAmJiAoVEFSR0VUX09TX0lPUyAmJiAhKGRlZmluZWQoVEFSR0VU
X09TX01BQ0NBVEFMWVNUKSAmJiBUQVJHRVRfT1NfTUFDQ0FUQUxZU1QpKQogI2RlZmluZSBXVEZf
T1NfSU9TIDEKICNlbmRpZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>