212425 2020-05-27 11:47:54 -0700 webkit-patch create-revert cannot handle reason string with Unicode characters (like smart quotes) 2020-06-06 21:16:52 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=212422 InRadar P2 Normal --- 1 ysuzuki webkit-unassigned aakash_jain ap ddkilzer jbedard webkit-bug-importer oldest_to_newest 1656486 0 ysuzuki 2020-05-27 11:47:54 -0700 If we pass non-ascii reason text to this command, it fails. Traceback (most recent call last): File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkit-patch", line 80, in <module> main() File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py", line 62, in run message = self._message_for_revert(state["revision_list"], state["reason"], state["description_list"], reverted_bug_url_list, revert_bug_url) File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py", line 48, in _message_for_revert message += "\"%s\"\n" % description_list[index] UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 79: ordinal not in range(128) 1656496 1 ddkilzer 2020-05-27 11:54:26 -0700 See: Bug 212422: REGRESSION(r260023): “Regression in ITP sparse plist decoding.” 1656499 2 ddkilzer 2020-05-27 11:55:49 -0700 Note that Slack appears to default to using smart quotes. 1656523 3 jbedard 2020-05-27 12:50:01 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Note that Slack appears to default to using smart quotes. We should fix this bug, but I also think that we should convert smart quotes to normal quotes. 1660039 4 webkit-bug-importer 2020-06-06 21:16:52 -0700 <rdar://problem/64081137>