212421 2020-05-27 11:26:37 -0700 -Wdeprecated-copy caused by Bitmap copy assignment operator 2020-05-27 13:16:18 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro benjamin cdumez cmarcelo ews-watchlist mark.lam mcatanzaro webkit-bug-importer oldest_to_newest 1656460 0 mcatanzaro 2020-05-27 11:26:37 -0700 Continued from bug #212190, r262030 introduced a warning spam with GCC: introduced a nice GCC warning spam: In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f0a787a9-2.cpp:5: /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysis.cpp:194:16: warning: implicitly-declared ‘constexpr WTF::Bitmap<4>::Bitmap(const WTF::Bitmap<4>&)’ is deprecated [-Wdeprecated-copy] 194 | return result; | ^~~~~~ because: DerivedSources/ForwardingHeaders/wtf/Bitmap.h:480:13: note: because ‘WTF::Bitmap<4>’ has user-provided ‘void WTF::Bitmap<bitmapSize, WordType>::operator=(const WTF::Bitmap<bitmapSize, WordType>&) [with long unsigned int bitmapSize = 4; WordType = unsigned int]’ 480 | inline void Bitmap<bitmapSize, WordType>::operator=(const Bitmap& other) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ To avoid the warning, we should either (a) remove the copy assignment operator, or (b) add a copy constructor. Either way would be fine, but in this case I'd prefer (a) because I don't think the new copy assignment operator is needed. It uses a loop to manually copy the bits of the sole member variable, a std::array, but a default copy of the array should be equivalent (and possibly also a bit faster). 1656462 1 400356 mcatanzaro 2020-05-27 11:31:46 -0700 Created attachment 400356 Patch 1656464 2 400356 mark.lam 2020-05-27 11:34:39 -0700 Comment on attachment 400356 Patch Removal of the assignment operator is not an option. This was added as a step for upcoming work. I'll need to take a closer look at what the GCC complaint is and decide what the best solution is. 1656479 3 400356 mark.lam 2020-05-27 11:45:36 -0700 Comment on attachment 400356 Patch I stand corrected. Michael pointed out on slack that the default assignment operator would take care of the job. There's no need for my hand written one. r=me if theAPI test bots are green. 1656525 4 400356 mark.lam 2020-05-27 12:51:57 -0700 Comment on attachment 400356 Patch API bots are green. Landing this. 1656537 5 ews-feeder 2020-05-27 13:15:52 -0700 Committed r262211: <https://trac.webkit.org/changeset/262211> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400356. 1656538 6 webkit-bug-importer 2020-05-27 13:16:18 -0700 <rdar://problem/63687389> 400356 2020-05-27 11:31:46 -0700 2020-05-27 13:15:53 -0700 Patch bug-212421-20200527133145.patch text/plain 1849 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA4YzYyMjk1NGRmMjIyZDQyNGY1Zjlh ODczM2JlODNlNTU4NzQ0M2MuLmY1MzBmYTE0ZTFhMTZhNDhmYTE3N2RkNzUxMzI0YTVkNGU1Nzkw ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDUtMjcgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgLVdkZXByZWNhdGVkLWNvcHkgY2F1c2Vk IGJ5IEJpdG1hcCBjb3B5IGFzc2lnbm1lbnQgb3BlcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjQyMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY29weSBhc3NpZ25tZW50IG9wZXJhdG9y IGlzIG5vdCBuZWVkZWQsIGFuZCBjYXVzZXMgd2FybmluZ3MgYmVjYXVzZSB3ZSBkbyBub3QgaGF2 ZSBhCisgICAgICAgIGNvcnJlc3BvbmRpbmcgY29weSBjb25zdHJ1Y3Rvci4gV2UgY291bGQgYWRk IGEgY29weSBjb25zdHJ1Y3RvciwgYnV0IGl0J3MgZWFzaWVzdCB0byBqdXN0CisgICAgICAgIHJl bW92ZSB0aGUgY29weSBhc3NpZ25tZW50IG9wZXJhdG9yLgorCisgICAgICAgICogd3RmL0JpdG1h cC5oOgorCiAyMDIwLTA1LTI2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBTb3J0IFBsYXRmb3JtRW5hYmxlQ29jb2EuaCBhbmQgYWRkIGRlZmluaXRpb25zIGZvciB0 aGUgc2ltcGxlIGNhc2VzIGZyb20gRmVhdHVyZURlZmluZXMueGNjb25maWcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL0JpdG1hcC5oIGIvU291cmNlL1dURi93dGYvQml0bWFwLmgKaW5kZXgg ZmExNGI1MWJiZWI3ZjZiZGNkMzRlODVjOTYyZGQ4ZTYwMmYwMzM5My4uMWEzYTY3N2NlODhlOTll N2NlMmJiNzk1MThmMWEzNmE3ZTQ3NzNhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQml0 bWFwLmgKKysrIGIvU291cmNlL1dURi93dGYvQml0bWFwLmgKQEAgLTEyNCw3ICsxMjQsNiBAQCBw dWJsaWM6CiAgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEJpdG1hcCYpIGNvbnN0OwogICAgIGJv b2wgb3BlcmF0b3IhPShjb25zdCBCaXRtYXAmKSBjb25zdDsKIAotICAgIHZvaWQgb3BlcmF0b3I9 KGNvbnN0IEJpdG1hcCYpOwogICAgIHZvaWQgb3BlcmF0b3J8PShjb25zdCBCaXRtYXAmKTsKICAg ICB2b2lkIG9wZXJhdG9yJj0oY29uc3QgQml0bWFwJik7CiAgICAgdm9pZCBvcGVyYXRvcl49KGNv bnN0IEJpdG1hcCYpOwpAQCAtNDc2LDEzICs0NzUsNiBAQCBpbmxpbmUgYm9vbCBCaXRtYXA8Yml0 bWFwU2l6ZSwgV29yZFR5cGU+OjpvcGVyYXRvciE9KGNvbnN0IEJpdG1hcCYgb3RoZXIpIGNvbnN0 CiAgICAgcmV0dXJuICEoKnRoaXMgPT0gb3RoZXIpOwogfQogCi10ZW1wbGF0ZTxzaXplX3QgYml0 bWFwU2l6ZSwgdHlwZW5hbWUgV29yZFR5cGU+Ci1pbmxpbmUgdm9pZCBCaXRtYXA8Yml0bWFwU2l6 ZSwgV29yZFR5cGU+OjpvcGVyYXRvcj0oY29uc3QgQml0bWFwJiBvdGhlcikKLXsKLSAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IHdvcmRzOyArK2kpCi0gICAgICAgIGJpdHNbaV0gPSBvdGhlci5i aXRzW2ldOwotfQotCiB0ZW1wbGF0ZTxzaXplX3QgYml0bWFwU2l6ZSwgdHlwZW5hbWUgV29yZFR5 cGU+CiBpbmxpbmUgdm9pZCBCaXRtYXA8Yml0bWFwU2l6ZSwgV29yZFR5cGU+OjpvcGVyYXRvcnw9 KGNvbnN0IEJpdG1hcCYgb3RoZXIpCiB7Cg==