212404 2020-05-27 05:06:21 -0700 [WPE] REGRESSION(r253675) Crash when using threaded rendering 2020-05-27 06:25:50 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cgarcia oldest_to_newest 1656338 0 magomez 2020-05-27 05:06:21 -0700 r253675 modified ImageBufferCairo::draw and ImageBufferCairo::drawPattern (currently ImageBufferCairoBackend::draw and ImageBufferCairoBackend::drawPattern) to use cairo and the platformContext to paint instead of using the GraphicsContext methods. While this is ok is most of the cases, when using threaded rendering, all the drawing must happen through the GraphicsContext so the rendering commands can be recorded and replayed afterwards. Even more, the GraphicsContextImpl used in this case is a CairoOperationRecorder, which doesn't even have a platformContext. So this ends crashing. 1656341 1 400322 magomez 2020-05-27 05:11:36 -0700 Created attachment 400322 Patch 1656352 2 ews-feeder 2020-05-27 06:25:49 -0700 Committed r262194: <https://trac.webkit.org/changeset/262194> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400322. 400322 2020-05-27 05:11:36 -0700 2020-05-27 06:25:49 -0700 Patch bug-212404-20200527141135.patch text/plain 3674 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmYyMjY4ODlhYTAyZmFi MzA1OTRjNGRhNTUzYWIxYTRmMzdiODFlNS4uYTZhMGJiMTllOTIxZDQ3YmIzYjk3YTM1ZmI1YWIw MDJiN2UxMmRjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTI3ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gUkVHUkVTU0lP TihyMjUzNjc1KSBDcmFzaCB3aGVuIHVzaW5nIHRocmVhZGVkIHJlbmRlcmluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNDA0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgd2hldGhlciB0aGUg R3JhcGhpY3NDb250ZXh0IGhhcyBhIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0IGJlZm9yZSB0cnlp bmcgdG8gcGFpbnQgd2l0aAorICAgICAgICBpdC4gSWYgdGhlcmUncyBubyBQbGF0Zm9ybUdyYXBo aWNzQ29udGV4dCwgcGFpbnQgdXNpbmcgdGhlIEdyYXBoaWNzQ29udGV4dCBtZXRob2RzIGluc3Rl YWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJv QmFja2VuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlckNhaXJvQmFja2VuZDo6 ZHJhdyk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlckNhaXJvQmFja2VuZDo6ZHJhd1Bh dHRlcm4pOgorCiAyMDIwLTA1LTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLNF0gTWFrZSBQb2ludGVyTG9jayB3b3JrCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNh aXJvQmFja2VuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9J bWFnZUJ1ZmZlckNhaXJvQmFja2VuZC5jcHAKaW5kZXggYTgxMDJmYWE1MTAzNWEwNTA1ZDA4ZGFi ZGZhNmE0Mjk0NTc1ZDI2NC4uZjkwNzEwNTZkMzE2Y2UwMjE1Y2M4ZjIyOGNmYjg3ZWQ4OTcxM2I1 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1h Z2VCdWZmZXJDYWlyb0JhY2tlbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm9CYWNrZW5kLmNwcApAQCAtNTQsNiArNTQsMTQg QEAgUmVmUHRyPEltYWdlPiBJbWFnZUJ1ZmZlckNhaXJvQmFja2VuZDo6Y29weUltYWdlKEJhY2tp bmdTdG9yZUNvcHkgY29weUJlaGF2aW9yLAogCiB2b2lkIEltYWdlQnVmZmVyQ2Fpcm9CYWNrZW5k OjpkcmF3KEdyYXBoaWNzQ29udGV4dCYgZGVzdENvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgZGVz dFJlY3QsIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgY29uc3QgSW1hZ2VQYWludGluZ09wdGlv bnMmIG9wdGlvbnMpCiB7CisgICAgaWYgKCFkZXN0Q29udGV4dC5oYXNQbGF0Zm9ybUNvbnRleHQo KSkgeworICAgICAgICAvLyBJZiB0aGVyZSdzIG5vIHBsYXRmb3JtQ29udGV4dCwgd2UncmUgdXNp bmcgdGhyZWFkZWQgcmVuZGVyaW5nLCBhbmQgYWxsIHRoZSBvcGVyYXRpb25zIG11c3QgYmUgZG9u ZQorICAgICAgICAvLyB0aHJvdWdoIHRoZSBHcmFwaGljc0NvbnRleHQuCisgICAgICAgIGF1dG8g aW1hZ2UgPSBjb3B5SW1hZ2UoJmRlc3RDb250ZXh0ID09ICZjb250ZXh0KCkgPyBDb3B5QmFja2lu Z1N0b3JlIDogRG9udENvcHlCYWNraW5nU3RvcmUpOworICAgICAgICBkZXN0Q29udGV4dC5kcmF3 SW1hZ2UoKmltYWdlLCBkZXN0UmVjdCwgc3JjUmVjdCwgb3B0aW9ucyk7CisgICAgICAgIHJldHVy bjsKKyAgICB9CisKICAgICBJbnRlcnBvbGF0aW9uUXVhbGl0eU1haW50YWluZXIgaW50ZXJwb2xh dGlvblF1YWxpdHlGb3JUaGlzU2NvcGUoZGVzdENvbnRleHQsIG9wdGlvbnMuaW50ZXJwb2xhdGlv blF1YWxpdHkoKSk7CiAgICAgY29uc3QgYXV0byYgZGVzdGluYXRpb25Db250ZXh0U3RhdGUgPSBk ZXN0Q29udGV4dC5zdGF0ZSgpOwogCkBAIC02MSw4ICs2OSwxNiBAQCB2b2lkIEltYWdlQnVmZmVy Q2Fpcm9CYWNrZW5kOjpkcmF3KEdyYXBoaWNzQ29udGV4dCYgZGVzdENvbnRleHQsIGNvbnN0IEZs b2F0UmVjdAogICAgICAgICBkcmF3TmF0aXZlSW1hZ2UoKmRlc3RDb250ZXh0LnBsYXRmb3JtQ29u dGV4dCgpLCBpbWFnZS5nZXQoKSwgZGVzdFJlY3QsIHNyY1JlY3QsIHsgb3B0aW9ucywgZGVzdGlu YXRpb25Db250ZXh0U3RhdGUuaW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eSB9LCBkZXN0aW5hdGlv bkNvbnRleHRTdGF0ZS5hbHBoYSwgV2ViQ29yZTo6Q2Fpcm86OlNoYWRvd1N0YXRlKGRlc3RpbmF0 aW9uQ29udGV4dFN0YXRlKSk7CiB9CiAKLXZvaWQgSW1hZ2VCdWZmZXJDYWlyb0JhY2tlbmQ6OmRy YXdQYXR0ZXJuKEdyYXBoaWNzQ29udGV4dCYgZGVzdENvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYg ZGVzdFJlY3QsIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNmb3Jt JiBwYXR0ZXJuVHJhbnNmb3JtLCBjb25zdCBGbG9hdFBvaW50JiBwaGFzZSwgY29uc3QgRmxvYXRT aXplJiwgY29uc3QgSW1hZ2VQYWludGluZ09wdGlvbnMmIG9wdGlvbnMpCit2b2lkIEltYWdlQnVm ZmVyQ2Fpcm9CYWNrZW5kOjpkcmF3UGF0dGVybihHcmFwaGljc0NvbnRleHQmIGRlc3RDb250ZXh0 LCBjb25zdCBGbG9hdFJlY3QmIGRlc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIGNv bnN0IEFmZmluZVRyYW5zZm9ybSYgcGF0dGVyblRyYW5zZm9ybSwgY29uc3QgRmxvYXRQb2ludCYg cGhhc2UsIGNvbnN0IEZsb2F0U2l6ZSYgc3BhY2luZywgY29uc3QgSW1hZ2VQYWludGluZ09wdGlv bnMmIG9wdGlvbnMpCiB7CisgICAgaWYgKCFkZXN0Q29udGV4dC5oYXNQbGF0Zm9ybUNvbnRleHQo KSkgeworICAgICAgICAvLyBJZiB0aGVyZSdzIG5vIHBsYXRmb3JtQ29udGV4dCwgd2UncmUgdXNp bmcgdGhyZWFkZWQgcmVuZGVyaW5nLCBhbmQgYWxsIHRoZSBvcGVyYXRpb25zIG11c3QgYmUgZG9u ZQorICAgICAgICAvLyB0aHJvdWdoIHRoZSBHcmFwaGljc0NvbnRleHQuCisgICAgICAgIGF1dG8g aW1hZ2UgPSBjb3B5SW1hZ2UoRG9udENvcHlCYWNraW5nU3RvcmUpOworICAgICAgICBpbWFnZS0+ ZHJhd1BhdHRlcm4oZGVzdENvbnRleHQsIGRlc3RSZWN0LCBzcmNSZWN0LCBwYXR0ZXJuVHJhbnNm b3JtLCBwaGFzZSwgc3BhY2luZywgb3B0aW9ucyk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisK ICAgICBpZiAoYXV0byBpbWFnZSA9IGNvcHlOYXRpdmVJbWFnZSgmZGVzdENvbnRleHQgPT0gJmNv bnRleHQoKSA/IENvcHlCYWNraW5nU3RvcmUgOiBEb250Q29weUJhY2tpbmdTdG9yZSkpCiAgICAg ICAgIENhaXJvOjpkcmF3UGF0dGVybigqZGVzdENvbnRleHQucGxhdGZvcm1Db250ZXh0KCksIGlt YWdlLmdldCgpLCBtX2xvZ2ljYWxTaXplLCBkZXN0UmVjdCwgc3JjUmVjdCwgcGF0dGVyblRyYW5z Zm9ybSwgcGhhc2UsIG9wdGlvbnMpOwogfQo=