212395 2020-05-26 18:46:31 -0700 Web Inspector: ⌘G should not override the current query of the find banner if it's visible 2020-05-26 19:43:12 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 113588 1 hi hi hi inspector-bugzilla-changes simon.fraser webkit-bug-importer oldest_to_newest 1656244 0 hi 2020-05-26 18:46:31 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. search (⌘F) in the Elements Tab 3. press ⌘G => search query in find banner changes to the current pasteboard string and the search resets, instead of just going to the next search result 1656248 1 400292 hi 2020-05-26 18:54:38 -0700 Created attachment 400292 Patch 1656262 2 ews-feeder 2020-05-26 19:42:19 -0700 Committed r262173: <https://trac.webkit.org/changeset/262173> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400292. 1656263 3 webkit-bug-importer 2020-05-26 19:43:12 -0700 <rdar://problem/63656597> 400292 2020-05-26 18:54:38 -0700 2020-05-26 19:42:19 -0700 Patch bug-212395-20200526195437.patch text/plain 3493 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZlNjBjZjM1OWE4NjJhZmMzYWI3ZDdmNTUxNTBi ZTBmNTViNzQxNjEuLmQ4YWZkYWQ1YTM2ZDcyZTk1MzBmY2M2OWE0MmU3ZjIwMDE1ZjQ0NTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTI2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiDi jJhHIHNob3VsZCBub3Qgb3ZlcnJpZGUgdGhlIGN1cnJlbnQgcXVlcnkgb2YgdGhlIGZpbmQgYmFu bmVyIGlmIGl0J3MgdmlzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjEyMzk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRCcm93c2VyLmpzOgorICAg ICAgICAoV0kuQ29udGVudEJyb3dzZXIucHJvdG90eXBlLmFzeW5jIGhhbmRsZUZpbmROZXh0U2hv cnRjdXQpOgorICAgICAgICAoV0kuQ29udGVudEJyb3dzZXIucHJvdG90eXBlLmFzeW5jIGhhbmRs ZUZpbmRQcmV2aW91c1Nob3J0Y3V0KToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xv Z0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLmhp Z2hsaWdodFByZXZpb3VzU2VhcmNoTWF0Y2gpOgorICAgICAgICAoV0kuTG9nQ29udGVudFZpZXcu cHJvdG90eXBlLmhpZ2hsaWdodE5leHRTZWFyY2hNYXRjaCk6CisKIDIwMjAtMDUtMjIgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0 b3JhZ2U6IGRvbid0IHJlcXVlc3QgdGhlIGxpc3Qgb2YgSW5kZXhlZERCIGRhdGFiYXNlIG5hbWVz IG11bHRpcGxlIHRpbWVzIGZvciB0aGUgc2FtZSBzZWN1cml0eSBvcmlnaW4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRCcm93c2Vy LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJy b3dzZXIuanMKaW5kZXggMDQ5YTQ3MTQ1NWIwNTM5ZmQ5OTBlYTQxZTYzOTM4Mzk4NWUzNGVkNC4u NzA2NzVhYTdjZGE4MGViMjQ0NzEyZGIwYWViMGIwYzMwZGY2NmFmNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJyb3dzZXIuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJy b3dzZXIuanMKQEAgLTI2Miw3ICsyNjIsNyBAQCBXSS5Db250ZW50QnJvd3NlciA9IGNsYXNzIENv bnRlbnRCcm93c2VyIGV4dGVuZHMgV0kuVmlldwogCiAgICAgYXN5bmMgaGFuZGxlRmluZE5leHRT aG9ydGN1dCgpCiAgICAgewotICAgICAgICBpZiAodGhpcy5fZmluZEJhbm5lci5zZWFyY2hRdWVy eSAhPT0gV0kuZmluZFN0cmluZykgeworICAgICAgICBpZiAoIXRoaXMuX2ZpbmRCYW5uZXIuc2hv d2luZyAmJiB0aGlzLl9maW5kQmFubmVyLnNlYXJjaFF1ZXJ5ICE9PSBXSS5maW5kU3RyaW5nKSB7 CiAgICAgICAgICAgICBsZXQgc2VhcmNoUXVlcnkgPSBXSS5maW5kU3RyaW5nOwogICAgICAgICAg ICAgdGhpcy5fZmluZEJhbm5lci5zZWFyY2hRdWVyeSA9IHNlYXJjaFF1ZXJ5OwogCkBAIC0yODAs NyArMjgwLDcgQEAgV0kuQ29udGVudEJyb3dzZXIgPSBjbGFzcyBDb250ZW50QnJvd3NlciBleHRl bmRzIFdJLlZpZXcKIAogICAgIGFzeW5jIGhhbmRsZUZpbmRQcmV2aW91c1Nob3J0Y3V0KCkKICAg ICB7Ci0gICAgICAgIGlmICh0aGlzLl9maW5kQmFubmVyLnNlYXJjaFF1ZXJ5ICE9PSBXSS5maW5k U3RyaW5nKSB7CisgICAgICAgIGlmICghdGhpcy5fZmluZEJhbm5lci5zaG93aW5nICYmIHRoaXMu X2ZpbmRCYW5uZXIuc2VhcmNoUXVlcnkgIT09IFdJLmZpbmRTdHJpbmcpIHsKICAgICAgICAgICAg IGxldCBzZWFyY2hRdWVyeSA9IFdJLmZpbmRTdHJpbmc7CiAgICAgICAgICAgICB0aGlzLl9maW5k QmFubmVyLnNlYXJjaFF1ZXJ5ID0gc2VhcmNoUXVlcnk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMK aW5kZXggY2U3YmE2OGI4MGJmNGFlYjU5ODRjNDBkZmVkYWI1YTRkNDhkNzhiOS4uMTE4ZmY5MDUz YjFhZjdiMzY2NDdlOTY0OGNlYWFjOTgzZWY0MDkwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMK QEAgLTMyMyw3ICszMjMsNyBAQCBXSS5Mb2dDb250ZW50VmlldyA9IGNsYXNzIExvZ0NvbnRlbnRW aWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKIAogICAgIGhpZ2hsaWdodFByZXZpb3VzU2VhcmNo TWF0Y2goKQogICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLmhhc1BlcmZvcm1lZFNlYXJjaCB8fCB0 aGlzLl9maW5kQmFubmVyLnNlYXJjaFF1ZXJ5ICE9PSBXSS5maW5kU3RyaW5nKSB7CisgICAgICAg IGlmICghdGhpcy5oYXNQZXJmb3JtZWRTZWFyY2ggfHwgKCF0aGlzLl9maW5kQmFubmVyLnNob3dp bmcgJiYgdGhpcy5fZmluZEJhbm5lci5zZWFyY2hRdWVyeSAhPT0gV0kuZmluZFN0cmluZykpIHsK ICAgICAgICAgICAgIHRoaXMuX2ZpbmRCYW5uZXIuc2VhcmNoUXVlcnkgPSBXSS5maW5kU3RyaW5n OwogCiAgICAgICAgICAgICB0aGlzLnBlcmZvcm1TZWFyY2godGhpcy5fZmluZEJhbm5lci5zZWFy Y2hRdWVyeSk7CkBAIC0zNDMsNyArMzQzLDcgQEAgV0kuTG9nQ29udGVudFZpZXcgPSBjbGFzcyBM b2dDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWV3CiAKICAgICBoaWdobGlnaHROZXh0 U2VhcmNoTWF0Y2goKQogICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLmhhc1BlcmZvcm1lZFNlYXJj aCB8fCB0aGlzLl9maW5kQmFubmVyLnNlYXJjaFF1ZXJ5ICE9PSBXSS5maW5kU3RyaW5nKSB7Cisg ICAgICAgIGlmICghdGhpcy5oYXNQZXJmb3JtZWRTZWFyY2ggfHwgKCF0aGlzLl9maW5kQmFubmVy LnNob3dpbmcgJiYgdGhpcy5fZmluZEJhbm5lci5zZWFyY2hRdWVyeSAhPT0gV0kuZmluZFN0cmlu ZykpIHsKICAgICAgICAgICAgIHRoaXMuX2ZpbmRCYW5uZXIuc2VhcmNoUXVlcnkgPSBXSS5maW5k U3RyaW5nOwogCiAgICAgICAgICAgICB0aGlzLnBlcmZvcm1TZWFyY2godGhpcy5fZmluZEJhbm5l ci5zZWFyY2hRdWVyeSk7Cg==