212386 2020-05-26 14:51:59 -0700 Enhance Bitmap::setEachNthBit() to also take an end index. 2020-05-26 16:34:24 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist rmorisset webkit-bug-importer oldest_to_newest 1656188 0 mark.lam 2020-05-26 14:51:59 -0700 Previously, it was only taking the n interval, and the start index. 1656189 1 webkit-bug-importer 2020-05-26 14:52:24 -0700 <rdar://problem/63643324> 1656194 2 400279 mark.lam 2020-05-26 14:57:40 -0700 Created attachment 400279 proposed patch. 1656199 3 400279 rmorisset 2020-05-26 15:13:20 -0700 Comment on attachment 400279 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=400279&action=review r=me > Source/WTF/wtf/Bitmap.h:436 > + ASSERT(start <= end && end <= bitmapSize); The first ASSERT is redundant, and I would split the other ASSERT into two for better error messages. 1656204 4 400279 mark.lam 2020-05-26 15:16:57 -0700 Comment on attachment 400279 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=400279&action=review >> Source/WTF/wtf/Bitmap.h:436 >> + ASSERT(start <= end && end <= bitmapSize); > > The first ASSERT is redundant, and I would split the other ASSERT into two for better error messages. Will fix. 1656225 5 mark.lam 2020-05-26 16:34:09 -0700 Thanks for the review. Landed in r262167: <http://trac.webkit.org/r262167>. 400279 2020-05-26 14:57:40 -0700 2020-05-26 16:34:24 -0700 proposed patch. bug-212386.patch text/plain 6815 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjIxNTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA1LTI2ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBFbmhhbmNlIEJpdG1hcDo6c2V0RWFjaE50aEJpdCgpIHRv IGFsc28gdGFrZSBhbiBlbmQgaW5kZXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTIzODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYzNjQzMzI0 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZp b3VzbHksIGl0IHdhcyBvbmx5IHRha2luZyB0aGUgbiBpbnRlcnZhbCwgYW5kIHRoZSBzdGFydCBp bmRleC4KKyAgICAgICAgQWxzbyBmaXhlZCBpc0VtcHR5KCkgYW5kIGlzRnVsbCgpIHRvIHJldHVy biBhIGJvb2wgaW5zdGVhZCBvZiBzaXplX3QuCisKKyAgICAgICAgKiB3dGYvQml0bWFwLmg6Cisg ICAgICAgIChXVEY6OldvcmRUeXBlPjo6aXNFbXB0eSBjb25zdCk6CisgICAgICAgIChXVEY6Oldv cmRUeXBlPjo6aXNGdWxsIGNvbnN0KToKKyAgICAgICAgKFdURjo6V29yZFR5cGU+OjpzZXRFYWNo TnRoQml0KToKKwogMjAyMC0wNS0yNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIEV4cG9zZSBtb3JlIG5ldHdvcmsgbWV0cmljcyB0byBXZWJD b3JlTlNVUkxTZXNzaW9uCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9CaXRtYXAuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV1RGL3d0Zi9CaXRtYXAuaAkocmV2aXNpb24gMjYyMTUzKQorKysgU291cmNl L1dURi93dGYvQml0bWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDggKzU4LDggQEAgcHVibGlj OgogICAgIHZvaWQgaW52ZXJ0KCk7CiAgICAgaW50NjRfdCBmaW5kUnVuT2ZaZXJvcyhzaXplX3Qg cnVuTGVuZ3RoKSBjb25zdDsKICAgICBzaXplX3QgY291bnQoc2l6ZV90IHN0YXJ0ID0gMCkgY29u c3Q7Ci0gICAgc2l6ZV90IGlzRW1wdHkoKSBjb25zdDsKLSAgICBzaXplX3QgaXNGdWxsKCkgY29u c3Q7CisgICAgYm9vbCBpc0VtcHR5KCkgY29uc3Q7CisgICAgYm9vbCBpc0Z1bGwoKSBjb25zdDsK ICAgICAKICAgICB2b2lkIG1lcmdlKGNvbnN0IEJpdG1hcCYpOwogICAgIHZvaWQgZmlsdGVyKGNv bnN0IEJpdG1hcCYpOwpAQCAtMTE5LDcgKzExOSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIG1lcmdl QW5kQ2xlYXIoQml0bWFwJik7CiAgICAgdm9pZCBzZXRBbmRDbGVhcihCaXRtYXAmKTsKIAotICAg IHZvaWQgc2V0RWFjaE50aEJpdChzaXplX3Qgc3RhcnQsIHNpemVfdCBuKTsKKyAgICB2b2lkIHNl dEVhY2hOdGhCaXQoc2l6ZV90IG4sIHNpemVfdCBzdGFydCA9IDAsIHNpemVfdCBlbmQgPSBiaXRt YXBTaXplKTsKIAogICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBCaXRtYXAmKSBjb25zdDsKICAg ICBib29sIG9wZXJhdG9yIT0oY29uc3QgQml0bWFwJikgY29uc3Q7CkBAIC0yOTMsNyArMjkzLDcg QEAgaW5saW5lIHNpemVfdCBCaXRtYXA8Yml0bWFwU2l6ZSwgV29yZFR5cAogfQogCiB0ZW1wbGF0 ZTxzaXplX3QgYml0bWFwU2l6ZSwgdHlwZW5hbWUgV29yZFR5cGU+Ci1pbmxpbmUgc2l6ZV90IEJp dG1hcDxiaXRtYXBTaXplLCBXb3JkVHlwZT46OmlzRW1wdHkoKSBjb25zdAoraW5saW5lIGJvb2wg Qml0bWFwPGJpdG1hcFNpemUsIFdvcmRUeXBlPjo6aXNFbXB0eSgpIGNvbnN0CiB7CiAgICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCB3b3JkczsgKytpKQogICAgICAgICBpZiAoYml0c1tpXSkKQEAg LTMwMiw3ICszMDIsNyBAQCBpbmxpbmUgc2l6ZV90IEJpdG1hcDxiaXRtYXBTaXplLCBXb3JkVHlw CiB9CiAKIHRlbXBsYXRlPHNpemVfdCBiaXRtYXBTaXplLCB0eXBlbmFtZSBXb3JkVHlwZT4KLWlu bGluZSBzaXplX3QgQml0bWFwPGJpdG1hcFNpemUsIFdvcmRUeXBlPjo6aXNGdWxsKCkgY29uc3QK K2lubGluZSBib29sIEJpdG1hcDxiaXRtYXBTaXplLCBXb3JkVHlwZT46OmlzRnVsbCgpIGNvbnN0 CiB7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB3b3JkczsgKytpKQogICAgICAgICBpZiAo fmJpdHNbaV0pIHsKQEAgLTQzMCwxMiArNDMwLDE1IEBAIGlubGluZSB2b2lkIEJpdG1hcDxiaXRt YXBTaXplLCBXb3JkVHlwZT4KIH0KIAogdGVtcGxhdGU8c2l6ZV90IGJpdG1hcFNpemUsIHR5cGVu YW1lIFdvcmRUeXBlPgotaW5saW5lIHZvaWQgQml0bWFwPGJpdG1hcFNpemUsIFdvcmRUeXBlPjo6 c2V0RWFjaE50aEJpdChzaXplX3Qgc3RhcnQsIHNpemVfdCBuKQoraW5saW5lIHZvaWQgQml0bWFw PGJpdG1hcFNpemUsIFdvcmRUeXBlPjo6c2V0RWFjaE50aEJpdChzaXplX3Qgbiwgc2l6ZV90IHN0 YXJ0LCBzaXplX3QgZW5kKQogewotICAgIHNpemVfdCBpbmRleCA9IHN0YXJ0OwotICAgIHNpemVf dCB3b3JkSW5kZXggPSBpbmRleCAvIHdvcmRTaXplOwotICAgIGluZGV4ID0gaW5kZXggLSB3b3Jk SW5kZXggKiB3b3JkU2l6ZTsKLSAgICB3aGlsZSAod29yZEluZGV4IDwgd29yZHMpIHsKKyAgICBB U1NFUlQoc3RhcnQgPD0gYml0bWFwU2l6ZSk7CisgICAgQVNTRVJUKHN0YXJ0IDw9IGVuZCAmJiBl bmQgPD0gYml0bWFwU2l6ZSk7CisKKyAgICBzaXplX3Qgd29yZEluZGV4ID0gc3RhcnQgLyB3b3Jk U2l6ZTsKKyAgICBzaXplX3QgZW5kV29yZEluZGV4ID0gZW5kIC8gd29yZFNpemU7CisgICAgc2l6 ZV90IGluZGV4ID0gc3RhcnQgLSB3b3JkSW5kZXggKiB3b3JkU2l6ZTsKKyAgICB3aGlsZSAod29y ZEluZGV4IDwgZW5kV29yZEluZGV4KSB7CiAgICAgICAgIHdoaWxlIChpbmRleCA8IHdvcmRTaXpl KSB7CiAgICAgICAgICAgICBiaXRzW3dvcmRJbmRleF0gfD0gKG9uZSA8PCBpbmRleCk7CiAgICAg ICAgICAgICBpbmRleCArPSBuOwpAQCAtNDQzLDYgKzQ0NiwxMyBAQCBpbmxpbmUgdm9pZCBCaXRt YXA8Yml0bWFwU2l6ZSwgV29yZFR5cGU+CiAgICAgICAgIGluZGV4IC09IHdvcmRTaXplOwogICAg ICAgICB3b3JkSW5kZXgrKzsKICAgICB9CisKKyAgICBzaXplX3QgZW5kSW5kZXggPSBlbmQgLSBl bmRXb3JkSW5kZXggKiB3b3JkU2l6ZTsKKyAgICB3aGlsZSAoaW5kZXggPCBlbmRJbmRleCkgewor ICAgICAgICBiaXRzW3dvcmRJbmRleF0gfD0gKG9uZSA8PCBpbmRleCk7CisgICAgICAgIGluZGV4 ICs9IG47CisgICAgfQorCiAgICAgaWYgY29uc3RleHByICghIShiaXRtYXBTaXplICUgd29yZFNp emUpKSB7CiAgICAgICAgIGNvbnN0ZXhwciBzaXplX3QgcmVtYWluaW5nQml0cyA9IGJpdG1hcFNp emUgJSB3b3JkU2l6ZTsKICAgICAgICAgY29uc3RleHByIFdvcmRUeXBlIG1hc2sgPSAoc3RhdGlj X2Nhc3Q8V29yZFR5cGU+KDEpIDw8IHJlbWFpbmluZ0JpdHMpIC0gMTsKSW5kZXg6IFRvb2xzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MjE2MikK KysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIw LTA1LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBFbmhhbmNl IEJpdG1hcDo6c2V0RWFjaE50aEJpdCgpIHRvIGFsc28gdGFrZSBhbiBlbmQgaW5kZXguCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIzODYKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzYzNjQzMzI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvQml0bWFwLmNw cDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OnRlc3RCaXRtYXBTZXRFYWNoTnRoQml0SW1wbCk6 CisKIDIwMjAtMDUtMjYgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+ CiAKICAgICAgICAgW1dpbkNhaXJvXVtXSzJdIFVzZSBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBl ciBmb3IgQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmcgbW9kZQpJbmRleDogVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvQml0bWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dURi9CaXRtYXAuY3BwCShyZXZpc2lvbiAyNjIxNTMpCisrKyBUb29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dURi9CaXRtYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05ODEsMjcg Kzk4MSw0NCBAQCB2b2lkIHRlc3RCaXRtYXBTZXRFYWNoTnRoQml0SW1wbChzaXplX3QgCiAgICAg Qml0bWFwIHRlbXA7CiAKICAgICBFWFBFQ1RfVFJVRSh0ZW1wID09IHplcm9lcyk7Ci0gICAgdGVt cC5zZXRFYWNoTnRoQml0KDAsIDEpOworICAgIHRlbXAuc2V0RWFjaE50aEJpdCgxKTsKICAgICBF WFBFQ1RfVFJVRSh0ZW1wID09IG9uZXMpOwogCiAgICAgc2l6ZV90IG5WYWx1ZXNbXSA9IHsgMSwg Miwgd29yZFNpemUgLyAyLCB3b3JkU2l6ZSAtIDEsIHdvcmRTaXplLCBzaXplIC8gMiwgc2l6ZSAt IDEsIHNpemUgfTsKICAgICBzaXplX3QgblZhbHVlc0NvdW50ID0gc2l6ZW9mKG5WYWx1ZXMpIC8g c2l6ZW9mKG5WYWx1ZXNbMF0pOwogCi0gICAgZm9yIChzaXplX3Qgc3RhcnQgPSAwOyBzdGFydCA8 IHdvcmRTaXplOyArK3N0YXJ0KSB7Ci0gICAgICAgIGZvciAoc2l6ZV90IGogPSAwOyBqIDwgblZh bHVlc0NvdW50OyArK2opIHsKLSAgICAgICAgICAgIHNpemVfdCBuID0gblZhbHVlc1tqXTsKLSAg ICAgICAgICAgIHRlbXAuY2xlYXJBbGwoKTsKLSAgICAgICAgICAgIHRlbXAuc2V0RWFjaE50aEJp dChzdGFydCwgbik7Ci0KLSAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgc3RhcnQ7 ICsraSkKLSAgICAgICAgICAgICAgICBFWFBFQ1RfRkFMU0UodGVtcC5nZXQoaSkpOwotCi0gICAg ICAgICAgICBzaXplX3QgY291bnQgPSAwOwotICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IHN0 YXJ0OyBpIDwgc2l6ZTsgKytpKSB7Ci0gICAgICAgICAgICAgICAgYm9vbCBleHBlY3RlZCA9ICFj b3VudDsKLSAgICAgICAgICAgICAgICBFWFBFQ1RfVFJVRSh0ZW1wLmdldChpKSA9PSBleHBlY3Rl ZCk7Ci0gICAgICAgICAgICAgICAgY291bnQrKzsKLSAgICAgICAgICAgICAgICBjb3VudCA9IGNv dW50ICUgbjsKKyAgICBzaXplX3Qgc3RhcnRFbmRWYWx1ZXNbXSA9IHsgMCwgMSwgMiwgd29yZFNp emUgLyAyLCB3b3JkU2l6ZSAtIDEsIHdvcmRTaXplLCBzaXplIC8gMiwgc2l6ZSAtIDEsIHNpemUg fTsKKyAgICBjb25zdGV4cHIgc2l6ZV90IG51bWJlck9mU3RhcnRFbmRWYWx1ZXMgPSBzaXplb2Yo c3RhcnRFbmRWYWx1ZXMpIC8gc2l6ZW9mKHN0YXJ0RW5kVmFsdWVzWzBdKTsKKworICAgIGZvciAo c2l6ZV90IHN0YXJ0ID0gMDsgc3RhcnQgPCBudW1iZXJPZlN0YXJ0RW5kVmFsdWVzOyArK3N0YXJ0 KSB7CisgICAgICAgIGZvciAoc2l6ZV90IGVuZCA9IHN0YXJ0OyBlbmQgPCBudW1iZXJPZlN0YXJ0 RW5kVmFsdWVzOyArK2VuZCkgeworICAgICAgICAgICAgc2l6ZV90IHN0YXJ0SW5kZXggPSBzdGFy dEVuZFZhbHVlc1tzdGFydF07CisgICAgICAgICAgICBzaXplX3QgZW5kSW5kZXggPSBzdGFydEVu ZFZhbHVlc1tlbmRdOworICAgICAgICAgICAgaWYgKGVuZEluZGV4IDwgc3RhcnRJbmRleCkKKyAg ICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIGlmIChzdGFydEluZGV4ID4gc2l6 ZSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIGlmIChlbmRJbmRleCA+ IHNpemUpCisgICAgICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgICAgIGZvciAoc2l6 ZV90IGogPSAwOyBqIDwgblZhbHVlc0NvdW50OyArK2opIHsKKyAgICAgICAgICAgICAgICBzaXpl X3QgbiA9IG5WYWx1ZXNbal07CisgICAgICAgICAgICAgICAgdGVtcC5jbGVhckFsbCgpOworICAg ICAgICAgICAgICAgIHRlbXAuc2V0RWFjaE50aEJpdChuLCBzdGFydEluZGV4LCBlbmRJbmRleCk7 CisKKyAgICAgICAgICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHN0YXJ0SW5kZXg7ICsr aSkKKyAgICAgICAgICAgICAgICAgICAgRVhQRUNUX0ZBTFNFKHRlbXAuZ2V0KGkpKTsKKworICAg ICAgICAgICAgICAgIHNpemVfdCBjb3VudCA9IDA7CisgICAgICAgICAgICAgICAgZm9yIChzaXpl X3QgaSA9IHN0YXJ0SW5kZXg7IGkgPCBlbmRJbmRleDsgKytpKSB7CisgICAgICAgICAgICAgICAg ICAgIGJvb2wgZXhwZWN0ZWQgPSAhY291bnQ7CisgICAgICAgICAgICAgICAgICAgIEVYUEVDVF9U UlVFKHRlbXAuZ2V0KGkpID09IGV4cGVjdGVkKTsKKyAgICAgICAgICAgICAgICAgICAgY291bnQr KzsKKyAgICAgICAgICAgICAgICAgICAgY291bnQgPSBjb3VudCAlIG47CisgICAgICAgICAgICAg ICAgfQorCisgICAgICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IGVuZEluZGV4OyBpIDwgc2l6 ZTsgKytpKQorICAgICAgICAgICAgICAgICAgICBFWFBFQ1RfRkFMU0UodGVtcC5nZXQoaSkpOwog ICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQo=