212363 2020-05-25 19:48:37 -0700 [iOS] ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink is failing consistently 2020-05-25 21:49:03 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin dino megan_gardner thorton webkit-bug-importer oldest_to_newest 1655958 0 wenson_hsieh 2020-05-25 19:48:37 -0700 <rdar://problem/63508866> 1655959 1 400225 wenson_hsieh 2020-05-25 19:55:52 -0700 Created attachment 400225 Patch 1655965 2 400227 wenson_hsieh 2020-05-25 20:34:21 -0700 Created attachment 400227 Fix non-internal build 1655975 3 ews-feeder 2020-05-25 21:49:02 -0700 Committed r262136: <https://trac.webkit.org/changeset/262136> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400227. 400225 2020-05-25 19:55:52 -0700 2020-05-25 20:34:20 -0700 Patch bug-212363-20200525195552.patch text/plain 2711 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWZiYTk2YTU0OTQ2ODEzNDgzZDE1ZWQyZjI2YmQzY2M5 ZmQxOWY0My4uZGFhZjdlMTY3YzU0ZWRkZGM1ODlhOGVlNzU0NTk2OTkwZDM4NDJmNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDIwLTA1LTI1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1NdIEFjdGlvblNoZWV0VGVzdHMuRGF0YURldGVjdG9yc0xpbmtJc05vdFBy ZXNlbnRlZEFzQUxpbmsgaXMgZmFpbGluZyBjb25zaXN0ZW50bHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjM2MworICAgICAgICA8cmRhcjovL3By b2JsZW0vNjM1MDg4NjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyB0ZXN0IGJlZ2FuIHRvIGNvbnNpc3RlbnRseSB0aHJvdyBhbiBleGNlcHRp b24gYWZ0ZXIgPGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3IyNjExNTc+LCBkdWUgdG8gaG93Cisg ICAgICAgIFVzZXJJbnRlcmZhY2VTd2l6emxlciBhbHdheXMgaW5zdGFudGlhdGVzIHRoZSBzaGFy ZWQgVUlBcHBsaWNhdGlvbi4gVGhpcyBhcHBhcmVudGx5IGNhdXNlcyAtW1dLQ29udGVudFZpZXcK KyAgICAgICAgcmVzaXphYmxlU25hcHNob3RWaWV3RnJvbVJlY3Q6YWZ0ZXJTY3JlZW5VcGRhdGVz OndpdGhDYXBJbnNldHM6XSB0byByZXR1cm4gYG5pbGAgaW5zdGVhZCBvZiBhIHJlcGxpY2Egdmll dy4gQXMgYQorICAgICAgICByZXN1bHQsIHdlIGNyYXNoIHVuZGVyIGBjcmVhdGVGYWxsYmFja1Rh cmdldGVkUHJldmlld2AgYXMgd2UncmUgYXR0ZW1wdGluZyB0byBhc3NlbWJsZSBhIHRhcmdldGVk IHByZXZpZXcgZm9yCisgICAgICAgIHRoZSBjb250ZXh0IG1lbnUgaW50ZXJhY3Rpb24uCisKKyAg ICAgICAgU2luY2UgdGhpcyBzZWVtcyB0byBvbmx5IGFmZmVjdCB0aGlzIHBhcnRpY3VsYXIgQVBJ IHRlc3QsIHdvcmsgYXJvdW5kIGl0IGJ5IHN3aXp6bGluZyBvdXQKKyAgICAgICAgYC1yZXNpemFi bGVTbmFwc2hvdFZpZXdGcm9tUmVjdDphZnRlclNjcmVlblVwZGF0ZXM6d2l0aENhcEluc2V0czpg IGluIHRoaXMgQVBJIHRlc3QgdG8gcmV0dXJuIGEgbm9uLW51bGwgVUlWaWV3LgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbToKKyAgICAgICAg KFRlc3RXZWJLaXRBUEk6OnN3aXp6bGVkUmVzaXphYmxlU25hcHNob3RWaWV3RnJvbVJlY3QpOgor ICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMjAtMDUtMjQgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NsaXBib2FyZCBBUEldIFN1 cHBvcnQgcmVhZGluZyAiaW1hZ2UvcG5nIiBvbiBDbGlwYm9hcmRJdGVtCmRpZmYgLS1naXQgYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbQppbmRleCBlY2NlZWM2 MTExNWYwMDRhYmQ1MjNiMDRjMWFjNDQ2NWJiMDZkNDZkLi45MDhiZmNiNGFiNWE3N2YyMjk3Y2Vl ZjlhMzhlNmVlOWVlMjU4YmJhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv aW9zL0FjdGlvblNoZWV0VGVzdHMubW0KQEAgLTE1Miw5ICsxNTIsMTkgQEAgVEVTVChBY3Rpb25T aGVldFRlc3RzLCBJbWFnZU1hcERvZXNOb3REZXN0cm95U2VsZWN0aW9uKQogICAgIEVYUEVDVF9X S19TVFJFUSgiSGVsbG8gd29ybGQiLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2Ny aXB0OkAiZ2V0U2VsZWN0aW9uKCkudG9TdHJpbmcoKSJdKTsKIH0KIAorc3RhdGljIFVJVmlldyAq c3dpenpsZWRSZXNpemFibGVTbmFwc2hvdFZpZXdGcm9tUmVjdChpZCwgU0VMLCBDR1JlY3QgcmVj dCwgQk9PTCwgVUlFZGdlSW5zZXRzKQoreworICAgIHJldHVybiBbW1VJVmlldyBhbGxvY10gaW5p dFdpdGhTaXplOnJlY3Quc2l6ZV07Cit9CisKIFRFU1QoQWN0aW9uU2hlZXRUZXN0cywgRGF0YURl dGVjdG9yc0xpbmtJc05vdFByZXNlbnRlZEFzQUxpbmspCiB7CiAgICAgSVBhZFVzZXJJbnRlcmZh Y2VTd2l6emxlciBpUGFkVXNlckludGVyZmFjZTsKKyAgICBJbnN0YW5jZU1ldGhvZFN3aXp6bGVy IHNuYXBzaG90Vmlld1N3aXp6bGVyIHsKKyAgICAgICAgVUlWaWV3LmNsYXNzLAorICAgICAgICBA c2VsZWN0b3IocmVzaXphYmxlU25hcHNob3RWaWV3RnJvbVJlY3Q6YWZ0ZXJTY3JlZW5VcGRhdGVz OndpdGhDYXBJbnNldHM6KSwKKyAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxJTVA+KHN3aXp6bGVk UmVzaXphYmxlU25hcHNob3RWaWV3RnJvbVJlY3QpCisgICAgfTsKIAogICAgIGF1dG8gd2ViVmll dyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1h a2UoMCwgMCwgMTAyNCwgNzY4KV0pOwogICAgIGF1dG8gb2JzZXJ2ZXIgPSBhZG9wdE5TKFtbQWN0 aW9uU2hlZXRPYnNlcnZlciBhbGxvY10gaW5pdF0pOwo= 400227 2020-05-25 20:34:21 -0700 2020-05-25 21:49:02 -0700 Fix non-internal build bug-212363-20200525203421.patch text/plain 2764 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWZiYTk2YTU0OTQ2ODEzNDgzZDE1ZWQyZjI2YmQzY2M5 ZmQxOWY0My4uZmYwOWMwMjRkZTEyZDk1ZmQ0ZTRlYjYyNTM0OGRjYWY0MzdkZWU1NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDIwLTA1LTI1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1NdIEFjdGlvblNoZWV0VGVzdHMuRGF0YURldGVjdG9yc0xpbmtJc05vdFBy ZXNlbnRlZEFzQUxpbmsgaXMgZmFpbGluZyBjb25zaXN0ZW50bHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjM2MworICAgICAgICA8cmRhcjovL3By b2JsZW0vNjM1MDg4NjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAg ICAgICBUaGlzIHRlc3QgYmVnYW4gdG8gY29uc2lzdGVudGx5IHRocm93IGFuIGV4Y2VwdGlvbiBh ZnRlciA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvcjI2MTE1Nz4sIGR1ZSB0byBob3cKKyAgICAg ICAgVXNlckludGVyZmFjZVN3aXp6bGVyIGFsd2F5cyBpbnN0YW50aWF0ZXMgdGhlIHNoYXJlZCBV SUFwcGxpY2F0aW9uLiBUaGlzIGFwcGFyZW50bHkgY2F1c2VzIC1bV0tDb250ZW50VmlldworICAg ICAgICByZXNpemFibGVTbmFwc2hvdFZpZXdGcm9tUmVjdDphZnRlclNjcmVlblVwZGF0ZXM6d2l0 aENhcEluc2V0czpdIHRvIHJldHVybiBgbmlsYCBpbnN0ZWFkIG9mIGEgcmVwbGljYSB2aWV3LiBB cyBhCisgICAgICAgIHJlc3VsdCwgd2UgY3Jhc2ggdW5kZXIgYGNyZWF0ZUZhbGxiYWNrVGFyZ2V0 ZWRQcmV2aWV3YCBhcyB3ZSdyZSBhdHRlbXB0aW5nIHRvIGFzc2VtYmxlIGEgdGFyZ2V0ZWQgcHJl dmlldyBmb3IKKyAgICAgICAgdGhlIGNvbnRleHQgbWVudSBpbnRlcmFjdGlvbi4KKworICAgICAg ICBTaW5jZSB0aGlzIHNlZW1zIHRvIG9ubHkgYWZmZWN0IHRoaXMgcGFydGljdWxhciBBUEkgdGVz dCwgd29yayBhcm91bmQgaXQgYnkgc3dpenpsaW5nIG91dAorICAgICAgICBgLXJlc2l6YWJsZVNu YXBzaG90Vmlld0Zyb21SZWN0OmFmdGVyU2NyZWVuVXBkYXRlczp3aXRoQ2FwSW5zZXRzOmAgaW4g dGhpcyBBUEkgdGVzdCB0byByZXR1cm4gYSBub24tbnVsbCBVSVZpZXcuCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tOgorICAgICAgICAoVGVz dFdlYktpdEFQSTo6c3dpenpsZWRSZXNpemFibGVTbmFwc2hvdFZpZXdGcm9tUmVjdCk6CisgICAg ICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMC0wNS0yNCAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ2xpcGJvYXJkIEFQSV0gU3VwcG9y dCByZWFkaW5nICJpbWFnZS9wbmciIG9uIENsaXBib2FyZEl0ZW0KZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0FjdGlvblNoZWV0VGVzdHMubW0gYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tCmluZGV4IGVjY2VlYzYxMTE1 ZjAwNGFiZDUyM2IwNGMxYWM0NDY1YmIwNmQ0NmQuLjc4N2QzZmVlYWE2OWE4NTU4NzNkZmRjYTQ2 ZWRiM2IyMTk5NTk3NTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9z L0FjdGlvblNoZWV0VGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3Mv QWN0aW9uU2hlZXRUZXN0cy5tbQpAQCAtMTUyLDkgKzE1MiwxOSBAQCBURVNUKEFjdGlvblNoZWV0 VGVzdHMsIEltYWdlTWFwRG9lc05vdERlc3Ryb3lTZWxlY3Rpb24pCiAgICAgRVhQRUNUX1dLX1NU UkVRKCJIZWxsbyB3b3JsZCIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6 QCJnZXRTZWxlY3Rpb24oKS50b1N0cmluZygpIl0pOwogfQogCitzdGF0aWMgVUlWaWV3ICpzd2l6 emxlZFJlc2l6YWJsZVNuYXBzaG90Vmlld0Zyb21SZWN0KGlkLCBTRUwsIENHUmVjdCByZWN0LCBC T09MLCBVSUVkZ2VJbnNldHMpCit7CisgICAgcmV0dXJuIFtbW1VJVmlldyBhbGxvY10gaW5pdFdp dGhGcmFtZTpDR1JlY3RNYWtlKDAsIDAsIHJlY3Quc2l6ZS53aWR0aCwgcmVjdC5zaXplLmhlaWdo dCldIGF1dG9yZWxlYXNlXTsKK30KKwogVEVTVChBY3Rpb25TaGVldFRlc3RzLCBEYXRhRGV0ZWN0 b3JzTGlua0lzTm90UHJlc2VudGVkQXNBTGluaykKIHsKICAgICBJUGFkVXNlckludGVyZmFjZVN3 aXp6bGVyIGlQYWRVc2VySW50ZXJmYWNlOworICAgIEluc3RhbmNlTWV0aG9kU3dpenpsZXIgc25h cHNob3RWaWV3U3dpenpsZXIgeworICAgICAgICBVSVZpZXcuY2xhc3MsCisgICAgICAgIEBzZWxl Y3RvcihyZXNpemFibGVTbmFwc2hvdFZpZXdGcm9tUmVjdDphZnRlclNjcmVlblVwZGF0ZXM6d2l0 aENhcEluc2V0czopLAorICAgICAgICByZWludGVycHJldF9jYXN0PElNUD4oc3dpenpsZWRSZXNp emFibGVTbmFwc2hvdFZpZXdGcm9tUmVjdCkKKyAgICB9OwogCiAgICAgYXV0byB3ZWJWaWV3ID0g YWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgw LCAwLCAxMDI0LCA3NjgpXSk7CiAgICAgYXV0byBvYnNlcnZlciA9IGFkb3B0TlMoW1tBY3Rpb25T aGVldE9ic2VydmVyIGFsbG9jXSBpbml0XSk7Cg==