212358 2020-05-25 12:06:10 -0700 Use an Optional<> for LayerFragment::boundingBox 2020-05-25 17:28:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser changseok esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1655902 0 simon.fraser 2020-05-25 12:06:10 -0700 Use an Optional<> for LayerFragment::boundingBox 1655903 1 400211 simon.fraser 2020-05-25 12:06:46 -0700 Created attachment 400211 Patch 1655955 2 ews-feeder 2020-05-25 17:27:16 -0700 Committed r262133: <https://trac.webkit.org/changeset/262133> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400211. 1655956 3 webkit-bug-importer 2020-05-25 17:28:14 -0700 <rdar://problem/63607223> 400211 2020-05-25 12:06:46 -0700 2020-05-25 17:27:17 -0700 Patch bug-212358-20200525120645.patch text/plain 7410 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ5YTc5ZTZhNjk3ZTgw ZDQyNzk2ODFkYjcwNzhkMjAxNTc4YmE5Mi4uMmJjYzViNmFmMDFhNTM3NTMxZmQxOTEyZGU1ZmFh MTFmMjk1NDZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA1LTI1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBhbiBPcHRp b25hbDw+IGZvciBMYXllckZyYWdtZW50Ojpib3VuZGluZ0JveAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMzU4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSBhIGJvb2wgKyBMYXlvdXRSZWN0 IHdpdGggT3B0aW9uYWw8TGF5b3V0UmVjdD4uCisKKyAgICAgICAgKiByZW5kZXJpbmcvTGF5ZXJG cmFnbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJGcmFnbWVudDo6c2V0UmVjdHMpOgor ICAgICAgICAoV2ViQ29yZTo6TGF5ZXJGcmFnbWVudDo6bW92ZUJ5KToKKyAgICAgICAgKFdlYkNv cmU6OkxheWVyRnJhZ21lbnQ6OmludGVyc2VjdCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjb2xsZWN0RnJhZ21l bnRzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1cGRhdGVQYWludGluZ0luZm9G b3JGcmFnbWVudHMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZUNs aXBSZWN0cyBjb25zdCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisKIDIw MjAtMDUtMjQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZD XVtURkNdIElnbm9yZSBzZWN0aW9uIGJvcmRlcnMgZXZlbiB3aGVuIGJvcmRlciBjb2xsYXBzZSBp cyBvZmYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5ZXJGcmFnbWVu dC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xheWVyRnJhZ21lbnQuaAppbmRleCA2NGIw YzhhNmYwZmI5MDAyOTNlOWE1ZDQ2OTZmNmJiMTA0ODZjOWUyLi4yMjgyYTRlY2U5ODgyZmU4OWM4 YmVkMmVjOTZiYWEzYjMxNjlkMjI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvTGF5ZXJGcmFnbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MYXllckZy YWdtZW50LmgKQEAgLTMzLDE1ICszMywxMiBAQCBjbGFzcyBMYXllckZyYWdtZW50IHsKIHB1Ymxp YzoKICAgICBMYXllckZyYWdtZW50KCkgPSBkZWZhdWx0OwogICAgIAotICAgIHZvaWQgc2V0UmVj dHMoY29uc3QgTGF5b3V0UmVjdCYgYm91bmRzLCBjb25zdCBDbGlwUmVjdCYgYmFja2dyb3VuZCwg Y29uc3QgQ2xpcFJlY3QmIGZvcmVncm91bmQsIGNvbnN0IExheW91dFJlY3QqIGJib3gpCisgICAg dm9pZCBzZXRSZWN0cyhjb25zdCBMYXlvdXRSZWN0JiBib3VuZHMsIGNvbnN0IENsaXBSZWN0JiBi YWNrZ3JvdW5kLCBjb25zdCBDbGlwUmVjdCYgZm9yZWdyb3VuZCwgY29uc3QgT3B0aW9uYWw8TGF5 b3V0UmVjdD4mIGJib3gpCiAgICAgewogICAgICAgICBsYXllckJvdW5kcyA9IGJvdW5kczsKICAg ICAgICAgYmFja2dyb3VuZFJlY3QgPSBiYWNrZ3JvdW5kOwogICAgICAgICBmb3JlZ3JvdW5kUmVj dCA9IGZvcmVncm91bmQ7Ci0gICAgICAgIGlmIChiYm94KSB7Ci0gICAgICAgICAgICBib3VuZGlu Z0JveCA9ICpiYm94OwotICAgICAgICAgICAgaGFzQm91bmRpbmdCb3ggPSB0cnVlOwotICAgICAg ICB9CisgICAgICAgIGJvdW5kaW5nQm94ID0gYmJveDsKICAgICB9CiAgICAgCiAgICAgdm9pZCBt b3ZlQnkoY29uc3QgTGF5b3V0UG9pbnQmIG9mZnNldCkKQEAgLTUwLDE0ICs0NywxNiBAQCBwdWJs aWM6CiAgICAgICAgIGJhY2tncm91bmRSZWN0Lm1vdmVCeShvZmZzZXQpOwogICAgICAgICBmb3Jl Z3JvdW5kUmVjdC5tb3ZlQnkob2Zmc2V0KTsKICAgICAgICAgcGFnaW5hdGlvbkNsaXAubW92ZUJ5 KG9mZnNldCk7Ci0gICAgICAgIGJvdW5kaW5nQm94Lm1vdmVCeShvZmZzZXQpOworICAgICAgICBp ZiAoYm91bmRpbmdCb3gpCisgICAgICAgICAgICBib3VuZGluZ0JveC0+bW92ZUJ5KG9mZnNldCk7 CiAgICAgfQogICAgIAogICAgIHZvaWQgaW50ZXJzZWN0KGNvbnN0IExheW91dFJlY3QmIHJlY3Qp CiAgICAgewogICAgICAgICBiYWNrZ3JvdW5kUmVjdC5pbnRlcnNlY3QocmVjdCk7CiAgICAgICAg IGZvcmVncm91bmRSZWN0LmludGVyc2VjdChyZWN0KTsKLSAgICAgICAgYm91bmRpbmdCb3guaW50 ZXJzZWN0KHJlY3QpOworICAgICAgICBpZiAoYm91bmRpbmdCb3gpCisgICAgICAgICAgICBib3Vu ZGluZ0JveC0+aW50ZXJzZWN0KHJlY3QpOwogICAgIH0KICAgICAKICAgICB2b2lkIGludGVyc2Vj dChjb25zdCBDbGlwUmVjdCYgY2xpcFJlY3QpCkBAIC02NywxMSArNjYsMTEgQEAgcHVibGljOgog ICAgIH0KIAogICAgIGJvb2wgc2hvdWxkUGFpbnRDb250ZW50ID0gZmFsc2U7Ci0gICAgYm9vbCBo YXNCb3VuZGluZ0JveCA9IGZhbHNlOworICAgIE9wdGlvbmFsPExheW91dFJlY3Q+IGJvdW5kaW5n Qm94OworCiAgICAgTGF5b3V0UmVjdCBsYXllckJvdW5kczsKICAgICBDbGlwUmVjdCBiYWNrZ3Jv dW5kUmVjdDsKICAgICBDbGlwUmVjdCBmb3JlZ3JvdW5kUmVjdDsKLSAgICBMYXlvdXRSZWN0IGJv dW5kaW5nQm94OwogICAgIAogICAgIC8vIFVuaXF1ZSB0byBwYWdpbmF0ZWQgZnJhZ21lbnRzLiBU aGUgcGh5c2ljYWwgdHJhbnNsYXRpb24gdG8gYXBwbHkgdG8gc2hpZnQgdGhlIGxheWVyIHdoZW4g cGFpbnRpbmcvaGl0LXRlc3RpbmcuCiAgICAgTGF5b3V0U2l6ZSBwYWdpbmF0aW9uT2Zmc2V0Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggZWQ3MzNlNzE0NDM2 N2I3NzUyZTU1MjEzNThlNGI3YTFjYWMxMDViMi4uOTRjNWFkNzU3ZWY3NzJlYjgzNTAxNDMyMjdk YTFlMTFlNWVjMjE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw CkBAIC00ODc0LDcgKzQ4NzQsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpjb2xsZWN0RnJhZ21lbnRz KExheWVyRnJhZ21lbnRzJiBmcmFnbWVudHMsIGNvbnN0IFJlbmRlckxheWVyKgogICAgICAgICAg ICAgICAgIExheWVyRnJhZ21lbnQmIGZyYWdtZW50ID0gZnJhZ21lbnRzLmF0KGkpOwogICAgICAg ICAgICAgICAgIAogICAgICAgICAgICAgICAgIC8vIFNldCBvdXIgZm91ciByZWN0cyB3aXRoIGFs bCBjbGlwcGluZyBhcHBsaWVkIHRoYXQgd2FzIGludGVybmFsIHRvIHRoZSBmbG93IHRocmVhZC4K LSAgICAgICAgICAgICAgICBmcmFnbWVudC5zZXRSZWN0cyhsYXllckJvdW5kc0luRnJhZ21lbnRl ZEZsb3csIGJhY2tncm91bmRSZWN0SW5GcmFnbWVudGVkRmxvdywgZm9yZWdyb3VuZFJlY3RJbkZy YWdtZW50ZWRGbG93LCAmbGF5ZXJCb3VuZGluZ0JveEluRnJhZ21lbnRlZEZsb3cpOworICAgICAg ICAgICAgICAgIGZyYWdtZW50LnNldFJlY3RzKGxheWVyQm91bmRzSW5GcmFnbWVudGVkRmxvdywg YmFja2dyb3VuZFJlY3RJbkZyYWdtZW50ZWRGbG93LCBmb3JlZ3JvdW5kUmVjdEluRnJhZ21lbnRl ZEZsb3csIGxheWVyQm91bmRpbmdCb3hJbkZyYWdtZW50ZWRGbG93KTsKICAgICAgICAgICAgICAg ICAKICAgICAgICAgICAgICAgICAvLyBTaGlmdCB0byB0aGUgcm9vdC1yZWxhdGl2ZSBwaHlzaWNh bCBwb3NpdGlvbiB1c2VkIHdoZW4gcGFpbnRpbmcgdGhlIGZsb3cgdGhyZWFkIGluIHRoaXMgZnJh Z21lbnQuCiAgICAgICAgICAgICAgICAgZnJhZ21lbnQubW92ZUJ5KHRvTGF5b3V0UG9pbnQoYW5j ZXN0b3JGcmFnbWVudC5wYWdpbmF0aW9uT2Zmc2V0ICsgZnJhZ21lbnQucGFnaW5hdGlvbk9mZnNl dCArIG9mZnNldFdpdGhpblBhcmVudFBhZ2luYXRlZExheWVyKSk7CkBAIC00OTE3LDcgKzQ5MTcs NyBAQCB2b2lkIFJlbmRlckxheWVyOjpjb2xsZWN0RnJhZ21lbnRzKExheWVyRnJhZ21lbnRzJiBm cmFnbWVudHMsIGNvbnN0IFJlbmRlckxheWVyKgogCiAgICAgZm9yIChhdXRvJiBmcmFnbWVudCA6 IGZyYWdtZW50cykgewogICAgICAgICAvLyBTZXQgb3VyIGZvdXIgcmVjdHMgd2l0aCBhbGwgY2xp cHBpbmcgYXBwbGllZCB0aGF0IHdhcyBpbnRlcm5hbCB0byB0aGUgZmxvdyB0aHJlYWQuCi0gICAg ICAgIGZyYWdtZW50LnNldFJlY3RzKGxheWVyQm91bmRzSW5GcmFnbWVudGVkRmxvdywgYmFja2dy b3VuZFJlY3RJbkZyYWdtZW50ZWRGbG93LCBmb3JlZ3JvdW5kUmVjdEluRnJhZ21lbnRlZEZsb3cs ICZsYXllckJvdW5kaW5nQm94SW5GcmFnbWVudGVkRmxvdyk7CisgICAgICAgIGZyYWdtZW50LnNl dFJlY3RzKGxheWVyQm91bmRzSW5GcmFnbWVudGVkRmxvdywgYmFja2dyb3VuZFJlY3RJbkZyYWdt ZW50ZWRGbG93LCBmb3JlZ3JvdW5kUmVjdEluRnJhZ21lbnRlZEZsb3csIGxheWVyQm91bmRpbmdC b3hJbkZyYWdtZW50ZWRGbG93KTsKICAgICAgICAgCiAgICAgICAgIC8vIFNoaWZ0IHRvIHRoZSBy b290LXJlbGF0aXZlIHBoeXNpY2FsIHBvc2l0aW9uIHVzZWQgd2hlbiBwYWludGluZyB0aGUgZmxv dyB0aHJlYWQgaW4gdGhpcyBmcmFnbWVudC4KICAgICAgICAgZnJhZ21lbnQubW92ZUJ5KHRvTGF5 b3V0UG9pbnQoZnJhZ21lbnQucGFnaW5hdGlvbk9mZnNldCArIG9mZnNldE9mUGFnaW5hdGlvbkxh eWVyRnJvbVJvb3QpKTsKQEAgLTQ5NDIsNyArNDk0Miw3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVw ZGF0ZVBhaW50aW5nSW5mb0ZvckZyYWdtZW50cyhMYXllckZyYWdtZW50cyYgZnJhZ21lbnRzLCBj b25zCiAgICAgICAgIGZyYWdtZW50LnNob3VsZFBhaW50Q29udGVudCA9IHNob3VsZFBhaW50Q29u dGVudDsKICAgICAgICAgaWYgKHRoaXMgIT0gbG9jYWxQYWludGluZ0luZm8ucm9vdExheWVyIHx8 ICEobG9jYWxQYWludEZsYWdzICYgUGFpbnRMYXllclBhaW50aW5nT3ZlcmZsb3dDb250ZW50cykp IHsKICAgICAgICAgICAgIExheW91dFNpemUgbmV3T2Zmc2V0RnJvbVJvb3QgPSBvZmZzZXRGcm9t Um9vdCArIGZyYWdtZW50LnBhZ2luYXRpb25PZmZzZXQ7Ci0gICAgICAgICAgICBmcmFnbWVudC5z aG91bGRQYWludENvbnRlbnQgJj0gaW50ZXJzZWN0c0RhbWFnZVJlY3QoZnJhZ21lbnQubGF5ZXJC b3VuZHMsIGZyYWdtZW50LmJhY2tncm91bmRSZWN0LnJlY3QoKSwgbG9jYWxQYWludGluZ0luZm8u cm9vdExheWVyLCBuZXdPZmZzZXRGcm9tUm9vdCwgZnJhZ21lbnQuaGFzQm91bmRpbmdCb3ggPyAm ZnJhZ21lbnQuYm91bmRpbmdCb3ggOiAwKTsKKyAgICAgICAgICAgIGZyYWdtZW50LnNob3VsZFBh aW50Q29udGVudCAmPSBpbnRlcnNlY3RzRGFtYWdlUmVjdChmcmFnbWVudC5sYXllckJvdW5kcywg ZnJhZ21lbnQuYmFja2dyb3VuZFJlY3QucmVjdCgpLCBsb2NhbFBhaW50aW5nSW5mby5yb290TGF5 ZXIsIG5ld09mZnNldEZyb21Sb290LCBmcmFnbWVudC5ib3VuZGluZ0JveCk7CiAgICAgICAgIH0K ICAgICB9CiB9CkBAIC01OTk1LDcgKzU5OTUsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpyZXBhaW50 QmxvY2tTZWxlY3Rpb25HYXBzKCkKICAgICAgICAgcmVuZGVyZXIoKS5yZXBhaW50UmVjdGFuZ2xl KHJlY3QpOwogfQogCi1ib29sIFJlbmRlckxheWVyOjppbnRlcnNlY3RzRGFtYWdlUmVjdChjb25z dCBMYXlvdXRSZWN0JiBsYXllckJvdW5kcywgY29uc3QgTGF5b3V0UmVjdCYgZGFtYWdlUmVjdCwg Y29uc3QgUmVuZGVyTGF5ZXIqIHJvb3RMYXllciwgY29uc3QgTGF5b3V0U2l6ZSYgb2Zmc2V0RnJv bVJvb3QsIGNvbnN0IExheW91dFJlY3QqIGNhY2hlZEJvdW5kaW5nQm94KSBjb25zdAorYm9vbCBS ZW5kZXJMYXllcjo6aW50ZXJzZWN0c0RhbWFnZVJlY3QoY29uc3QgTGF5b3V0UmVjdCYgbGF5ZXJC b3VuZHMsIGNvbnN0IExheW91dFJlY3QmIGRhbWFnZVJlY3QsIGNvbnN0IFJlbmRlckxheWVyKiBy b290TGF5ZXIsIGNvbnN0IExheW91dFNpemUmIG9mZnNldEZyb21Sb290LCBjb25zdCBPcHRpb25h bDxMYXlvdXRSZWN0PiYgY2FjaGVkQm91bmRpbmdCb3gpIGNvbnN0CiB7CiAgICAgLy8gQWx3YXlz IGV4YW1pbmUgdGhlIGNhbnZhcyBhbmQgdGhlIHJvb3QuCiAgICAgLy8gRklYTUU6IENvdWxkIGVs aW1pbmF0ZSB0aGUgaXNEb2N1bWVudEVsZW1lbnRSZW5kZXJlcigpIGNoZWNrIGlmIHdlIGZpeCBi YWNrZ3JvdW5kIHBhaW50aW5nIHNvIHRoYXQgdGhlIFJlbmRlclZpZXcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmgKaW5kZXggNmRlMGQwMDcyZWFiNWQyMDExNGIxY2QwZTY0NjRm NjEyZWQ3MWU1YS4uYzRjY2E4MjliZmVlNzM2ZDBhNzY3Nzc1YjdmZTNlYzEwMzQ2MjVmOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTczMyw3ICs3MzMsNyBAQCBw dWJsaWM6CiAgICAgYm9vbCBjbGlwQ3Jvc3Nlc1BhaW50aW5nQm91bmRhcnkoKSBjb25zdDsKIAog ICAgIC8vIFBhc3Mgb2Zmc2V0RnJvbVJvb3QgaWYga25vd24uCi0gICAgYm9vbCBpbnRlcnNlY3Rz RGFtYWdlUmVjdChjb25zdCBMYXlvdXRSZWN0JiBsYXllckJvdW5kcywgY29uc3QgTGF5b3V0UmVj dCYgZGFtYWdlUmVjdCwgY29uc3QgUmVuZGVyTGF5ZXIqIHJvb3RMYXllciwgY29uc3QgTGF5b3V0 U2l6ZSYgb2Zmc2V0RnJvbVJvb3QsIGNvbnN0IExheW91dFJlY3QqIGNhY2hlZEJvdW5kaW5nQm94 ID0gbnVsbHB0cikgY29uc3Q7CisgICAgYm9vbCBpbnRlcnNlY3RzRGFtYWdlUmVjdChjb25zdCBM YXlvdXRSZWN0JiBsYXllckJvdW5kcywgY29uc3QgTGF5b3V0UmVjdCYgZGFtYWdlUmVjdCwgY29u c3QgUmVuZGVyTGF5ZXIqIHJvb3RMYXllciwgY29uc3QgTGF5b3V0U2l6ZSYgb2Zmc2V0RnJvbVJv b3QsIGNvbnN0IE9wdGlvbmFsPExheW91dFJlY3Q+JiBjYWNoZWRCb3VuZGluZ0JveCA9IFdURjo6 bnVsbG9wdCkgY29uc3Q7CiAKICAgICBlbnVtIENhbGN1bGF0ZUxheWVyQm91bmRzRmxhZyB7CiAg ICAgICAgIEluY2x1ZGVTZWxmVHJhbnNmb3JtICAgICAgICAgICAgICAgICAgICA9IDEgPDwgMCwK