212290 2020-05-22 16:50:53 -0700 REGRESSION (r204916): WTF::isValidEnum() has a typo in static_assert making it a tautological comparison 2020-05-22 20:32:15 -0700 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 161103 1 ddkilzer ddkilzer achristensen benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1655505 0 ddkilzer 2020-05-22 16:50:53 -0700 WTF::isValidEnum() has a typo in static_assert making it a tautological comparison. template<typename E, typename T, std::enable_if_t<std::is_enum<E>::value && !std::is_same<std::underlying_type_t<E>, bool>::value && !HasCustomIsValidEnum<E>::value>* = nullptr> constexpr bool isValidEnum(T t) { static_assert(sizeof(T) >= std::underlying_type_t<E>(), "Integral type must be at least the size of the underlying enum type"); return EnumValueChecker<T, typename EnumTraits<E>::values>::isValidEnum(t); } Note that `sizeof(T) >= std::underlying_type_t<E>()` is a tautological comparison because `std::underlying_type_t<E>()` evaluates to zero. 1655512 1 400089 ddkilzer 2020-05-22 16:54:00 -0700 Created attachment 400089 Patch v1 1655515 2 ddkilzer 2020-05-22 16:56:09 -0700 Regressed in r204916: <https://trac.webkit.org/r204916> 1655534 3 400089 ysuzuki 2020-05-22 17:44:04 -0700 Comment on attachment 400089 Patch v1 r=me 1655568 4 ews-feeder 2020-05-22 20:31:28 -0700 Committed r262092: <https://trac.webkit.org/changeset/262092> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400089. 1655569 5 webkit-bug-importer 2020-05-22 20:32:15 -0700 <rdar://problem/63562556> 400089 2020-05-22 16:54:00 -0700 2020-05-22 20:31:28 -0700 Patch v1 bug-212290-20200522165507.patch text/plain 1652 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVkZWM4ZWMxODY5YWQ2ZjA1NWVkYWIx NWUwZjZiN2E4ZTE1OTIzMzIuLjQ4ZTM3ZDZmODc3NDc1MTc3ZGNiZjg4ZWQwYWYxY2E3YzM3YWFi MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDUtMjIgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBXVEY6OmlzVmFsaWRFbnVtKCkgaGFzIGEgdHlwbyBp biBzdGF0aWNfYXNzZXJ0IG1ha2luZyBpdCBhIHRhdXRvbG9naWNhbCBjb21wYXJpc29uCisgICAg ICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMTIyOTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvRW51bVRyYWl0cy5oOgorICAgICAgICAo V1RGOjppc1ZhbGlkRW51bSk6IFVzZSBzaXplb2Yoc3RkOjp1bmRlcmx5aW5nX3R5cGVfdDxFPikK KyAgICAgICAgaW5zdGVhZCBvZiBzdGQ6OnVuZGVybHlpbmdfdHlwZV90PEU+KCkgdG8gZml4IHRo ZSBidWcuCisKIDIwMjAtMDUtMjAgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBVc2UgT3B0aW9uU2V0PERyYWdEZXN0aW5hdGlvbkFjdGlvbj4gZm9yIG1hc2sg dmFsdWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9FbnVtVHJhaXRzLmggYi9Tb3VyY2Uv V1RGL3d0Zi9FbnVtVHJhaXRzLmgKaW5kZXggMDkzMzg1ZjNjNDNiNzgyNjRkOWY5ZWI4YjE2NTY3 YTQxODgwYzU3OS4uOTkyNzg4NzI5M2QwYTdiM2JhMWU4NTA2YjBjZGFmMzUzYTk5YjI0YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvRW51bVRyYWl0cy5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L0VudW1UcmFpdHMuaApAQCAtNTYsNyArNTYsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBjbGFz cyBIYXNDdXN0b21Jc1ZhbGlkRW51bSA6IHB1YmxpYyBzdGQ6OmZhbHNlX3R5cGUgeyB9OwogdGVt cGxhdGU8dHlwZW5hbWUgRSwgdHlwZW5hbWUgVCwgc3RkOjplbmFibGVfaWZfdDxzdGQ6OmlzX2Vu dW08RT46OnZhbHVlICYmICFzdGQ6OmlzX3NhbWU8c3RkOjp1bmRlcmx5aW5nX3R5cGVfdDxFPiwg Ym9vbD46OnZhbHVlICYmICFIYXNDdXN0b21Jc1ZhbGlkRW51bTxFPjo6dmFsdWU+KiA9IG51bGxw dHI+CiBjb25zdGV4cHIgYm9vbCBpc1ZhbGlkRW51bShUIHQpCiB7Ci0gICAgc3RhdGljX2Fzc2Vy dChzaXplb2YoVCkgPj0gc3RkOjp1bmRlcmx5aW5nX3R5cGVfdDxFPigpLCAiSW50ZWdyYWwgdHlw ZSBtdXN0IGJlIGF0IGxlYXN0IHRoZSBzaXplIG9mIHRoZSB1bmRlcmx5aW5nIGVudW0gdHlwZSIp OworICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKFQpID49IHNpemVvZihzdGQ6OnVuZGVybHlpbmdf dHlwZV90PEU+KSwgIkludGVncmFsIHR5cGUgbXVzdCBiZSBhdCBsZWFzdCB0aGUgc2l6ZSBvZiB0 aGUgdW5kZXJseWluZyBlbnVtIHR5cGUiKTsKIAogICAgIHJldHVybiBFbnVtVmFsdWVDaGVja2Vy PFQsIHR5cGVuYW1lIEVudW1UcmFpdHM8RT46OnZhbHVlcz46OmlzVmFsaWRFbnVtKHQpOwogfQo=