21229 2008-09-29 21:43:31 -0700 NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN) 2008-10-12 19:14:05 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Trivial --- 1 fishd darin oldest_to_newest 93331 0 fishd 2008-09-29 21:43:31 -0700 NetworkStateNotifier.h lacks a #include <windows.h> This causes build problems if you do not force include windows.h, which seems like an undesirable requirement (to me at least). 93343 1 23934 fishd 2008-09-30 01:41:24 -0700 Created attachment 23934 v1 patch Simple fix. 93378 2 23934 darin 2008-09-30 09:04:56 -0700 Comment on attachment 23934 v1 patch r=me One thing we might want to be more standard about is which basic system headers are handled by either the project file prefix or the "config.h" include file. Those includes won't need to be added in each file that depends on them. I thought <windows.h> was in that category. Also I thought we needed to set some macros like NOMINMAX before including <windows.h> and it was a problem any time the include was in a file "alone" like this. But I'm not sure of either of those things, it's something we can clean up later, and this seems fine if it's helpful for building Chrome. 93383 3 fishd 2008-09-30 10:07:34 -0700 I don't see NOMINMAX defined anywhere. I do see an entry in ChangeLog-2006-12-31 about it though. Maybe it got removed later? 94316 4 eric 2008-10-06 18:17:32 -0700 I'll leave Darin Fisher this patch to commit once his commit-bit gets turned on. 95140 5 darin 2008-10-12 19:11:46 -0700 I did a quick search and found that platform/win/COMPtr.h defines NOMINMAX, but that seems like an anomaly. It looks like the NOMINMAX thing is dealt with in WebCore/config.h. But I also see lots of includes of <windows.h> in various source files in WebCore and JavaScriptCore. It's a slight mystery why we're able to compile NetworkStateNotifier.h on Windows outside Chromium. 95141 6 darin 2008-10-12 19:14:05 -0700 http://trac.webkit.org/changeset/37552 23934 2008-09-30 01:41:24 -0700 2008-09-30 09:04:56 -0700 v1 patch notifier-1.diff text/plain 878 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3MDg5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDkt MjkgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEyMjkKKworICAgICAgICAqIHBsYXRmb3JtXG5ldHdvcmtcTmV0d29y a1N0YXRlTm90aWZpZXIuaAorOgorCiAyMDA4LTA5LTI5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogcGxhdGZv cm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3Jt L25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaAkocmV2aXNpb24gMzcwODkpCisrKyBwbGF0 Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMy LDYgKzMyLDggQEAKIAogdHlwZWRlZiBjb25zdCBzdHJ1Y3QgX19DRkFycmF5ICogQ0ZBcnJheVJl ZjsKIHR5cGVkZWYgY29uc3Qgc3RydWN0IF9fU0NEeW5hbWljU3RvcmUgKiBTQ0R5bmFtaWNTdG9y ZVJlZjsKKyNlbGlmIFBMQVRGT1JNKFdJTikKKyNpbmNsdWRlIDx3aW5kb3dzLmg+CiAjZW5kaWYK IAogbmFtZXNwYWNlIFdlYkNvcmUgewo=