212268 2020-05-22 10:35:47 -0700 [WKTR] Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank 2020-05-22 11:19:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen ap beidson ggaren jbedard webkit-bug-importer oldest_to_newest 1655351 0 cdumez 2020-05-22 10:35:47 -0700 Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank. In <rdar://problem/63493074>, we have evidence that TestController::resetStateToConsistentValues() sometimes fails to load about:blank, likely due to an unresponsive WebProcess. When this happens, WebKitTestRunner reports the test as timing out and logs this on stderr: """ <unknown> - TestController::run - Failed to reset state to consistent values #PROCESS UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 57421) """ This is unfortunate because this does not indicate that anything is particularly wrong with the test in question. Rather, it indicates that the WebProcess is unresponsive (likely due to a hang caused by a previous test), which prevents WebKitTestRunner to reset the state in order to run the test. I propose that if we fail to load about:blank once, we log an error message to stderr but then terminate the WebProcess and try once again, to make WebKitTestRunner more robust. I have verified the change locally, by injecting a script in resetStateToConsistentValues() that causes a WebProcess hang. Before my change, the test would time out and the same logging as in <rdar://problem/63493074> would show. After my change though, the test would pass successfully despite the WebProcess hang. 1655353 1 cdumez 2020-05-22 10:35:57 -0700 <rdar://problem/63493074> 1655357 2 400056 cdumez 2020-05-22 10:38:02 -0700 Created attachment 400056 Patch 1655364 3 400056 ggaren 2020-05-22 10:58:33 -0700 Comment on attachment 400056 Patch r=me 1655371 4 ews-feeder 2020-05-22 11:19:08 -0700 Committed r262065: <https://trac.webkit.org/changeset/262065> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400056. 400056 2020-05-22 10:38:02 -0700 2020-05-22 11:19:08 -0700 Patch bug-212268-20200522103801.patch text/plain 3679 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMDU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODE4OTk1N2VhY2FlYjdjMTdiM2I5N2E4YTU3OTU4MzUw NmIyNmE1NS4uMTU1MTQ3NzQ5OWYyMDkzMzMzYTc2Mzg4YTQ5Y2M1NTBiZmQxYmU2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1 IEBACisyMDIwLTA1LTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgW1dLVFJdIE1ha2UgVGVzdENvbnRyb2xsZXI6OnJlc2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1 ZXMoKSBtb3JlIHJvYnVzdCBhZ2FpbnN0IGZhaWx1cmVzIHRvIG5hdmlnYXRlIHRvIGFib3V0OmJs YW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIy NjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYzNDkzMDc0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgVGVzdENvbnRyb2xsZXI6OnJlc2V0 U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMoKSBtb3JlIHJvYnVzdCBhZ2FpbnN0IGZhaWx1cmVzIHRv IG5hdmlnYXRlIHRvIGFib3V0OmJsYW5rLgorCisgICAgICAgIEluIDxyZGFyOi8vcHJvYmxlbS82 MzQ5MzA3ND4sIHdlIGhhdmUgZXZpZGVuY2UgdGhhdCBUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0 ZVRvQ29uc2lzdGVudFZhbHVlcygpIHNvbWV0aW1lcworICAgICAgICBmYWlscyB0byBsb2FkIGFi b3V0OmJsYW5rLCBsaWtlbHkgZHVlIHRvIGFuIHVucmVzcG9uc2l2ZSBXZWJQcm9jZXNzLiBXaGVu IHRoaXMgaGFwcGVucywgV2ViS2l0VGVzdFJ1bm5lcgorICAgICAgICByZXBvcnRzIHRoZSB0ZXN0 IGFzIHRpbWluZyBvdXQgYW5kIGxvZ3MgdGhpcyBvbiBzdGRlcnI6CisgICAgICAgICIiIgorICAg ICAgICA8dW5rbm93bj4gLSBUZXN0Q29udHJvbGxlcjo6cnVuIC0gRmFpbGVkIHRvIHJlc2V0IHN0 YXRlIHRvIGNvbnNpc3RlbnQgdmFsdWVzCisgICAgICAgICNQUk9DRVNTIFVOUkVTUE9OU0lWRSAt IGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5EZXZlbG9wbWVudCAocGlkIDU3NDIxKQorICAg ICAgICAiIiIKKworICAgICAgICBUaGlzIGlzIHVuZm9ydHVuYXRlIGJlY2F1c2UgdGhpcyBkb2Vz IG5vdCBpbmRpY2F0ZSB0aGF0IGFueXRoaW5nIGlzIHBhcnRpY3VsYXJseSB3cm9uZyB3aXRoIHRo ZSB0ZXN0IGluCisgICAgICAgIHF1ZXN0aW9uLiBSYXRoZXIsIGl0IGluZGljYXRlcyB0aGF0IHRo ZSBXZWJQcm9jZXNzIGlzIHVucmVzcG9uc2l2ZSAobGlrZWx5IGR1ZSB0byBhIGhhbmcgY2F1c2Vk IGJ5IGEKKyAgICAgICAgcHJldmlvdXMgdGVzdCksIHdoaWNoIHByZXZlbnRzIFdlYktpdFRlc3RS dW5uZXIgdG8gcmVzZXQgdGhlIHN0YXRlIGluIG9yZGVyIHRvIHJ1biB0aGUgdGVzdC4KKworICAg ICAgICBJIHByb3Bvc2UgdGhhdCBpZiB3ZSBmYWlsIHRvIGxvYWQgYWJvdXQ6Ymxhbmsgb25jZSwg d2UgbG9nIGFuIGVycm9yIG1lc3NhZ2UgdG8gc3RkZXJyIGJ1dCB0aGVuIHRlcm1pbmF0ZQorICAg ICAgICB0aGUgV2ViUHJvY2VzcyBhbmQgdHJ5IG9uY2UgYWdhaW4sIHRvIG1ha2UgV2ViS2l0VGVz dFJ1bm5lciBtb3JlIHJvYnVzdC4KKyAgICAgICAgSSBoYXZlIHZlcmlmaWVkIHRoZSBjaGFuZ2Ug bG9jYWxseSwgYnkgaW5qZWN0aW5nIGEgc2NyaXB0IGluIHJlc2V0U3RhdGVUb0NvbnNpc3RlbnRW YWx1ZXMoKSB0aGF0IGNhdXNlcworICAgICAgICBhIFdlYlByb2Nlc3MgaGFuZy4gQmVmb3JlIG15 IGNoYW5nZSwgdGhlIHRlc3Qgd291bGQgdGltZSBvdXQgYW5kIHRoZSBzYW1lIGxvZ2dpbmcgYXMg aW4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYzNDkzMDc0PiB3b3VsZCBzaG93LiBBZnRlciBt eSBjaGFuZ2UgdGhvdWdoLCB0aGUgdGVzdCB3b3VsZCBwYXNzIHN1Y2Nlc3NmdWxseSBkZXNwaXRl IHRoZQorICAgICAgICBXZWJQcm9jZXNzIGhhbmcuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVu bmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OnJl c2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDIwLTA1LTIyICBQaGlsaXBwZSBOb3Jt YW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRmxhdHBhayBTREtdIEFkZCBi dWJibGV3cmFwIC4uLiB3cmFwcGVyCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwCmluZGV4IGQzOGQ4NTRiNzYwMmRmNzU1Y2M2NzBmYTY0MTI3MTJkOWQxYWIzMGQuLjY3 MTVmZDIyYzhhYTc5OGM2NTMzM2U2YjEzYzUxOTEyYzVmMWQ4NjkgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBAIC0xMTQyLDEyICsxMTQyLDIyIEBAIGJvb2wg VGVzdENvbnRyb2xsZXI6OnJlc2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMoY29uc3QgVGVzdE9w dGlvbnMmIG9wdGlvbnMsIFJlCiAgICAgbV9zZXJ2ZXJUcnVzdEV2YWx1YXRpb25DYWxsYmFja0Nh bGxzQ291bnQgPSAwOwogICAgIG1fc2hvdWxkRGlzbWlzc0phdmFTY3JpcHRBbGVydHNBc3luY2hy b25vdXNseSA9IGZhbHNlOwogCisgICAgYXV0byBsb2FkQWJvdXRCbGFuayA9IFt0aGlzXSB7Cisg ICAgICAgIG1fZG9uZVJlc2V0dGluZyA9IGZhbHNlOworICAgICAgICBXS1BhZ2VMb2FkVVJMKG1f bWFpbldlYlZpZXctPnBhZ2UoKSwgYmxhbmtVUkwoKSk7CisgICAgICAgIHJ1blVudGlsKG1fZG9u ZVJlc2V0dGluZywgbV9jdXJyZW50SW52b2NhdGlvbi0+c2hvcnRUaW1lb3V0KCkpOworICAgICAg ICByZXR1cm4gbV9kb25lUmVzZXR0aW5nOworICAgIH07CisKICAgICAvLyBSZXNldCBtYWluIHBh Z2UgYmFjayB0byBhYm91dDpibGFuawotICAgIG1fZG9uZVJlc2V0dGluZyA9IGZhbHNlOwotICAg IFdLUGFnZUxvYWRVUkwobV9tYWluV2ViVmlldy0+cGFnZSgpLCBibGFua1VSTCgpKTsKLSAgICBy dW5VbnRpbChtX2RvbmVSZXNldHRpbmcsIG1fY3VycmVudEludm9jYXRpb24tPnNob3J0VGltZW91 dCgpKTsKLSAgICBpZiAoIW1fZG9uZVJlc2V0dGluZykKLSAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIGlmICghbG9hZEFib3V0QmxhbmsoKSkgeworICAgICAgICBXVEZMb2dBbHdheXMoIkZhaWxl ZCB0byBsb2FkICdhYm91dDpibGFuaycsIHRlcm1pbmF0aW5nIHByb2Nlc3MgYW5kIHRyeWluZyBh Z2Fpbi4iKTsKKyAgICAgICAgV0tQYWdlVGVybWluYXRlKG1fbWFpbldlYlZpZXctPnBhZ2UoKSk7 CisgICAgICAgIGlmICghbG9hZEFib3V0QmxhbmsoKSkgeworICAgICAgICAgICAgV1RGTG9nQWx3 YXlzKCJGYWlsZWQgdG8gbG9hZCAnYWJvdXQ6YmxhbmsnIGFnYWluIGFmdGVyIHRlcm1pbmF0aW9u LiIpOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CisgICAgfQogICAgIAog ICAgIGlmIChyZXNldFN0YWdlID09IFJlc2V0U3RhZ2U6OkFmdGVyVGVzdCkgewogICAgICAgICB1 cGRhdGVMaXZlRG9jdW1lbnRzQWZ0ZXJUZXN0KCk7Cg==