212247 2020-05-21 19:24:04 -0700 Extended Color Cleanup: Move Color coder definitions to Color to allow for future encaspulation improvements 2020-05-21 20:53:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212184 1 sam sam darin simon.fraser webkit-bug-importer oldest_to_newest 1655194 0 sam 2020-05-21 19:24:04 -0700 Extended Color Cleanup: Move Color coder definitions to Color to allow for future encaspulation improvements 1655195 1 400011 sam 2020-05-21 19:28:58 -0700 Created attachment 400011 Patch 1655230 2 ews-feeder 2020-05-21 20:52:12 -0700 Committed r262045: <https://trac.webkit.org/changeset/262045> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400011. 1655232 3 webkit-bug-importer 2020-05-21 20:53:15 -0700 <rdar://problem/63526276> 400011 2020-05-21 19:28:58 -0700 2020-05-21 20:52:13 -0700 Patch bug-212247-20200521192857.patch text/plain 7196 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MjA0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTIxICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBFeHRlbmRlZCBDb2xvciBDbGVhbnVw OiBNb3ZlIENvbG9yIGNvZGVyIGRlZmluaXRpb25zIHRvIENvbG9yIHRvIGFsbG93IGZvciBmdXR1 cmUgZW5jYXNwdWxhdGlvbiBpbXByb3ZlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjI0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgSVBDIGVuY29kZXIvZGVjb2RlciBkZWZpbml0aW9u cyBmcm9tIFdlYktpdCBkb3duIGludG8gQ29sb3IgaXRzZWxmIHRvIG1vdmUgY2xvc2VyCisgICAg ICAgIHRvIG1ha2luZyBDb2xvcjo6cmdiKCkgcHJpdmF0ZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL0NvbG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpDb2xvcjo6ZW5jb2RlIGNvbnN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbG9yOjpkZWNvZGUpOgorCiAyMDIwLTA1LTIxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBzb21lIHRo cmVhZCBzYWZldHkgaXNzdWVzIHdpdGggU2Nyb2xsQ29udHJvbGxlciB0aW1lcnMKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3IuaAkocmV2aXNpb24gMjYyMDQyKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3IuaAkod29ya2luZyBjb3B5 KQpAQCAtMjg2LDYgKzI4Niw5IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBpc0JsYWNrQ29s b3IoY29uc3QgQ29sb3ImKTsKICAgICBzdGF0aWMgYm9vbCBpc1doaXRlQ29sb3IoY29uc3QgQ29s b3ImKTsKIAorICAgIHRlbXBsYXRlPGNsYXNzIEVuY29kZXI+IHZvaWQgZW5jb2RlKEVuY29kZXIm KSBjb25zdDsKKyAgICB0ZW1wbGF0ZTxjbGFzcyBEZWNvZGVyPiBzdGF0aWMgT3B0aW9uYWw8Q29s b3I+IGRlY29kZShEZWNvZGVyJik7CisKIHByaXZhdGU6CiAgICAgdm9pZCBzZXRSR0IoaW50IHIs IGludCBnLCBpbnQgYikgeyBzZXRSR0IobWFrZVJHQihyLCBnLCBiKSk7IH0KICAgICB2b2lkIHNl dFJHQihSR0JBMzIpOwpAQCAtNDM5LDYgKzQ0Miw3NCBAQCBpbmxpbmUgYm9vbCBDb2xvcjo6aXNX aGl0ZUNvbG9yKGNvbnN0IENvCiAgICAgcmV0dXJuIGNvbG9yLnJnYigpID09IENvbG9yOjp3aGl0 ZTsKIH0KIAordGVtcGxhdGU8Y2xhc3MgRW5jb2Rlcj4KK3ZvaWQgQ29sb3I6OmVuY29kZShFbmNv ZGVyJiBlbmNvZGVyKSBjb25zdAoreworICAgIGlmIChpc0V4dGVuZGVkKCkpIHsKKyAgICAgICAg ZW5jb2RlciA8PCB0cnVlOworICAgICAgICBlbmNvZGVyIDw8IGFzRXh0ZW5kZWQoKS5yZWQoKTsK KyAgICAgICAgZW5jb2RlciA8PCBhc0V4dGVuZGVkKCkuZ3JlZW4oKTsKKyAgICAgICAgZW5jb2Rl ciA8PCBhc0V4dGVuZGVkKCkuYmx1ZSgpOworICAgICAgICBlbmNvZGVyIDw8IGFzRXh0ZW5kZWQo KS5hbHBoYSgpOworICAgICAgICBlbmNvZGVyIDw8IGFzRXh0ZW5kZWQoKS5jb2xvclNwYWNlKCk7 CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBlbmNvZGVyIDw8IGZhbHNlOworCisgICAg aWYgKCFpc1ZhbGlkKCkpIHsKKyAgICAgICAgZW5jb2RlciA8PCBmYWxzZTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKworICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBlbmNvZGUgd2hldGhlciB0 aGUgY29sb3IgaXMgc2VtYW50aWMuCisKKyAgICB1aW50MzJfdCB2YWx1ZSA9IHJnYigpLnZhbHVl KCk7CisKKyAgICBlbmNvZGVyIDw8IHRydWU7CisgICAgZW5jb2RlciA8PCB2YWx1ZTsKK30KKwor dGVtcGxhdGU8Y2xhc3MgRGVjb2Rlcj4KK09wdGlvbmFsPENvbG9yPiBDb2xvcjo6ZGVjb2RlKERl Y29kZXImIGRlY29kZXIpCit7CisgICAgYm9vbCBpc0V4dGVuZGVkOworICAgIGlmICghZGVjb2Rl ci5kZWNvZGUoaXNFeHRlbmRlZCkpCisgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CisKKyAg ICBpZiAoaXNFeHRlbmRlZCkgeworICAgICAgICBmbG9hdCByZWQ7CisgICAgICAgIGZsb2F0IGdy ZWVuOworICAgICAgICBmbG9hdCBibHVlOworICAgICAgICBmbG9hdCBhbHBoYTsKKyAgICAgICAg Q29sb3JTcGFjZSBjb2xvclNwYWNlOworICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlZCkp CisgICAgICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OworICAgICAgICBpZiAoIWRlY29kZXIu ZGVjb2RlKGdyZWVuKSkKKyAgICAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CisgICAgICAg IGlmICghZGVjb2Rlci5kZWNvZGUoYmx1ZSkpCisgICAgICAgICAgICByZXR1cm4gV1RGOjpudWxs b3B0OworICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGFscGhhKSkKKyAgICAgICAgICAgIHJl dHVybiBXVEY6Om51bGxvcHQ7CisgICAgICAgIGlmICghZGVjb2Rlci5kZWNvZGUoY29sb3JTcGFj ZSkpCisgICAgICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OworICAgICAgICByZXR1cm4gQ29s b3IocmVkLCBncmVlbiwgYmx1ZSwgYWxwaGEsIGNvbG9yU3BhY2UpOworICAgIH0KKworICAgIGJv b2wgaXNWYWxpZDsKKyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGlzVmFsaWQpKQorICAgICAgICBy ZXR1cm4gV1RGOjpudWxsb3B0OworCisgICAgaWYgKCFpc1ZhbGlkKQorICAgICAgICByZXR1cm4g Q29sb3IoKTsKKworICAgIHVpbnQzMl90IHZhbHVlOworICAgIGlmICghZGVjb2Rlci5kZWNvZGUo dmFsdWUpKQorICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OworCisgICAgcmV0dXJuIENvbG9y IHsgU2ltcGxlQ29sb3IgeyB2YWx1ZSB9IH07Cit9CisKIGNvbnN0ZXhwciBSR0JBMzIgbWFrZVJH QihpbnQgciwgaW50IGcsIGludCBiKQogewogICAgIHJldHVybiBtYWtlUkdCQShyLCBnLCBiLCAw eEZGKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjIwNDMpCisrKyBTb3VyY2UvV2ViS2l0L0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA1LTIxICBTYW0g V2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBFeHRlbmRlZCBDb2xvciBDbGVh bnVwOiBNb3ZlIENvbG9yIGNvZGVyIGRlZmluaXRpb25zIHRvIENvbG9yIHRvIGFsbG93IGZvciBm dXR1cmUgZW5jYXNwdWxhdGlvbiBpbXByb3ZlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjI0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgSVBDIGVuY29kZXIvZGVjb2RlciBkZWZpbml0 aW9ucyBmcm9tIFdlYktpdCBkb3duIGludG8gQ29sb3IgaXRzZWxmIHRvIG1vdmUgY2xvc2VyCisg ICAgICAgIHRvIG1ha2luZyBDb2xvcjo6cmdiKCkgcHJpdmF0ZS4KKworICAgICAgICAqIFNoYXJl ZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVy PENvbG9yPjo6ZW5jb2RlKTogRGVsZXRlZC4KKyAgICAgICAgKElQQzo6QXJndW1lbnRDb2RlcjxD b2xvcj46OmRlY29kZSk6IERlbGV0ZWQuCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVu dENvZGVycy5oOgorCiAyMDIwLTA1LTIxICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IGlzc3VlcyBvZiB0aGUgUGljdHVyZS1pbi1QaWN0dXJlIEFQSSB1bmRl ciBzdHJlc3MgdGVzdHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVu dENvZGVycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQvV2ViQ29yZUFy Z3VtZW50Q29kZXJzLmNwcAkocmV2aXNpb24gMjYyMDQyKQorKysgU291cmNlL1dlYktpdC9TaGFy ZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUyNiw4NCAr MTUyNiw2IEBAIGJvb2wgQXJndW1lbnRDb2RlcjxXaW5kb3dGZWF0dXJlcz46OmRlY28KICAgICBy ZXR1cm4gdHJ1ZTsKIH0KIAotCi12b2lkIEFyZ3VtZW50Q29kZXI8Q29sb3I+OjplbmNvZGUoRW5j b2RlciYgZW5jb2RlciwgY29uc3QgQ29sb3ImIGNvbG9yKQotewotICAgIGlmIChjb2xvci5pc0V4 dGVuZGVkKCkpIHsKLSAgICAgICAgZW5jb2RlciA8PCB0cnVlOwotICAgICAgICBlbmNvZGVyIDw8 IGNvbG9yLmFzRXh0ZW5kZWQoKS5yZWQoKTsKLSAgICAgICAgZW5jb2RlciA8PCBjb2xvci5hc0V4 dGVuZGVkKCkuZ3JlZW4oKTsKLSAgICAgICAgZW5jb2RlciA8PCBjb2xvci5hc0V4dGVuZGVkKCku Ymx1ZSgpOwotICAgICAgICBlbmNvZGVyIDw8IGNvbG9yLmFzRXh0ZW5kZWQoKS5hbHBoYSgpOwot ICAgICAgICBlbmNvZGVyIDw8IGNvbG9yLmFzRXh0ZW5kZWQoKS5jb2xvclNwYWNlKCk7Ci0gICAg ICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBlbmNvZGVyIDw8IGZhbHNlOwotCi0gICAgaWYgKCFj b2xvci5pc1ZhbGlkKCkpIHsKLSAgICAgICAgZW5jb2RlciA8PCBmYWxzZTsKLSAgICAgICAgcmV0 dXJuOwotICAgIH0KLQotICAgIHVpbnQzMl90IHZhbHVlID0gY29sb3IucmdiKCkudmFsdWUoKTsK LQotICAgIGVuY29kZXIgPDwgdHJ1ZTsKLSAgICBlbmNvZGVyIDw8IHZhbHVlOwotfQotCi1ib29s IEFyZ3VtZW50Q29kZXI8Q29sb3I+OjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgQ29sb3ImIGNv bG9yKQotewotICAgIGJvb2wgaXNFeHRlbmRlZDsKLSAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGlz RXh0ZW5kZWQpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBpZiAoaXNFeHRlbmRlZCkg ewotICAgICAgICBmbG9hdCByZWQ7Ci0gICAgICAgIGZsb2F0IGdyZWVuOwotICAgICAgICBmbG9h dCBibHVlOwotICAgICAgICBmbG9hdCBhbHBoYTsKLSAgICAgICAgQ29sb3JTcGFjZSBjb2xvclNw YWNlOwotICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlZCkpCi0gICAgICAgICAgICByZXR1 cm4gZmFsc2U7Ci0gICAgICAgIGlmICghZGVjb2Rlci5kZWNvZGUoZ3JlZW4pKQotICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwotICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGJsdWUpKQotICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGFscGhh KSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgaWYgKCFkZWNvZGVyLmRlY29k ZShjb2xvclNwYWNlKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgY29sb3Ig PSBDb2xvcihyZWQsIGdyZWVuLCBibHVlLCBhbHBoYSwgY29sb3JTcGFjZSk7Ci0gICAgICAgIHJl dHVybiB0cnVlOwotICAgIH0KLQotICAgIGJvb2wgaXNWYWxpZDsKLSAgICBpZiAoIWRlY29kZXIu ZGVjb2RlKGlzVmFsaWQpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBpZiAoIWlzVmFs aWQpIHsKLSAgICAgICAgY29sb3IgPSBDb2xvcigpOwotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAg ICB9Ci0KLSAgICB1aW50MzJfdCB2YWx1ZTsKLSAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHZhbHVl KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgY29sb3IgPSBTaW1wbGVDb2xvciB7IHZh bHVlIH07Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KLU9wdGlvbmFsPENvbG9yPiBBcmd1bWVudENv ZGVyPENvbG9yPjo6ZGVjb2RlKERlY29kZXImIGRlY29kZXIpCi17Ci0gICAgQ29sb3IgY29sb3I7 Ci0gICAgaWYgKCFkZWNvZGUoZGVjb2RlciwgY29sb3IpKQotICAgICAgICByZXR1cm4gV1RGOjpu dWxsb3B0OwotCi0gICAgcmV0dXJuIGNvbG9yOwotfQotCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9S VCkKIHZvaWQgQXJndW1lbnRDb2RlcjxEcmFnRGF0YT46OmVuY29kZShFbmNvZGVyJiBlbmNvZGVy LCBjb25zdCBEcmFnRGF0YSYgZHJhZ0RhdGEpCiB7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1NoYXJl ZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1No YXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAkocmV2aXNpb24gMjYyMDQyKQorKysgU291cmNl L1dlYktpdC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgJKHdvcmtpbmcgY29weSkKQEAg LTQ0MywxMiArNDQzLDYgQEAgdGVtcGxhdGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxXZWJDb3Jl OgogICAgIHN0YXRpYyBXQVJOX1VOVVNFRF9SRVRVUk4gYm9vbCBkZWNvZGUoRGVjb2RlciYsIFdl YkNvcmU6OldpbmRvd0ZlYXR1cmVzJik7CiB9OwogCi10ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVu dENvZGVyPFdlYkNvcmU6OkNvbG9yPiB7Ci0gICAgc3RhdGljIHZvaWQgZW5jb2RlKEVuY29kZXIm LCBjb25zdCBXZWJDb3JlOjpDb2xvciYpOwotICAgIHN0YXRpYyBXQVJOX1VOVVNFRF9SRVRVUk4g Ym9vbCBkZWNvZGUoRGVjb2RlciYsIFdlYkNvcmU6OkNvbG9yJik7Ci0gICAgc3RhdGljIE9wdGlv bmFsPFdlYkNvcmU6OkNvbG9yPiBkZWNvZGUoRGVjb2RlciYpOwotfTsKLQogI2lmIEVOQUJMRShE UkFHX1NVUFBPUlQpCiB0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OkRy YWdEYXRhPiB7CiAgICAgc3RhdGljIHZvaWQgZW5jb2RlKEVuY29kZXImLCBjb25zdCBXZWJDb3Jl OjpEcmFnRGF0YSYpOwo=