212240 2020-05-21 16:51:27 -0700 PVRTC compressed textures are failing with ANGLE backend 2020-06-01 14:20:56 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212612 1 dino dino dino ews-watchlist graouts jdarpinian justin_fan kbr kondapallykalyan webkit-bug-importer oldest_to_newest 1655148 0 dino 2020-05-21 16:51:27 -0700 extensions/webgl-compressed-texture-pvrtc.html is failing. uploading data with COMPRESSED_RGB_PVRTC_2BPPV1_IMG produces an INVALID_VALUE 1655149 1 webkit-bug-importer 2020-05-21 16:51:39 -0700 <rdar://problem/63517385> 1655164 2 kbr 2020-05-21 17:15:20 -0700 Inside ANGLE, ValidateCompressedTexImage2D in src/libANGLE/validationES2.cpp, this is the code which is failing: GLuint blockSize = 0; if (!formatInfo.computeCompressedImageSize(Extents(width, height, 1), &blockSize)) { context->validationError(GL_INVALID_OPERATION, kIntegerOverflow); return false; } if (imageSize < 0 || static_cast<GLuint>(imageSize) != blockSize) { context->validationError(GL_INVALID_VALUE, kCompressedTextureDimensionsMustMatchData); // <--- fails return false; } Here, imageSize is 32 but blockSize is 0. computeCompressedImageSize failed to compute the compressed image size. 1655166 3 dino 2020-05-21 17:23:16 -0700 It comes from formatutils.cpp AddCompressedFormat(&map, GL_COMPRESSED_RGB_PVRTC_2BPPV1_IMG.... produces a pixelBytes value of 0, because compressedBlockSize is 1, and it is divided by 8 to produce 0. 1655180 4 dino 2020-05-21 18:20:06 -0700 If I update the values in formatutils.cpp to use 32 and 16 for blocksize on 4bpp and 2bpp respectively, things start working much better. The rendering looks good too. I still get some errors though: testing COMPRESSED_RGBA_PVRTC_2BPPV1_IMG 4x4 PASS getError was expected value: NO_ERROR : uploading compressed texture PASS getError was expected value: INVALID_OPERATION : trying to generate mipmaps from compressed texture expected actual PASS texture rendered correctly PASS getError was expected value: INVALID_VALUE : non 0 border FAIL getError expected: INVALID_OPERATION. Was INVALID_VALUE : invalid dimensions FAIL getError expected: INVALID_OPERATION. Was INVALID_VALUE : invalid dimensions FAIL getError expected: INVALID_OPERATION. Was INVALID_VALUE : invalid dimensions FAIL getError expected: INVALID_OPERATION. Was INVALID_VALUE : invalid dimensions PASS getError was expected value: NO_ERROR : compressedTexSubImage2D allowed for reloading of complete textures PASS getError was expected value: INVALID_OPERATION : compressedTexSubImage2D not allowed for partial texture updates PASS getError was expected value: INVALID_OPERATION : compressedTexSubImage2D not allowed for partial texture updates PASS getError was expected value: INVALID_OPERATION : compressedTexSubImage2D not allowed for partial texture updates PASS getError was expected value: INVALID_OPERATION : compressedTexSubImage2D not allowed for partial texture updates 1655201 5 400013 kbr 2020-05-21 19:33:47 -0700 Created attachment 400013 Patch for testing Patch for testing 1655202 6 kbr 2020-05-21 19:35:00 -0700 Dean, could you try this patch instead? From reading the PVRTC extension spec: https://www.khronos.org/registry/OpenGL/extensions/IMG/IMG_texture_compression_pvrtc.txt I think the compressed block size for 2BPP textures is 16x8, and for 4BPP textures, 8x8. This equates to a block size of 256 bits for both formats. 1655212 7 400016 dino 2020-05-21 20:16:27 -0700 Created attachment 400016 Patch 1655213 8 ews-watchlist 2020-05-21 20:17:11 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1655214 9 400016 kbr 2020-05-21 20:17:35 -0700 Comment on attachment 400016 Patch LGTM 1655215 10 kbr 2020-05-21 20:17:54 -0700 Looks good to me but I think the CQ's going to reject my review bit! 1655216 11 dino 2020-05-21 20:21:47 -0700 I will land manually to avoid any robots checking your status! 1655217 12 dino 2020-05-21 20:26:46 -0700 Committed r262044: <https://trac.webkit.org/changeset/262044> 400013 2020-05-21 19:33:47 -0700 2020-05-21 20:16:24 -0700 Patch for testing pvrtc.patch text/plain 4712 kbr ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9mb3JtYXR1 dGlscy5jcHAgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvZm9ybWF0dXRp bHMuY3BwCmluZGV4IGViODI3NDk4NTEzLi41OGUxNjgyMjk5ZiAxMDA2NDQKLS0tIGEvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL2Zvcm1hdHV0aWxzLmNwcAorKysgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvZm9ybWF0dXRpbHMuY3BwCkBAIC05NzEs MTcgKzk3MSwxNyBAQCBzdGF0aWMgSW50ZXJuYWxGb3JtYXRJbmZvTWFwIEJ1aWxkSW50ZXJuYWxG b3JtYXRJbmZvTWFwKCkKIAogICAgIC8vIEZyb20gR0xfSU1HX3RleHR1cmVfY29tcHJlc3Npb25f cHZydGMKICAgICAvLyAgICAgICAgICAgICAgICAgICAgICAgfCBJbnRlcm5hbCBmb3JtYXQgICAg ICAgICAgICAgICAgICAgICAgIHwgVyB8IEggfCBEIHwgQlMgfENDfCBTUkdCIHwgVGV4dHVyZSBz dXBwb3J0ZWQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IEZpbHRlcmFibGUgICAg IHwgVGV4dHVyZSBhdHRhY2htZW50IHwgUmVuZGVyYnVmZmVyICB8IEJsZW5kCi0gICAgQWRkQ29t cHJlc3NlZEZvcm1hdCgmbWFwLCBHTF9DT01QUkVTU0VEX1JHQl9QVlJUQ180QlBQVjFfSU1HLCAg ICAgIDEsICAxLCAgMSwgICAxLCAzLCBmYWxzZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29t cHJlc3NlZFRleHR1cmVQVlJUQz4sICAgIEFsd2F5c1N1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQs ICAgICAgTmV2ZXJTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkKTsKLSAgICBBZGRDb21wcmVzc2Vk Rm9ybWF0KCZtYXAsIEdMX0NPTVBSRVNTRURfUkdCX1BWUlRDXzJCUFBWMV9JTUcsICAgICAgMSwg IDEsICAxLCAgIDEsIDMsIGZhbHNlLCBSZXF1aXJlRXh0PCZFeHRlbnNpb25zOjpjb21wcmVzc2Vk VGV4dHVyZVBWUlRDPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCwgICAgICBO ZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOwotICAgIEFkZENvbXByZXNzZWRGb3JtYXQo Jm1hcCwgR0xfQ09NUFJFU1NFRF9SR0JBX1BWUlRDXzRCUFBWMV9JTUcsICAgICAxLCAgMSwgIDEs ICAgMSwgNCwgZmFsc2UsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6OmNvbXByZXNzZWRUZXh0dXJl UFZSVEM+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAgIE5ldmVyU3Vw cG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7Ci0gICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFwLCBH TF9DT01QUkVTU0VEX1JHQkFfUFZSVENfMkJQUFYxX0lNRywgICAgIDEsICAxLCAgMSwgICAxLCA0 LCBmYWxzZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQz4s ICAgIEFsd2F5c1N1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQsICAgICAgTmV2ZXJTdXBwb3J0ZWQs IE5ldmVyU3VwcG9ydGVkKTsKKyAgICBBZGRDb21wcmVzc2VkRm9ybWF0KCZtYXAsIEdMX0NPTVBS RVNTRURfUkdCX1BWUlRDXzRCUFBWMV9JTUcsICAgICAgOCwgIDgsICAxLCAyNTYsIDMsIGZhbHNl LCBSZXF1aXJlRXh0PCZFeHRlbnNpb25zOjpjb21wcmVzc2VkVGV4dHVyZVBWUlRDPiwgICAgQWx3 YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJT dXBwb3J0ZWQpOworICAgIEFkZENvbXByZXNzZWRGb3JtYXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9S R0JfUFZSVENfMkJQUFYxX0lNRywgICAgIDE2LCAgOCwgIDEsIDI1NiwgMywgZmFsc2UsIFJlcXVp cmVFeHQ8JkV4dGVuc2lvbnM6OmNvbXByZXNzZWRUZXh0dXJlUFZSVEM+LCAgICBBbHdheXNTdXBw b3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAgIE5ldmVyU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRl ZCk7CisgICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFwLCBHTF9DT01QUkVTU0VEX1JHQkFfUFZS VENfNEJQUFYxX0lNRywgICAgIDgsICA4LCAgMSwgMjU2LCA0LCBmYWxzZSwgUmVxdWlyZUV4dDwm RXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQz4sICAgIEFsd2F5c1N1cHBvcnRlZCwg TmV2ZXJTdXBwb3J0ZWQsICAgICAgTmV2ZXJTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkKTsKKyAg ICBBZGRDb21wcmVzc2VkRm9ybWF0KCZtYXAsIEdMX0NPTVBSRVNTRURfUkdCQV9QVlJUQ18yQlBQ VjFfSU1HLCAgICAxNiwgIDgsICAxLCAyNTYsIDQsIGZhbHNlLCBSZXF1aXJlRXh0PCZFeHRlbnNp b25zOjpjb21wcmVzc2VkVGV4dHVyZVBWUlRDPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1 cHBvcnRlZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOwogCiAgICAgLy8g RnJvbSBHTF9FWFRfcHZydGNfc1JHQgogICAgIC8vICAgICAgICAgICAgICAgICAgICAgICB8IElu dGVybmFsIGZvcm1hdCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBXIHwgSCB8IEQgfCBC UyB8Q0N8IFNSR0IgfCBUZXh0dXJlIHN1cHBvcnRlZCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8IEZpbHRlcmFibGUgICAgIHwgVGV4dHVyZSBhdHRhY2htZW50IHwgUmVuZGVy YnVmZmVyICB8IEJsZW5kCi0gICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFwLCBHTF9DT01QUkVT U0VEX1NSR0JfUFZSVENfMkJQUFYxX0VYVCwgICAgICAgICAgIDEsICAxLCAgMSwgICAxLCAzLCAg dHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQ3NSR0I+ LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAgIE5ldmVyU3VwcG9ydGVk LCBOZXZlclN1cHBvcnRlZCk7Ci0gICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFwLCBHTF9DT01Q UkVTU0VEX1NSR0JfUFZSVENfNEJQUFYxX0VYVCwgICAgICAgICAgIDEsICAxLCAgMSwgICAxLCAz LCAgdHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQ3NS R0I+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAgIE5ldmVyU3VwcG9y dGVkLCBOZXZlclN1cHBvcnRlZCk7Ci0gICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFwLCBHTF9D T01QUkVTU0VEX1NSR0JfQUxQSEFfUFZSVENfMkJQUFYxX0VYVCwgICAgIDEsICAxLCAgMSwgICAx LCA0LCAgdHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJU Q3NSR0I+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAgIE5ldmVyU3Vw cG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7Ci0gICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFwLCBH TF9DT01QUkVTU0VEX1NSR0JfQUxQSEFfUFZSVENfNEJQUFYxX0VYVCwgICAgIDEsICAxLCAgMSwg ICAxLCA0LCAgdHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQ VlJUQ3NSR0I+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAgIE5ldmVy U3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7CisgICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFw LCBHTF9DT01QUkVTU0VEX1NSR0JfUFZSVENfMkJQUFYxX0VYVCwgICAgICAgICAgMTYsICA4LCAg MSwgMjU2LCAzLCAgdHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1 cmVQVlJUQ3NSR0I+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAgIE5l dmVyU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7CisgICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgm bWFwLCBHTF9DT01QUkVTU0VEX1NSR0JfUFZSVENfNEJQUFYxX0VYVCwgICAgICAgICAgIDgsICA4 LCAgMSwgMjU2LCAzLCAgdHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRl eHR1cmVQVlJUQ3NSR0I+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAg IE5ldmVyU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7CisgICAgQWRkQ29tcHJlc3NlZEZvcm1h dCgmbWFwLCBHTF9DT01QUkVTU0VEX1NSR0JfQUxQSEFfUFZSVENfMkJQUFYxX0VYVCwgICAgMTYs ICA4LCAgMSwgMjU2LCA0LCAgdHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3Nl ZFRleHR1cmVQVlJUQ3NSR0I+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAg ICAgIE5ldmVyU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7CisgICAgQWRkQ29tcHJlc3NlZEZv cm1hdCgmbWFwLCBHTF9DT01QUkVTU0VEX1NSR0JfQUxQSEFfUFZSVENfNEJQUFYxX0VYVCwgICAg IDgsICA4LCAgMSwgMjU2LCA0LCAgdHJ1ZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJl c3NlZFRleHR1cmVQVlJUQ3NSR0I+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVk LCAgICAgIE5ldmVyU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7CiAKICAgICAvLyBGb3IgU1RF TkNJTF9JTkRFWDggd2UgY2hvc2UgYSBub3JtYWxpemVkIGNvbXBvbmVudCB0eXBlIGZvciB0aGUg Zm9sbG93aW5nIHJlYXNvbnM6CiAgICAgLy8gLSBNdWx0aXNhbXBsZWQgYnVmZmVyIGFyZSBkaXNh bGxvd2VkIGZvciBub24tbm9ybWFsaXplZCBpbnRlZ2VyIGNvbXBvbmVudCB0eXBlcyBhbmQgd2Ug d2FudCB0byBzdXBwb3J0IGl0IGZvciBTVEVOQ0lMX0lOREVYOAo= 400016 2020-05-21 20:16:27 -0700 2020-05-21 20:17:35 -0700 Patch bug-212240-20200522131626.patch text/plain 7416 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggODE0MDI4YWViNTc1MjBjZTVmYWY3NTdhYzQxNTI5YTQxYjE3N2VmNC4uNzlhZWNkZTQ3ZWQy NTc5NmM4YTAxMzkxNDBiOGJlOTZiNWRhYmU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA1LTIxICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KKworICAgICAgICBQVlJUQyBjb21wcmVzc2VkIHRleHR1cmVzIGFyZSBmYWlsaW5nIHdp dGggQU5HTEUgYmFja2VuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjEyMjQwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MzUxNzM4NT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdmFsdWVzIHVz ZWQgZm9yIHRoZSBQVlJUQyBmb3JtYXRzIHdlcmUgaW5jb3JyZWN0LgorCisgICAgICAgICogc3Jj L2xpYkFOR0xFL2Zvcm1hdHV0aWxzLmNwcDoKKyAgICAgICAgKGdsOjpCdWlsZEludGVybmFsRm9y bWF0SW5mb01hcCk6CisKIDIwMjAtMDUtMjEgIEtlbm5ldGggUnVzc2VsbCAgPGtickBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgRVhUX2NvbG9yX2J1ZmZlcl9oYWxmX2Zsb2F0IG5vdCBleHBvc2Vk IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xF L2Zvcm1hdHV0aWxzLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9m b3JtYXR1dGlscy5jcHAKaW5kZXggZWI4Mjc0OTg1MTNmOWUyNGUxZWU1OGFlYmU2MmU5ZTAyMmU1 NWE3ZS4uMzBkM2VjOTY4MGM5OTIxMTFjNzIyZDQ3YzYyMTU0NTI0MGQwODhkNCAxMDA2NDQKLS0t IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL2Zvcm1hdHV0aWxzLmNwcAor KysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvZm9ybWF0dXRpbHMuY3Bw CkBAIC05NzEsMTcgKzk3MSwxNyBAQCBzdGF0aWMgSW50ZXJuYWxGb3JtYXRJbmZvTWFwIEJ1aWxk SW50ZXJuYWxGb3JtYXRJbmZvTWFwKCkKIAogICAgIC8vIEZyb20gR0xfSU1HX3RleHR1cmVfY29t cHJlc3Npb25fcHZydGMKICAgICAvLyAgICAgICAgICAgICAgICAgICAgICAgfCBJbnRlcm5hbCBm b3JtYXQgICAgICAgICAgICAgICAgICAgICAgIHwgVyB8IEggfCBEIHwgQlMgfENDfCBTUkdCIHwg VGV4dHVyZSBzdXBwb3J0ZWQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IEZpbHRl cmFibGUgICAgIHwgVGV4dHVyZSBhdHRhY2htZW50IHwgUmVuZGVyYnVmZmVyICB8IEJsZW5kCi0g ICAgQWRkQ29tcHJlc3NlZEZvcm1hdCgmbWFwLCBHTF9DT01QUkVTU0VEX1JHQl9QVlJUQ180QlBQ VjFfSU1HLCAgICAgIDEsICAxLCAgMSwgICAxLCAzLCBmYWxzZSwgUmVxdWlyZUV4dDwmRXh0ZW5z aW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQz4sICAgIEFsd2F5c1N1cHBvcnRlZCwgTmV2ZXJT dXBwb3J0ZWQsICAgICAgTmV2ZXJTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkKTsKLSAgICBBZGRD b21wcmVzc2VkRm9ybWF0KCZtYXAsIEdMX0NPTVBSRVNTRURfUkdCX1BWUlRDXzJCUFBWMV9JTUcs ICAgICAgMSwgIDEsICAxLCAgIDEsIDMsIGZhbHNlLCBSZXF1aXJlRXh0PCZFeHRlbnNpb25zOjpj b21wcmVzc2VkVGV4dHVyZVBWUlRDPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRl ZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOwotICAgIEFkZENvbXByZXNz ZWRGb3JtYXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9SR0JBX1BWUlRDXzRCUFBWMV9JTUcsICAgICAx LCAgMSwgIDEsICAgMSwgNCwgZmFsc2UsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6OmNvbXByZXNz ZWRUZXh0dXJlUFZSVEM+LCAgICBBbHdheXNTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkLCAgICAg IE5ldmVyU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCk7Ci0gICAgQWRkQ29tcHJlc3NlZEZvcm1h dCgmbWFwLCBHTF9DT01QUkVTU0VEX1JHQkFfUFZSVENfMkJQUFYxX0lNRywgICAgIDEsICAxLCAg MSwgICAxLCA0LCBmYWxzZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1 cmVQVlJUQz4sICAgIEFsd2F5c1N1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQsICAgICAgTmV2ZXJT dXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVkKTsKKyAgICBBZGRDb21wcmVzc2VkRm9ybWF0KCZtYXAs IEdMX0NPTVBSRVNTRURfUkdCX1BWUlRDXzRCUFBWMV9JTUcsICAgICAgOCwgIDgsICAxLCAyNTYs ICAzLCBmYWxzZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJU Qz4sICAgIEFsd2F5c1N1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQsICAgICAgTmV2ZXJTdXBwb3J0 ZWQsIE5ldmVyU3VwcG9ydGVkKTsKKyAgICBBZGRDb21wcmVzc2VkRm9ybWF0KCZtYXAsIEdMX0NP TVBSRVNTRURfUkdCX1BWUlRDXzJCUFBWMV9JTUcsICAgICAxNiwgIDgsICAxLCAyNTYsICAzLCBm YWxzZSwgUmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQz4sICAg IEFsd2F5c1N1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQsICAgICAgTmV2ZXJTdXBwb3J0ZWQsIE5l dmVyU3VwcG9ydGVkKTsKKyAgICBBZGRDb21wcmVzc2VkRm9ybWF0KCZtYXAsIEdMX0NPTVBSRVNT RURfUkdCQV9QVlJUQ180QlBQVjFfSU1HLCAgICAgOCwgIDgsICAxLCAyNTYsICA0LCBmYWxzZSwg UmVxdWlyZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQz4sICAgIEFsd2F5 c1N1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQsICAgICAgTmV2ZXJTdXBwb3J0ZWQsIE5ldmVyU3Vw cG9ydGVkKTsKKyAgICBBZGRDb21wcmVzc2VkRm9ybWF0KCZtYXAsIEdMX0NPTVBSRVNTRURfUkdC QV9QVlJUQ18yQlBQVjFfSU1HLCAgICAxNiwgIDgsICAxLCAyNTYsICA0LCBmYWxzZSwgUmVxdWly ZUV4dDwmRXh0ZW5zaW9uczo6Y29tcHJlc3NlZFRleHR1cmVQVlJUQz4sICAgIEFsd2F5c1N1cHBv cnRlZCwgTmV2ZXJTdXBwb3J0ZWQsICAgICAgTmV2ZXJTdXBwb3J0ZWQsIE5ldmVyU3VwcG9ydGVk KTsKIAogICAgIC8vIEZyb20gR0xfRVhUX3B2cnRjX3NSR0IKICAgICAvLyAgICAgICAgICAgICAg ICAgICAgICAgfCBJbnRlcm5hbCBmb3JtYXQgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg VyB8IEggfCBEIHwgQlMgfENDfCBTUkdCIHwgVGV4dHVyZSBzdXBwb3J0ZWQgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCBGaWx0ZXJhYmxlICAgICB8IFRleHR1cmUgYXR0YWNo bWVudCB8IFJlbmRlcmJ1ZmZlciAgfCBCbGVuZAotICAgIEFkZENvbXByZXNzZWRGb3JtYXQoJm1h cCwgR0xfQ09NUFJFU1NFRF9TUkdCX1BWUlRDXzJCUFBWMV9FWFQsICAgICAgICAgICAxLCAgMSwg IDEsICAgMSwgMywgIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6OmNvbXByZXNzZWRUZXh0 dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCwgICAgICBO ZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOwotICAgIEFkZENvbXByZXNzZWRGb3JtYXQo Jm1hcCwgR0xfQ09NUFJFU1NFRF9TUkdCX1BWUlRDXzRCUFBWMV9FWFQsICAgICAgICAgICAxLCAg MSwgIDEsICAgMSwgMywgIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6OmNvbXByZXNzZWRU ZXh0dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCwgICAg ICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOwotICAgIEFkZENvbXByZXNzZWRGb3Jt YXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9TUkdCX0FMUEhBX1BWUlRDXzJCUFBWMV9FWFQsICAgICAx LCAgMSwgIDEsICAgMSwgNCwgIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6OmNvbXByZXNz ZWRUZXh0dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRlZCwg ICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOwotICAgIEFkZENvbXByZXNzZWRG b3JtYXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9TUkdCX0FMUEhBX1BWUlRDXzRCUFBWMV9FWFQsICAg ICAxLCAgMSwgIDEsICAgMSwgNCwgIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6OmNvbXBy ZXNzZWRUZXh0dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBvcnRl ZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOworICAgIEFkZENvbXByZXNz ZWRGb3JtYXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9TUkdCX1BWUlRDXzJCUFBWMV9FWFQsICAgICAg ICAgIDE2LCAgOCwgIDEsIDI1NiwgIDMsIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6OmNv bXByZXNzZWRUZXh0dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1cHBv cnRlZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOworICAgIEFkZENvbXBy ZXNzZWRGb3JtYXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9TUkdCX1BWUlRDXzRCUFBWMV9FWFQsICAg ICAgICAgICA4LCAgOCwgIDEsIDI1NiwgIDMsIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVuc2lvbnM6 OmNvbXByZXNzZWRUZXh0dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZlclN1 cHBvcnRlZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOworICAgIEFkZENv bXByZXNzZWRGb3JtYXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9TUkdCX0FMUEhBX1BWUlRDXzJCUFBW MV9FWFQsICAgIDE2LCAgOCwgIDEsIDI1NiwgIDQsIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVuc2lv bnM6OmNvbXByZXNzZWRUZXh0dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBOZXZl clN1cHBvcnRlZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOworICAgIEFk ZENvbXByZXNzZWRGb3JtYXQoJm1hcCwgR0xfQ09NUFJFU1NFRF9TUkdCX0FMUEhBX1BWUlRDXzRC UFBWMV9FWFQsICAgICA4LCAgOCwgIDEsIDI1NiwgIDQsIHRydWUsIFJlcXVpcmVFeHQ8JkV4dGVu c2lvbnM6OmNvbXByZXNzZWRUZXh0dXJlUFZSVENzUkdCPiwgICAgQWx3YXlzU3VwcG9ydGVkLCBO ZXZlclN1cHBvcnRlZCwgICAgICBOZXZlclN1cHBvcnRlZCwgTmV2ZXJTdXBwb3J0ZWQpOwogCiAg ICAgLy8gRm9yIFNURU5DSUxfSU5ERVg4IHdlIGNob3NlIGEgbm9ybWFsaXplZCBjb21wb25lbnQg dHlwZSBmb3IgdGhlIGZvbGxvd2luZyByZWFzb25zOgogICAgIC8vIC0gTXVsdGlzYW1wbGVkIGJ1 ZmZlciBhcmUgZGlzYWxsb3dlZCBmb3Igbm9uLW5vcm1hbGl6ZWQgaW50ZWdlciBjb21wb25lbnQg dHlwZXMgYW5kIHdlIHdhbnQgdG8gc3VwcG9ydCBpdCBmb3IgU1RFTkNJTF9JTkRFWDgKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBlM2NjY2Q2NGY1NzRkZTBkOWI0MWZhNTYwZTEwNTk1MzU0NzUwN2M1Li44NzMxM2IwZjZjZGY4 MzI1NTE5OTQ3YWU5ZGMwZDY1MjhjNjQwNDVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAt MDUtMjEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFBWUlRDIGNv bXByZXNzZWQgdGV4dHVyZXMgYXJlIGZhaWxpbmcgd2l0aCBBTkdMRSBiYWNrZW5kCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIyNDAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYzNTE3Mzg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE1lcmdlIHRoZSB1cHN0cmVhbSBjaGFuZ2UgdG8gdGhpcyB0ZXN0 LgorCisgICAgICAgICogd2ViZ2wvMS4wLjMvcmVzb3VyY2VzL3dlYmdsX3Rlc3RfZmlsZXMvY29u Zm9ybWFuY2UvZXh0ZW5zaW9ucy93ZWJnbC1jb21wcmVzc2VkLXRleHR1cmUtcHZydGMuaHRtbDoK KwogMjAyMC0wNS0yMSAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAg IExheW91dCB0ZXN0IG1lZGlhL3ZpZGVvLWZ1bGxzY3JlZW4tb25seS1wbGF5YmFjay5odG1sIGlz IGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViZ2wvMS4wLjMvcmVz b3VyY2VzL3dlYmdsX3Rlc3RfZmlsZXMvY29uZm9ybWFuY2UvZXh0ZW5zaW9ucy93ZWJnbC1jb21w cmVzc2VkLXRleHR1cmUtcHZydGMuaHRtbCBiL0xheW91dFRlc3RzL3dlYmdsLzEuMC4zL3Jlc291 cmNlcy93ZWJnbF90ZXN0X2ZpbGVzL2NvbmZvcm1hbmNlL2V4dGVuc2lvbnMvd2ViZ2wtY29tcHJl c3NlZC10ZXh0dXJlLXB2cnRjLmh0bWwKaW5kZXggMzI3MTUwODEwNDkyOWRlN2UxNGMzY2ZhNTQ3 ZWExYTkzMWI3Y2EyNC4uMDJjODhkNWQ1Y2VkNWYxZTEwYzQ0ZDEzZDhhYTVjOTQ3MWUwMTI5NSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2ViZ2wvMS4wLjMvcmVzb3VyY2VzL3dlYmdsX3Rlc3Rf ZmlsZXMvY29uZm9ybWFuY2UvZXh0ZW5zaW9ucy93ZWJnbC1jb21wcmVzc2VkLXRleHR1cmUtcHZy dGMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJnbC8xLjAuMy9yZXNvdXJjZXMvd2ViZ2xfdGVz dF9maWxlcy9jb25mb3JtYW5jZS9leHRlbnNpb25zL3dlYmdsLWNvbXByZXNzZWQtdGV4dHVyZS1w dnJ0Yy5odG1sCkBAIC0yNzEsNyArMjcxLDcgQEAgZnVuY3Rpb24gdGVzdFBWUlRDVGV4dHVyZSh0 ZXN0KSB7CiAgICAgd3R1LmdsRXJyb3JTaG91bGRCZShnbCwgZ2wuTk9fRVJST1IsICJ1cGxvYWRp bmcgY29tcHJlc3NlZCB0ZXh0dXJlIik7CiAgICAgZ2wuZ2VuZXJhdGVNaXBtYXAoZ2wuVEVYVFVS RV8yRCk7CiAgICAgd3R1LmdsRXJyb3JTaG91bGRCZShnbCwgZ2wuSU5WQUxJRF9PUEVSQVRJT04s ICJ0cnlpbmcgdG8gZ2VuZXJhdGUgbWlwbWFwcyBmcm9tIGNvbXByZXNzZWQgdGV4dHVyZSIpOwot ICAgIHd0dS5kcmF3UXVhZChnbCk7CisgICAgd3R1LmNsZWFyQW5kRHJhd1VuaXRRdWFkKGdsKTsK ICAgICBjb21wYXJlUmVjdCh3aWR0aCwgaGVpZ2h0LCB0ZXN0LmNoYW5uZWxzLCB3aWR0aCwgaGVp Z2h0LCB1bmNvbXByZXNzZWREYXRhLCBkYXRhLCBmb3JtYXQpOwogCiAgICAgZ2wuY29tcHJlc3Nl ZFRleEltYWdlMkQoZ2wuVEVYVFVSRV8yRCwgMCwgZm9ybWF0LCB3aWR0aCwgaGVpZ2h0LCAxLCBk YXRhKTsK