212236 2020-05-21 16:01:38 -0700 [GTK] Manette_INCLUDE_DIR and Manette_LIBRARY are undefined. 2020-05-27 10:52:43 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133847 1 changseok changseok alex annulen aperez bugs-noreply cgarcia don.olmstead ews-watchlist gyuyoung.kim mcatanzaro pnormand ryuan.choi sergio oldest_to_newest 1655125 0 changseok 2020-05-21 16:01:38 -0700 The cmake complains Manette_INCLUDE_DIR and Manette_LIBRARY are missing where ENABLE_GAMEPAD is enabled. 1655130 1 399993 changseok 2020-05-21 16:12:25 -0700 Created attachment 399993 Patch 1655927 2 changseok 2020-05-25 13:52:56 -0700 I think this is a necessary change. The imported_target argument does not set <XXX>_INCLUDE_DIR and <XXX>_LIBRARY according to the cmake doc. https://cmake.org/cmake/help/v3.13/module/FindPkgConfig.html#command:pkg_check_modules 1656063 3 400254 don.olmstead 2020-05-26 09:34:04 -0700 Created attachment 400254 WIP Patch In your original patch for manette I made a comment about copying what was happening in the Find modules within that directory already. This is what that would look like. I didn't see an actual release of manette on its GitLab so I'm not able to confirm the regex version finding but it should work. This will for sure set all the variables that the CMake references. Also as an aside find_package(Manette 0.2.4 REQUIRED) if (NOT Manette_FOUND) message(FATAL_ERROR "libmanette is required for ENABLE_GAMEPAD") endif () SET_AND_EXPOSE_TO_BUILD(USE_MANETTE TRUE) You should also remove the REQUIRED as it will error before your FATAL_ERROR message is reached. 1656301 4 400312 changseok 2020-05-26 23:55:37 -0700 Created attachment 400312 Patch 1656303 5 changseok 2020-05-27 00:01:04 -0700 (In reply to Don Olmstead from comment #3) > In your original patch for manette I made a comment about copying what was > happening in the Find modules within that directory already. This is what > that would look like. It's my bad. I did not catch this configuration failure due to the cache on my local. :P > I didn't see an actual release of manette on its > GitLab so I'm not able to confirm the regex version finding but it should > work. This will for sure set all the variables that the CMake references. I followed FindOpenJPEG.cmake as you said, and checked if the build is fine. > > Also as an aside > > find_package(Manette 0.2.4 REQUIRED) > if (NOT Manette_FOUND) > message(FATAL_ERROR "libmanette is required for ENABLE_GAMEPAD") > endif () > SET_AND_EXPOSE_TO_BUILD(USE_MANETTE TRUE) > > You should also remove the REQUIRED as it will error before your FATAL_ERROR > message is reached. You're right. REQUIRED is removed. 1656425 6 400312 changseok 2020-05-27 10:28:31 -0700 Comment on attachment 400312 Patch Thanks! 1656436 7 ews-feeder 2020-05-27 10:52:41 -0700 Committed r262201: <https://trac.webkit.org/changeset/262201> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400312. 399993 2020-05-21 16:12:25 -0700 2020-05-26 23:55:32 -0700 Patch bug-212236-20200521191224.patch text/plain 1677 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZE1hbmV0dGUuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZE1hbmV0dGUuY21ha2UKaW5kZXggZTgz NGMwYTI0NDFhNmFhMjM5YTYwNGIxOTFhYzY3YjlkZTc0Zjg4ZS4uMGQ5NzIxNjRjNTA3NGU4MDg2 YThhMDdmZDUzNzM5Mzk4YzU0NmM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRNYW5l dHRlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kTWFuZXR0ZS5jbWFrZQpAQCAtNTUsNiAr NTUsMTggQEAgVGhpcyB3aWxsIGRlZmluZSB0aGUgZm9sbG93aW5nIHZhcmlhYmxlcyBpbiB5b3Vy IHByb2plY3Q6CiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQogcGtnX2NoZWNrX21vZHVsZXMoUENf TUFORVRURSBJTVBPUlRFRF9UQVJHRVQgbWFuZXR0ZS0wLjIpCiAKK2ZpbmRfcGF0aChNYW5ldHRl X0lOQ0xVREVfRElSCisgICAgTkFNRVMgbGlibWFuZXR0ZS5oCisgICAgSElOVFMgJHtQQ19NQU5F VFRFX0lOQ0xVREVESVJ9CisgICAgICAgICAgJHtQQ19NQU5FVFRFX0lOQ0xVREVfRElSU30KKykK KworZmluZF9saWJyYXJ5KE1hbmV0dGVfTElCUkFSWQorICAgIE5BTUVTIG1hbmV0dGUtMC4yCisg ICAgSElOVFMgJHtQQ19NQU5FVFRFX0xJQkRJUn0KKyAgICAgICAgICAke1BDX01BTkVUVEVfTElC UkFSWV9ESVJTfQorKQorCiBpbmNsdWRlKEZpbmRQYWNrYWdlSGFuZGxlU3RhbmRhcmRBcmdzKQog ZmluZF9wYWNrYWdlX2hhbmRsZV9zdGFuZGFyZF9hcmdzKE1hbmV0dGUKICAgICBGT1VORF9WQVIg TWFuZXR0ZV9GT1VORApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDk0 ODMwNTRjNjc4NTNmNzE5YTMzMjAxMzk3ZGQzZDNmZDQzZTFiZjcuLjIzZDIwOGZiYzg4YmQ3YmFk MTZlNjJjMDdiYmI1NGI3MWUzZTFhN2QgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0wNS0yMSAgQ2hhbmdTZW9rIE9oICA8Y2hhbmdz ZW9rQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0dUS10gTWFuZXR0ZV9JTkNMVURFX0RJUiBhbmQg TWFuZXR0ZV9MSUJSQVJZIGFyZSB1bmRlZmluZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIyMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY21ha2UgY29tcGxhaW5zIE1hbmV0dGVfSU5DTFVE RV9ESVIgYW5kIE1hbmV0dGVfTElCUkFSWSBhcmUgbWlzc2luZworICAgICAgICBpbiBmaW5kaW5n IHRoZSBtYW5ldHRlIHBhY2thZ2Ugd2hlcmUgR0FNRVBBRCBpcyBlbmFibGVkIGZvciBndGsgcG9y dC4KKyAgICAgICAgSW4gcjI2MTk2NSwgd2UgdGhvdWdodCB0aGV5IHdvdWxkIGJlIGF1dG9tYXRp Y2FsbHkgZGVmaW5lZCB3aXRoIElNUE9SVEVEX1RBUkdFVAorICAgICAgICBidXQgdGhleSBzZWVt IG5vdC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kTWFuZXR0ZS5jbWFrZToKKwogMjAy MC0wNS0yMCAgQ2hhbmdTZW9rIE9oICA8Y2hhbmdzZW9rQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W0dUS10gSW1wbGVtZW50IGNvbm5lY3RlZCBhbmQgZGlzY29ubmVjdGVkIGV2ZW50cyBvZiBHQU1F UEFEIEFQSSB3aXRoIGxpYm1hbmV0dGUK 400254 2020-05-26 09:34:04 -0700 2020-05-26 23:55:34 -0700 WIP Patch manette.diff text/plain 2725 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kTWFuZXR0ZS5jbWFrZSBiL1NvdXJjZS9jbWFr ZS9GaW5kTWFuZXR0ZS5jbWFrZQppbmRleCBlODM0YzBhMjQ0MWEuLmIyODY5NWVkMDBjMSAxMDA2 NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRNYW5ldHRlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFr ZS9GaW5kTWFuZXR0ZS5jbWFrZQpAQCAtNTMsNyArNTMsMzcgQEAgVGhpcyB3aWxsIGRlZmluZSB0 aGUgZm9sbG93aW5nIHZhcmlhYmxlcyBpbiB5b3VyIHByb2plY3Q6CiAjXT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 XQogCiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoUENfTUFORVRU RSBJTVBPUlRFRF9UQVJHRVQgbWFuZXR0ZS0wLjIpCitwa2dfY2hlY2tfbW9kdWxlcyhQQ19NQU5F VFRFIFFVSUVUIG1hbmV0dGUtMC4yKQorc2V0KE1hbmV0dGVfQ09NUElMRV9PUFRJT05TICR7UENf TUFORVRURV9DRkxBR1NfT1RIRVJ9KQorc2V0KE1hbmV0dGVfVkVSU0lPTiAke1BDX01BTkVUVEVf VkVSU0lPTn0pCisKK2ZpbmRfcGF0aChNYW5ldHRlX0lOQ0xVREVfRElSCisgICAgTkFNRVMgbGli bWFuZXR0ZS5oCisgICAgSElOVFMgJHtQQ19NQU5FVFRFX0lOQ0xVREVESVJ9ICR7UENfTUFORVRU RV9JTkNMVURFX0RJUn0KKyAgICBQQVRIX1NVRkZJWEVTIGNhaXJvCispCisKK2ZpbmRfbGlicmFy eShNYW5ldHRlX0xJQlJBUlkKKyAgICBOQU1FUyAke01hbmV0dGVfTkFNRVN9IG1hbmV0dGUtMC4y CisgICAgSElOVFMgJHtQQ19NQU5FVFRFX0xJQkRJUn0gJHtQQ19NQU5FVFRFX0xJQlJBUllfRElS U30KKykKKworaWYgKE1hbmV0dGVfSU5DTFVERV9ESVIgQU5EIE5PVCBNYW5ldHRlX1ZFUlNJT04p CisgICAgaWYgKEVYSVNUUyAiJHtNYW5ldHRlX0lOQ0xVREVfRElSfS9tYW5ldHRlLXZlcnNpb24u aCIpCisgICAgICAgIGZpbGUoUkVBRCAiJHtNYW5ldHRlX0lOQ0xVREVfRElSfS9tYW5ldHRlLXZl cnNpb24uaCIgTWFuZXR0ZV9WRVJTSU9OX0NPTlRFTlQpCisKKyAgICAgICAgc3RyaW5nKFJFR0VY IE1BVENIICIjZGVmaW5lICtMSUJNQU5FVFRFX01BSk9SX1ZFUlNJT04gKyhbMC05XSspIiBfZHVt bXkgIiR7TWFuZXR0ZV9WRVJTSU9OX0NPTlRFTlR9IikKKyAgICAgICAgc2V0KE1hbmV0dGVfVkVS U0lPTl9NQUpPUiAiJHtDTUFLRV9NQVRDSF8xfSIpCisKKyAgICAgICAgc3RyaW5nKFJFR0VYIE1B VENIICIjZGVmaW5lICtMSUJNQU5FVFRFX01JTk9SX1ZFUlNJT04gKyhbMC05XSspIiBfZHVtbXkg IiR7TWFuZXR0ZV9WRVJTSU9OX0NPTlRFTlR9IikKKyAgICAgICAgc2V0KE1hbmV0dGVfVkVSU0lP Tl9NSU5PUiAiJHtDTUFLRV9NQVRDSF8xfSIpCisKKyAgICAgICAgc3RyaW5nKFJFR0VYIE1BVENI ICIjZGVmaW5lICtMSUJNQU5FVFRFX01JQ1JPX1ZFUlNJT04gKyhbMC05XSspIiBfZHVtbXkgIiR7 TWFuZXR0ZV9WRVJTSU9OX0NPTlRFTlR9IikKKyAgICAgICAgc2V0KE1hbmV0dGVfVkVSU0lPTl9Q QVRDSCAiJHtDTUFLRV9NQVRDSF8xfSIpCisKKyAgICAgICAgc2V0KE1hbmV0dGVfVkVSU0lPTiAi JHtNYW5ldHRlX1ZFUlNJT05fTUFKT1J9LiR7TWFuZXR0ZV9WRVJTSU9OX01JTk9SfS4ke01hbmV0 dGVfVkVSU0lPTl9QQVRDSH0iKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQogCiBpbmNsdWRlKEZp bmRQYWNrYWdlSGFuZGxlU3RhbmRhcmRBcmdzKQogZmluZF9wYWNrYWdlX2hhbmRsZV9zdGFuZGFy ZF9hcmdzKE1hbmV0dGUKQEAgLTYyLDExICs5MiwxOCBAQCBmaW5kX3BhY2thZ2VfaGFuZGxlX3N0 YW5kYXJkX2FyZ3MoTWFuZXR0ZQogICAgIFZFUlNJT05fVkFSIE1hbmV0dGVfVkVSU0lPTgogKQog Ci1pZiAoVEFSR0VUIFBrZ0NvbmZpZzo6UENfTUFORVRURSBBTkQgTk9UIFRBUkdFVCBNYW5ldHRl OjpNYW5ldHRlKQotICAgIGFkZF9saWJyYXJ5KE1hbmV0dGU6Ok1hbmV0dGUgSU5URVJGQUNFIElN UE9SVEVEIEdMT0JBTCkKLSAgICBzZXRfcHJvcGVydHkoVEFSR0VUIE1hbmV0dGU6Ok1hbmV0dGUg UFJPUEVSVFkKLSAgICAgICAgSU5URVJGQUNFX0xJTktfTElCUkFSSUVTIFBrZ0NvbmZpZzo6UENf TUFORVRURQoraWYgKE1hbmV0dGVfTElCUkFSWSBBTkQgTk9UIFRBUkdFVCBNYW5ldHRlOjpNYW5l dHRlKQorICAgIGFkZF9saWJyYXJ5KE1hbmV0dGU6Ok1hbmV0dGUgVU5LTk9XTiBJTVBPUlRFRCBH TE9CQUwpCisgICAgc2V0X3RhcmdldF9wcm9wZXJ0aWVzKE1hbmV0dGU6Ok1hbmV0dGUgUFJPUEVS VElFUworICAgICAgICBJTVBPUlRFRF9MT0NBVElPTiAiJHtNYW5ldHRlX0xJQlJBUll9IgorICAg ICAgICBJTlRFUkZBQ0VfQ09NUElMRV9PUFRJT05TICIke01hbmV0dGVfQ09NUElMRV9PUFRJT05T fSIKKyAgICAgICAgSU5URVJGQUNFX0lOQ0xVREVfRElSRUNUT1JJRVMgIiR7TWFuZXR0ZV9JTkNM VURFX0RJUn0iCiAgICAgKQogZW5kaWYgKCkKIAotbWFya19hc19hZHZhbmNlZChNYW5ldHRlX0lO Q0xVREVfRElSIE1hbmV0dGVfTElCUkFSWSkKK21hcmtfYXNfYWR2YW5jZWQoTWFuZXR0ZV9JTkNM VURFX0RJUiBNYW5ldHRlX0xJQlJBUklFUykKKworaWYgKE1hbmV0dGVfRk9VTkQpCisgICAgc2V0 KE1hbmV0dGVfTElCUkFSSUVTICR7TWFuZXR0ZV9MSUJSQVJZfSkKKyAgICBzZXQoTWFuZXR0ZV9J TkNMVURFX0RJUlMgJHtNYW5ldHRlX0lOQ0xVREVfRElSfSkKK2VuZGlmICgpCg== 400312 2020-05-26 23:55:37 -0700 2020-05-27 10:52:42 -0700 Patch bug-212236-20200527025536.patch text/plain 4260 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZE1hbmV0dGUuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZE1hbmV0dGUuY21ha2UKaW5kZXggZTgz NGMwYTI0NDFhNmFhMjM5YTYwNGIxOTFhYzY3YjlkZTc0Zjg4ZS4uNTAzMTc5Yjk2OWViZmYyZGE4 ZjQ5NDM5YmI2NWFhZWZhMTZhYmE3YyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRNYW5l dHRlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kTWFuZXR0ZS5jbWFrZQpAQCAtNTMsNyAr NTMsMzggQEAgVGhpcyB3aWxsIGRlZmluZSB0aGUgZm9sbG93aW5nIHZhcmlhYmxlcyBpbiB5b3Vy IHByb2plY3Q6CiAjXT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09XQogCiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQot cGtnX2NoZWNrX21vZHVsZXMoUENfTUFORVRURSBJTVBPUlRFRF9UQVJHRVQgbWFuZXR0ZS0wLjIp Citwa2dfY2hlY2tfbW9kdWxlcyhQQ19NQU5FVFRFIFFVSUVUIG1hbmV0dGUtMC4yKQorc2V0KE1h bmV0dGVfQ09NUElMRV9PUFRJT05TICR7UENfTUFORVRURV9DRkxBR1NfT1RIRVJ9KQorc2V0KE1h bmV0dGVfVkVSU0lPTiAke1BDX01BTkVUVEVfVkVSU0lPTn0pCisKK2ZpbmRfcGF0aChNYW5ldHRl X0lOQ0xVREVfRElSCisgICAgTkFNRVMgbGlibWFuZXR0ZS5oCisgICAgSElOVFMgJHtQQ19NQU5F VFRFX0lOQ0xVREVESVJ9CisgICAgICAgICAgJHtQQ19NQU5FVFRFX0lOQ0xVREVfRElSU30KKykK KworZmluZF9saWJyYXJ5KE1hbmV0dGVfTElCUkFSWQorICAgIE5BTUVTICR7TWFuZXR0ZV9OQU1F U30gbWFuZXR0ZS0wLjIKKyAgICBISU5UUyAke1BDX01BTkVUVEVfTElCRElSfQorICAgICAgICAg ICR7UENfTUFORVRURV9MSUJSQVJZX0RJUlN9CispCisKK2lmIChNYW5ldHRlX0lOQ0xVREVfRElS IEFORCBOT1QgTWFuZXR0ZV9WRVJTSU9OKQorICAgIGlmIChFWElTVFMgIiR7TWFuZXR0ZV9JTkNM VURFX0RJUn0vbWFuZXR0ZS12ZXJzaW9uLmgiKQorICAgICAgICBmaWxlKFJFQUQgIiR7TWFuZXR0 ZV9JTkNMVURFX0RJUn0vbWFuZXR0ZS12ZXJzaW9uLmgiIE1hbmV0dGVfVkVSU0lPTl9DT05URU5U KQorCisgICAgICAgIHN0cmluZyhSRUdFWCBNQVRDSCAiI2RlZmluZSArTElCTUFORVRURV9NQUpP Ul9WRVJTSU9OICsoWzAtOV0rKSIgX2R1bW15ICIke01hbmV0dGVfVkVSU0lPTl9DT05URU5UfSIp CisgICAgICAgIHNldChNYW5ldHRlX1ZFUlNJT05fTUFKT1IgIiR7Q01BS0VfTUFUQ0hfMX0iKQor CisgICAgICAgIHN0cmluZyhSRUdFWCBNQVRDSCAiI2RlZmluZSArTElCTUFORVRURV9NSU5PUl9W RVJTSU9OICsoWzAtOV0rKSIgX2R1bW15ICIke01hbmV0dGVfVkVSU0lPTl9DT05URU5UfSIpCisg ICAgICAgIHNldChNYW5ldHRlX1ZFUlNJT05fTUlOT1IgIiR7Q01BS0VfTUFUQ0hfMX0iKQorCisg ICAgICAgIHN0cmluZyhSRUdFWCBNQVRDSCAiI2RlZmluZSArTElCTUFORVRURV9NSUNST19WRVJT SU9OICsoWzAtOV0rKSIgX2R1bW15ICIke01hbmV0dGVfVkVSU0lPTl9DT05URU5UfSIpCisgICAg ICAgIHNldChNYW5ldHRlX1ZFUlNJT05fUEFUQ0ggIiR7Q01BS0VfTUFUQ0hfMX0iKQorCisgICAg ICAgIHNldChNYW5ldHRlX1ZFUlNJT04gIiR7TWFuZXR0ZV9WRVJTSU9OX01BSk9SfS4ke01hbmV0 dGVfVkVSU0lPTl9NSU5PUn0uJHtNYW5ldHRlX1ZFUlNJT05fUEFUQ0h9IikKKyAgICBlbmRpZiAo KQorZW5kaWYgKCkKIAogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykKIGZp bmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJncyhNYW5ldHRlCkBAIC02MiwxMSArOTMsMTgg QEAgZmluZF9wYWNrYWdlX2hhbmRsZV9zdGFuZGFyZF9hcmdzKE1hbmV0dGUKICAgICBWRVJTSU9O X1ZBUiBNYW5ldHRlX1ZFUlNJT04KICkKIAotaWYgKFRBUkdFVCBQa2dDb25maWc6OlBDX01BTkVU VEUgQU5EIE5PVCBUQVJHRVQgTWFuZXR0ZTo6TWFuZXR0ZSkKLSAgICBhZGRfbGlicmFyeShNYW5l dHRlOjpNYW5ldHRlIElOVEVSRkFDRSBJTVBPUlRFRCBHTE9CQUwpCi0gICAgc2V0X3Byb3BlcnR5 KFRBUkdFVCBNYW5ldHRlOjpNYW5ldHRlIFBST1BFUlRZCi0gICAgICAgIElOVEVSRkFDRV9MSU5L X0xJQlJBUklFUyBQa2dDb25maWc6OlBDX01BTkVUVEUKK2lmIChNYW5ldHRlX0xJQlJBUlkgQU5E IE5PVCBUQVJHRVQgTWFuZXR0ZTo6TWFuZXR0ZSkKKyAgICBhZGRfbGlicmFyeShNYW5ldHRlOjpN YW5ldHRlIFVOS05PV04gSU1QT1JURUQgR0xPQkFMKQorICAgIHNldF90YXJnZXRfcHJvcGVydGll cyhNYW5ldHRlOjpNYW5ldHRlIFBST1BFUlRJRVMKKyAgICAgICAgSU1QT1JURURfTE9DQVRJT04g IiR7TWFuZXR0ZV9MSUJSQVJZfSIKKyAgICAgICAgSU5URVJGQUNFX0NPTVBJTEVfT1BUSU9OUyAi JHtNYW5ldHRlX0NPTVBJTEVfT1BUSU9OU30iCisgICAgICAgIElOVEVSRkFDRV9JTkNMVURFX0RJ UkVDVE9SSUVTICIke01hbmV0dGVfSU5DTFVERV9ESVJ9IgogICAgICkKIGVuZGlmICgpCiAKIG1h cmtfYXNfYWR2YW5jZWQoTWFuZXR0ZV9JTkNMVURFX0RJUiBNYW5ldHRlX0xJQlJBUlkpCisKK2lm IChNYW5ldHRlX0ZPVU5EKQorICAgIHNldChNYW5ldHRlX0xJQlJBUklFUyAke01hbmV0dGVfTElC UkFSWX0pCisgICAgc2V0KE1hbmV0dGVfSU5DTFVERV9ESVJTICR7TWFuZXR0ZV9JTkNMVURFX0RJ Un0pCitlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2Ug Yi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCA3NTcwZmJjZGVkMzY0NmQxYWM3 MmQzYjY4YmRkYzI5MmE4NzUzZjA4Li4yZjg5MTc3N2Q3ODZhMzVjZGFlMDk5OWU0YjhmYzMwNTk2 MDg1OGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9T b3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtMjQ2LDcgKzI0Niw3IEBAIGlmIChVU0Vf V1BFX1JFTkRFUkVSKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9HQU1FUEFEKQotICAgIGZpbmRf cGFja2FnZShNYW5ldHRlIDAuMi40IFJFUVVJUkVEKQorICAgIGZpbmRfcGFja2FnZShNYW5ldHRl IDAuMi40KQogICAgIGlmIChOT1QgTWFuZXR0ZV9GT1VORCkKICAgICAgICAgbWVzc2FnZShGQVRB TF9FUlJPUiAibGlibWFuZXR0ZSBpcyByZXF1aXJlZCBmb3IgRU5BQkxFX0dBTUVQQUQiKQogICAg IGVuZGlmICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzlmMGUx OTNlMWVjZTBiYmQxYTU0NDk0ZWViOGYxMWE1MDU2NjdhZS4uYjU5NmY1MmQzNjE2MThkNmYzOGMw ODM3NTVjZDlkNmU5YTYyODg2MSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA1LTI2ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2tA d2Via2l0Lm9yZz4KKworICAgICAgICBbR1RLXSBNYW5ldHRlX0lOQ0xVREVfRElSIGFuZCBNYW5l dHRlX0xJQlJBUlkgYXJlIHVuZGVmaW5lZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjIzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBjbWFrZSBjb21wbGFpbnMgTWFuZXR0ZV9JTkNMVURFX0RJ UiBhbmQgTWFuZXR0ZV9MSUJSQVJZIGFyZSBtaXNzaW5nCisgICAgICAgIGluIGZpbmRpbmcgdGhl IG1hbmV0dGUgcGFja2FnZSB3aGVyZSBHQU1FUEFEIGlzIGVuYWJsZWQgZm9yIHRoZSBndGsgcG9y dC4KKyAgICAgICAgSW4gcjI2MTk2NSwgd2UgdGhvdWdodCB0aGV5IHdvdWxkIGJlIGF1dG9tYXRp Y2FsbHkgZGVmaW5lZCB3aXRoIElNUE9SVEVEX1RBUkdFVAorICAgICAgICBidXQgdGhleSBzZWVt IG5vdC4gV2UgZXhwbGljaXRseSBmaW5kIHRoZSBoZWFkZXIgYW5kIGxpYnJhcnkgcGF0aHMsIGZv bGxvd2luZyBGaW5kT3BlbkpQRUcuY21ha2UuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmlu ZE1hbmV0dGUuY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6 IFJFUVVJUkVEIHJlbW92ZWQuCisKIDIwMjAtMDUtMjEgIFlvc2hpYWtpIEppdHN1a2F3YSAgPHlv c2hpYWtpLmppdHN1a2F3YUBzb255LmNvbT4KIAogICAgICAgICBbUGxheVN0YXRpb25dIEFkZCBt aW5pbWFsIFdLVmlldyBBUEkgdG8gZW5hYmxlIFRlc3RXZWJLaXRBUEkK