212218 2020-05-21 09:31:14 -0700 REGRESSION (r261277): [ Mac iOS ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout 2020-05-27 00:48:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell youennf eric.carlson ews-watchlist mjs webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1654954 0 tsavell 2020-05-21 09:31:14 -0700 webrtc/datachannel/gather-candidates-networkprocess-crash.html This test began timing out recently History: https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fdatachannel%2Fgather-candidates-networkprocess-crash.html I am able to reproduce the timeout with command: run-webkit-tests --iterations 2000 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --debug-rwt-logging --no-retry --force --no-build -f webrtc/datachannel/gather-candidates-networkprocess-crash.html I am working to bisect this now. 1654955 1 webkit-bug-importer 2020-05-21 09:31:31 -0700 <rdar://problem/63496692> 1654966 2 tsavell 2020-05-21 09:51:31 -0700 it looks like this was caused by the changes in https://trac.webkit.org/changeset/261277/webkit I am able to reproduce on 261277 but not 261276 1654969 3 tsavell 2020-05-21 10:01:16 -0700 marking this test as a flaky timeout while it is investigated: https://trac.webkit.org/changeset/262010/webkit 1655814 4 youennf 2020-05-25 02:45:46 -0700 There is a slight moment in time where the socket factory has no connection due to a crash in network process. In that case, the factory will ask for a new connection to network process and in the meantime will fail the socket creations. We do not want to do callOnMainThreadAndWait as this might deadlock the web process in that case. The current approach is fine as is as the socket could have been created a few seconds before and would have been closed by network process crash. I'll update the test to make it more robust. 1655830 5 400195 youennf 2020-05-25 05:16:39 -0700 Created attachment 400195 Patch 1655946 6 mjs 2020-05-25 15:37:59 -0700 Was the patch meant to be flagged for review? 1656306 7 ews-feeder 2020-05-27 00:48:22 -0700 Committed r262183: <https://trac.webkit.org/changeset/262183> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400195. 400195 2020-05-25 05:16:39 -0700 2020-05-27 00:48:23 -0700 Patch bug-212218-20200525141638.patch text/plain 2506 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTA2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmIwMjhiNzViODMyZDM0Mzg5ZjRj NDBlYTM1MTkxNDk5MGMyMWM0My4uOGM0NjNjY2JiZTMwZmIwZGYxZGZiNTQ1ZjFiMDQ4NzFkZTZm YWVlNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTI1ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjYxMjc3KTogWyBNYWMg aU9TIF0gd2VicnRjL2RhdGFjaGFubmVsL2dhdGhlci1jYW5kaWRhdGVzLW5ldHdvcmtwcm9jZXNz LWNyYXNoLmh0bWwgaXMgYSBmbGFreSB0aW1lb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIyMTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYz NDk2NjkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd2VicnRjL2RhdGFjaGFubmVsL2dhdGhlci1jYW5kaWRhdGVzLW5ldHdvcmtwcm9jZXNzLWNy YXNoLmh0bWw6CisgICAgICAgIENyZWF0ZSBhIG5ldyBwZWVyIGNvbm5lY3Rpb24gYWZ0ZXIgdGhl IG5ldHdvcmsgcHJvY2VzcyBjcmFzaCB0byB2YWxpZGF0ZSBpdCBkb2VzIG5vdCBzdGF5IGhhbmdp bmcuCisKIDIwMjAtMDUtMjAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBhIHRlc3QgdG8gY2hlY2sgZm9yIGNyZWF0aW9uIGFuZCBkZWxldGlvbiBvZiBh biBhdWRpbyByZW5kZXJlciB3aXRob3V0IHBsYXlpbmcgaXQKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9nYXRoZXItY2FuZGlkYXRlcy1uZXR3b3JrcHJvY2Vzcy1j cmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvd2VicnRjL2RhdGFjaGFubmVsL2dhdGhlci1jYW5kaWRh dGVzLW5ldHdvcmtwcm9jZXNzLWNyYXNoLmh0bWwKaW5kZXggM2YzZTNkNjdjMDY1NmQxN2M3ZDMz NjZjOTVjYTEwNGNmZjI2NDIxNS4uZDQ2MWNlMTkxMzNjZDEwZTgyM2U2ZTEyM2Q3YjkxNDcwNWVj YmY3NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2VicnRjL2RhdGFjaGFubmVsL2dhdGhlci1j YW5kaWRhdGVzLW5ldHdvcmtwcm9jZXNzLWNyYXNoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvd2Vi cnRjL2RhdGFjaGFubmVsL2dhdGhlci1jYW5kaWRhdGVzLW5ldHdvcmtwcm9jZXNzLWNyYXNoLmh0 bWwKQEAgLTksMTkgKzksMjQgQEAKICAgPGJvZHk+CiAgICAgPHNjcmlwdD4KIHByb21pc2VfdGVz dChhc3luYyAodGVzdCkgPT4gewotICAgIHZhciBjb3VudGVyID0gMDsKLSAgICB2YXIgcGMgPSBu ZXcgUlRDUGVlckNvbm5lY3Rpb24oKTsKKyAgICBsZXQgcGMgPSBuZXcgUlRDUGVlckNvbm5lY3Rp b24oKTsKICAgICBwYy5jcmVhdGVEYXRhQ2hhbm5lbCgnc2VuZERhdGFDaGFubmVsJyk7Ci0KLSAg ICBjb25zdCBpY2VDYW5kaWRhdGVQcm9taXNlID0gbmV3IFByb21pc2UociA9PiBwYy5vbmljZWNh bmRpZGF0ZSA9IHIpOwotCi0gICAgY29uc3Qgb2ZmZXIgPSBhd2FpdCBwYy5jcmVhdGVPZmZlcigp OworICAgIGxldCBvZmZlciA9IGF3YWl0IHBjLmNyZWF0ZU9mZmVyKCk7CiAgICAgcGMuc2V0TG9j YWxEZXNjcmlwdGlvbihvZmZlcik7CiAgICAgLy8gVGhpcyB0ZXN0IGlzIGEgYml0IHJhY3ksIHdl IGFyZSB0cnlpbmcgdG8gaGF2ZSBuZXR3b3JrIHByb2Nlc3MgY3Jhc2ggYmV0d2VlbiB0aGUgdGlt ZSBpdCByZWNlaXZlcyBhIG1vbml0b3Igc3RhcnQgcmVxdWVzdCBhbmQgdGhlIHRpbWUgaXQgYW5z d2VycyB0aGF0IHJlcXVlc3QuCiAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyICYmIHRlc3RSdW5u ZXIudGVybWluYXRlTmV0d29ya1Byb2Nlc3MpCiAgICAgICAgc2V0VGltZW91dCgoKSA9PiB0ZXN0 UnVubmVyLnRlcm1pbmF0ZU5ldHdvcmtQcm9jZXNzKCksIDApOwogCi0gICAgYXdhaXQgaWNlQ2Fu ZGlkYXRlUHJvbWlzZTsKKyAgICBhd2FpdCBmZXRjaCgiLiIpLnRoZW4oKCkgPT4geyB9LCAoKSA9 PiB7IH0pOworCisgICAgbGV0IHBjMiA9IG5ldyBSVENQZWVyQ29ubmVjdGlvbigpOworICAgIHBj Mi5jcmVhdGVEYXRhQ2hhbm5lbCgnc2VuZERhdGFDaGFubmVsJyk7CisKKyAgICBjb25zdCBpY2VD YW5kaWRhdGVQcm9taXNlID0gbmV3IFByb21pc2UociA9PiBwYzIub25pY2VjYW5kaWRhdGUgPSBy KTsKKworICAgIG9mZmVyID0gYXdhaXQgcGMyLmNyZWF0ZU9mZmVyKCk7CisgICAgcGMyLnNldExv Y2FsRGVzY3JpcHRpb24ob2ZmZXIpOworICAgIHJldHVybiBpY2VDYW5kaWRhdGVQcm9taXNlOwog fSwgIkdhdGhlcmluZyBJQ0UgY2FuZGlkYXRlcyBmcm9tIGEgZGF0YSBjaGFubmVsIHdoaWxlIG5l dHdvcmsgcHJvY2VzcyBpcyBjcmFzaGluZyIpOwogICAgIDwvc2NyaXB0PgogICA8L2JvZHk+Cg==