21221 2008-09-29 13:31:32 -0700 Crash when using console.trace() 2009-07-09 00:24:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P2 Normal --- 1 kmccullough webkit-unassigned keishi kmccullough timothy oldest_to_newest 93274 0 kmccullough 2008-09-29 13:31:32 -0700 If I open the WebInspector and type "console.trace()" the inspector will crash. It should probably do nothing. Maybe if we were broken in the script debugger it should show a back trace, but normally it seems meaningless. Sorry my debugger is sucking and I don't have a backtrace. 93326 1 timothy 2008-09-29 19:39:04 -0700 I think it is crashing because the console uses eval(). Just a hunch. 93333 2 23930 keishi 2008-09-29 22:32:36 -0700 Created attachment 23930 patch Checking if the caller function is 0 was missing. 93334 3 23931 keishi 2008-09-29 22:36:04 -0700 Created attachment 23931 fixed minor mistake fixed mistake 93337 4 23931 eric 2008-09-29 22:53:11 -0700 Comment on attachment 23931 fixed minor mistake This should have a layout test and use if (!func) to comply with the style guidelines. 93360 5 23939 keishi 2008-09-30 05:51:58 -0700 Created attachment 23939 patch I wasn't sure how to write a layout test so I wrote a manual test. What is the difference between a layout test and a manual test? 93401 6 23939 kmccullough 2008-09-30 12:03:49 -0700 Comment on attachment 23939 patch I was able to replicate the error by having a script tag with nothing in it but "console.trace()". Since that case does not require a manual action we can make an automated layout test instead of a manual test. To see many examples of layout tests look in the LayoutTests/fast/ directory. 93552 7 devin 2008-10-01 09:32:50 -0700 Try console.trace(console) in the Web Inspector. Or console.trace(function(){}). Anything will crash it. 23930 2008-09-29 22:32:36 -0700 2008-09-29 22:36:04 -0700 patch patch55.txt text/plain 1477 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzA4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDktMjkgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgRml4ZWQgY3Jhc2ggd2hlbiBjYWxsaW5nIGNvbnNvbGUu dHJhY2UoKSBvdXRzaWRlIGEgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwYWdlL0NvbnNvbGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q29uc29sZTo6dHJhY2UpOiBDaGVja3MgaWYgdGhlIGNhbGxlciBpcyAwLgorCiAyMDA4LTA5LTI5 ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT YW0gV2VpbmlnLgpJbmRleDogV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGFnZS9Db25zb2xlLmNwcAkocmV2aXNpb24gMzcwNjEpCisrKyBXZWJDb3JlL3Bh Z2UvQ29uc29sZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4OSwxMyArMjg5LDE1IEBAIHZvaWQg Q29uc29sZTo6dHJhY2UoRXhlY1N0YXRlKiBleGVjKQogCiAgICAgZXhlYy0+bWFjaGluZSgpLT5y ZXRyaWV2ZUxhc3RDYWxsZXIoZXhlYywgc2lnbmVkTGluZU51bWJlciwgc291cmNlSWRlbnRpZmVy LCB1cmxTdHJpbmcsIGZ1bmMpOwogCisgICAgaWYgKGZ1bmMgPT0gMCkKKyAgICAgICAgcmV0dXJu OworCiAgICAgQXJnTGlzdCBhcmdzOwogICAgIHdoaWxlICghZnVuYy0+aXNOdWxsKCkpIHsKICAg ICAgICAgYXJncy5hcHBlbmQoZnVuYyk7CiAgICAgICAgIGZ1bmMgPSBleGVjLT5tYWNoaW5lKCkt PnJldHJpZXZlQ2FsbGVyKGV4ZWMsIHN0YXRpY19jYXN0PEludGVybmFsRnVuY3Rpb24qPihmdW5j KSk7CiAgICAgfQotICAgIAotICAgIHBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+YWRkTWVz c2FnZVRvQ29uc29sZShKU01lc3NhZ2VTb3VyY2UsIFRyYWNlTWVzc2FnZUxldmVsLCBleGVjLCBh cmdzLCAwLCBTdHJpbmcoKSk7CisgICAgcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5hZGRN ZXNzYWdlVG9Db25zb2xlKEpTTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZUxldmVsLCBleGVjLCBh cmdzLCAwLCBTdHJpbmcoKSk7CiB9CiAKIHZvaWQgQ29uc29sZTo6YXNzZXJ0Q29uZGl0aW9uKGJv b2wgY29uZGl0aW9uLCBFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCg== 23931 2008-09-29 22:36:04 -0700 2008-09-30 05:51:58 -0700 fixed minor mistake patch55.txt text/plain 1280 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzA4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDktMjkgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgRml4ZWQgY3Jhc2ggd2hlbiBjYWxsaW5nIGNvbnNvbGUu dHJhY2UoKSBvdXRzaWRlIGEgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwYWdlL0NvbnNvbGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q29uc29sZTo6dHJhY2UpOiBDaGVja3MgaWYgdGhlIGNhbGxlciBpcyAwLgorCiAyMDA4LTA5LTI5 ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT YW0gV2VpbmlnLgpJbmRleDogV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGFnZS9Db25zb2xlLmNwcAkocmV2aXNpb24gMzcwNjEpCisrKyBXZWJDb3JlL3Bh Z2UvQ29uc29sZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4OSwxMiArMjg5LDE1IEBAIHZvaWQg Q29uc29sZTo6dHJhY2UoRXhlY1N0YXRlKiBleGVjKQogCiAgICAgZXhlYy0+bWFjaGluZSgpLT5y ZXRyaWV2ZUxhc3RDYWxsZXIoZXhlYywgc2lnbmVkTGluZU51bWJlciwgc291cmNlSWRlbnRpZmVy LCB1cmxTdHJpbmcsIGZ1bmMpOwogCisgICAgaWYgKGZ1bmMgPT0gMCkKKyAgICAgICAgcmV0dXJu OworCiAgICAgQXJnTGlzdCBhcmdzOwogICAgIHdoaWxlICghZnVuYy0+aXNOdWxsKCkpIHsKICAg ICAgICAgYXJncy5hcHBlbmQoZnVuYyk7CiAgICAgICAgIGZ1bmMgPSBleGVjLT5tYWNoaW5lKCkt PnJldHJpZXZlQ2FsbGVyKGV4ZWMsIHN0YXRpY19jYXN0PEludGVybmFsRnVuY3Rpb24qPihmdW5j KSk7CiAgICAgfQotICAgIAorCiAgICAgcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5hZGRN ZXNzYWdlVG9Db25zb2xlKEpTTWVzc2FnZVNvdXJjZSwgVHJhY2VNZXNzYWdlTGV2ZWwsIGV4ZWMs IGFyZ3MsIDAsIFN0cmluZygpKTsKIH0KIAo= 23939 2008-09-30 05:51:58 -0700 2008-09-30 12:03:49 -0700 patch patch56.txt text/plain 2137 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzA5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDktMzAgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgRml4ZWQgY3Jhc2ggd2hlbiBjYWxsaW5nIGNvbnNvbGUu dHJhY2UoKSBvdXRzaWRlIGEgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtdHJhY2Uu aHRtbDogQWRkZWQuCisgICAgICAgICogcGFnZS9Db25zb2xlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNvbnNvbGU6OnRyYWNlKTogQ2hlY2tzIGlmIHRoZSBjYWxsZXIgZnVuY3Rpb24gZXhpc3Rz LgorCiAyMDA4LTA5LTI5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgVGltIEhhdGNoZXIuCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNw ZWN0b3IvY29uc29sZS10cmFjZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbWFudWFsLXRl c3RzL2luc3BlY3Rvci9jb25zb2xlLXRyYWNlLmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3Jl L21hbnVhbC10ZXN0cy9pbnNwZWN0b3IvY29uc29sZS10cmFjZS5odG1sCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDIzIEBACis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0i dXRmLTgiPgorZnVuY3Rpb24gZnVuYzEoKSB7CisgICAgZXZhbCgiZnVuYzIoKSIpOworfTsKK2Z1 bmN0aW9uIGZ1bmMyKCkgeworICAgIGZ1bmMzKCk7Cit9OwordmFyIGZ1bmMzID0gZnVuY3Rpb24o KSB7CisgICAgZnVuYzQoKTsKK307CitmdW5jdGlvbiBmdW5jNCgpIHsKKyAgICBjb25zb2xlLnRy YWNlKCk7Cit9OworZnVuYzEoKTsKK2NvbnNvbGUudHJhY2UoKTsKKzwvc2NyaXB0PgorCis8cD5U ZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkxNTciPkJ1ZyAxOTE1NzogSW5zcGVjdG9yIHNob3VsZCBzdXBwb3J0IGNvbnNvbGUudHJhY2U8 L2E+LjwvcD4KKzxwPkNvbnNvbGUgc2hvdWxkIGRpc3BsYXkgdGhpcy48L3A+Cis8cD5mdW5jNDxi cj4KKyhhbm9ueW1vdXMgZnVuY3Rpb24pPGJyPgorZnVuYzI8YnI+Cis8L3A+ClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGFnZS9Db25zb2xlLmNwcAkocmV2aXNpb24gMzcwNjEpCisrKyBXZWJD b3JlL3BhZ2UvQ29uc29sZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4OSwxMiArMjg5LDE1IEBA IHZvaWQgQ29uc29sZTo6dHJhY2UoRXhlY1N0YXRlKiBleGVjKQogCiAgICAgZXhlYy0+bWFjaGlu ZSgpLT5yZXRyaWV2ZUxhc3RDYWxsZXIoZXhlYywgc2lnbmVkTGluZU51bWJlciwgc291cmNlSWRl bnRpZmVyLCB1cmxTdHJpbmcsIGZ1bmMpOwogCisgICAgaWYgKCFmdW5jKQorICAgICAgICByZXR1 cm47CisKICAgICBBcmdMaXN0IGFyZ3M7CiAgICAgd2hpbGUgKCFmdW5jLT5pc051bGwoKSkgewog ICAgICAgICBhcmdzLmFwcGVuZChmdW5jKTsKICAgICAgICAgZnVuYyA9IGV4ZWMtPm1hY2hpbmUo KS0+cmV0cmlldmVDYWxsZXIoZXhlYywgc3RhdGljX2Nhc3Q8SW50ZXJuYWxGdW5jdGlvbio+KGZ1 bmMpKTsKICAgICB9Ci0gICAgCisKICAgICBwYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPmFk ZE1lc3NhZ2VUb0NvbnNvbGUoSlNNZXNzYWdlU291cmNlLCBUcmFjZU1lc3NhZ2VMZXZlbCwgZXhl YywgYXJncywgMCwgU3RyaW5nKCkpOwogfQogCg==