<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>212177</bug_id>
          
          <creation_ts>2020-05-20 16:32:45 -0700</creation_ts>
          <short_desc>[WK2] WebKit abandons compiled sandbox profiles</short_desc>
          <delta_ts>2024-02-21 10:21:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>ap</cc>
    
    <cc>benjamin</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>jbedard</cc>
    
    <cc>mitz</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1654715</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-20 16:32:45 -0700</bug_when>
    <thetext>WebKit generates new compiled sandbox profiles whenever sandbox profiles are updated or whenever webkit directories change (which is super common for WebKitTestRunner). Previous compiled sandbox profiles do not get deleted and therefore may accumulate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654716</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-20 16:32:55 -0700</bug_when>
    <thetext>&lt;rdar://problem/54613619&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654718</commentid>
    <comment_count>2</comment_count>
      <attachid>399913</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-20 16:35:35 -0700</bug_when>
    <thetext>Created attachment 399913
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654750</commentid>
    <comment_count>3</comment_count>
      <attachid>399913</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-05-20 17:29:44 -0700</bug_when>
    <thetext>Comment on attachment 399913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399913&amp;action=review

&gt; Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:259
&gt; +    // We save the profiles in the user tempory directory so that they get cleaned after on reboot

&quot;after on&quot; =&gt; &quot;on&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654751</commentid>
    <comment_count>4</comment_count>
      <attachid>399913</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-05-20 17:30:38 -0700</bug_when>
    <thetext>Comment on attachment 399913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399913&amp;action=review

&gt; Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:260
&gt; +    // or if they are not accessed in 3 days. This avoids accumulating profiles whenever we change

&quot;in 3 days&quot; =&gt; &quot;for 3 days&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654752</commentid>
    <comment_count>5</comment_count>
      <attachid>399913</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-05-20 17:31:13 -0700</bug_when>
    <thetext>Comment on attachment 399913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399913&amp;action=review

&gt;&gt; Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:260
&gt;&gt; +    // or if they are not accessed in 3 days. This avoids accumulating profiles whenever we change
&gt; 
&gt; &quot;in 3 days&quot; =&gt; &quot;for 3 days&quot;

actually, I&apos;m not sure which is more grammatically correct. I&apos;ll leave it up to you</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654925</commentid>
    <comment_count>6</comment_count>
      <attachid>399913</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-21 08:22:51 -0700</bug_when>
    <thetext>Comment on attachment 399913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399913&amp;action=review

&gt;&gt; Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:259
&gt;&gt; +    // We save the profiles in the user tempory directory so that they get cleaned after on reboot
&gt; 
&gt; &quot;after on&quot; =&gt; &quot;on&quot;

Will fix.

&gt;&gt;&gt; Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:260
&gt;&gt;&gt; +    // or if they are not accessed in 3 days. This avoids accumulating profiles whenever we change
&gt;&gt; 
&gt;&gt; &quot;in 3 days&quot; =&gt; &quot;for 3 days&quot;
&gt; 
&gt; actually, I&apos;m not sure which is more grammatically correct. I&apos;ll leave it up to you

I copied from the official documentation which says &quot;if they are not accessed in 3 days&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654926</commentid>
    <comment_count>7</comment_count>
      <attachid>399956</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-21 08:25:32 -0700</bug_when>
    <thetext>Created attachment 399956
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654939</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-05-21 09:08:54 -0700</bug_when>
    <thetext>Committed r262004: &lt;https://trac.webkit.org/changeset/262004&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399956.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654941</commentid>
    <comment_count>9</comment_count>
      <attachid>399956</attachid>
    <who name="">mitz</who>
    <bug_when>2020-05-21 09:10:31 -0700</bug_when>
    <thetext>Comment on attachment 399956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399956&amp;action=review

&gt; Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:264
&gt;          WTFLogAlways(&quot;%s: Could not retrieve user cache directory path: %s\n&quot;, getprogname(), strerror(errno));

Should probably change this from “cache” to “temporary”.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1654942</commentid>
    <comment_count>10</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-21 09:12:54 -0700</bug_when>
    <thetext>(In reply to mitz from comment #9)
&gt; Comment on attachment 399956 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=399956&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:264
&gt; &gt;          WTFLogAlways(&quot;%s: Could not retrieve user cache directory path: %s\n&quot;, getprogname(), strerror(errno));
&gt; 
&gt; Should probably change this from “cache” to “temporary”.

Fixed in &lt;https://trac.webkit.org/changeset/262005&gt;, thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1667328</commentid>
    <comment_count>11</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-06-29 15:56:11 -0700</bug_when>
    <thetext>Reverted r262004 for reason:

Revert r262004 as it is not OK to have a data vault in /var/folders/zy/g91x07sn08bgjkm8d_pg0vfc0000gn/T/ &lt;rdar://problem/64540215&gt;

Committed r263705: &lt;https://trac.webkit.org/changeset/263705&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1675302</commentid>
    <comment_count>12</comment_count>
      <attachid>405292</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-07-27 10:47:06 -0700</bug_when>
    <thetext>Created attachment 405292
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2015677</commentid>
    <comment_count>13</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2024-02-20 20:31:56 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/24861</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2015789</commentid>
    <comment_count>14</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-02-21 10:21:22 -0800</bug_when>
    <thetext>Committed 275108@main (2dfb4e9da6fd): &lt;https://commits.webkit.org/275108@main&gt;

Reviewed commits have been landed. Closing PR #24861 and removing active labels.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>399913</attachid>
            <date>2020-05-20 16:35:35 -0700</date>
            <delta_ts>2020-05-21 08:25:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212177-20200520163534.patch</filename>
            <type>text/plain</type>
            <size>2379</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE1MjIxYWNlNjk4ZDM2ZWEz
ODg2MjJlYWZmMzc3NTg4Njc3YTRiZWUuLmJkOTYyZDkyNjY1MmNhMjA4NzE0MTIxM2Q0ZjZiYzU1
ODZmOTg3MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDUtMjAgIENocmlzIER1
bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbV0syXSBXZWJLaXQgYWJhbmRvbnMg
Y29tcGlsZWQgc2FuZGJveCBwcm9maWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMTc3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDYxMzYx
OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJL
aXQgZ2VuZXJhdGVzIG5ldyBjb21waWxlZCBzYW5kYm94IHByb2ZpbGVzIHdoZW5ldmVyIHNhbmRi
b3ggcHJvZmlsZXMgYXJlIHVwZGF0ZWQgb3IKKyAgICAgICAgd2hlbmV2ZXIgd2Via2l0IGRpcmVj
dG9yaWVzIGNoYW5nZSAod2hpY2ggaXMgc3VwZXIgY29tbW9uIGZvciBXZWJLaXRUZXN0UnVubmVy
KS4gUHJldmlvdXMKKyAgICAgICAgY29tcGlsZWQgc2FuZGJveCBwcm9maWxlcyBkbyBub3QgZ2V0
IGRlbGV0ZWQgYW5kIHRoZXJlZm9yZSBtYXkgYWNjdW11bGF0ZS4KKworICAgICAgICBUbyBhZGRy
ZXNzIHRoZSBpc3N1ZSwgd2Ugbm93IHNhdmUgY29tcGlsZWQgc2FuZGJveCBwcm9maWxlcyB1bmRl
ciBfQ1NfREFSV0lOX1VTRVJfVEVNUF9ESVIKKyAgICAgICAgaW5zdGVhZCBvZiBfQ1NfREFSV0lO
X1VTRVJfQ0FDSEVfRElSLiBUaGUgc3lzdGVtIHRha2VzIGNhcmUgb2YgZGVsZXRpbmcgdGhlIGZp
bGVzIHVuZGVyCisgICAgICAgIF9DU19EQVJXSU5fVVNFUl9URU1QX0RJUiB1cG9uIHJlYm9vdCBv
ciBpZiB0aGV5IGhhdmUgbm90IGJlZW4gYWNjZXNzZWQgZm9yIDMgZGF5cy4KKworICAgICAgICAq
IFNoYXJlZC9tYWMvQXV4aWxpYXJ5UHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6c2Fu
ZGJveERhdGFWYXVsdFBhcmVudERpcmVjdG9yeSk6CisKIDIwMjAtMDUtMjAgIENocmlzIER1bWV6
ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBEZXByZWNhdGUgV0tCdW5kbGVQYWdlU2V0
UG9saWN5Q2xpZW50KCkgSW5qZWN0ZWQgYnVuZGxlIEMgQVBJCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViS2l0L1NoYXJlZC9tYWMvQXV4aWxpYXJ5UHJvY2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQv
U2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1tCmluZGV4IDdhZGU2ZDIyZDIzMzNkMDA2
MDZjMGI0OGI5NGU0NTA5MDAzYmI0YzUuLjY3ZmQxMzNmZDBiZGY0Mjc5MTE3YzJmNGQ2NTUyZWFl
NDAyM2QwZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQ
cm9jZXNzTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9j
ZXNzTWFjLm1tCkBAIC0yNTYsNyArMjU2LDEwIEBAIHN0YXRpYyBPcHRpb25hbDxDU3RyaW5nPiBz
ZXRBbmRTZXJpYWxpemVTYW5kYm94UGFyYW1ldGVycyhjb25zdCBTYW5kYm94SW5pdGlhbGl6CiBz
dGF0aWMgU3RyaW5nIHNhbmRib3hEYXRhVmF1bHRQYXJlbnREaXJlY3RvcnkoKQogewogICAgIGNo
YXIgdGVtcFtQQVRIX01BWF07Ci0gICAgc2l6ZV90IGxlbmd0aCA9IGNvbmZzdHIoX0NTX0RBUldJ
Tl9VU0VSX0NBQ0hFX0RJUiwgdGVtcCwgc2l6ZW9mKHRlbXApKTsKKyAgICAvLyBXZSBzYXZlIHRo
ZSBwcm9maWxlcyBpbiB0aGUgdXNlciB0ZW1wb3J5IGRpcmVjdG9yeSBzbyB0aGF0IHRoZXkgZ2V0
IGNsZWFuZWQgYWZ0ZXIgb24gcmVib290CisgICAgLy8gb3IgaWYgdGhleSBhcmUgbm90IGFjY2Vz
c2VkIGluIDMgZGF5cy4gVGhpcyBhdm9pZHMgYWNjdW11bGF0aW5nIHByb2ZpbGVzIHdoZW5ldmVy
IHdlIGNoYW5nZQorICAgIC8vIG91ciBzYW5kYm94IHJ1bGVzIG9yIHdlYmtpdCBjYWNoZSBkaXJl
Y3RvcmllcyAocmRhcjovL3Byb2JsZW0vNTQ2MTM2MTkpLgorICAgIHNpemVfdCBsZW5ndGggPSBj
b25mc3RyKF9DU19EQVJXSU5fVVNFUl9URU1QX0RJUiwgdGVtcCwgc2l6ZW9mKHRlbXApKTsKICAg
ICBpZiAoIWxlbmd0aCkgewogICAgICAgICBXVEZMb2dBbHdheXMoIiVzOiBDb3VsZCBub3QgcmV0
cmlldmUgdXNlciBjYWNoZSBkaXJlY3RvcnkgcGF0aDogJXNcbiIsIGdldHByb2duYW1lKCksIHN0
cmVycm9yKGVycm5vKSk7CiAgICAgICAgIGV4aXQoRVhfTk9QRVJNKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>399956</attachid>
            <date>2020-05-21 08:25:32 -0700</date>
            <delta_ts>2020-07-27 10:47:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212177-20200521082531.patch</filename>
            <type>text/plain</type>
            <size>2421</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhmZTZjNGExNjVkODJkNGMz
Yjk0N2MyZWE3NjEyYTU1ZmNhYmU1MTMuLjNiN2VhNjAxNTE1NmM5OWEzOTBkNTg5ODkwYzI2Yzdl
ODIyOWU0ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDUtMjEgIENocmlzIER1
bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbV0syXSBXZWJLaXQgYWJhbmRvbnMg
Y29tcGlsZWQgc2FuZGJveCBwcm9maWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMTc3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDYxMzYx
OT4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICBXZWJLaXQg
Z2VuZXJhdGVzIG5ldyBjb21waWxlZCBzYW5kYm94IHByb2ZpbGVzIHdoZW5ldmVyIHNhbmRib3gg
cHJvZmlsZXMgYXJlIHVwZGF0ZWQgb3IKKyAgICAgICAgd2hlbmV2ZXIgd2Via2l0IGRpcmVjdG9y
aWVzIGNoYW5nZSAod2hpY2ggaXMgc3VwZXIgY29tbW9uIGZvciBXZWJLaXRUZXN0UnVubmVyKS4g
UHJldmlvdXMKKyAgICAgICAgY29tcGlsZWQgc2FuZGJveCBwcm9maWxlcyBkbyBub3QgZ2V0IGRl
bGV0ZWQgYW5kIHRoZXJlZm9yZSBtYXkgYWNjdW11bGF0ZS4KKworICAgICAgICBUbyBhZGRyZXNz
IHRoZSBpc3N1ZSwgd2Ugbm93IHNhdmUgY29tcGlsZWQgc2FuZGJveCBwcm9maWxlcyB1bmRlciBf
Q1NfREFSV0lOX1VTRVJfVEVNUF9ESVIKKyAgICAgICAgaW5zdGVhZCBvZiBfQ1NfREFSV0lOX1VT
RVJfQ0FDSEVfRElSLiBUaGUgc3lzdGVtIHRha2VzIGNhcmUgb2YgZGVsZXRpbmcgdGhlIGZpbGVz
IHVuZGVyCisgICAgICAgIF9DU19EQVJXSU5fVVNFUl9URU1QX0RJUiB1cG9uIHJlYm9vdCBvciBp
ZiB0aGV5IGhhdmUgbm90IGJlZW4gYWNjZXNzZWQgZm9yIDMgZGF5cy4KKworICAgICAgICAqIFNo
YXJlZC9tYWMvQXV4aWxpYXJ5UHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6c2FuZGJv
eERhdGFWYXVsdFBhcmVudERpcmVjdG9yeSk6CisKIDIwMjAtMDUtMjEgIEVucmlxdWUgT2Nhw7Fh
IEdvbnrDoWxleiAgPGVvY2FuaGFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXVtH
VEtdW1dQRV0gRXhwb3NlIGFuZCBob25vciB0aGUgbWVkaWEgY29udGVudCB0eXBlcyByZXF1aXJp
bmcgaGFyZHdhcmUgc3VwcG9ydCBzZXR0aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1No
YXJlZC9tYWMvQXV4aWxpYXJ5UHJvY2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21h
Yy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1tCmluZGV4IDdhZGU2ZDIyZDIzMzNkMDA2MDZjMGI0OGI5
NGU0NTA5MDAzYmI0YzUuLmVjZjYyYWZkNTA2OGUzNTEzYjVjYzhkZTgwOGZkMzlkYjljOWU2YmEg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFj
Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1t
CkBAIC0yNTYsNyArMjU2LDEwIEBAIHN0YXRpYyBPcHRpb25hbDxDU3RyaW5nPiBzZXRBbmRTZXJp
YWxpemVTYW5kYm94UGFyYW1ldGVycyhjb25zdCBTYW5kYm94SW5pdGlhbGl6CiBzdGF0aWMgU3Ry
aW5nIHNhbmRib3hEYXRhVmF1bHRQYXJlbnREaXJlY3RvcnkoKQogewogICAgIGNoYXIgdGVtcFtQ
QVRIX01BWF07Ci0gICAgc2l6ZV90IGxlbmd0aCA9IGNvbmZzdHIoX0NTX0RBUldJTl9VU0VSX0NB
Q0hFX0RJUiwgdGVtcCwgc2l6ZW9mKHRlbXApKTsKKyAgICAvLyBXZSBzYXZlIHRoZSBwcm9maWxl
cyBpbiB0aGUgdXNlciB0ZW1wb3J5IGRpcmVjdG9yeSBzbyB0aGF0IHRoZXkgZ2V0IGNsZWFuZWQg
b24gcmVib290CisgICAgLy8gb3IgaWYgdGhleSBhcmUgbm90IGFjY2Vzc2VkIGluIDMgZGF5cy4g
VGhpcyBhdm9pZHMgYWNjdW11bGF0aW5nIHByb2ZpbGVzIHdoZW5ldmVyIHdlIGNoYW5nZQorICAg
IC8vIG91ciBzYW5kYm94IHJ1bGVzIG9yIHdlYmtpdCBjYWNoZSBkaXJlY3RvcmllcyAocmRhcjov
L3Byb2JsZW0vNTQ2MTM2MTkpLgorICAgIHNpemVfdCBsZW5ndGggPSBjb25mc3RyKF9DU19EQVJX
SU5fVVNFUl9URU1QX0RJUiwgdGVtcCwgc2l6ZW9mKHRlbXApKTsKICAgICBpZiAoIWxlbmd0aCkg
ewogICAgICAgICBXVEZMb2dBbHdheXMoIiVzOiBDb3VsZCBub3QgcmV0cmlldmUgdXNlciBjYWNo
ZSBkaXJlY3RvcnkgcGF0aDogJXNcbiIsIGdldHByb2duYW1lKCksIHN0cmVycm9yKGVycm5vKSk7
CiAgICAgICAgIGV4aXQoRVhfTk9QRVJNKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405292</attachid>
            <date>2020-07-27 10:47:06 -0700</date>
            <delta_ts>2024-02-20 20:22:58 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212177-20200727104705.patch</filename>
            <type>text/plain</type>
            <size>3307</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhiNDVkMzQxNmE0MWEwOWIw
ZDVhMjgxYzEyOTFjNTZkOWJmNTM4NDUuLjdmYTgzNTU2NTZkZjkwNGYxMjg3M2Y3ODMyMTk1MTNk
Y2JhOTIxNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDctMjcgIENocmlzIER1
bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbV0syXSBXZWJLaXQgYWJhbmRvbnMg
Y29tcGlsZWQgc2FuZGJveCBwcm9maWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMTc3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDYxMzYx
OT4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICBXZWJLaXQg
Z2VuZXJhdGVzIG5ldyBjb21waWxlZCBzYW5kYm94IHByb2ZpbGVzIHdoZW5ldmVyIHNhbmRib3gg
cHJvZmlsZXMgYXJlIHVwZGF0ZWQgb3IKKyAgICAgICAgd2hlbmV2ZXIgd2Via2l0IGRpcmVjdG9y
aWVzIGNoYW5nZSAod2hpY2ggaXMgc3VwZXIgY29tbW9uIGZvciBXZWJLaXRUZXN0UnVubmVyKS4g
UHJldmlvdXMKKyAgICAgICAgY29tcGlsZWQgc2FuZGJveCBwcm9maWxlcyBkbyBub3QgZ2V0IGRl
bGV0ZWQgYW5kIHRoZXJlZm9yZSBtYXkgYWNjdW11bGF0ZS4KKworICAgICAgICBUbyBhZGRyZXNz
IHRoZSBpc3N1ZSwgd2Ugbm93IHNhdmUgY29tcGlsZWQgc2FuZGJveCBwcm9maWxlcyB1bmRlciBf
Q1NfREFSV0lOX1VTRVJfVEVNUF9ESVIKKyAgICAgICAgaW5zdGVhZCBvZiBfQ1NfREFSV0lOX1VT
RVJfQ0FDSEVfRElSLiBUaGUgc3lzdGVtIHRha2VzIGNhcmUgb2YgZGVsZXRpbmcgdGhlIGZpbGVz
IHVuZGVyCisgICAgICAgIF9DU19EQVJXSU5fVVNFUl9URU1QX0RJUiB1cG9uIHJlYm9vdCBvciBp
ZiB0aGV5IGhhdmUgbm90IGJlZW4gYWNjZXNzZWQgZm9yIDMgZGF5cy4KKworICAgICAgICAqIFNo
YXJlZC9tYWMvQXV4aWxpYXJ5UHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6c2FuZGJv
eERhdGFWYXVsdFBhcmVudERpcmVjdG9yeSk6CisKIDIwMjAtMDctMjcgIE1lZ2FuIEdhcmRuZXIg
IDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnlpbmcgdG8gbG9va3VwIHdo
ZW4gV2ViVmlldyBpcyBpbiBhIHBvcG92ZXIgY2F1c2VzIHByb2Nlc3MgdG8gaGFuZy4KZGlmZiAt
LWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oIGIvU291cmNlL1dURi93dGYvUGxh
dGZvcm1IYXZlLmgKaW5kZXggMTdhYjgyNGRlNDYyNGFiNDE0Yjg0YjExZjNiOTBiZWMzYzg1MmNk
YS4uMzFjZTFmN2UxZTQwYjQwZGMzNTJkYzNhYWRjMDJjOWJmMzYwOTJhMSAxMDA2NDQKLS0tIGEv
U291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZv
cm1IYXZlLmgKQEAgLTcwNywzICs3MDcsNyBAQAogI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFD
X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTEwMDAwKQogI2RlZmluZSBIQVZFX05TVEFC
TEVWSUVXU1RZTEUgMQogI2VuZGlmCisKKyNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19Y
X1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDExMDAwMCkKKyNkZWZpbmUgSEFWRV9EQVRBVkFVTFRf
SU5fVE1QRElSX1NVUFBPUlQgMQorI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1No
YXJlZC9tYWMvQXV4aWxpYXJ5UHJvY2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21h
Yy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1tCmluZGV4IGYzM2NlN2M5ODY1NDA5ZGRhZjk1OTdlZDRl
NTMxMTY1MDYxMWU1N2MuLmEzMDU5ZmYzZjM4OTYwZTkzY2I2MWFmYTY4NjVjZTE5NGIzNTY3MmQg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFj
Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1t
CkBAIC0yNjAsMTEgKzI2MCwyMiBAQCBzdGF0aWMgT3B0aW9uYWw8Q1N0cmluZz4gc2V0QW5kU2Vy
aWFsaXplU2FuZGJveFBhcmFtZXRlcnMoY29uc3QgU2FuZGJveEluaXRpYWxpegogc3RhdGljIFN0
cmluZyBzYW5kYm94RGF0YVZhdWx0UGFyZW50RGlyZWN0b3J5KCkKIHsKICAgICBjaGFyIHRlbXBb
UEFUSF9NQVhdOwotICAgIHNpemVfdCBsZW5ndGggPSBjb25mc3RyKF9DU19EQVJXSU5fVVNFUl9D
QUNIRV9ESVIsIHRlbXAsIHNpemVvZih0ZW1wKSk7CisjaWYgSEFWRShEQVRBVkFVTFRfSU5fVE1Q
RElSX1NVUFBPUlQpCisgICAgLy8gV2Ugc2F2ZSB0aGUgcHJvZmlsZXMgaW4gdGhlIHVzZXIgdGVt
cG9yeSBkaXJlY3Rvcnkgc28gdGhhdCB0aGV5IGdldCBjbGVhbmVkIG9uIHJlYm9vdAorICAgIC8v
IG9yIGlmIHRoZXkgYXJlIG5vdCBhY2Nlc3NlZCBpbiAzIGRheXMuIFRoaXMgYXZvaWRzIGFjY3Vt
dWxhdGluZyBwcm9maWxlcyB3aGVuZXZlciB3ZSBjaGFuZ2UKKyAgICAvLyBvdXIgc2FuZGJveCBy
dWxlcyBvciB3ZWJraXQgY2FjaGUgZGlyZWN0b3JpZXMgKHJkYXI6Ly9wcm9ibGVtLzU0NjEzNjE5
KS4KKyAgICBzaXplX3QgbGVuZ3RoID0gY29uZnN0cihfQ1NfREFSV0lOX1VTRVJfVEVNUF9ESVIs
IHRlbXAsIHNpemVvZih0ZW1wKSk7CiAgICAgaWYgKCFsZW5ndGgpIHsKICAgICAgICAgV1RGTG9n
QWx3YXlzKCIlczogQ291bGQgbm90IHJldHJpZXZlIHVzZXIgdGVtcG9yYXJ5IGRpcmVjdG9yeSBw
YXRoOiAlc1xuIiwgZ2V0cHJvZ25hbWUoKSwgc3RyZXJyb3IoZXJybm8pKTsKICAgICAgICAgZXhp
dChFWF9OT1BFUk0pOwogICAgIH0KKyNlbHNlCisgICAgc2l6ZV90IGxlbmd0aCA9IGNvbmZzdHIo
X0NTX0RBUldJTl9VU0VSX0NBQ0hFX0RJUiwgdGVtcCwgc2l6ZW9mKHRlbXApKTsKKyAgICBpZiAo
IWxlbmd0aCkgeworICAgICAgICBXVEZMb2dBbHdheXMoIiVzOiBDb3VsZCBub3QgcmV0cmlldmUg
dXNlciBjYWNoZSBkaXJlY3RvcnkgcGF0aDogJXNcbiIsIGdldHByb2duYW1lKCksIHN0cmVycm9y
KGVycm5vKSk7CisgICAgICAgIGV4aXQoRVhfTk9QRVJNKTsKKyAgICB9CisjZW5kaWYKICAgICBS
RUxFQVNFX0FTU0VSVChsZW5ndGggPD0gc2l6ZW9mKHRlbXApKTsKICAgICBjaGFyIHJlc29sdmVk
UGF0aFtQQVRIX01BWF07CiAgICAgaWYgKCFyZWFscGF0aCh0ZW1wLCByZXNvbHZlZFBhdGgpKSB7
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>