212153 2020-05-20 10:11:39 -0700 REGRESSION (r261892) [ Mac Debug ] 4 API tests failing related to ResourceLoadStatistics 2020-05-20 11:37:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell katherine_cheney bfulgham cdumez katherine_cheney sihui_liu webkit-bot-watchers-bugzilla webkit-bug-importer wilander oldest_to_newest 1654497 0 tsavell 2020-05-20 10:11:39 -0700 after the changes in https://trac.webkit.org/changeset/261892/webkit This test is failing: TestWebKitAPI.ResourceLoadStatistics.MigrateDataFromMissingTopFrameUniqueRedirectSameSiteStrictTableSchema and these are timing out: TestWebKitAPI.ResourceLoadStatistics.NetworkProcessRestart TestWebKitAPI.ResourceLoadStatistics.ShouldNotGrandfatherOnStartupDatabase TestWebKitAPI.ResourceLoadStatistics.ShouldNotGrandfatherOnStartup Result output: https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/4380/steps/run-api-tests/logs/stdio 1654498 1 webkit-bug-importer 2020-05-20 10:12:06 -0700 <rdar://problem/63452541> 1654501 2 tsavell 2020-05-20 10:17:49 -0700 It looks like this test is specifically broken on Mojave Debug: TestWebKitAPI.ResourceLoadStatistics.NoMessagesWhenNotTesting History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.ResourceLoadStatistics.NoMessagesWhenNotTesting 1654513 3 399851 katherine_cheney 2020-05-20 10:42:31 -0700 Created attachment 399851 Patch 1654515 4 katherine_cheney 2020-05-20 10:45:47 -0700 I got a little too excited when deleting reset() calls in https://trac.webkit.org/changeset/261892/webkit. In this case it is needed because this statement is initialized in this function and does not use SQLiteStatementAutoResetScope, so it must be reset between iterations of the loop. 1654549 5 ews-feeder 2020-05-20 11:37:51 -0700 Committed r261935: <https://trac.webkit.org/changeset/261935> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399851. 399851 2020-05-20 10:42:31 -0700 2020-05-20 11:37:52 -0700 Patch bug-212153-20200520104230.patch text/plain 2035 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhjMjcyYWM4ODAwMDY2Yjc5 MTQ2MzllMTFlYTM3MDE2OGIzOTllYTEuLjA5ZmMwOWYwNjdkZjdmYjRkYjA0NmQwMWFlN2NkZWRh NzMxMWZjZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDUtMjAgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjI2MTg5MikgWyBNYWMgRGVidWcgXSA0IEFQSSB0ZXN0cyBmYWlsaW5nIHJlbGF0ZWQgdG8gUmVz b3VyY2VMb2FkU3RhdGlzdGljcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjEyMTUzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MzQ1MjU0MT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NpZGVudGFs bHkgZGVsZXRlZCBuZWNlc3NhcnkgcmVzZXQoKSBjYWxsIGZvciBhIFNRTGl0ZSBzdGF0ZW1lbnQK KyAgICAgICAgd2hlbiBjb252ZXJ0aW5nIHN0b3JlZCBzdGF0ZW1lbnRzIHRvIFNRTGl0ZVN0YXRl bWVudEF1dG9SZXNldFNjb3BlIGluCisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2No YW5nZXNldC8yNjE4OTIvd2Via2l0LgorCisgICAgICAgIFRoaXMgc3RhdGVtZW50IGlzIHVzZWQg aW4gYSBsb29wIHdpdGggbXVsdGlwbGUgYmluZCgpIGNhbGxzIHNvIGl0IG11c3QgYmUgcmVzZXQu CisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRp c3RpY3NEYXRhYmFzZVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVzb3VyY2VMb2FkU3Rh dGlzdGljc0RhdGFiYXNlU3RvcmU6OmNoZWNrRm9yTWlzc2luZ1RhYmxlc0luU2NoZW1hKToKKwog MjAyMC0wNS0xOSAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAog ICAgICAgICBJVFAgZGF0YWJhc2Ugc2hvdWxkIGZpbmFsaXplIGFsbCBwcmVwYXJlZCBzdGF0ZW1l bnRzIGJlZm9yZSBjbG9zaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRp c3RpY3NEYXRhYmFzZVN0b3JlLmNwcAppbmRleCBjNjU0ZGQzYTJjZmZlODQ1ODViM2FhNWU1MzJi NzliYWUzMmNlMjQ2Li4xNDdkNmU5MzRjODc2ZDc5ZTNmZjg3OTZhNDgxNjQ4ZWRiNjYxOGY3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9y ZS5jcHAKQEAgLTM1Miw2ICszNTIsNyBAQCBPcHRpb25hbDxWZWN0b3I8U3RyaW5nPj4gUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmU6OmNoZWNrRm9yTWlzc2luZ1RhYgogICAgICAg ICAgICAgUkVMRUFTRV9MT0dfRVJST1IoTmV0d29yaywgIiVwIC0gUmVzb3VyY2VMb2FkU3RhdGlz dGljc0RhdGFiYXNlU3RvcmU6OmNoZWNrRm9yTWlzc2luZ1RhYmxlc0luU2NoZW1hIHNjaGVtYSBp cyBtaXNzaW5nIHRhYmxlOiAlcyIsIHRoaXMsIHRhYmxlLmFzY2lpKCkuZGF0YSgpKTsKICAgICAg ICAgICAgIG1pc3NpbmdUYWJsZXMuYXBwZW5kKFN0cmluZyh0YWJsZSkpOwogICAgICAgICB9Cisg ICAgICAgIHN0YXRlbWVudC5yZXNldCgpOwogICAgIH0KICAgICBpZiAobWlzc2luZ1RhYmxlcy5p c0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7Cg==