212142 2020-05-20 08:46:24 -0700 Fix for accessibility-node-memory-management.html in isolated tree mode. 2020-05-20 11:22:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1654457 0 andresg_22 2020-05-20 08:46:24 -0700 Fix for accessibility-node-memory-management.html in isolated tree mode. 1654463 1 399842 andresg_22 2020-05-20 08:57:23 -0700 Created attachment 399842 Patch 1654473 2 399842 cfleizach 2020-05-20 09:12:50 -0700 Comment on attachment 399842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399842&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380 > auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper(); is this a pointer? should we be using auto& ? 1654524 3 andresg_22 2020-05-20 10:55:09 -0700 (In reply to chris fleizach from comment #2) > Comment on attachment 399842 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399842&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380 > > auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper(); > > is this a pointer? should we be using auto& ? I believe it is ok because wrapper is a reference to either NodeChange::m_wrapper or AXCoreObject::m_wrapper, which is a RetainPtr. 1654540 4 ews-feeder 2020-05-20 11:21:14 -0700 Committed r261934: <https://trac.webkit.org/changeset/261934> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399842. 1654541 5 webkit-bug-importer 2020-05-20 11:22:15 -0700 <rdar://problem/63455951> 399842 2020-05-20 08:57:23 -0700 2020-05-20 11:21:14 -0700 Patch bug-212142-20200520115722.patch text/plain 5776 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDdjNWZhZmJjZjExZGNm Zjc5MDg3ZWUxMWU4ZGM0YmNlNmI2ZDUzNS4uYmU1YTllOThkYzllNjdjM2U2YTMzMzdjNzFjNTI1 Njc3N2M0OTFjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIwLTA1LTIwICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggZm9yIGFj Y2Vzc2liaWxpdHktbm9kZS1tZW1vcnktbWFuYWdlbWVudC5odG1sIGluIGlzb2xhdGVkIHRyZWUg bW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MjE0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExh eW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYWNjZXNzaWJpbGl0eS1ub2RlLW1lbW9yeS1tYW5hZ2Vt ZW50Lmh0bWwuCisKKyAgICAgICAgLSBGaXggaW4gYXBwbHlQZW5kaW5nQ2hhbmdlcyB0aGF0IHdh cyBub3QgcmVtb3ZpbmcgcmVtb3ZlZCBub2RlcyBmcm9tCisgICAgICAgIHRoZSBub2RlcyBtYXAu IFRoaXMgd2FzIGNhdXNpbmcgdGhhdCBzb21lIGRldGFjaGVkIEFYSXNvbGF0ZWRPYmplY3RzCisg ICAgICAgIHdlcmUgYmVpbmcgcmV0dXJuZWQuCisgICAgICAgIC0gQWxzbyBoYW5kbGUgdGhlIGNh c2Ugd2hlcmUgcGVuZGluZyBjaGFuZ2VzIGNhbiBjb21lIGZyb20gYSBkZXRhY2hlZAorICAgICAg ICBBWE9iamVjdCB3aXRoIGludmFsaWQgSUQgYW5kIG5vIHBsYXRmb3JtIHdyYXBwZXIuCisgICAg ICAgIC0gdXBkYXRlQ2hpbGRyZW4gYmV0dGVyIGhhbmRsZXMgdGhlIGNhc2Ugd2hlbiB0aGUgbm90 aWZpY2F0aW9uIHRhcmdldAorICAgICAgICBpcyBub3QgaW4gdGhlIGlzb2xhdGVkIHRyZWUgYnkg d2Fsa2luZyB1cCB0aGUgb2JqZWN0IGhpZXJhcmNoeSB1bnRpbCBpdAorICAgICAgICBmaW5kcyBh biBhc3NvY2lhdGVkIG9iamVjdCB0aGF0IGRvZXMgaGF2ZSBhIGNvcnJlc3BvbmRpbmcgaXNvbGF0 ZWQgb2JqZWN0LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29s YXRlZFRyZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZFRyZWU6OnRyZWVGb3JQ YWdlSUQpOgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZFRyZWU6OnVwZGF0ZUNoaWxkcmVu KToKKyAgICAgICAgKFdlYkNvcmU6OkFYSXNvbGF0ZWRUcmVlOjphcHBseVBlbmRpbmdDaGFuZ2Vz KToKKwogMjAyMC0wNS0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIGl0ZXJhdG9yIGNoZWNraW5nIHRvIExpc3RIYXNoU2V0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJl ZS5jcHAKaW5kZXggMjY1ZWExZTcwMjAxZjY4MjQzNjQ3Zjk4ZmFhZWZkZDQ4YmMxMmY4NC4uYzI0 MGY4ZGU2ZjdiNjhlYTE3NDdjNjRhM2RlOTJmOWFiYTY5MjNlMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRU cmVlLmNwcApAQCAtMTI5LDcgKzEyOSw2IEBAIHZvaWQgQVhJc29sYXRlZFRyZWU6OnJlbW92ZVRy ZWVGb3JQYWdlSUQoUGFnZUlkZW50aWZpZXIgcGFnZUlEKQogCiBSZWZQdHI8QVhJc29sYXRlZFRy ZWU+IEFYSXNvbGF0ZWRUcmVlOjp0cmVlRm9yUGFnZUlEKFBhZ2VJZGVudGlmaWVyIHBhZ2VJRCkK IHsKLSAgICBBWFRSQUNFKCJBWElzb2xhdGVkVHJlZTo6dHJlZUZvclBhZ2VJRCIpOwogICAgIExv Y2tIb2xkZXIgbG9ja2VyKHNfY2FjaGVMb2NrKTsKIAogICAgIGlmIChhdXRvIHRyZWUgPSB0cmVl UGFnZUNhY2hlKCkuZ2V0KHBhZ2VJRCkpCkBAIC0yMzcsMjEgKzIzNiwyNyBAQCB2b2lkIEFYSXNv bGF0ZWRUcmVlOjp1cGRhdGVDaGlsZHJlbihBWENvcmVPYmplY3QmIGF4T2JqZWN0KQogICAgIGlm ICghYXhPYmplY3QuZG9jdW1lbnQoKSB8fCAhYXhPYmplY3QuZG9jdW1lbnQoKS0+aGFzTGl2aW5n UmVuZGVyVHJlZSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBBWElEIGF4T2JqZWN0SUQgPSBh eE9iamVjdC5vYmplY3RJRCgpOwotCiAgICAgYXBwbHlQZW5kaW5nQ2hhbmdlcygpOwogICAgIExv Y2tIb2xkZXIgbG9ja2VyIHsgbV9jaGFuZ2VMb2dMb2NrIH07Ci0gICAgYXV0byBvYmplY3QgPSBu b2RlRm9ySUQoYXhPYmplY3RJRCk7Ci0gICAgaWYgKCFvYmplY3QpIHsKLSAgICAgICAgQVhMT0co Ik5vIGFzc29jaWF0ZWQgaXNvbGF0ZWQgb2JqZWN0ISIpOworCisgICAgLy8gdXBkYXRlQ2hpbGRy ZW4gbWF5IGJlIGNhbGxlZCBhcyB0aGUgcmVzdWx0IG9mIGEgY2hpbGRyZW4gY2hhbmdlZAorICAg IC8vIG5vdGlmaWNhdGlvbiBmb3IgYW4gYXhPYmplY3QgdGhhdCBoYXMgbm8gYXNzb2NpYXRlZCBp c29sYXRlZCBvYmplY3QuCisgICAgLy8gQW4gZXhhbXBsZSBvZiB0aGlzIGlzIHdoZW4gYW4gZW1w dHkgZWxlbWVudCBzdWNoIGFzIGEgPGNhbnZhcz4gb3IgPGRpdj4KKyAgICAvLyBpcyBhZGRlZCBh IG5ldyBjaGlsZC4gU28gZmluZCB0aGUgY2xvc2VzdCBhbmNlc3RvciBvZiBheE9iamVjdCB0aGF0 IGhhcworICAgIC8vIGFuIGFzc29jaWF0ZWQgaXNvbGF0ZWQgb2JqZWN0IGFuZCB1cGRhdGUgaXRz IGNoaWxkcmVuLgorICAgIFJlZlB0cjxBWElzb2xhdGVkT2JqZWN0PiBvYmplY3Q7CisgICAgYXV0 byogYXhBbmNlc3RvciA9IEFjY2Vzc2liaWxpdHk6OmZpbmRBbmNlc3RvcihheE9iamVjdCwgdHJ1 ZSwgWyZvYmplY3QsIHRoaXNdIChjb25zdCBBWENvcmVPYmplY3QmIGFuY2VzdG9yKSB7CisgICAg ICAgIHJldHVybiBvYmplY3QgPSBub2RlRm9ySUQoYW5jZXN0b3Iub2JqZWN0SUQoKSk7CisgICAg fSk7CisgICAgQVNTRVJUKG9iamVjdCAmJiBvYmplY3QtPm9iamVjdElEKCkgIT0gSW52YWxpZEFY SUQpOworICAgIGlmICghYXhBbmNlc3RvciB8fCAhb2JqZWN0KQogICAgICAgICByZXR1cm47IC8v IG5vdGhpbmcgdG8gdXBkYXRlLgotICAgIH0KIAogICAgIGF1dG8gcmVtb3ZhbHMgPSBvYmplY3Qt Pm1fY2hpbGRyZW5JRHM7CiAgICAgbG9ja2VyLnVubG9ja0Vhcmx5KCk7CiAKLSAgICBjb25zdCBh dXRvJiBheENoaWxkcmVuID0gYXhPYmplY3QuY2hpbGRyZW4oKTsKLSAgICBhdXRvIGF4Q2hpbGRy ZW5JRHMgPSBheE9iamVjdC5jaGlsZHJlbklEcygpOworICAgIGNvbnN0IGF1dG8mIGF4Q2hpbGRy ZW4gPSBheEFuY2VzdG9yLT5jaGlsZHJlbigpOworICAgIGF1dG8gYXhDaGlsZHJlbklEcyA9IGF4 QW5jZXN0b3ItPmNoaWxkcmVuSURzKCk7CiAKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGF4 Q2hpbGRyZW5JRHMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgc2l6ZV90IGluZGV4ID0gcmVtb3Zh bHMuZmluZChheENoaWxkcmVuSURzW2ldKTsKQEAgLTI2MSw3ICsyNjYsNyBAQCB2b2lkIEFYSXNv bGF0ZWRUcmVlOjp1cGRhdGVDaGlsZHJlbihBWENvcmVPYmplY3QmIGF4T2JqZWN0KQogICAgICAg ICAgICAgLy8gVGhpcyBpcyBhIG5ldyBjaGlsZCwgYWRkIGl0IHRvIHRoZSB0cmVlLgogICAgICAg ICAgICAgQVhMT0coIkFkZGluZyBhIG5ldyBjaGlsZCBmb3I6Iik7CiAgICAgICAgICAgICBBWExP RyhheENoaWxkcmVuW2ldKTsKLSAgICAgICAgICAgIGdlbmVyYXRlU3VidHJlZSgqYXhDaGlsZHJl bltpXSwgYXhPYmplY3RJRCwgdHJ1ZSk7CisgICAgICAgICAgICBnZW5lcmF0ZVN1YnRyZWUoKmF4 Q2hpbGRyZW5baV0sIG9iamVjdC0+b2JqZWN0SUQoKSwgdHJ1ZSk7CiAgICAgICAgIH0KICAgICB9 CiAKQEAgLTM1MCwzNSArMzU1LDMxIEBAIHZvaWQgQVhJc29sYXRlZFRyZWU6OmFwcGx5UGVuZGlu Z0NoYW5nZXMoKQogICAgIHdoaWxlIChtX3BlbmRpbmdOb2RlUmVtb3ZhbHMuc2l6ZSgpKSB7CiAg ICAgICAgIGF1dG8gYXhJRCA9IG1fcGVuZGluZ05vZGVSZW1vdmFscy50YWtlTGFzdCgpOwogICAg ICAgICBBWExPRyhtYWtlU3RyaW5nKCJyZW1vdmluZyBheElEICIsIGF4SUQpKTsKLSAgICAgICAg aWYgKGF4SUQgPT0gSW52YWxpZEFYSUQpCi0gICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAg ICBpZiAoYXV0byBvYmplY3QgPSBub2RlRm9ySUQoYXhJRCkpCisgICAgICAgIGlmIChhdXRvIG9i amVjdCA9IG5vZGVGb3JJRChheElEKSkgewogICAgICAgICAgICAgb2JqZWN0LT5kZXRhY2goQWNj ZXNzaWJpbGl0eURldGFjaG1lbnRUeXBlOjpFbGVtZW50RGVzdHJveWVkKTsKKyAgICAgICAgICAg IG1fcmVhZGVyVGhyZWFkTm9kZU1hcC5yZW1vdmUoYXhJRCk7CisgICAgICAgIH0KICAgICB9CiAK ICAgICB3aGlsZSAobV9wZW5kaW5nU3VidHJlZVJlbW92YWxzLnNpemUoKSkgewogICAgICAgICBh dXRvIGF4SUQgPSBtX3BlbmRpbmdTdWJ0cmVlUmVtb3ZhbHMudGFrZUxhc3QoKTsKICAgICAgICAg QVhMT0cobWFrZVN0cmluZygicmVtb3Zpbmcgc3VidHJlZSBheElEICIsIGF4SUQpKTsKLSAgICAg ICAgaWYgKGF4SUQgPT0gSW52YWxpZEFYSUQpCi0gICAgICAgICAgICBjb250aW51ZTsKLQogICAg ICAgICBpZiAoYXV0byBvYmplY3QgPSBub2RlRm9ySUQoYXhJRCkpIHsKICAgICAgICAgICAgIG9i amVjdC0+ZGV0YWNoKEFjY2Vzc2liaWxpdHlEZXRhY2htZW50VHlwZTo6RWxlbWVudERlc3Ryb3ll ZCk7CiAgICAgICAgICAgICBtX3BlbmRpbmdTdWJ0cmVlUmVtb3ZhbHMuYXBwZW5kVmVjdG9yKG9i amVjdC0+bV9jaGlsZHJlbklEcyk7CisgICAgICAgICAgICBtX3JlYWRlclRocmVhZE5vZGVNYXAu cmVtb3ZlKGF4SUQpOwogICAgICAgICB9CiAgICAgfQogCiAgICAgZm9yIChjb25zdCBhdXRvJiBp dGVtIDogbV9wZW5kaW5nQXBwZW5kcykgewotICAgICAgICAvLyBFaXRoZXIgdGhlIG5ldyBvYmpl Y3QgaGFzIGEgd3JhcHBlciBhbHJlYWR5IGF0dGFjaGVkLCBvciBvbmUgaXMgcGFzc2VkIHRvIGJl IGF0dGFjaGVkLCBub3QgYm90aC4KLSAgICAgICAgQVNTRVJUKChpdGVtLm1faXNvbGF0ZWRPYmpl Y3QtPndyYXBwZXIoKSB8fCBpdGVtLm1fd3JhcHBlcikKLSAgICAgICAgICAgICYmICEoaXRlbS5t X2lzb2xhdGVkT2JqZWN0LT53cmFwcGVyKCkgJiYgaXRlbS5tX3dyYXBwZXIpKTsKICAgICAgICAg QVhJRCBheElEID0gaXRlbS5tX2lzb2xhdGVkT2JqZWN0LT5vYmplY3RJRCgpOwogICAgICAgICBB WExPRyhtYWtlU3RyaW5nKCJhcHBlbmRpbmcgYXhJRCAiLCBheElEKSk7CiAgICAgICAgIGlmIChh eElEID09IEludmFsaWRBWElEKQogICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgYXV0 byYgd3JhcHBlciA9IGl0ZW0ubV93cmFwcGVyID8gaXRlbS5tX3dyYXBwZXIgOiBpdGVtLm1faXNv bGF0ZWRPYmplY3QtPndyYXBwZXIoKTsKKyAgICAgICAgaWYgKCF3cmFwcGVyKQorICAgICAgICAg ICAgY29udGludWU7CiAKICAgICAgICAgaWYgKGF1dG8gb2JqZWN0ID0gbV9yZWFkZXJUaHJlYWRO b2RlTWFwLmdldChheElEKSkgewogICAgICAgICAgICAgaWYgKG9iamVjdCAhPSAmaXRlbS5tX2lz b2xhdGVkT2JqZWN0LmdldCgpCg==