212136 2020-05-20 07:26:22 -0700 REGRESSION(r261554): [GTK] Version 2.29.1 crashes using drag-n-drop API 2020-05-20 16:04:46 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 guillaume.webkit webkit-unassigned aperez bugs-noreply cgarcia oldest_to_newest 1654416 0 guillaume.webkit 2020-05-20 07:26:22 -0700 When using the drag-n-drop API, Epiphany with WebKitGTK 2.29.1 crashes. Previous versions of WebKitGTK were working. Example: https://jsbin.com/hiqasek/edit?html,js,output - Epiphany 3.37.1 - WebKitGTK 2.29.1 1654444 1 cgarcia 2020-05-20 08:22:58 -0700 Right, I forgot to handle selection data in Pasteboard::read taking a PasteboardFileReader. 1654445 2 399840 cgarcia 2020-05-20 08:24:50 -0700 Created attachment 399840 Patch 1654465 3 cgarcia 2020-05-20 09:00:06 -0700 Committed r261923: <https://trac.webkit.org/changeset/261923> 1654695 4 guillaume.webkit 2020-05-20 16:04:46 -0700 That was really, really fast. Thank you ♥, the patch works perfectly! 399840 2020-05-20 08:24:50 -0700 2020-05-20 08:56:22 -0700 Patch wkgtk-dnd-files-crash.diff text/plain 1407 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNjlmN2RmMDM3MmMuLmEzNzI4MzliZTJkMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDIwLTA1LTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNjE1NTQpOiBbR1RLXSBWZXJzaW9u IDIuMjkuMSBjcmFzaGVzIHVzaW5nIGRyYWctbi1kcm9wIEFQSQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMTM2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0 ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjpyZWFkKTogVXNlIG1fc2VsZWN0 aW9uRGF0YSBpZiBwcmVzZW50LgorCiAyMDIwLTA1LTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR1RLNCBidWls ZCB3aXRoIEdUSyAzLjk4LjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9QYXN0ZWJvYXJkR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJv YXJkR3RrLmNwcAppbmRleCAyNTM4MGQxMmZkNmMuLmNiNjJiMzU5MWNmNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkR3RrLmNwcApAQCAtMzA1LDYgKzMwNSwx MiBAQCB2b2lkIFBhc3RlYm9hcmQ6OnJlYWQoUGFzdGVib2FyZFdlYkNvbnRlbnRSZWFkZXImIHJl YWRlciwgV2ViQ29udGVudFJlYWRpbmdQb2xpYwogCiB2b2lkIFBhc3RlYm9hcmQ6OnJlYWQoUGFz dGVib2FyZEZpbGVSZWFkZXImIHJlYWRlcikKIHsKKyAgICBpZiAobV9zZWxlY3Rpb25EYXRhKSB7 CisgICAgICAgIGZvciAoY29uc3QgYXV0byYgZmlsZVBhdGggOiBtX3NlbGVjdGlvbkRhdGEtPmZp bGVuYW1lcygpKQorICAgICAgICAgICAgcmVhZGVyLnJlYWRGaWxlbmFtZShmaWxlUGF0aCk7Cisg ICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBhdXRvIGZpbGVQYXRocyA9IHBsYXRmb3JtU3Ry YXRlZ2llcygpLT5wYXN0ZWJvYXJkU3RyYXRlZ3koKS0+cmVhZEZpbGVQYXRoc0Zyb21DbGlwYm9h cmQobV9uYW1lKTsKICAgICBmb3IgKGNvbnN0IGF1dG8mIGZpbGVQYXRoIDogZmlsZVBhdGhzKQog ICAgICAgICByZWFkZXIucmVhZEZpbGVuYW1lKGZpbGVQYXRoKTsK