21211 2008-09-29 07:27:36 -0700 [CURL] Upload doesn't work because cancel is called 2008-10-15 13:55:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Major --- 1 marco.barisione marco.barisione louis oldest_to_newest 93223 0 marco.barisione 2008-09-29 07:27:36 -0700 When uploading a file with the curl backend cancel is always called at the end of the upload, so the file has been uploaded, the response has been received from the server but no result is shown. 93226 1 23907 marco.barisione 2008-09-29 07:42:06 -0700 Created attachment 23907 Don't call cancel if the upload was successful FormDataStream::read() returns 0 when retrieving data from the form fails, but also when there is no more data to send. This means that cancel is always called even when the data was successfully sent. 94350 2 webkit.amit.nargund 2008-10-07 02:51:25 -0700 This patch prevents cancellation of a request, but still does not successfully upload the file. Here is what I tried, open rapidshare.com and try uploading a file. I observed the HTTP traffic and noticed that POST packet is not seen, i.e. nothing is posted to the server! 94481 3 marco.barisione 2008-10-07 17:37:05 -0700 (In reply to comment #2) > This patch prevents cancellation of a request, but still does not successfully > upload the file. > Here is what I tried, > open rapidshare.com and try uploading a file. > I observed the HTTP traffic and noticed that POST packet is not seen, i.e. > nothing is posted to the server! Really? I tried it and upload was working even before. What doesn't work is showing the page you get after you upload a file. I suspect that your problem could be a separate issue, I will test it in the next days. 95152 4 webkit.amit.nargund 2008-10-13 00:13:02 -0700 I merged the latest code in my code and it is able POST the contents successfully now. The problem which you mentioned that next page is not displayed, when I included the patch that is provided for this bug with the latest code the code started working fine. So I think if you merge the patch for this bug in the latest code uploading will work fine! 95434 5 23907 zecke 2008-10-15 13:29:12 -0700 Comment on attachment 23907 Don't call cancel if the upload was successful Sounds reasonable. The only complain would be to always put the Vector on the stack. In the majority of code we have early exits. e.g if (!httpBody()) return false; return m_formDataElementIndex < m_resourceHandle()->request().httpBody()->elements().size(); but this is no hard requirement but something to keep in mind. 95441 6 zecke 2008-10-15 13:38:54 -0700 Okay this does not even compile because of the const, non-const mismatch. I will land a compiling version. 95444 7 zecke 2008-10-15 13:55:02 -0700 The patch was applied. Closing this bug. 23907 2008-09-29 07:42:06 -0700 2008-10-15 13:29:12 -0700 Don't call cancel if the upload was successful has-more-elements.patch text/plain 3105 marco.barisione SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcAkocmV2aXNpb25lIDM3MDYxKQorKysgV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkoY29waWEgbG9jYWxlKQpA QCAtMjM1LDYgKzIzNSw5IEBACiAgICAgaWYgKCFzaXplIHx8ICFubWVtYikKICAgICAgICAgcmV0 dXJuIDA7CiAKKyAgICBpZiAoIWQtPm1fZm9ybURhdGFTdHJlYW0uaGFzTW9yZUVsZW1lbnRzKCkp CisgICAgICAgIHJldHVybiAwOworCiAgICAgc2l6ZV90IHNlbnQgPSBkLT5tX2Zvcm1EYXRhU3Ry ZWFtLnJlYWQocHRyLCBzaXplLCBubWVtYik7CiAKICAgICAvLyBTb21ldGhpbmcgd2VudCB3cm9u ZyBzbyBjYW5jZWwgdGhlIGpvYi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L0Zvcm1EYXRhU3RyZWFtQ3VybC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvRm9ybURhdGFTdHJlYW1DdXJsLmNwcAkocmV2aXNpb25lIDM3MDYxKQorKysg V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvRm9ybURhdGFTdHJlYW1DdXJsLmNwcAkoY29w aWEgbG9jYWxlKQpAQCAtMyw2ICszLDcgQEAKICAqIENvcHlyaWdodCAoQykgMjAwNiBNaWNoYWVs IEVtbWVsIG1pa2UuZW1tZWxAZ21haWwuY29tCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcgQWxwIFRv a2VyIDxhbHAudG9rZXJAY29sbGFib3JhLmNvLnVrPgogICogQ29weXJpZ2h0IChDKSAyMDA3IEhv bGdlciBIYW5zIFBldGVyIEZyZXl0aGVyCisgKiBDb3B5cmlnaHQgKEMpIDIwMDggQ29sbGFib3Jh IEx0ZC4KICAqIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC0xMDAs NCArMTAxLDEzIEBACiAgICAgcmV0dXJuIHNlbnQ7CiB9CiAKK2Jvb2wgRm9ybURhdGFTdHJlYW06 Omhhc01vcmVFbGVtZW50cygpCit7CisgICAgVmVjdG9yPEZvcm1EYXRhRWxlbWVudD4gZWxlbWVu dHM7CisgICAgaWYgKG1fcmVzb3VyY2VIYW5kbGUtPnJlcXVlc3QoKS5odHRwQm9keSgpKQorICAg ICAgICBlbGVtZW50cyA9IG1fcmVzb3VyY2VIYW5kbGUtPnJlcXVlc3QoKS5odHRwQm9keSgpLT5l bGVtZW50cygpOworCisgICAgcmV0dXJuIG1fZm9ybURhdGFFbGVtZW50SW5kZXggPCBlbGVtZW50 cy5zaXplKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFdlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jdXJsL0Zvcm1EYXRhU3RyZWFtQ3VybC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Zvcm1EYXRhU3RyZWFtQ3VybC5oCShyZXZpc2lv bmUgMzcwNjEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9Gb3JtRGF0YVN0cmVh bUN1cmwuaAkoY29waWEgbG9jYWxlKQpAQCAtNDYsNiArNDYsNyBAQAogICAgIH5Gb3JtRGF0YVN0 cmVhbSgpOwogCiAgICAgc2l6ZV90IHJlYWQodm9pZCogcHRyLCBzaXplX3QgYmxvY2tTaXplLCBz aXplX3QgbnVtYmVyT2ZCbG9ja3MpOworICAgIGJvb2wgaGFzTW9yZUVsZW1lbnRzKCkgY29uc3Q7 CiAKIHByaXZhdGU6CiAgICAgLy8gV2UgY2FuIGhvbGQgYSB3ZWFrIHJlZmVyZW5jZSB0byBvdXIg UmVzb3VyY2VIYW5kbGUgYXMgaXQgaG9sZHMgYSBzdHJvbmcgcmVmZXJlbmNlCkluZGV4OiBXZWJD b3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb25l IDM3MDYxKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKGNvcGlhIGxvY2FsZSkKQEAgLTEsMyArMSwy NCBAQAorMjAwOC0wOS0yOSAgTWFyY28gQmFyaXNpb25lICA8bWFyY28uYmFyaXNpb25lQGNvbGxh Ym9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIxMQorICAgICAg ICBbQ1VSTF0gVXBsb2FkIGRvZXNuJ3Qgd29yayBiZWNhdXNlIGNhbmNlbCBpcyBjYWxsZWQKKwor ICAgICAgICBGb3JtRGF0YVN0cmVhbTo6cmVhZCByZXR1cm5zIDAgd2hlbiByZXRyaWV2aW5nIGRh dGEgZnJvbSB0aGUgZm9ybQorICAgICAgICBmYWlscywgYnV0IGFsc28gd2hlbiB0aGVyZSBpcyBu byBtb3JlIGRhdGEgdG8gc2VuZC4gVGhpcyBtZWFucyB0aGF0CisgICAgICAgIFJlc291cmNlSGFu ZGxlTWFuYWdlcjo6Y2FuY2VsIGlzIGFsd2F5cyBjYWxsZWQgZXZlbiB3aGVuIHRoZSBkYXRhIHdh cworICAgICAgICBzdWNjZXNzZnVsbHkgc2VudC4KKworICAgICAgICBDaGVjayBpZiB0aGVyZSBh cmUgbW9yZSBlbGVtZW50cyBpbiB0aGUgZm9ybSBiZWZvcmUgY2FsbGluZworICAgICAgICBGb3Jt RGF0YVN0cmVhbTo6cmVhZC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9Gb3Jt RGF0YVN0cmVhbUN1cmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9ybURhdGFTdHJlYW06Omhh c01vcmVFbGVtZW50cyk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0Zvcm1EYXRh U3RyZWFtQ3VybC5oOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhh bmRsZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVhZENhbGxiYWNrKToKKwogMjAw OC0wOS0yOSAgVGhpYWdvIE1hY2llaXJhICA8dGhpYWdvLm1hY2llaXJhQG5va2lhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTaW1vbi4K