212107 2020-05-19 13:56:06 -0700 WTF::LockedPrintStream should be final 2020-05-19 14:29:13 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1654171 0 aperez 2020-05-19 13:56:06 -0700 As Clang wisely advises: ../Source/WTF/wtf/LockedPrintStream.h:38:26: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~LockedPrintStream() final; ^ ../Source/WTF/wtf/LockedPrintStream.h:35:7: note: mark 'WTF::LockedPrintStream' as 'final' to silence this warning class LockedPrintStream : public PrintStream { ^ 1 warning generated. 1654173 1 399767 aperez 2020-05-19 13:57:29 -0700 Created attachment 399767 Patch 1654174 2 399767 darin 2020-05-19 14:00:10 -0700 Comment on attachment 399767 Patch OK, why not. 1654183 3 ews-feeder 2020-05-19 14:28:25 -0700 Committed r261886: <https://trac.webkit.org/changeset/261886> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399767. 1654184 4 webkit-bug-importer 2020-05-19 14:29:13 -0700 <rdar://problem/63414754> 399767 2020-05-19 13:57:29 -0700 2020-05-19 14:28:25 -0700 Patch bug-212107-20200519235728.patch text/plain 1193 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZhODhkYWM1MTY1NjlhYjVjNzdhZjZj YzVlNmNlMmNmZTFlZjBmZmEuLjUxNmRhM2UwODUwNTQxNDYyZjA3MDc5MWZmYjkyYzYyMTRkNDNi NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDUtMTkgIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBXVEY6OkxvY2tlZFByaW50U3RyZWFt IHNob3VsZCBiZSBmaW5hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjEyMTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3dGYvTG9ja2VkUHJpbnRTdHJlYW0uaDogTWFrZSBjbGFzcyBXVEY6OkxvY2tl ZFByaW50U3RyZWFtIGZpbmFsLgorCiAyMDIwLTA1LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBQdXQgUHRyVGFnTG9va3VwIGRhdGEgc3RydWN0dXJlcyBpbiBD b25maWdzIGZvciBmcmVlemluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0xvY2tlZFBy aW50U3RyZWFtLmggYi9Tb3VyY2UvV1RGL3d0Zi9Mb2NrZWRQcmludFN0cmVhbS5oCmluZGV4IGU0 ZmFkYjg1ZGJiM2ZkYWRjODY4MmQ4ZTI1NGM2MmJmNGNmZWI1NWMuLjIzYTc5ZjJlNjgyYWEwZTU4 NGI2MGJmMzczZTI1MTYwNDRkZmNkMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0xvY2tl ZFByaW50U3RyZWFtLmgKKysrIGIvU291cmNlL1dURi93dGYvTG9ja2VkUHJpbnRTdHJlYW0uaApA QCAtMzIsNyArMzIsNyBAQAogbmFtZXNwYWNlIFdURiB7CiAKIC8vIE1ha2VzIGV2ZXJ5IGNhbGwg dG8gcHJpbnQoKSBhdG9taWMuCi1jbGFzcyBMb2NrZWRQcmludFN0cmVhbSA6IHB1YmxpYyBQcmlu dFN0cmVhbSB7CitjbGFzcyBMb2NrZWRQcmludFN0cmVhbSBmaW5hbCA6IHB1YmxpYyBQcmludFN0 cmVhbSB7CiBwdWJsaWM6CiAgICAgTG9ja2VkUHJpbnRTdHJlYW0oc3RkOjp1bmlxdWVfcHRyPFBy aW50U3RyZWFtPiB0YXJnZXQpOwogICAgIH5Mb2NrZWRQcmludFN0cmVhbSgpIGZpbmFsOwo=