212095 2020-05-19 11:26:00 -0700 Make union initializers for JSC::PropertySlot more explicit about which field is being initialized 2020-05-19 12:19:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified NEW https://en.cppreference.com/w/cpp/language/aggregate_initialization P2 Normal --- 211267 1 ddkilzer ddkilzer aakash_jain bfulgham darin ews-watchlist keith_miller mark.lam msaboff pvollan saam stephan.szabo tzagallo oldest_to_newest 1654092 0 ddkilzer 2020-05-19 11:26:00 -0700 Make union initializers for JSC::PropertySlot more explicit on which field is being initialized. This is a follow-up to Bug 211267: REGRESSION (r154253): JSC::PropertySlot::m_attributes is uninitialized in constructor. See Bug 211267 Comment #7: <https://bugs.webkit.org/show_bug.cgi?id=211267#c7> 1654095 1 399754 ddkilzer 2020-05-19 11:29:57 -0700 Created attachment 399754 Patch v1 1654098 2 399754 mark.lam 2020-05-19 11:33:18 -0700 Comment on attachment 399754 Patch v1 Neat, but the Windows bots don't seem to like this change. 1654115 3 ddkilzer 2020-05-19 11:57:37 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 399754 [details] > Patch v1 > > Neat, but the Windows bots don't seem to like this change. Ha! C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\runtime\PropertySlot.h(389): error C7555: use of designated initializers requires at least '/std:c++latest' C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\runtime\PropertySlot.h(404): error C7555: use of designated initializers requires at least '/std:c++latest' I guess we can hold off on this until the Windows bots add the '/std:c++latest' switch in the future. 399754 2020-05-19 11:29:57 -0700 2020-05-19 11:57:43 -0700 Patch v1 bug-212095-20200519113043.patch text/plain 1946 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NTJiYTAwYWM2Y2QzZWY5ZTljMjRmMGE3YTFjMDNjMGQ4Yjg4NDBmLi44MDdiNWQzMzQ1M2VmNDE2 NmY4YWRiMzM1ODhiYTU5ZDI0NTRlODQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wNS0xOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIE1ha2UgdW5pb24gaW5pdGlhbGl6ZXJzIGZvciBKU0M6OlByb3BlcnR5U2xv dCBtb3JlIGV4cGxpY2l0IGFib3V0IHdoaWNoIGZpZWxkIGlzIGJlaW5nIGluaXRpYWxpemVkCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMTIwOTU+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL1Byb3BlcnR5U2xvdC5oOgor ICAgICAgICAoSlNDOjpQcm9wZXJ0eVNsb3Q6OlByb3BlcnR5U2xvdCk6CisgICAgICAgIC0gQWRk IGRlZmF1bHQgaW5pdGlhbGl6ZXJzIGZvciBtX2RhdGEgYW5kIG1fYWRkaXRpb25hbERhdGEgdXNp bmcKKyAgICAgICAgICBhZ2dyZWdhdGUgaW5pdGlhbGl6YXRpb24gc3ludGF4IHdpdGggZXhwbGlj aXQgZmllbGQgbmFtZXMuCisKIDIwMjAtMDUtMTkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIFsgTWFjIHdrMSBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2Jhc2ljL3N0cmVhbS1zYWZlLWNyZWF0aW9uLmFueS5odG1s ICBpcyBmbGFreSBjcmFzaGluZyB3aXRoIGFsZXJ0cyAtIFdURkNyYXNoV2l0aEluZm8gLSBTQzo6 SlNPYmplY3Q6OmdldChKU0M6OkpTR2xvYmFsT2JqZWN0KiwgSlNDOjpQcm9wZXJ0eU5hbWUpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eVNsb3QuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Byb3BlcnR5U2xvdC5oCmluZGV4IDhkOWUx MzIyOTE1NmEzZTBjZDY1NzdhMzg0YTE2OTJiYzcxNTNmMWQuLmFiMWU2ZjYzOWIzNjJhMjZjZDVi ZmUyNjFjZGUzYmQxZWQ3ZjBhZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1Byb3BlcnR5U2xvdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1Byb3BlcnR5U2xvdC5oCkBAIC0zODYsNyArMzg2LDcgQEAgcHJpdmF0ZToKICAgICAgICAgc3Ry dWN0IHsKICAgICAgICAgICAgIEN1c3RvbUdldHRlclNldHRlciogZ2V0dGVyU2V0dGVyOwogICAg ICAgICB9IGN1c3RvbUFjY2Vzc29yOwotICAgIH0gbV9kYXRhOworICAgIH0gbV9kYXRhIHsgLnZh bHVlID0gMCB9OwogCiAgICAgdW5zaWduZWQgbV9hdHRyaWJ1dGVzIHsgMCB9OwogICAgIFByb3Bl cnR5T2Zmc2V0IG1fb2Zmc2V0IHsgaW52YWxpZE9mZnNldCB9OwpAQCAtNDAxLDcgKzQwMSw3IEBA IHByaXZhdGU6CiAgICAgdW5pb24gewogICAgICAgICBET01BdHRyaWJ1dGVBbm5vdGF0aW9uIGRv bUF0dHJpYnV0ZTsKICAgICAgICAgTW9kdWxlTmFtZXNwYWNlU2xvdCBtb2R1bGVOYW1lc3BhY2VT bG90OwotICAgIH0gbV9hZGRpdGlvbmFsRGF0YSB7IHsgbnVsbHB0ciwgbnVsbHB0ciB9IH07Cisg ICAgfSBtX2FkZGl0aW9uYWxEYXRhIHsgLmRvbUF0dHJpYnV0ZSA9IHsgbnVsbHB0ciwgbnVsbHB0 ciB9IH07CiB9OwogCiBBTFdBWVNfSU5MSU5FIEpTVmFsdWUgUHJvcGVydHlTbG90OjpnZXRWYWx1 ZShKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1l KSBjb25zdAo=