212090 2020-05-19 10:24:49 -0700 SQLite database fails to close in SQLiteIDBBackingStore::databaseNameFromFile 2020-05-21 11:04:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu alecflett beidson darin ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1654057 0 sihui_liu 2020-05-19 10:24:49 -0700 ... 1654059 1 399747 sihui_liu 2020-05-19 10:27:38 -0700 Created attachment 399747 Patch 1654262 2 399747 darin 2020-05-19 17:46:50 -0700 Comment on attachment 399747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399747&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:924 > database.close(); I suggest removing this line of code also. > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:-929 > - database.close(); I don’t think you need to do the rest of this change. Just removing this line of code alone should fix the bug, without the restructuring. 1654983 3 399965 sihui_liu 2020-05-21 10:32:23 -0700 Created attachment 399965 Patch for landing 1655002 4 ews-feeder 2020-05-21 11:03:02 -0700 Committed r262015: <https://trac.webkit.org/changeset/262015> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399965. 1655004 5 webkit-bug-importer 2020-05-21 11:04:14 -0700 <rdar://problem/63501180> 399747 2020-05-19 10:27:38 -0700 2020-05-21 10:32:21 -0700 Patch bug-212090-20200519102737.patch text/plain 1759 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDAwOTdlNjU1ZTM0Mzc5 MDAxMjllODk0MDZjNzgzNzE1MmEwYzVlZS4uNjE5YmQzOWI1ODVjOWQzNTM3ODc0ODYwY2MzNzI1 MmYwNzUyMDQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTE5ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFNRTGl0ZSBkYXRhYmFzZSBm YWlscyB0byBjbG9zZSBpbiBTUUxpdGVJREJCYWNraW5nU3RvcmU6OmRhdGFiYXNlTmFtZUZyb21G aWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIw OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBz aG91bGQgZmluaXNoIFNRTGl0ZSBzdGF0ZW1lbnQgYmVmb3JlIGNsb3NpbmcgZGF0YWJhc2UuCisK KyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3Jl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNlcnZlcjo6U1FMaXRlSURCQmFja2luZ1N0b3Jl OjpkYXRhYmFzZU5hbWVGcm9tRmlsZSk6CisKIDIwMjAtMDUtMTkgIEFuZHkgRXN0ZXMgIDxhZXN0 ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtBcHBsZSBQYXldIEFkZCB0ZXN0aW5nIGFuZCBsb2dn aW5nIGZvciBBcHBsZVBheVNldHVwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwCmlu ZGV4IDlmOTU5MTU5MzE5YTkyM2I0OWUyYzAxNzJkMmQ3OTkyNTM2ZTFiZDAuLjI5NTFiYjVmNjE5 ODNiZmRmMTExZTI0NTYzZTZhNzA1NzlkOWNjMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5n U3RvcmUuY3BwCkBAIC05MjQsOSArOTI0LDEzIEBAIFN0cmluZyBTUUxpdGVJREJCYWNraW5nU3Rv cmU6OmRhdGFiYXNlTmFtZUZyb21GaWxlKGNvbnN0IFN0cmluZyYgZGF0YWJhc2VQYXRoKQogICAg ICAgICBkYXRhYmFzZS5jbG9zZSgpOwogICAgICAgICByZXR1cm4geyB9OwogICAgIH0KLSAgICBT UUxpdGVTdGF0ZW1lbnQgc3FsKGRhdGFiYXNlLCAiU0VMRUNUIHZhbHVlIEZST00gSURCRGF0YWJh c2VJbmZvIFdIRVJFIGtleSA9ICdEYXRhYmFzZU5hbWUnOyIpOwotICAgIGF1dG8gZGF0YWJhc2VO YW1lID0gc3FsLmdldENvbHVtblRleHQoMCk7Ci0gICAgZGF0YWJhc2UuY2xvc2UoKTsKKworICAg IFN0cmluZyBkYXRhYmFzZU5hbWU7CisgICAgeworICAgICAgICBTUUxpdGVTdGF0ZW1lbnQgc3Fs KGRhdGFiYXNlLCAiU0VMRUNUIHZhbHVlIEZST00gSURCRGF0YWJhc2VJbmZvIFdIRVJFIGtleSA9 ICdEYXRhYmFzZU5hbWUnOyIpOworICAgICAgICBkYXRhYmFzZU5hbWUgPSBzcWwuZ2V0Q29sdW1u VGV4dCgwKTsKKyAgICB9CisKICAgICByZXR1cm4gZGF0YWJhc2VOYW1lOwogfQogCg== 399965 2020-05-21 10:32:23 -0700 2020-05-21 11:03:03 -0700 Patch for landing bug-212090-20200521103222.patch text/plain 1870 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkwYjJjMTY5MDhiZDRj ZGZjN2ZhOTU0ZTNlYmY4ZmVhNDkxZWY1OS4uYjdmODViNTA3ZjUxMTJlYmY5NDZiNTI3YTdjOWUy YTc4NTJmZTI3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTIxICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFNRTGl0ZSBkYXRhYmFzZSBm YWlscyB0byBjbG9zZSBpbiBTUUxpdGVJREJCYWNraW5nU3RvcmU6OmRhdGFiYXNlTmFtZUZyb21G aWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIw OTAKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBXZSBzaG91 bGQgZmluaXNoIFNRTGl0ZSBzdGF0ZW1lbnQgYmVmb3JlIGNsb3NpbmcgZGF0YWJhc2UuCisKKyAg ICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNlcnZlcjo6U1FMaXRlSURCQmFja2luZ1N0b3JlOjpk YXRhYmFzZU5hbWVGcm9tRmlsZSk6CisKIDIwMjAtMDUtMjAgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIDxpbWc+IHRhZyBuZWVk cyB0byBzdXBwb3J0IHZpZGVvIGZvcm1hdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5j cHAKaW5kZXggOWY5NTkxNTkzMTlhOTIzYjQ5ZTJjMDE3MmQyZDc5OTI1MzZlMWJkMC4uZWFhZDdl OTBiZWRmNmVkZGI0ZTllMWQ1ZmI3MDA2OGZhMTRmZTM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJh Y2tpbmdTdG9yZS5jcHAKQEAgLTkyMSwxMyArOTIxLDEwIEBAIFN0cmluZyBTUUxpdGVJREJCYWNr aW5nU3RvcmU6OmRhdGFiYXNlTmFtZUZyb21GaWxlKGNvbnN0IFN0cmluZyYgZGF0YWJhc2VQYXRo KQogICAgIH0KICAgICBpZiAoIWRhdGFiYXNlLnRhYmxlRXhpc3RzKCJJREJEYXRhYmFzZUluZm8i X3MpKSB7CiAgICAgICAgIExPR19FUlJPUigiQ291bGQgbm90IGZpbmQgSURCRGF0YWJhc2VJbmZv IHRhYmxlIGFuZCBnZXQgZGF0YWJhc2UgbmFtZSglaSkgLSAlcyIsIGRhdGFiYXNlLmxhc3RFcnJv cigpLCBkYXRhYmFzZS5sYXN0RXJyb3JNc2coKSk7Ci0gICAgICAgIGRhdGFiYXNlLmNsb3NlKCk7 CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfQogICAgIFNRTGl0ZVN0YXRlbWVudCBzcWwoZGF0 YWJhc2UsICJTRUxFQ1QgdmFsdWUgRlJPTSBJREJEYXRhYmFzZUluZm8gV0hFUkUga2V5ID0gJ0Rh dGFiYXNlTmFtZSc7Iik7Ci0gICAgYXV0byBkYXRhYmFzZU5hbWUgPSBzcWwuZ2V0Q29sdW1uVGV4 dCgwKTsKLSAgICBkYXRhYmFzZS5jbG9zZSgpOwotICAgIHJldHVybiBkYXRhYmFzZU5hbWU7Cisg ICAgcmV0dXJuIHNxbC5nZXRDb2x1bW5UZXh0KDApOwogfQogCiBTdHJpbmcgU1FMaXRlSURCQmFj a2luZ1N0b3JlOjpmdWxsRGF0YWJhc2VEaXJlY3RvcnlXaXRoVXBncmFkZSgpCg==