212089 2020-05-19 10:21:43 -0700 Put PtrTagLookup data structures in Configs for freezing. 2020-05-19 11:49:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1654054 0 mark.lam 2020-05-19 10:21:43 -0700 PtrTagLookup data structures were always meant to be only initialized once at initialization time and never modified thereafter. Will put them in the Configs for freezing to document and enforce this invariant. 1654055 1 webkit-bug-importer 2020-05-19 10:22:15 -0700 <rdar://problem/63401487> 1654060 2 399748 mark.lam 2020-05-19 10:30:41 -0700 Created attachment 399748 proposed patch. 1654081 3 399748 rmorisset 2020-05-19 11:16:05 -0700 Comment on attachment 399748 proposed patch. r=me 1654094 4 399748 mark.lam 2020-05-19 11:29:34 -0700 Comment on attachment 399748 proposed patch. Thanks for the review. Landing now. 1654112 5 ews-feeder 2020-05-19 11:49:10 -0700 Committed r261877: <https://trac.webkit.org/changeset/261877> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399748. 399748 2020-05-19 10:30:41 -0700 2020-05-19 11:49:11 -0700 proposed patch. bug-212089.patch text/plain 6786 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYxODY4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDIwLTA1LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBQ dXQgUHRyVGFnTG9va3VwIGRhdGEgc3RydWN0dXJlcyBpbiBDb25maWdzIGZvciBmcmVlemluZy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjA4OQor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjM0MDE0ODc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHRyVGFnTG9va3VwIGRhdGEgc3RydWN0dXJlcyB3 ZXJlIGFsd2F5cyBtZWFudCB0byBvbmx5IGJlIGluaXRpYWxpemVkIG9uY2UgYXQKKyAgICAgICAg aW5pdGlhbGl6YXRpb24gdGltZSBhbmQgbmV2ZXIgbW9kaWZpZWQgdGhlcmVhZnRlci4gIFRoaXMg cGF0Y2ggcHV0cyB0aGVtIGluIHRoZQorICAgICAgICBDb25maWdzIGZvciBmcmVlemluZyB0byBk b2N1bWVudCBhbmQgZW5mb3JjZSB0aGlzIGludmFyaWFudC4KKworICAgICAgICAqIHJ1bnRpbWUv SlNDQ29uZmlnLmg6CisgICAgICAgICogcnVudGltZS9KU0NQdHJUYWcuY3BwOgorICAgICAgICAo SlNDOjppbml0aWFsaXplUHRyVGFnTG9va3VwKToKKwogMjAyMC0wNS0xOSAgWW91ZW5uIEZhYmxl dCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgWyBNYWMgd2sxIERlYnVnIF0gaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvYmFzaWMvc3RyZWFtLXNhZmUtY3Jl YXRpb24uYW55Lmh0bWwgIGlzIGZsYWt5IGNyYXNoaW5nIHdpdGggYWxlcnRzIC0gV1RGQ3Jhc2hX aXRoSW5mbyAtIFNDOjpKU09iamVjdDo6Z2V0KEpTQzo6SlNHbG9iYWxPYmplY3QqLCBKU0M6OlBy b3BlcnR5TmFtZSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0NvbmZp Zy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0NvbmZp Zy5oCShyZXZpc2lvbiAyNjE4MzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0NDb25maWcuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmln aHQgKEMpIDIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0 IChDKSAyMDE5LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0yNyw2ICsyNyw3IEBACiAKICNpbmNsdWRlICJPcHRp b25zTGlzdC5oIgogI2luY2x1ZGUgPHd0Zi9QYWdlQmxvY2suaD4KKyNpbmNsdWRlIDx3dGYvUHRy VGFnLmg+CiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgogCiBuYW1lc3BhY2UgSlNDIHsK QEAgLTgwLDYgKzgxLDggQEAgc3RydWN0IENvbmZpZyB7CiAgICAgICAgICAgICBPcHRpb25zU3Rv cmFnZSBvcHRpb25zOwogCiAgICAgICAgICAgICB2b2lkICgqc2hlbGxUaW1lb3V0Q2hlY2tDYWxs YmFjaykoVk0mKTsKKworICAgICAgICAgICAgV1RGOjpQdHJUYWdMb29rdXAgcHRyVGFnTG9va3Vw UmVjb3JkOwogICAgICAgICB9OwogICAgICAgICBjaGFyIGVuc3VyZVNpemVbQ29uZmlnU2l6ZVRv UHJvdGVjdF07CiAgICAgfTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT Q1B0clRhZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNDUHRyVGFnLmNwcAkocmV2aXNpb24gMjYxODMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNDUHRyVGFnLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8q Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMTgtMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTgtMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI2LDYgKzI2LDggQEAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJKU0NQdHJUYWcuaCIKIAorI2luY2x1ZGUg IkpTQ0NvbmZpZy5oIgorCiBuYW1lc3BhY2UgSlNDIHsKIAogI2lmIENQVShBUk02NEUpCkBAIC01 Miw3ICs1NCw4IEBAIHN0YXRpYyBjb25zdCBjaGFyKiBwdHJUYWdOYW1lKFB0clRhZyB0YWcKIAog dm9pZCBpbml0aWFsaXplUHRyVGFnTG9va3VwKCkKIHsKLSAgICBzdGF0aWMgV1RGOjpQdHJUYWdM b29rdXAgbG9va3VwID0geyB0YWdGb3JQdHIsIHB0clRhZ05hbWUgfTsKKyAgICBXVEY6OlB0clRh Z0xvb2t1cCYgbG9va3VwID0gZ19qc2NDb25maWcucHRyVGFnTG9va3VwUmVjb3JkOworICAgIGxv b2t1cC5pbml0aWFsaXplKHRhZ0ZvclB0ciwgcHRyVGFnTmFtZSk7CiAgICAgV1RGOjpyZWdpc3Rl clB0clRhZ0xvb2t1cCgmbG9va3VwKTsKIH0KIApJbmRleDogU291cmNlL1dURi9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MTg2NykKKysr IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIw MjAtMDUtMTkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIFB1dCBQ dHJUYWdMb29rdXAgZGF0YSBzdHJ1Y3R1cmVzIGluIENvbmZpZ3MgZm9yIGZyZWV6aW5nLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMDg5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82MzQwMTQ4Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QdHJUYWcuY3BwOgorICAgICAgICAoV1RGOjp0 YWdGb3JQdHIpOgorICAgICAgICAoV1RGOjpwdHJUYWdOYW1lKToKKyAgICAgICAgKFdURjo6cmVn aXN0ZXJQdHJUYWdMb29rdXApOgorICAgICAgICAqIHd0Zi9QdHJUYWcuaDoKKyAgICAgICAgKFdU Rjo6UHRyVGFnTG9va3VwOjppbml0aWFsaXplKToKKyAgICAgICAgKiB3dGYvV1RGQ29uZmlnLmg6 CisKIDIwMjAtMDUtMTggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg IGh0dHAvdGVzdHMvc3NsL2FwcGxlcGF5L0FwcGxlUGF5SW5zdGFsbG1lbnRDb25maWd1cmF0aW9u Lmh0dHBzLmh0bWwgZmFpbHMgaW4gcHVibGljIFNESyBidWlsZHMKSW5kZXg6IFNvdXJjZS9XVEYv d3RmL1B0clRhZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUHRyVGFnLmNwcAko cmV2aXNpb24gMjYxODMwKQorKysgU291cmNlL1dURi93dGYvUHRyVGFnLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTgtMjAxOSBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTgtMjAyMCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKQEAgLTI2LDE1ICsyNiwxNSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg PHd0Zi9QdHJUYWcuaD4KIAorI2luY2x1ZGUgPHd0Zi9XVEZDb25maWcuaD4KKwogbmFtZXNwYWNl IFdURiB7CiAKICNpZiBDUFUoQVJNNjRFKQogCi1zdGF0aWMgUHRyVGFnTG9va3VwKiBzX3B0clRh Z0xvb2t1cCA9IG51bGxwdHI7Ci0KIHN0YXRpYyBjb25zdCBjaGFyKiB0YWdGb3JQdHIoY29uc3Qg dm9pZCogcHRyKQogewotICAgIFB0clRhZ0xvb2t1cCogbG9va3VwID0gc19wdHJUYWdMb29rdXA7 CisgICAgUHRyVGFnTG9va3VwKiBsb29rdXAgPSBnX3d0ZkNvbmZpZy5wdHJUYWdMb29rdXBIZWFk OwogICAgIHdoaWxlIChsb29rdXApIHsKICAgICAgICAgY29uc3QgY2hhciogdGFnTmFtZSA9IGxv b2t1cC0+dGFnRm9yUHRyKHB0cik7CiAgICAgICAgIGlmICh0YWdOYW1lKQpAQCAtNTYsNyArNTYs NyBAQCBzdGF0aWMgY29uc3QgY2hhciogdGFnRm9yUHRyKGNvbnN0IHZvaWQqCiAKIHN0YXRpYyBj b25zdCBjaGFyKiBwdHJUYWdOYW1lKFB0clRhZyB0YWcpCiB7Ci0gICAgUHRyVGFnTG9va3VwKiBs b29rdXAgPSBzX3B0clRhZ0xvb2t1cDsKKyAgICBQdHJUYWdMb29rdXAqIGxvb2t1cCA9IGdfd3Rm Q29uZmlnLnB0clRhZ0xvb2t1cEhlYWQ7CiAgICAgd2hpbGUgKGxvb2t1cCkgewogICAgICAgICBj b25zdCBjaGFyKiB0YWdOYW1lID0gbG9va3VwLT5wdHJUYWdOYW1lKHRhZyk7CiAgICAgICAgIGlm ICh0YWdOYW1lKQpAQCAtNzQsOCArNzQsOCBAQCBzdGF0aWMgY29uc3QgY2hhciogcHRyVGFnTmFt ZShQdHJUYWcgdGFnCiAKIHZvaWQgcmVnaXN0ZXJQdHJUYWdMb29rdXAoUHRyVGFnTG9va3VwKiBs b29rdXApCiB7Ci0gICAgbG9va3VwLT5uZXh0ID0gc19wdHJUYWdMb29rdXA7Ci0gICAgc19wdHJU YWdMb29rdXAgPSBsb29rdXA7CisgICAgbG9va3VwLT5uZXh0ID0gZ193dGZDb25maWcucHRyVGFn TG9va3VwSGVhZDsKKyAgICBnX3d0ZkNvbmZpZy5wdHJUYWdMb29rdXBIZWFkID0gbG9va3VwOwog fQogCiB2b2lkIHJlcG9ydEJhZFRhZyhjb25zdCB2b2lkKiBwdHIsIFB0clRhZyBleHBlY3RlZFRh ZykKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1B0clRhZy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvd3RmL1B0clRhZy5oCShyZXZpc2lvbiAyNjE4MzApCisrKyBTb3VyY2UvV1RGL3d0Zi9QdHJU YWcuaAkod29ya2luZyBjb3B5KQpAQCAtODUsOSArODUsMTggQEAgRk9SX0VBQ0hfQURESVRJT05B TF9XVEZfUFRSVEFHKFdURl9ERUNMQQogI2VuZGlmCiAKIHN0cnVjdCBQdHJUYWdMb29rdXAgewot ICAgIGNvbnN0IGNoYXIqICgqdGFnRm9yUHRyKShjb25zdCB2b2lkKik7Ci0gICAgY29uc3QgY2hh ciogKCpwdHJUYWdOYW1lKShQdHJUYWcpOwotICAgIFB0clRhZ0xvb2t1cCogbmV4dCB7IG51bGxw dHIgfTsKKyAgICB1c2luZyBUYWdGb3JQdHJGdW5jID0gY29uc3QgY2hhciogKCopKGNvbnN0IHZv aWQqKTsKKyAgICB1c2luZyBQdHJUYWdOYW1lRnVuYyA9IGNvbnN0IGNoYXIqICgqKShQdHJUYWcp OworCisgICAgdm9pZCBpbml0aWFsaXplKFRhZ0ZvclB0ckZ1bmMgdGFnRm9yUHRyLCBQdHJUYWdO YW1lRnVuYyBwdHJUYWdOYW1lKQorICAgIHsKKyAgICAgICAgdGhpcy0+dGFnRm9yUHRyID0gdGFn Rm9yUHRyOworICAgICAgICB0aGlzLT5wdHJUYWdOYW1lID0gcHRyVGFnTmFtZTsKKyAgICB9CisK KyAgICBUYWdGb3JQdHJGdW5jIHRhZ0ZvclB0cjsKKyAgICBQdHJUYWdOYW1lRnVuYyBwdHJUYWdO YW1lOworICAgIFB0clRhZ0xvb2t1cCogbmV4dDsKIH07CiAKICNpZiBDUFUoQVJNNjRFKQpJbmRl eDogU291cmNlL1dURi93dGYvV1RGQ29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93 dGYvV1RGQ29uZmlnLmgJKHJldmlzaW9uIDI2MTgzMCkKKysrIFNvdXJjZS9XVEYvd3RmL1dURkNv bmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSA8d3RmL0F0 b21pY3MuaD4KICNpbmNsdWRlIDx3dGYvRXhwb3J0TWFjcm9zLmg+CiAjaW5jbHVkZSA8d3RmL1Bh Z2VCbG9jay5oPgorI2luY2x1ZGUgPHd0Zi9QdHJUYWcuaD4KICNpbmNsdWRlIDx3dGYvU3RkTGli RXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL3RocmVhZHMvU2lnbmFscy5oPgogCkBAIC01NSw2ICs1 Niw3IEBAIHN0cnVjdCBDb25maWcgewogI2lmIFVTRShQVEhSRUFEUykgJiYgSEFWRShNQUNISU5F X0NPTlRFWFQpCiAgICAgICAgICAgICBTaWduYWxIYW5kbGVycyBzaWduYWxIYW5kbGVyczsKICNl bmRpZgorICAgICAgICAgICAgUHRyVGFnTG9va3VwKiBwdHJUYWdMb29rdXBIZWFkOwogICAgICAg ICB9OwogICAgICAgICBjaGFyIGVuc3VyZVNpemVbQ29uZmlnU2l6ZVRvUHJvdGVjdF07CiAgICAg fTsK