212084 2020-05-19 09:35:59 -0700 Remove unnecessary debug logging from release builds. 2020-05-19 10:57:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo darin ews-watchlist saam webkit-bug-importer oldest_to_newest 1654031 0 mark.lam 2020-05-19 09:35:59 -0700 ... 1654032 1 webkit-bug-importer 2020-05-19 09:36:24 -0700 <rdar://problem/63398704> 1654037 2 399743 mark.lam 2020-05-19 09:51:12 -0700 Created attachment 399743 proposed patch. 1654068 3 ews-feeder 2020-05-19 10:53:56 -0700 Committed r261870: <https://trac.webkit.org/changeset/261870> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399743. 1654071 4 399743 darin 2020-05-19 10:57:03 -0700 Comment on attachment 399743 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=399743&action=review > Source/WTF/wtf/PtrTag.h:115 > #if ASSERT_ENABLED > constexpr bool enablePtrTagDebugAssert = true; > +#define REPORT_BAD_TAG(success, ptr, expectedTag) do { \ > + if (UNLIKELY(!success)) \ > + reportBadTag(reinterpret_cast<const void*>(ptr), expectedTag); \ > + } while (false) > #else > constexpr bool enablePtrTagDebugAssert = false; > +#define REPORT_BAD_TAG(success, ptr, expectedTag) > #endif I like this, but I would like to point out that in this case, this could have been an inline function rather than a macro; an empty inline function would neatly compile down to nothing. 399743 2020-05-19 09:51:12 -0700 2020-05-19 10:53:57 -0700 proposed patch. bug-212084.patch text/plain 1839 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjE4NjcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA1LTE5ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgZGVidWcgbG9nZ2luZyBm cm9tIHJlbGVhc2UgYnVpbGRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjEyMDg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MzM5ODcwND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QdHJU YWcuaDoKKwogMjAyMC0wNS0xOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAg ICAgICAgaHR0cC90ZXN0cy9zc2wvYXBwbGVwYXkvQXBwbGVQYXlJbnN0YWxsbWVudENvbmZpZ3Vy YXRpb24uaHR0cHMuaHRtbCBmYWlscyBpbiBwdWJsaWMgU0RLIGJ1aWxkcwpJbmRleDogU291cmNl L1dURi93dGYvUHRyVGFnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUHRyVGFnLmgJ KHJldmlzaW9uIDI2MTgzMCkKKysrIFNvdXJjZS9XVEYvd3RmL1B0clRhZy5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMDUsOCArMTA1LDEzIEBAIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHJlcG9ydEJh ZFRhZyhjb24KIAogI2lmIEFTU0VSVF9FTkFCTEVECiBjb25zdGV4cHIgYm9vbCBlbmFibGVQdHJU YWdEZWJ1Z0Fzc2VydCA9IHRydWU7CisjZGVmaW5lIFJFUE9SVF9CQURfVEFHKHN1Y2Nlc3MsIHB0 ciwgZXhwZWN0ZWRUYWcpIGRvIHsgXAorICAgICAgICBpZiAoVU5MSUtFTFkoIXN1Y2Nlc3MpKSBc CisgICAgICAgICAgICByZXBvcnRCYWRUYWcocmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lkKj4o cHRyKSwgZXhwZWN0ZWRUYWcpOyBcCisgICAgfSB3aGlsZSAoZmFsc2UpCiAjZWxzZQogY29uc3Rl eHByIGJvb2wgZW5hYmxlUHRyVGFnRGVidWdBc3NlcnQgPSBmYWxzZTsKKyNkZWZpbmUgUkVQT1JU X0JBRF9UQUcoc3VjY2VzcywgcHRyLCBleHBlY3RlZFRhZykKICNlbmRpZgogCiAjZGVmaW5lIFdU Rl9QVFJUQUdfQVNTRVJUKGFjdGlvbiwgcHRyLCBleHBlY3RlZFRhZywgYXNzZXJ0aW9uKSBcCkBA IC0xMTQsOSArMTE5LDcgQEAgY29uc3RleHByIGJvb2wgZW5hYmxlUHRyVGFnRGVidWdBc3NlcnQg PQogICAgICAgICBpZiAoYWN0aW9uID09IFB0clRhZ0FjdGlvbjo6UmVsZWFzZUFzc2VydCBcCiAg ICAgICAgICAgICB8fCAoV1RGOjplbmFibGVQdHJUYWdEZWJ1Z0Fzc2VydCAmJiBhY3Rpb24gPT0g UHRyVGFnQWN0aW9uOjpEZWJ1Z0Fzc2VydCkpIHsgXAogICAgICAgICAgICAgYm9vbCBwYXNzZWQg PSAoYXNzZXJ0aW9uKTsgXAotICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFwYXNzZWQpKSB7IFwK LSAgICAgICAgICAgICAgICByZXBvcnRCYWRUYWcocmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lk Kj4ocHRyKSwgZXhwZWN0ZWRUYWcpOyBcCi0gICAgICAgICAgICB9IFwKKyAgICAgICAgICAgIFJF UE9SVF9CQURfVEFHKHBhc3NlZCwgcHRyLCBleHBlY3RlZFRhZyk7IFwKICAgICAgICAgICAgIFJF TEVBU0VfQVNTRVJUKHBhc3NlZCAmJiAjYXNzZXJ0aW9uKTsgXAogICAgICAgICB9IFwKICAgICB9 IHdoaWxlIChmYWxzZSkK