212071 2020-05-19 07:17:35 -0700 [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource 2020-05-20 06:31:15 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf benjamin cdumez cmarcelo eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1653984 0 youennf 2020-05-19 07:17:35 -0700 [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource 1653985 1 399732 youennf 2020-05-19 07:20:24 -0700 Created attachment 399732 Patch 1654039 2 399732 eric.carlson 2020-05-19 09:52:37 -0700 Comment on attachment 399732 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399732&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83 > - // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed. > -#if PLATFORM(MAC) > - return kCVPixelFormatType_420YpCbCr8Planar; > -#else > return preferedPixelBufferFormat(); > -#endif We should make this conditional on the build target since the fix is unlikely to be back ported. Maybe define something like HAVE_DISPLAY_LAYER_PLANAR_SUPPORT? 1654102 3 youennf 2020-05-19 11:37:45 -0700 (In reply to Eric Carlson from comment #2) > Comment on attachment 399732 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399732&action=review > > > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83 > > - // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed. > > -#if PLATFORM(MAC) > > - return kCVPixelFormatType_420YpCbCr8Planar; > > -#else > > return preferedPixelBufferFormat(); > > -#endif > > We should make this conditional on the build target since the fix is > unlikely to be back ported. Maybe define something like > HAVE_DISPLAY_LAYER_PLANAR_SUPPORT? Oh right, will do! 1654365 4 399823 youennf 2020-05-20 02:27:21 -0700 Created attachment 399823 Patch 1654403 5 ews-feeder 2020-05-20 06:30:48 -0700 Committed r261915: <https://trac.webkit.org/changeset/261915> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399823. 1654404 6 webkit-bug-importer 2020-05-20 06:31:15 -0700 <rdar://problem/63444589> 399732 2020-05-19 07:20:24 -0700 2020-05-20 02:27:17 -0700 Patch bug-212071-20200519162023.patch text/plain 1517 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZjN2ZiYjc2NTQ2ZGMw NTNiZDBkZDcyYmVmNmFjYWRlYmRkNTFhYy4uMjM3MmMzODBmNTNjOWQyYTBlNzdjOGM2MDM1MDBm ZjJjMzU1NmVkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTE5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBVc2UgcHJlZmVy ZWRQaXhlbEJ1ZmZlckZvcm1hdCBmb3IgQVZWaWRlb0NhcHR1cmVTb3VyY2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjA3MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnVhbGx5IHRlc3RlZC4KKwor ICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNvdXJjZS5t bToKKyAgICAgICAgKFdlYkNvcmU6OmF2VmlkZW9DYXB0dXJlUGl4ZWxCdWZmZXJGb3JtYXQpOgor CiAyMDIwLTA1LTE4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAg ICBBbGxvdyBjYWxsaW5nIFZpZGVvU2FtcGxlT2JzZXJ2ZXI6OnZpZGVvU2FtcGxlQXZhaWxhYmxl IGZyb20gYSBiYWNrZ3JvdW5kIHRocmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tCmlu ZGV4IGQ1OTUyMGU2ZTMzMGRhYmRlMGVlNzE2NGZjNzNlMzVlMjhiYjM3ZjguLjdjYTRmMDk4ZDcy ZTc5MWE5MjExMjBiYzU4YmY1MTg5Yzk5ZWI3M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNvdXJjZS5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3Vy Y2UubW0KQEAgLTc1LDEyICs3NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGlu bGluZSBPU1R5cGUgYXZWaWRlb0NhcHR1cmVQaXhlbEJ1ZmZlckZvcm1hdCgpCiB7Ci0gICAgLy8g RklYTUU6IFVzZSBwcmVmZXJlZFBpeGVsQnVmZmVyRm9ybWF0KCkgb25jZSByZGFyOi8vcHJvYmxl bS80NDM5MTQ0NCBpcyBmaXhlZC4KLSNpZiBQTEFURk9STShNQUMpCi0gICAgcmV0dXJuIGtDVlBp eGVsRm9ybWF0VHlwZV80MjBZcENiQ3I4UGxhbmFyOwotI2Vsc2UKICAgICByZXR1cm4gcHJlZmVy ZWRQaXhlbEJ1ZmZlckZvcm1hdCgpOwotI2VuZGlmCiB9CiAKIHN0YXRpYyBkaXNwYXRjaF9xdWV1 ZV90IGdsb2JhVmlkZW9DYXB0dXJlU2VyaWFsUXVldWUoKQo= 399823 2020-05-20 02:27:21 -0700 2020-05-20 06:30:48 -0700 Patch bug-212071-20200520112720.patch text/plain 2711 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNkOTQwNTA1NTgxZTllNWM0NGE1ZTc1 YjI2MGRmMTBkY2FlMDRkODMuLmNkM2RlMjRlZmYxMDQ0NDY3ZjcxYWIzZjI0ODVkNDYxZDQ4NGUx ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDUtMjAgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFVzZSBwcmVmZXJlZFBpeGVsQnVmZmVyRm9y bWF0IGZvciBBVlZpZGVvQ2FwdHVyZVNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBD YXJsc29uLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOgorICAgICAgICBBZGQgSEFW RV9ESVNQTEFZX0xBWUVSX0JJUExBTkFSX1NVUFBPUlQgbWFjcm8uCisKIDIwMjAtMDUtMTkgIEFk cmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBXVEY6 OkxvY2tlZFByaW50U3RyZWFtIHNob3VsZCBiZSBmaW5hbApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDczMzExYWMx Mzg0NjQ2N2IxZGY0YTgyMzZjY2IyMzg2ZDdhYWI0YTkuLjA0MjQ5NzNlNGJkOTQ2MzAwYzYwNzhj MTJlZGQ4ODIxN2IxNjQ2ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wNS0y MCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gVXNl IHByZWZlcmVkUGl4ZWxCdWZmZXJGb3JtYXQgZm9yIEFWVmlkZW9DYXB0dXJlU291cmNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIwNzEKKworICAg ICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgTWFudWFsbHkgdGVzdGVk LgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291 cmNlLm1tOgorICAgICAgICAoV2ViQ29yZTo6YXZWaWRlb0NhcHR1cmVQaXhlbEJ1ZmZlckZvcm1h dCk6CisKIDIwMjAtMDUtMjAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAg ICAgICAgIEluY29ycmVjdCBsb2NhdGlvbi5vcmlnaW4gaW4gYmxvYiB3b3JrZXJzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm b3JtSGF2ZS5oCmluZGV4IDdhNzI1YmQ0YzdlZjBjOGU2ZDNiZGJkNWY4NzU3Y2FlNjRmMDA4ZDku LmFmOGNlODg5NjBmMGRjOTQxY2VhY2U4Y2E3ZTBiZTIzZjVkZjM0ZjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt SGF2ZS5oCkBAIC02MTgsMyArNjE4LDcgQEAKICNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19P U19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTUwMCkgfHwgUExBVEZPUk0oSU9TKSB8fCBQ TEFURk9STShNQUNDQVRBTFlTVCkKICNkZWZpbmUgSEFWRV9RVUlDS0xPT0tfVEhVTUJOQUlMSU5H IDEKICNlbmRpZgorCisjaWYgUExBVEZPUk0oSU9TKSB8fCAoUExBVEZPUk0oTUFDKSAmJiBfX01B Q19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTYwMCkKKyNkZWZpbmUgSEFWRV9ESVNQ TEFZX0xBWUVSX0JJUExBTkFSX1NVUFBPUlQgMQorI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVT b3VyY2UubW0KaW5kZXggZDU5NTIwZTZlMzMwZGFiZGUwZWU3MTY0ZmM3M2UzNWUyOGJiMzdmOC4u YmE1MmQ1YTA4MjI3ZjFjZGZkYjg2MzlhNmI0ODJlOTgzMDcxMjE5YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNl Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BVlZpZGVv Q2FwdHVyZVNvdXJjZS5tbQpAQCAtNzUsMTEgKzc1LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogc3RhdGljIGlubGluZSBPU1R5cGUgYXZWaWRlb0NhcHR1cmVQaXhlbEJ1ZmZlckZvcm1hdCgp CiB7Ci0gICAgLy8gRklYTUU6IFVzZSBwcmVmZXJlZFBpeGVsQnVmZmVyRm9ybWF0KCkgb25jZSBy ZGFyOi8vcHJvYmxlbS80NDM5MTQ0NCBpcyBmaXhlZC4KLSNpZiBQTEFURk9STShNQUMpCi0gICAg cmV0dXJuIGtDVlBpeGVsRm9ybWF0VHlwZV80MjBZcENiQ3I4UGxhbmFyOwotI2Vsc2UKKyNpZiBI QVZFKERJU1BMQVlfTEFZRVJfQklQTEFOQVJfU1VQUE9SVCkKICAgICByZXR1cm4gcHJlZmVyZWRQ aXhlbEJ1ZmZlckZvcm1hdCgpOworI2Vsc2UKKyAgICByZXR1cm4ga0NWUGl4ZWxGb3JtYXRUeXBl XzQyMFlwQ2JDcjhQbGFuYXI7CiAjZW5kaWYKIH0KIAo=