212065 2020-05-19 00:43:30 -0700 [WinCairo] ASSERT(m_eglDisplay == EGL_NO_DISPLAY) fails in ~PlatformDisplay() 2020-05-19 21:19:15 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170331 InRadar P2 Normal --- 1 fujii fujii don.olmstead pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1653947 0 fujii 2020-05-19 00:43:30 -0700 [WinCairo] ASSERT(m_eglDisplay == EGL_NO_DISPLAY) fails in ~PlatformDisplay() 1. Start WinCairo Debug buid WK2 MiniBrowser 2. Go to WebGL page (for example https://get.webgl.org/) 3. Close MiniBrowser window 4. The assertion fails Callstack: > WTF.dll!WTFCrash() Line 303 C++ > WebKit2.dll!WTFCrashWithInfo(int __formal=162, const char * __formal=0x00007ffd388adf70, const char * __formal=0x00007ffd388adf40, int __formal=261) Line 672 C++ > WebKit2.dll!WebCore::PlatformDisplay::~PlatformDisplay() Line 162 C++ > WebKit2.dll!WebCore::PlatformDisplayWin::~PlatformDisplayWin() Line 51 C++ > [External Code] > WebKit2.dll!WebKit::callExit(IPC::Connection * __formal=0x0000018fda960de0) Line 203 C++ > WebKit2.dll!IPC::Connection::connectionDidClose() Line 856 C++ > WebKit2.dll!IPC::Connection::readEventHandler() Line 156 C++ > WebKit2.dll!IPC::Connection::invokeReadEventHandler::__l2::<lambda>() Line 235 C++ > WebKit2.dll!WTF::Detail::CallableWrapper<void <lambda>(void),void>::call() Line 52 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 85 C++ > WTF.dll!WTF::WorkQueue::dispatch::__l2::<lambda>() Line 62 C++ > WTF.dll!WTF::Detail::CallableWrapper<void <lambda>(void),void>::call() Line 52 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 85 C++ > WTF.dll!WTF::RunLoop::performWork() Line 120 C++ > WTF.dll!WTF::RunLoop::wndProc(HWND__ * hWnd=0x0000000000190728, unsigned int message=1025, unsigned __int64 wParam=1717359019392, __int64 lParam=0) Line 57 C++ > WTF.dll!WTF::RunLoop::RunLoopWndProc(HWND__ * hWnd=0x0000000000190728, unsigned int message=1025, unsigned __int64 wParam=1717359019392, __int64 lParam=0) Line 39 C++ > [External Code] > WTF.dll!WTF::RunLoop::run() Line 74 C++ > WTF.dll!WTF::WorkQueue::platformInitialize::__l2::<lambda>() Line 42 C++ > WTF.dll!WTF::Detail::CallableWrapper<void <lambda>(void),void>::call() Line 52 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 85 C++ > WTF.dll!WTF::Thread::entryPoint(WTF::Thread::NewThreadContext * newThreadContext=0x0000018fda9394f0) Line 168 C++ > WTF.dll!WTF::wtfThreadEntryPoint(void * data=0x0000018fda9394f0) Line 153 C++ > [External Code] The same issue of WinCairo WK1 was fixed in Bug 170331 by calling PlatformDisplay::shutDownEglDisplays() in shutDownWebKit(). 1654164 1 399766 fujii 2020-05-19 13:35:13 -0700 Created attachment 399766 Patch 1654315 2 399766 fujii 2020-05-19 21:18:37 -0700 Comment on attachment 399766 Patch Clearing flags on attachment: 399766 Committed r261905: <https://trac.webkit.org/changeset/261905> 1654316 3 fujii 2020-05-19 21:18:40 -0700 All reviewed patches have been landed. Closing bug. 1654317 4 webkit-bug-importer 2020-05-19 21:19:15 -0700 <rdar://problem/63429994> 399766 2020-05-19 13:35:13 -0700 2020-05-19 21:18:37 -0700 Patch bug-212065-20200520053512.patch text/plain 5078 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ4OGUxMTc2OGJkZWI2 ZWNjODQzNzNiODQ0YzA2YzhiMjgwYjAzNC4uOGY3NjRkMjZlN2QwNTY5YjUzYmEwNmYwYzRhMjI4 NjJkMTQ1MWNkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIwLTA1LTE5ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gQVNTRVJUKG1fZWdsRGlzcGxheSA9PSBFR0xfTk9fRElTUExBWSkgZmFpbHMgaW4gflBsYXRm b3JtRGlzcGxheSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTIwNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQbGF0Zm9ybURpc3BsYXkgZGVzdG95cyBtX2VnbERpc3BsYXkgYnkgdXNpbmcgc3RkOjph dGV4aXQgdG8KKyAgICAgICAgZW5zdXJlIHRoZXkgYXJlIGRlc3RydWN0ZWQgYmVmb3JlIEVHTCdz IGF0ZXhpdCBoYW5kbGVyIChCdWcgMTU3OTczKS4KKyAgICAgICAgSG93ZXZlciwgY2FsbGluZyBl Z2xUZXJtaW5hdGUgaW4gYXRleGl0IGhhbmRsZXIgY2F1c2VzIGEKKyAgICAgICAgY3Jhc2ggb24g V2luZG93cyAoQnVnIDE0NTgzMiwgQnVnIDE3MDMzMSkuCisKKyAgICAgICAgVGhlbiwgcjIxNDY4 OCBhZGRlZCBzaHV0RG93bkVnbERpc3BsYXlzKCkgYW5kIGV4cGxpY2l0bHkgY2FsbCBpdAorICAg ICAgICBpbiBzaHV0RG93bldlYktpdCgpIHRvIGRlc3RvcnkgbV9lZ2xEaXNwbGF5IGluIFdpbmRv d3MgV2ViS2l0MS4KKyAgICAgICAgSG93ZXZlciwgV2luZG93cyBXZWJLaXQyIG1heSBjYWxsIF9l eGl0KCkgaW4gSVBDOjpDb25uZWN0aW9uJ3MKKyAgICAgICAgV29ya1F1ZXVlIHRocmVhZC4gSXQg ZG9lc24ndCBzZWVtIGEgZ29vZCBpZGVhIHRoYXQgZXhwbGljaXRseQorICAgICAgICBkZXN0cnVj dGluZyBtX2VnbERpc3BsYXkgYnkgY2FsbGluZyBzaHV0RG93bkVnbERpc3BsYXlzKCkuCisKKyAg ICAgICAgUmVtb3ZlIHNodXREb3duRWdsRGlzcGxheXMoKSBhbmQgdGhlIGFzc2VydGlvbiBmb3Ig V2luZG93cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6On5QbGF0Zm9ybURpc3BsYXkp OiBDb25kaXRpb25lZCBvdXQgdGhlCisgICAgICAgIGFzc2VydGlvbiBmb3IgUExBVEZPUk0oV0lO KS4KKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheTo6aW5pdGlhbGl6ZUVHTERpc3Bs YXkpOiBSZXN0b3JlZCB0aGUKKyAgICAgICAgb3JpZ2luYWwgYXRleGl0IGhhbmRsZXIgb2YgcjIw MTU5NS4KKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheTo6c2h1dERvd25FZ2xEaXNw bGF5cyk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNw bGF5Lmg6CisKIDIwMjAtMDUtMTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgTW92ZSBzb21lIG9mIHRoZSBtb3JlIGNoYXR0eSBTY3JvbGxpbmcgbG9n Z2luZyB0byBhIFNjcm9sbGluZ1RyZWUgY2hhbm5lbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dExlZ2FjeS93aW4vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vQ2hhbmdlTG9n CmluZGV4IGFiNGI2NmM0MjE5NWQwODEyYTZjMjU1M2NkNGNjZmViNzQ1MDY2M2UuLjU5MWNiMDA0 OTA1ZjcyYjQ0MmM3YzBlYmI2Yjg5NzNkNjk1YzZhNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvd2luL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNS0xOSAgRnVqaWkgSGlyb25vcmkgIDxIaXJv bm9yaS5GdWppaUBzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIEFTU0VSVChtX2VnbERp c3BsYXkgPT0gRUdMX05PX0RJU1BMQVkpIGZhaWxzIGluIH5QbGF0Zm9ybURpc3BsYXkoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMDY1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRETEwu Y3BwOgorICAgICAgICAoc2h1dERvd25XZWJLaXQpOiBEb24ndCBjYWxsIFBsYXRmb3JtRGlzcGxh eTo6c2h1dERvd25FZ2xEaXNwbGF5cygpLgorCiAyMDIwLTA1LTEyICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gTmV1dGVyIFdLRnJhbWVJc0ZyYW1lU2V0 KCkgLyBXS1BhZ2VHZXRGcmFtZVNldExhcmdlc3RGcmFtZSgpIEMgQVBJCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcAppbmRleCBm OTU0N2IzYWY2OWNiYTBiZDI0N2YzOTMxNjk2ZjRhZmZmZjZiZTA4Li4wMDIzNDk2ZjM0MDU4ODUz MmE3MGFiODY4YWQzOWUwM2ViYmI4YTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAKQEAgLTE1OCw3ICsxNTgsNyBAQCBQ bGF0Zm9ybURpc3BsYXk6OlBsYXRmb3JtRGlzcGxheShOYXRpdmVEaXNwbGF5T3duZWQgZGlzcGxh eU93bmVkKQogCiBQbGF0Zm9ybURpc3BsYXk6On5QbGF0Zm9ybURpc3BsYXkoKQogewotI2lmIFVT RShFR0wpCisjaWYgVVNFKEVHTCkgJiYgIVBMQVRGT1JNKFdJTikKICAgICBBU1NFUlQobV9lZ2xE aXNwbGF5ID09IEVHTF9OT19ESVNQTEFZKTsKICNlbmRpZgogICAgIGlmIChzX3NoYXJlZERpc3Bs YXlGb3JDb21wb3NpdGluZyA9PSB0aGlzKQpAQCAtMjMyLDcgKzIzMiwxMiBAQCB2b2lkIFBsYXRm b3JtRGlzcGxheTo6aW5pdGlhbGl6ZUVHTERpc3BsYXkoKQogICAgICAgICAvLyBFR0wgYXRleGl0 IGhhbmRsZXJzIGFuZCB0aGUgUGxhdGZvcm1EaXNwbGF5IGRlc3RydWN0b3IuCiAgICAgICAgIC8v IFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3OTczLgogICAg ICAgICBlZ2xBdGV4aXRIYW5kbGVySW5pdGlhbGl6ZWQgPSB0cnVlOwotICAgICAgICBzdGQ6OmF0 ZXhpdChzaHV0RG93bkVnbERpc3BsYXlzKTsKKyAgICAgICAgc3RkOjphdGV4aXQoW10geworICAg ICAgICAgICAgd2hpbGUgKCFlZ2xEaXNwbGF5cygpLmlzRW1wdHkoKSkgeworICAgICAgICAgICAg ICAgIGF1dG8qIGRpc3BsYXkgPSBlZ2xEaXNwbGF5cygpLnRha2VBbnkoKTsKKyAgICAgICAgICAg ICAgICBkaXNwbGF5LT50ZXJtaW5hdGVFR0xEaXNwbGF5KCk7CisgICAgICAgICAgICB9CisgICAg ICAgIH0pOwogICAgIH0KICNlbmRpZgogfQpAQCAtMjUxLDE0ICsyNTYsNiBAQCB2b2lkIFBsYXRm b3JtRGlzcGxheTo6dGVybWluYXRlRUdMRGlzcGxheSgpCiAgICAgbV9lZ2xEaXNwbGF5ID0gRUdM X05PX0RJU1BMQVk7CiB9CiAKLXZvaWQgUGxhdGZvcm1EaXNwbGF5OjpzaHV0RG93bkVnbERpc3Bs YXlzKCkKLXsKLSAgICB3aGlsZSAoIWVnbERpc3BsYXlzKCkuaXNFbXB0eSgpKSB7Ci0gICAgICAg IGF1dG8qIGRpc3BsYXkgPSBlZ2xEaXNwbGF5cygpLnRha2VBbnkoKTsKLSAgICAgICAgZGlzcGxh eS0+dGVybWluYXRlRUdMRGlzcGxheSgpOwotICAgIH0KLX0KLQogI2VuZGlmIC8vIFVTRShFR0wp CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmgKaW5kZXggNzQ3MDRiZjRhNjE5MzAzYjNhN2Fi N2JkYzI0NDVmMmY2MWFiNzA1Yy4uMjU3NmQwYTE4ODVjZDI2N2NhYzZhNDQ5M2MyNmRlNzdlZjg5 OGRhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZv cm1EaXNwbGF5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZv cm1EaXNwbGF5LmgKQEAgLTc1LDcgKzc1LDYgQEAgcHVibGljOgogI2lmIFVTRShFR0wpCiAgICAg RUdMRGlzcGxheSBlZ2xEaXNwbGF5KCkgY29uc3Q7CiAgICAgYm9vbCBlZ2xDaGVja1ZlcnNpb24o aW50IG1ham9yLCBpbnQgbWlub3IpIGNvbnN0OwotICAgIHN0YXRpYyB2b2lkIHNodXREb3duRWds RGlzcGxheXMoKTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVS X0dMKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViS2l0RExMLmNwcCBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL1dlYktpdERMTC5jcHAKaW5kZXggMzk2ZDY0ODAzOWM5 NmMxYTBlMjM5M2RiM2IxZTNlZjI4NDc4ZDNlNy4uZDFmMDllYmY2NDUyYjk1NWIwZGNhY2Q0MDdj Nzg4YTBjOTllZWM3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViS2l0 RExMLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJLaXRETEwuY3BwCkBAIC0x NjMsOSArMTYzLDYgQEAgU1REQVBJIExvY2FsU2VydmVyRGlkRGllKCkKIHZvaWQgc2h1dERvd25X ZWJLaXQoKQogewogICAgIFdlYktpdDo6V2ViU3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVyOjpjbG9z ZUxvY2FsU3RvcmFnZSgpOwotI2lmIFVTRShFR0wpCi0gICAgUGxhdGZvcm1EaXNwbGF5OjpzaHV0 RG93bkVnbERpc3BsYXlzKCk7Ci0jZW5kaWYKIH0KIAogLy9GSVhNRTogV2Ugc2hvdWxkIGNvbnNp ZGVyIG1vdmluZyB0aGlzIHRvIGEgbmV3IGZpbGUgZm9yIGNyb3NzLXByb2plY3QgZnVuY3Rpb25h bGl0eQo=