212057 2020-05-18 17:45:44 -0700 REGRESSION(r260760): ENABLE_GRAPHICS_CONTEXT_GL should be ON, not TRUE 2020-06-17 00:30:03 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro annulen bugs-noreply cgarcia ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio oldest_to_newest 1653835 0 mcatanzaro 2020-05-18 17:45:44 -0700 Our feature list after r260760, ENABLE_GRAPHICS_CONTEXT_GL is messed up: -- Enabled features: -- ENABLE_ACCELERATED_2D_CANVAS .................. OFF -- ENABLE_BUBBLEWRAP_SANDBOX ON -- ENABLE_DRAG_SUPPORT ........................... ON -- ENABLE_GLES2 ON -- ENABLE_GRAPHICS_CONTEXT_GL .................... TRUE -- ENABLE_GTKDOC OFF -- ENABLE_INTROSPECTION .......................... ON -- ENABLE_MEDIA_SOURCE ON -- ENABLE_MINIBROWSER ............................ ON -- ENABLE_QUARTZ_TARGET OFF -- ENABLE_SHAREABLE_RESOURCE ..................... ON -- ENABLE_SPELLCHECK ON -- ENABLE_TOUCH_EVENTS ........................... ON -- ENABLE_VIDEO ON -- ENABLE_WAYLAND_TARGET ......................... ON -- ENABLE_WEBDRIVER ON -- ENABLE_WEB_AUDIO .............................. ON -- ENABLE_WEB_CRYPTO ON -- ENABLE_X11_TARGET ............................. ON -- USE_GTK4 OFF -- USE_LIBHYPHEN ................................. ON -- USE_LIBNOTIFY ON -- USE_LIBSECRET ................................. ON -- USE_OPENJPEG ON -- USE_SYSTEMD ................................... ON -- USE_WOFF2 ON -- USE_WPE_RENDERER .............................. ON Since multiple variables were merged together, I think we can just remove the line that sets it explicitly. Let's see. 1653853 1 399693 mcatanzaro 2020-05-18 18:29:39 -0700 Created attachment 399693 Patch 1653854 2 mcatanzaro 2020-05-18 18:32:47 -0700 (In reply to Michael Catanzaro from comment #0) > Since multiple variables were merged together, I think we can just remove > the line that sets it explicitly. Let's see. To be completely sure, I checked to ensure poster circle still works. Seems fine. 1663243 3 mcatanzaro 2020-06-16 14:31:09 -0700 Ping reviewers. 1663397 4 ews-feeder 2020-06-17 00:30:00 -0700 Committed r263138: <https://trac.webkit.org/changeset/263138> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399693. 399693 2020-05-18 18:29:39 -0700 2020-06-17 00:30:01 -0700 Patch bug-212057-20200518202938.patch text/plain 1251 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDFiMGJi NTNjZDhjM2RmMDA0ZjE3OTlmZTI3MTlkNTI5YzJkOGRjOWEuLjE3MGYyMWUzMDA0Y2Y5ZjczZDg4 MDMzMGZhYWI4NTVlZTRlZTNlYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0zMjAsOCArMzIw LDYgQEAgaWYgKEVOQUJMRV9HUkFQSElDU19DT05URVhUX0dMKQogICAgICAgICBtZXNzYWdlKEZB VEFMX0VSUk9SICJFaXRoZXIgR0xYIG9yIEVHTCBpcyBuZWVkZWQgZm9yIEVOQUJMRV9HUkFQSElD U19DT05URVhUX0dMLiIpCiAgICAgZW5kaWYgKCkKIAotICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JV SUxEKEVOQUJMRV9HUkFQSElDU19DT05URVhUX0dMIFRSVUUpCi0KICAgICBTRVRfQU5EX0VYUE9T RV9UT19CVUlMRChVU0VfVEVYVFVSRV9NQVBQRVJfR0wgVFJVRSkKIAogICAgIFNFVF9BTkRfRVhQ T1NFX1RPX0JVSUxEKFVTRV9FR0wgJHtFR0xfRk9VTkR9KQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IDI2MjllMjVmNzVmYzViYTNjMDBiMDFjODVkN2ZiNmUwYmUxNTlk YzYuLmI2ODVhMWQ5MjA3YTIxMzE5Yjg1YWI2ZjNmZDFjYzk3YjZiZWMyNmMgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wNS0xOCAg TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KKworICAgICAgICBSRUdS RVNTSU9OKHIyNjA3NjApOiBFTkFCTEVfR1JBUEhJQ1NfQ09OVEVYVF9HTCBzaG91bGQgYmUgT04s IG5vdCBUUlVFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTIwNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGlzIGFscmVhZHkgc2V0IGJ5IGZlYXR1cmUgcG9saWN5LiBEb24ndCBjbG9iYmVyIGl0 LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIwMjAtMDUt MTggIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAg W0dUS10gQWxsb3cgZ3RrLWRvYyBhbmQgaW50cm9zcGVjdGlvbiBpbiBjcm9zcyBidWlsZHMK