212050 2020-05-18 15:29:45 -0700 Rare crash under -[WKContentView resignFirstResponderForWebView] 2020-06-26 15:48:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 213666 1 thorton thorton megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1653776 0 thorton 2020-05-18 15:29:45 -0700 Rare crash under -[WKContentView resignFirstResponderForWebView] 1653777 1 399677 thorton 2020-05-18 15:30:19 -0700 Created attachment 399677 Patch 1653778 2 thorton 2020-05-18 15:30:21 -0700 <rdar://problem/60187111> 1653781 3 399677 wenson_hsieh 2020-05-18 15:32:54 -0700 Comment on attachment 399677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399677&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1412 > + if (strongSelf->_keyWebEventHandler.get() != strongHandler.get()) Nit - are both of these .get() needed? 1653783 4 399677 megan_gardner 2020-05-18 15:34:53 -0700 Comment on attachment 399677 Patch r=me as well 1653792 5 399677 thorton 2020-05-18 16:02:33 -0700 Comment on attachment 399677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399677&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1412 >> + if (strongSelf->_keyWebEventHandler.get() != strongHandler.get()) > > Nit - are both of these .get() needed? As we learned extensively on Slack, yes, because this code is being pretty dirty and WeakObjCPtr<id>-ing the block, and no combination of BlockPtr/WeakObjCPtr on either side make enough implicit conversions that you can drop either get (nor both). 1653805 6 ews-feeder 2020-05-18 16:31:47 -0700 Committed r261838: <https://trac.webkit.org/changeset/261838> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399677. 399677 2020-05-18 15:30:19 -0700 2020-05-18 16:31:47 -0700 Patch bug-212050-20200518153018.patch text/plain 2993 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA4NDI2YTU5NzFhNjUwNmU0 ZGNhZGIwODEzOTc2OTU2NGNhNGMzMDMuLjY2MjA2OTYyNWE0Yjg1YzYyMjZjYTNlZTA2ZDlmZjM3 NzdlZWU4YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDUtMTggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmFyZSBjcmFzaCB1bmRl ciAtW1dLQ29udGVudFZpZXcgcmVzaWduRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3XQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMDUwCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82MDE4NzExMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHJlc2lnbkZpcnN0UmVzcG9uZGVyRm9y V2ViVmlld10pOgorICAgICAgICBSZW9yZ2FuaXplIHRoaXMgYmxvY2sgc28gdGhhdCBpdCBhbHdh eXMgdGFrZXMgYSBzdHJvbmcgcmVmZXJlbmNlIC9iZWZvcmUvCisgICAgICAgIG51bGwgY2hlY2tp bmcgYW5kIHVzaW5nIHRoZSBwb2ludGVyLiBBbHNvLCBhZGQgYSBfcGFnZSBudWxsIGNoZWNrLgor ICAgICAgICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4IGZvciBhbiB1bnJlcHJvZHVjaWJsZSBs b3ctcmF0ZSBjcmFzaC4KKworICAgICAgICBJbiB0aGVvcnkgdGhlIGV4aXN0aW5nIHRpbWUtb2Yt Y2hlY2sgcmFjZSBoZXJlIHNob3VsZCBub3QgYmUgYSBwcm9ibGVtLAorICAgICAgICBzaW5jZSBX S1dlYlZpZXcgaXMgc3VwcG9zZWQgdG8gYmUgZnJlZWQgb24gdGhlIG1haW4gdGhyZWFkLCBhbmQg dGhpcyBjb2RlCisgICAgICAgIHJ1bnMgb24gdGhlIG1haW4gdGhyZWFkLCBidXQgd2UgaGF2ZSBh bXBsZSBldmlkZW5jZSBvZiBXS1dlYlZpZXcKKyAgICAgICAgYmVpbmcgZnJlZWQgb2ZmIHRoZSBt YWluIHRocmVhZCBpbiB2YXJpb3VzIGNsaWVudHMuCisKIDIwMjAtMDUtMTQgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGluIFBERlBsdWdpbjo6ZW5z dXJlRGF0YUJ1ZmZlckxlbmd0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggZTA0NDg5ODg1MzFmMmEzMGYy OGExYTVkM2UxYmI0ZTRjMWFhNjY2Ni4uMGRjZWRjZDk0ZjAxZTIwYTc0Y2RkZjFjMDA5YWVmNTM2 NTI4M2Q1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xNDAzLDE2ICsxNDAzLDIwIEBAIC0gKEJPT0wp cmVzaWduRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3CiAKICAgICAgICAgaWYgKF9rZXlXZWJFdmVu dEhhbmRsZXIpIHsKICAgICAgICAgICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWlu X3F1ZXVlKCksIFt3ZWFrSGFuZGxlciA9IFdlYWtPYmpDUHRyPGlkPihfa2V5V2ViRXZlbnRIYW5k bGVyLmdldCgpKSwgd2Vha1NlbGYgPSBXZWFrT2JqQ1B0cjxXS0NvbnRlbnRWaWV3PihzZWxmKV0g ewotICAgICAgICAgICAgICAgIGlmICghd2Vha1NlbGYgfHwgIXdlYWtIYW5kbGVyKQotICAgICAg ICAgICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgICAgICAgICBhdXRvIHN0cm9uZ1NlbGYg PSB3ZWFrU2VsZi5nZXQoKTsKLSAgICAgICAgICAgICAgICBpZiAoW3N0cm9uZ1NlbGYgaXNGaXJz dFJlc3BvbmRlcl0gfHwgd2Vha0hhbmRsZXIuZ2V0KCkuZ2V0KCkgIT0gc3Ryb25nU2VsZi0+X2tl eVdlYkV2ZW50SGFuZGxlci5nZXQoKSkKKyAgICAgICAgICAgICAgICBpZiAoIXN0cm9uZ1NlbGYg fHwgW3N0cm9uZ1NlbGYgaXNGaXJzdFJlc3BvbmRlcl0pCisgICAgICAgICAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgICAgICAgICBhdXRvIHN0cm9uZ0hhbmRsZXIgPSB3ZWFrSGFuZGxlci5n ZXQoKTsKKyAgICAgICAgICAgICAgICBpZiAoIXN0cm9uZ0hhbmRsZXIpCisgICAgICAgICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICBpZiAoc3Ryb25nU2VsZi0+X2tleVdlYkV2 ZW50SGFuZGxlci5nZXQoKSAhPSBzdHJvbmdIYW5kbGVyLmdldCgpKQogICAgICAgICAgICAgICAg ICAgICByZXR1cm47Ci0KICAgICAgICAgICAgICAgICBhdXRvIGtleUV2ZW50SGFuZGxlciA9IHN0 ZDo6ZXhjaGFuZ2Uoc3Ryb25nU2VsZi0+X2tleVdlYkV2ZW50SGFuZGxlciwgbmlsKTsKLSAgICAg ICAgICAgICAgICBBU1NFUlQoc3Ryb25nU2VsZi0+X3BhZ2UtPmhhc1F1ZXVlZEtleUV2ZW50KCkp OwotICAgICAgICAgICAgICAgIGtleUV2ZW50SGFuZGxlcihzdHJvbmdTZWxmLT5fcGFnZS0+Zmly c3RRdWV1ZWRLZXlFdmVudCgpLm5hdGl2ZUV2ZW50KCksIFlFUyk7CisgICAgICAgICAgICAgICAg YXV0byBwYWdlID0gc3Ryb25nU2VsZi0+X3BhZ2U7CisgICAgICAgICAgICAgICAgaWYgKCFwYWdl KQorICAgICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgQVNTRVJUKHBh Z2UtPmhhc1F1ZXVlZEtleUV2ZW50KCkpOworICAgICAgICAgICAgICAgIGtleUV2ZW50SGFuZGxl cihwYWdlLT5maXJzdFF1ZXVlZEtleUV2ZW50KCkubmF0aXZlRXZlbnQoKSwgWUVTKTsKICAgICAg ICAgICAgIH0pOwogICAgICAgICB9CiAgICAgfQo=