212044 2020-05-18 13:39:48 -0700 [WinCairo] WKTR WebsiteDataStore is being overwritten by the default one 2020-05-18 19:42:15 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210106 InRadar P2 Normal --- 1 chris.reid chris.reid don.olmstead fujii ross.kirsling webkit-bug-importer oldest_to_newest 1653752 0 chris.reid 2020-05-18 13:39:48 -0700 This causes some Service Worker tests which expect clean DataStores to fail because they aren't using the temporary WebsiteDataStore. 1653753 1 399673 chris.reid 2020-05-18 13:44:42 -0700 Created attachment 399673 patch 1653849 2 399673 don.olmstead 2020-05-18 18:20:31 -0700 Comment on attachment 399673 patch There's a related block of code at platformInitializeDataStore which GTK and WPE implement in their respective TestController files. I'd wager that their implementation should just be shared in this file. Also while you're in there maybe add a !PLATFORM(COCOA) comment at the end of the #if !PLATFORM(COCOA) block this lives in. 1653855 3 chris.reid 2020-05-18 18:42:50 -0700 (In reply to Don Olmstead from comment #2) > Comment on attachment 399673 [details] > patch > > There's a related block of code at platformInitializeDataStore which GTK and > WPE implement in their respective TestController files. I'd wager that their > implementation should just be shared in this file. > Yeah, for reference wincairo recently started to hit crashes without that change similar to r261758. 1653863 4 399697 chris.reid 2020-05-18 19:11:00 -0700 Created attachment 399697 Patch for landing 1653869 5 ews-feeder 2020-05-18 19:41:16 -0700 Committed r261846: <https://trac.webkit.org/changeset/261846> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399697. 1653870 6 webkit-bug-importer 2020-05-18 19:42:15 -0700 <rdar://problem/63376620> 399673 2020-05-18 13:44:42 -0700 2020-05-18 19:10:57 -0700 patch 212044.diff text/plain 1546 chris.reid ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2ZjZk NzRmNzI3NDguLjNhMThmMjU2ZDhhMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTE4ICBDaHJpc3RvcGhl ciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIFdLVFIg V2Vic2l0ZURhdGFTdG9yZSBpcyBiZWluZyBvdmVyd3JpdHRlbiBieSB0aGUgZGVmYXVsdCBvbmUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjA0NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3VyZSBU ZXN0Q29udHJvbGxlcjo6ZGVmYXVsdFdlYlNpdGVEYXRhU3RvcmUgaXMgYmVpbmcgdXNlZCBmb3Ig V2luQ2Fpcm8gYXMgZG9uZSBpbiByMjU5NzA1LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0 Zm9ybUFkanVzdENvbnRleHQpOgorCiAyMDIwLTA1LTE4ICBQZW5nIExpdSAgPHBlbmcubGl1NkBh cHBsZS5jb20+CiAKICAgICAgICAgW2lQYWQgU2ltdWxhdG9yXSBUZXN0V2ViS2l0QVBJLldlYktp dExlZ2FjeS5TY3JvbGxpbmdEb2VzTm90UGF1c2VNZWRpYSBpcyB0aW1pbmcgb3V0CmRpZmYgLS1n aXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IGY2MGYxMjhmNTk5Ni4uYmJk NzEzMDA1ZWIzIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s bGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcApA QCAtMzEzNSwxMiArMzEzNSw4IEBAIFBsYXRmb3JtV2ViVmlldyogVGVzdENvbnRyb2xsZXI6OnBs YXRmb3JtQ3JlYXRlT3RoZXJQYWdlKFBsYXRmb3JtV2ViVmlldyogcGFyZW50CiAKIFdLQ29udGV4 dFJlZiBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1BZGp1c3RDb250ZXh0KFdLQ29udGV4dFJlZiBj b250ZXh0LCBXS0NvbnRleHRDb25maWd1cmF0aW9uUmVmIGNvbnRleHRDb25maWd1cmF0aW9uKQog ewotI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQogICAgIFdLV2Vic2l0ZURhdGFT dG9yZVNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGRlZmF1bHRXZWJzaXRlRGF0YVN0 b3JlKCksIHRydWUpOwogICAgIFdLQ29udGV4dFNldFByaW1hcnlXZWJzaXRlRGF0YVN0b3JlKGNv bnRleHQsIGRlZmF1bHRXZWJzaXRlRGF0YVN0b3JlKCkpOwotI2Vsc2UKLSAgICBXS1dlYnNpdGVE YXRhU3RvcmVTZXRSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRW5hYmxlZChXS0NvbnRleHRHZXRXZWJz aXRlRGF0YVN0b3JlKGNvbnRleHQpLCB0cnVlKTsKLSNlbmRpZgogICAgIHJldHVybiBjb250ZXh0 OwogfQogCg== 399697 2020-05-18 19:11:00 -0700 2020-05-18 19:41:17 -0700 Patch for landing bug-212044-20200518191059.patch text/plain 4239 chris.reid U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjFmMjNmYzE5YWI0YWZlM2ViMjAxMjI4MmRkYTkwNWUx MWFiZjMyYy4uMGQwN2U5NTg4ZGYwNGQ1ZGY2MTc3Yjg4NGJjZGVmY2FiMDJkZDZjNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIwLTA1LTE4ICBDaHJpc3RvcGhlciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNvbT4K KworICAgICAgICBbV2luQ2Fpcm9dIFdLVFIgV2Vic2l0ZURhdGFTdG9yZSBpcyBiZWluZyBvdmVy d3JpdHRlbiBieSB0aGUgZGVmYXVsdCBvbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjA0NAorCisgICAgICAgIFJldmlld2VkIGJ5IEZ1amlpIEhp cm9ub3JpLgorCisgICAgICAgIEVuc3VyZSBUZXN0Q29udHJvbGxlcjo6ZGVmYXVsdFdlYlNpdGVE YXRhU3RvcmUgaXMgYmVpbmcgdXNlZCBmb3IgV2luQ2Fpcm8gYXMgZG9uZSBpbiByMjU5NzA1Lgor CisgICAgICAgIEFsc28gY29uc29saWRhdGUgcGxhdGZvcm1Jbml0aWFsaXplRGF0YVN0b3JlIGlt cGxlbWVudGF0aW9ucyB3aXRoIEdUSy9XUEUgc2luY2UgV2luQ2Fpcm8gV0tUUgorICAgICAgICBh bHNvIHN0YXJ0ZWQgY3Jhc2hpbmcgc2luY2UgcjI2MTc1OC4KKworICAgICAgICAqIFdlYktpdFRl c3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv Z3RrL1Rlc3RDb250cm9sbGVyR3RrLmNwcDoKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3dw ZS9UZXN0Q29udHJvbGxlcldQRS5jcHA6CisKIDIwMjAtMDUtMTggIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFjZSB1c2VzIG9mICtzZWxmIHdp dGggK2NsYXNzCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s bGVyLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4 IGY2MGYxMjhmNTk5NjUxNDFmNjBiODk4OGExMzc2Y2JkZmZiZTBmYWQuLjM5OGEzZmVjYmNiOWVk MzgzYjhjOWQzMTY5NzY4YmIwYTFmMjA5ZjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwCkBAIC0zMTE2LDEyICszMTE2LDEwIEBAIHZvaWQgVGVzdENvbnRyb2xs ZXI6OnBsYXRmb3JtV2lsbFJ1blRlc3QoY29uc3QgVGVzdEludm9jYXRpb24mKQogewogfQogCi0j aWYgIVBMQVRGT1JNKEdUSykgJiYgIVBMQVRGT1JNKFdQRSkKLXZvaWQgVGVzdENvbnRyb2xsZXI6 OnBsYXRmb3JtSW5pdGlhbGl6ZURhdGFTdG9yZShXS1BhZ2VDb25maWd1cmF0aW9uUmVmIGNvbmZp Z3VyYXRpb24sIGNvbnN0IFRlc3RPcHRpb25zJikKK3ZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRm b3JtSW5pdGlhbGl6ZURhdGFTdG9yZShXS1BhZ2VDb25maWd1cmF0aW9uUmVmLCBjb25zdCBUZXN0 T3B0aW9ucyYpCiB7Ci0gICAgbV93ZWJzaXRlRGF0YVN0b3JlID0gV0tQYWdlQ29uZmlndXJhdGlv bkdldFdlYnNpdGVEYXRhU3RvcmUoY29uZmlndXJhdGlvbik7CisgICAgbV93ZWJzaXRlRGF0YVN0 b3JlID0gZGVmYXVsdFdlYnNpdGVEYXRhU3RvcmUoKTsKIH0KLSNlbmRpZgogCiB2b2lkIFRlc3RD b250cm9sbGVyOjpwbGF0Zm9ybUNyZWF0ZVdlYlZpZXcoV0tQYWdlQ29uZmlndXJhdGlvblJlZiBj b25maWd1cmF0aW9uLCBjb25zdCBUZXN0T3B0aW9ucyYgb3B0aW9ucykKIHsKQEAgLTMxMzUsMTIg KzMxMzMsOCBAQCBQbGF0Zm9ybVdlYlZpZXcqIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUNyZWF0 ZU90aGVyUGFnZShQbGF0Zm9ybVdlYlZpZXcqIHBhcmVudAogCiBXS0NvbnRleHRSZWYgVGVzdENv bnRyb2xsZXI6OnBsYXRmb3JtQWRqdXN0Q29udGV4dChXS0NvbnRleHRSZWYgY29udGV4dCwgV0tD b250ZXh0Q29uZmlndXJhdGlvblJlZiBjb250ZXh0Q29uZmlndXJhdGlvbikKIHsKLSNpZiBQTEFU Rk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkKICAgICBXS1dlYnNpdGVEYXRhU3RvcmVTZXRSZXNv dXJjZUxvYWRTdGF0aXN0aWNzRW5hYmxlZChkZWZhdWx0V2Vic2l0ZURhdGFTdG9yZSgpLCB0cnVl KTsKICAgICBXS0NvbnRleHRTZXRQcmltYXJ5V2Vic2l0ZURhdGFTdG9yZShjb250ZXh0LCBkZWZh dWx0V2Vic2l0ZURhdGFTdG9yZSgpKTsKLSNlbHNlCi0gICAgV0tXZWJzaXRlRGF0YVN0b3JlU2V0 UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJsZWQoV0tDb250ZXh0R2V0V2Vic2l0ZURhdGFTdG9y ZShjb250ZXh0KSwgdHJ1ZSk7Ci0jZW5kaWYKICAgICByZXR1cm4gY29udGV4dDsKIH0KIApAQCAt MzIwMSw3ICszMTk1LDcgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6Y2xlYXJMb2FkZWRUaGlyZFBh cnR5RG9tYWlucygpCiAgICAgV0tQYWdlQ2xlYXJMb2FkZWRUaGlyZFBhcnR5RG9tYWlucyhtX21h aW5XZWJWaWV3LT5wYWdlKCkpOwogfQogCi0jZW5kaWYKKyNlbmRpZiAvLyAhUExBVEZPUk0oQ09D T0EpCiAKIHN0cnVjdCBDbGVhclNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25zQ2FsbGJhY2tDb250 ZXh0IHsKICAgICBleHBsaWNpdCBDbGVhclNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25zQ2FsbGJh Y2tDb250ZXh0KFRlc3RDb250cm9sbGVyJiBjb250cm9sbGVyKQpkaWZmIC0tZ2l0IGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwCmluZGV4IDU5N2U2NjI2ZjljNWE2 NDAxZTNiMTJjMmEyMjEwMWZhZjU5M2I0N2YuLjM2NjQ3YzA0N2Y1ODQ3MGExNzBlZGYyNTRhNzcy OTJkZGMxMDNhMmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rlc3RD b250cm9sbGVyR3RrLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29u dHJvbGxlckd0ay5jcHAKQEAgLTQ2LDExICs0Niw2IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OnBs YXRmb3JtSW5pdGlhbGl6ZSgpCiB7CiB9CiAKLXZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3Jt SW5pdGlhbGl6ZURhdGFTdG9yZShXS1BhZ2VDb25maWd1cmF0aW9uUmVmLCBjb25zdCBUZXN0T3B0 aW9ucyYgb3B0aW9ucykKLXsKLSAgICBtX3dlYnNpdGVEYXRhU3RvcmUgPSBkZWZhdWx0V2Vic2l0 ZURhdGFTdG9yZSgpOwotfQotCiBXS1ByZWZlcmVuY2VzUmVmIFRlc3RDb250cm9sbGVyOjpwbGF0 Zm9ybVByZWZlcmVuY2VzKCkKIHsKICAgICByZXR1cm4gV0tQYWdlR3JvdXBHZXRQcmVmZXJlbmNl cyhtX3BhZ2VHcm91cC5nZXQoKSk7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L3dwZS9UZXN0Q29udHJvbGxlcldQRS5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3dwZS9U ZXN0Q29udHJvbGxlcldQRS5jcHAKaW5kZXggYzE1OGE1NDc3YzBlOWE3OGY0ZWRkMjE3NjFiNWE2 NDBhNTQ5OTg2Mi4uYWYwNDMyMWUwMzJlNmEwNDcwZjg0ZWE5ZmVkYTIxMjk0MDI4YWU3MyAxMDA2 NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93cGUvVGVzdENvbnRyb2xsZXJXUEUuY3Bw CisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvd3BlL1Rlc3RDb250cm9sbGVyV1BFLmNwcApA QCAtNDUsMTEgKzQ1LDYgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFsaXpl KCkKIHsKIH0KIAotdm9pZCBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFsaXplRGF0YVN0 b3JlKFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYsIGNvbnN0IFRlc3RPcHRpb25zJiBvcHRpb25zKQot ewotICAgIG1fd2Vic2l0ZURhdGFTdG9yZSA9IGRlZmF1bHRXZWJzaXRlRGF0YVN0b3JlKCk7Ci19 Ci0KIFdLUHJlZmVyZW5jZXNSZWYgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtUHJlZmVyZW5jZXMo KQogewogICAgIHJldHVybiBXS1BhZ2VHcm91cEdldFByZWZlcmVuY2VzKG1fcGFnZUdyb3VwLmdl dCgpKTsKd2FybmluZzogTEYgd2lsbCBiZSByZXBsYWNlZCBieSBDUkxGIGluIFRvb2xzL0NoYW5n ZUxvZy4KVGhlIGZpbGUgd2lsbCBoYXZlIGl0cyBvcmlnaW5hbCBsaW5lIGVuZGluZ3MgaW4geW91 ciB3b3JraW5nIGRpcmVjdG9yeS4K