212043 2020-05-18 13:31:06 -0700 REGRESSION(r257463): [GTK] Build failure with -DENABLE_GLES2=ON 2020-05-19 01:21:14 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply calvaris cgarcia ews-watchlist gustavo mcatanzaro menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1653743 0 mcatanzaro 2020-05-18 13:31:06 -0700 2.29.1 failed to build in gnome-build-meta because we use -DENABLE_GLES=ON for our ARM build. Note we have -DENABLE_X11_TARGET=ON and I see PlatformDisplayX11.h really is included, so this requires further investigation to see what's up with PlatformDisplayX11. I'll try a -DENABLE_GLES2=ON build tomorrow and see if I can figure out what's wrong. In file included from /usr/include/glib-2.0/gobject/gobject.h:24, from /usr/include/glib-2.0/gobject/gbinding.h:29, from /usr/include/glib-2.0/glib-object.h:22, from /usr/include/gstreamer-1.0/gst/gstenumtypes.h:6, from /usr/include/gstreamer-1.0/gst/gst.h:31, from ../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:24, from ../Source/WebCore/platform/graphics/PlatformDisplay.h:37, from ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:21: ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp: In function ‘GstGLDisplay* createGstGLDisplay(const WebCore::PlatformDisplay&)’: ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:69:80: error: ‘PlatfomDisplayX11’ was not declared in this scope; did you mean ‘PlatformDisplay_h’? 69 | return GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatfomDisplayX11>(sharedDisplay).eglDisplay())); | ^~~~~~~~~~~~~~~~~ ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:69:112: error: no matching function for call to ‘downcast<<expression error> >(const WebCore::PlatformDisplay&)’ 69 | return GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatfomDisplayX11>(sharedDisplay).eglDisplay())); | ^ In file included from ../Source/WebCore/platform/graphics/PlatformDisplay.h:30, from ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:21: DerivedSources/ForwardingHeaders/wtf/TypeCasts.h:83:43: note: candidate: ‘template<class Target, class Source> WTF::match_constness_t<Source, Target>* WTF::downcast(Source*)’ 83 | inline match_constness_t<Source, Target>* downcast(Source* source) | ^~~~~~~~ DerivedSources/ForwardingHeaders/wtf/TypeCasts.h:83:43: note: template argument deduction/substitution failed: In file included from /usr/include/glib-2.0/gobject/gobject.h:24, from /usr/include/glib-2.0/gobject/gbinding.h:29, from /usr/include/glib-2.0/glib-object.h:22, from /usr/include/gstreamer-1.0/gst/gstenumtypes.h:6, from /usr/include/gstreamer-1.0/gst/gst.h:31, from ../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:24, from ../Source/WebCore/platform/graphics/PlatformDisplay.h:37, from ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:21: ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:69:112: error: template argument 1 is invalid 69 | return GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatfomDisplayX11>(sharedDisplay).eglDisplay())); | ^ In file included from ../Source/WebCore/platform/graphics/PlatformDisplay.h:30, from ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:21: DerivedSources/ForwardingHeaders/wtf/TypeCasts.h:75:43: note: candidate: ‘template<class Target, class Source> WTF::match_constness_t<Source, Target>& WTF::downcast(Source&)’ 75 | inline match_constness_t<Source, Target>& downcast(Source& source) | ^~~~~~~~ DerivedSources/ForwardingHeaders/wtf/TypeCasts.h:75:43: note: template argument deduction/substitution failed: In file included from /usr/include/glib-2.0/gobject/gobject.h:24, from /usr/include/glib-2.0/gobject/gbinding.h:29, from /usr/include/glib-2.0/glib-object.h:22, from /usr/include/gstreamer-1.0/gst/gstenumtypes.h:6, from /usr/include/gstreamer-1.0/gst/gst.h:31, from ../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:24, from ../Source/WebCore/platform/graphics/PlatformDisplay.h:37, from ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:21: ../Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:69:112: error: template argument 1 is invalid 69 | return GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatfomDisplayX11>(sharedDisplay).eglDisplay())); | ^ 1653844 1 mcatanzaro 2020-05-18 18:08:37 -0700 (In reply to Michael Catanzaro from comment #0) > PlatfomDisplayX11 Missing 'r' ;) 1653859 2 399695 mcatanzaro 2020-05-18 18:51:49 -0700 Created attachment 399695 Patch 1653951 3 ews-feeder 2020-05-19 01:20:06 -0700 Committed r261854: <https://trac.webkit.org/changeset/261854> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399695. 1653953 4 webkit-bug-importer 2020-05-19 01:21:14 -0700 <rdar://problem/63385514> 399695 2020-05-18 18:51:49 -0700 2020-05-19 01:20:07 -0700 Patch bug-212043-20200518205148.patch text/plain 1753 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM2NDIxMGUyZGFjNTAy ODNjNmJjNDZlZGU2MDU5MDI2OGU3MjMwNi4uMzZjYjE1OGZmMzVmZmEzNGM0MjI2YTQ4NzkzMWU4 ZGZhZTZjZWJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTE4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjI1NzQ2Myk6IFtHVEtdIEJ1aWxkIGZhaWx1cmUgd2l0aCAtREVOQUJMRV9HTEVTMj1PTgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyMDQzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSB0 eXBvICJQbGF0Zm9tIiAtPiAiUGxhdGZvcm0iCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvUGxhdGZvcm1EaXNwbGF5R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKGNyZWF0 ZUdzdEdMRGlzcGxheSk6CisKIDIwMjAtMDUtMTggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2ll aEBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgY2xpcGJvYXJkIEFQSSBhY2Nlc3Mgd2hlbiBw YXN0aW5nIGZyb20gYSBtZW51IGl0ZW0gb3Iga2V5IGJpbmRpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybURpc3BsYXlHU3Ry ZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1Bs YXRmb3JtRGlzcGxheUdTdHJlYW1lci5jcHAKaW5kZXggZmIwYzE4Njg0MDhhZjM1ODYwNTg4ZGIy MmFlNjIxZTVjOTg5ZWQyZC4uNjRmMzJhZTAyOGZiZDVmNDBkNDJhNjY5ZjJmZTVlYzc1NGQyYTFj OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L1BsYXRmb3JtRGlzcGxheUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtRGlzcGxheUdTdHJlYW1lci5jcHAKQEAgLTY2 LDcgKzY2LDcgQEAgc3RhdGljIEdzdEdMRGlzcGxheSogY3JlYXRlR3N0R0xEaXNwbGF5KGNvbnN0 IFBsYXRmb3JtRGlzcGxheSYgc2hhcmVkRGlzcGxheSkKICAgICAgICAgcmV0dXJuIEdTVF9HTF9E SVNQTEFZKGdzdF9nbF9kaXNwbGF5X3gxMV9uZXdfd2l0aF9kaXNwbGF5KGRvd25jYXN0PFBsYXRm b3JtRGlzcGxheVgxMT4oc2hhcmVkRGlzcGxheSkubmF0aXZlKCkpKTsKICNlbGlmIFVTRShFR0wp CiAgICAgaWYgKGlzPFBsYXRmb3JtRGlzcGxheVgxMT4oc2hhcmVkRGlzcGxheSkpCi0gICAgICAg IHJldHVybiBHU1RfR0xfRElTUExBWShnc3RfZ2xfZGlzcGxheV9lZ2xfbmV3X3dpdGhfZWdsX2Rp c3BsYXkoZG93bmNhc3Q8UGxhdGZvbURpc3BsYXlYMTE+KHNoYXJlZERpc3BsYXkpLmVnbERpc3Bs YXkoKSkpOworICAgICAgICByZXR1cm4gR1NUX0dMX0RJU1BMQVkoZ3N0X2dsX2Rpc3BsYXlfZWds X25ld193aXRoX2VnbF9kaXNwbGF5KGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheVgxMT4oc2hhcmVk RGlzcGxheSkuZWdsRGlzcGxheSgpKSk7CiAjZW5kaWYKICNlbmRpZgogCg==