212031 2020-05-18 10:25:04 -0700 webkitpy: Add Source/WebKit/Scripts/webkit as relevant path to webkitpy-ews 2022-03-01 02:24:05 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 222276 P2 Normal --- 1 lmoura lmoura aakash_jain ews-watchlist glenn jbedard oldest_to_newest 1653652 0 lmoura 2020-05-18 10:25:04 -0700 Recently bug212008 was opened to fix some tests from Source/WebKit/Scripts/webkit/messages_unittest.py failing in webkitpy step, but the patch did not trigger the webkitpy EWS bot, with EWS citing "No relevant changes". This is happening because webkitpy-ews only watches Tools/Scripts/webkitpy (in Tools/BuildSlaveSupport/ews-build/config.json) 1653655 1 399655 lmoura 2020-05-18 10:30:40 -0700 Created attachment 399655 Patch 1653842 2 399655 ap 2020-05-18 18:05:28 -0700 Comment on attachment 399655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399655&action=review > Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py:69 > + "Source/WebKit/Scripts/webkit/", Seeing that test-webkitpy exercises this code, sure. Not sure great that test-webkitpy tests code that is not webkitpy. 1822205 3 lmoura 2021-12-09 11:04:11 -0800 *** This bug has been marked as a duplicate of bug 222276 *** 399655 2020-05-18 10:30:40 -0700 2022-03-01 02:24:05 -0800 Patch bug-212031-20200518143039.patch text/plain 1519 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTc0MDFiN2U2OTRkMGEzZTI5OWExMjQ5NDUxOGFhZjRm N2U1Nzk1OC4uZmJjYTkyMjcwNmQ0ZDRhN2RmMWEzZjM4MTM1MzZjNjk0YjViMTM4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTA1LTE4ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIHdlYmtpdHB5OiBBZGQgU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdCBhcyByZWxldmFu dCBwYXRoIHRvIHdlYmtpdHB5LWV3cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEyMDMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHNvbWUgcHl0aG9uIHRlc3RzIGluIFNvdXJjZS9XZWJL aXQvU2NyaXB0cy93ZWJraXQgYWxvbmdzaWRlCisgICAgICAgIHRoZSByZWd1bGFyIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHl0LiBDaGFuZ2VzIGluIHRlc3RzIGluIGZvcm1lciBzaG91bGQKKyAgICAg ICAgYWxzbyB0cmlnZ2VyIHdlYmtpdHB5IEVXUyBib3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc3RlcHMvY2hlY2twYXRjaHJlbGV2YW5jZS5weToKKyAgICAgICAgKENoZWNr UGF0Y2hSZWxldmFuY2UpOiBBZGQgU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdCB0bworICAg ICAgICB3ZWJraXRweS1ld3MgcmVsZXZhbnQgcGF0aCBsaXN0LgorCiAyMDIwLTA1LTE4ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBB ZGQgV2ViS2l0Q29udGV4dE1lbnVJdGVtVHlwZSBmb3IgcGFzdGUgYXMgcGxhaW50ZXh0CmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY2hlY2twYXRjaHJlbGV2 YW5jZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jaGVja3BhdGNocmVs ZXZhbmNlLnB5CmluZGV4IDA0YTRhNDZlNTM1MmE3NzFlYzgzMTM0NjBjYTdkOTQ4YzdkZTY2YjMu LmNhODMyOTkzZTRkNGE2MGY1OGNjNTQ1YjQxNzdlYTRjMmM4YjhiMDcgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jaGVja3BhdGNocmVsZXZhbmNlLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jaGVja3BhdGNocmVsZXZhbmNl LnB5CkBAIC02Niw2ICs2Niw3IEBAIGNsYXNzIENoZWNrUGF0Y2hSZWxldmFuY2UoQWJzdHJhY3RT dGVwKToKIAogICAgIHdlYmtpdHB5X3BhdGhzID0gWwogICAgICAgICAiVG9vbHMvU2NyaXB0cy93 ZWJraXRweS8iLAorICAgICAgICAiU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC8iLAogICAg IF0KIAogICAgIGdyb3VwX3RvX3BhdGhzX21hcHBpbmcgPSB7Cg==