212030 2020-05-18 10:07:38 -0700 [Win] Fix AppleWin build 2020-05-18 11:37:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr webkit-bug-importer oldest_to_newest 1653646 0 pvollan 2020-05-18 10:07:38 -0700 Building WebCore fails with the following error: rendering/style/StyleRareInheritedData.cpp(74,1): error C2338: StyleRareInheritedData_should_bit_pack 1653647 1 pvollan 2020-05-18 10:08:16 -0700 rdar://problem/63344903 1653649 2 399654 pvollan 2020-05-18 10:12:32 -0700 Created attachment 399654 Patch 1653683 3 399654 bfulgham 2020-05-18 11:19:53 -0700 Comment on attachment 399654 Patch How could EWS not catch this? r=me! 1653684 4 pvollan 2020-05-18 11:21:43 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 399654 [details] > Patch > > How could EWS not catch this? r=me! I am not sure, the EWS builders are fine without this change. There might be a difference in MSVC version. Thanks for reviewing! 1653691 5 ews-feeder 2020-05-18 11:36:59 -0700 Committed r261823: <https://trac.webkit.org/changeset/261823> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399654. 399654 2020-05-18 10:12:32 -0700 2020-05-18 11:37:00 -0700 Patch bug-212030-20200518101231.patch text/plain 1361 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MTgxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBGaXggQXBwbGVX aW4gYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMjAzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZSBidWlsZCBmYWlscyBiZWNhdXNlIHRoZSBudW1iZXIgb2YgYml0ZmllbGRzIGluIEdyZWF0 ZXJUaGFuT3JTYW1lU2l6ZUFzU3R5bGVSYXJlSW5oZXJpdGVkRGF0YSBkb2VzIG5vdCBtYXRjaCB0 aGUKKyAgICAgICAgYWN0dWFsIG51bWJlciBvZiBiaXRmaWVsZHMgaW4gU3R5bGVSYXJlSW5oZXJp dGVkRGF0YS4KKworICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWRE YXRhLmNwcDoKKwogMjAyMC0wNS0xOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtMRkNdW1RGQ10gQWRkIHN1cHBvcnQgZm9yIGNvbXB1dGluZyB0aGUgY29sbGFw c2VkIHRhYmxlIGJvcmRlcgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0 eWxlUmFyZUluaGVyaXRlZERhdGEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmNwcAkocmV2aXNpb24gMjYxNzQ1 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERh dGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSw3ICs0OSw3IEBAIHN0cnVjdCBHcmVhdGVyVGhh bk9yU2FtZVNpemVBc1N0eWxlUmFyZUkKICAgICBUZXh0VW5kZXJsaW5lT2Zmc2V0IG9mZnNldDsK ICAgICBUZXh0RGVjb3JhdGlvblRoaWNrbmVzcyB0aGlja25lc3M7CiAgICAgdm9pZCogY3VzdG9t UHJvcGVydHlEYXRhUmVmc1sxXTsKLSAgICB1bnNpZ25lZCBiaXRmaWVsZHNbNF07CisgICAgdW5z aWduZWQgYml0ZmllbGRzWzZdOwogICAgIHNob3J0IHBhZ2VkTWVkaWFTaG9ydHNbMl07CiAgICAg VGFiU2l6ZSB0YWJTaXplOwogICAgIHNob3J0IGh5cGhlbmF0aW9uU2hvcnRzWzNdOwo=