212026 2020-05-18 07:58:40 -0700 [GTK] Allow gtk-doc and introspection in cross builds 2020-05-18 13:38:07 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro annulen aperez bugs-noreply ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio oldest_to_newest 1653608 0 mcatanzaro 2020-05-18 07:58:40 -0700 See https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/76 OptionsGTK.cmake contains: # Override the cached variables, gtk-doc and gobject-introspection do not really work when cross-building. if (CMAKE_CROSSCOMPILING) set(ENABLE_GTKDOC OFF) set(ENABLE_INTROSPECTION OFF) endif () But in fact, if we remove these lines, cross building works perfectly fine. We've been patching out these lines when building the GNOME runtimes because we cross-build i386 and armv7 packages and obviously need introspection to work. These lines were added way back in r186259, so I can only presume something has changed somewhere such that it's no longer a problem, because both work perfectly fine. We have very simple CMake toolchain files that just set CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR, which is minimum required when cross building with CMake, so if it works for us I assume it should work for anyone.... 1653609 1 399647 mcatanzaro 2020-05-18 08:00:12 -0700 Created attachment 399647 Patch 1653630 2 399647 aperez 2020-05-18 09:14:30 -0700 Comment on attachment 399647 Patch I think this is from before the times packagers figured out that they could run gtk-doc and/or g-ir-scanner/g-ir-generate using qemu userspace emulation to allow running code for the target platform when doing a cross-compiled build. While that's a terrible hack and ideally GTK-Doc and GI should support cross-compilation better, it's true that it is no longer needed to forcibly disable these two options 🤔️ Let's land this. 1653634 3 ews-feeder 2020-05-18 09:20:13 -0700 Committed r261814: <https://trac.webkit.org/changeset/261814> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399647. 1653644 4 mcatanzaro 2020-05-18 10:00:48 -0700 I'm pretty sure we're not using qemu or anything special? *shrug* 1653735 5 aperez 2020-05-18 13:22:13 -0700 (In reply to Michael Catanzaro from comment #4) > I'm pretty sure we're not using qemu or anything special? *shrug* In case you feel like doing some oddball build tooling archeology... I have no idea how Fedora (which I suppose is the “we” there) wrangles this, but I am sure that's how Yocto and Buildroot do it: https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/classes/gobject-introspection.bbclass#n28 https://git.busybox.net/buildroot/tree/package/gobject-introspection/gobject-introspection.mk#n96 As for Flatpak, if you do a cross-build the whole build sandbox runs inside the qemu userspace emulator. 1653746 6 mcatanzaro 2020-05-18 13:36:55 -0700 (In reply to Adrian Perez from comment #5) > I have no idea how Fedora (which I suppose is the “we” there) wrangles > this, but I am sure that's how Yocto and Buildroot do it: No, Fedora never cross builds anything, we do native builds only. Maybe armv7 builds are done in a VM or something, dunno. Here "we" is GNOME, I'm trying to upstream this GNOME patch. > As for Flatpak, if you do a cross-build the whole build sandbox runs > inside the qemu userspace emulator. Probably that explains why it works for GNOME. 1653749 7 mcatanzaro 2020-05-18 13:38:07 -0700 (In reply to Michael Catanzaro from comment #6) > No, Fedora never cross builds anything, we do native builds only. Maybe > armv7 builds are done in a VM or something, dunno. Here "we" is GNOME, I'm > trying to upstream this GNOME patch. Ugh, sorry. There "we" in the first sentence meant Fedora, and in the third second meant GNOME. I can probably change my "we" multiple times in the same sentence if not careful. So many hats.... 399647 2020-05-18 08:00:12 -0700 2020-05-18 09:20:14 -0700 Patch bug-212026-20200518100010.patch text/plain 1309 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGIxYWMy NjYwNDk2ZTBlMjUwYTU4MDYzYmU1Zjk3MGNmMzhjN2VhN2EuLjU3ZjIwN2RjYzY0ODEyMmNiMmU2 NzE4ZTlmNDhlYjYwZjlhNGFkN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC00MjUsMTIgKzQy NSw2IEBAIGlmIChFTkFCTEVEX0NPTVBJTEVSX1NBTklUSVpFUlMpCiAgICAgc2V0KEVOQUJMRV9J TlRST1NQRUNUSU9OIE9GRikKIGVuZGlmICgpCiAKLSMgT3ZlcnJpZGUgdGhlIGNhY2hlZCB2YXJp YWJsZXMsIGd0ay1kb2MgYW5kIGdvYmplY3QtaW50cm9zcGVjdGlvbiBkbyBub3QgcmVhbGx5IHdv cmsgd2hlbiBjcm9zcy1idWlsZGluZy4KLWlmIChDTUFLRV9DUk9TU0NPTVBJTElORykKLSAgICBz ZXQoRU5BQkxFX0dUS0RPQyBPRkYpCi0gICAgc2V0KEVOQUJMRV9JTlRST1NQRUNUSU9OIE9GRikK LWVuZGlmICgpCi0KICMgT3ZlcnJpZGUgdGhlIGNhY2hlZCB2YXJpYWJsZSwgZ3RrLWRvYyBkb2Vz IG5vdCByZWFsbHkgd29yayB3aGVuIGJ1aWxkaW5nIG9uIE1hYy4KIGlmIChBUFBMRSkKICAgICBz ZXQoRU5BQkxFX0dUS0RPQyBPRkYpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cK aW5kZXggMWI2YTBjYTk2ZWRhOGI1ZDRiNjY1Y2ZmMDZmZjQwY2I3OWM3YjEwYi4uZTYyZDBkNjgz NDZlYjI4NWY0ZmEwNjcwNjBlZDRkOGQ2MmQ2MzRlYSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisr KyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTE4ICBNaWNoYWVsIENhdGFu emFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEFsbG93IGd0ay1k b2MgYW5kIGludHJvc3BlY3Rpb24gaW4gY3Jvc3MgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTIwMjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9wIGRpc2FibGluZyB0aGVzZSBvcHRpb25z IGluIGNyb3NzIGJ1aWxkcy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNt YWtlOgorCiAyMDIwLTA1LTEwICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBzb255LmNv bT4KIAogICAgICAgICBBZGQgRU5BQkxFX1BFUklPRElDX01FTU9SWV9NT05JVE9SIGZsYWcuCg==