212006 2020-05-17 19:17:48 -0700 [JSC] Silence unused-but-set-parameter warnings for older compilers 2020-05-18 06:19:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211701 InRadar P2 Normal --- 1 lmoura lmoura ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1653468 0 lmoura 2020-05-17 19:17:48 -0700 After r261754, older compilers (GCC up to 9.x) complain about the `sources` parameter being set but not used when NumberOfRegisters is zero. The same may happen to destinations when both NumberOfRegisters is zero and ASSERT_ENABLE is false. Example: In file included from ../../Source/JavaScriptCore/jit/Snippet.h:31, from ../../Source/JavaScriptCore/domjit/DOMJITCallDOMGetterSnippet.h:31, from ../../Source/JavaScriptCore/domjit/DOMJITGetterSetter.h:28, from ../../Source/JavaScriptCore/runtime/Lookup.h:26, from ../../Source/JavaScriptCore/runtime/JSObjectInlines.h:32, from ../../Source/JavaScriptCore/runtime/JSCInlines.h:48, from ../../Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.cpp:29, from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f0a787a9-9.cpp:3: ../../Source/JavaScriptCore/jit/CCallHelpers.h: In instantiation of ‘void JSC::CCallHelpers::setupStubArgs(std::array<RegType, NumberOfRegisters>, std::array<RegType, NumberOfRegisters>) [with unsigned int NumberOfRegisters = 0; RegType = JSC::X86Registers::RegisterID]’: ../../Source/JavaScriptCore/jit/CCallHelpers.h:645:9: required from ‘void JSC::CCallHelpers::setupArgumentsImpl(JSC::CCallHelpers::ArgCollection<numGPRArgs, numGPRSources, numFPRArgs, numFPRSources, numCrossSources, extraGPRArgs, extraPoke>) [with OperationType = void(JSC::VM*); unsigned int numGPRArgs = 1; unsigned int numGPRSources = 0; unsigned int numFPRArgs = 0; unsigned int numFPRSources = 0; unsigned int numCrossSources = 0; unsigned int extraGPRArgs = 0; unsigned int extraPoke = 0]’ ../../Source/JavaScriptCore/jit/CCallHelpers.h:585:13: required from ‘std::enable_if_t<(std::is_base_of<JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImm, Arg>::value || std::is_convertible<Arg, JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImm>::value)> JSC::CCallHelpers::setupArgumentsImpl(JSC::CCallHelpers::ArgCollection<numGPRArgs, numGPRSources, numFPRArgs, numFPRSources, numCrossSources, extraGPRArgs, extraPoke>, Arg, Args ...) [with OperationType = void(JSC::VM*); unsigned int numGPRArgs = 0; unsigned int numGPRSources = 0; unsigned int numFPRArgs = 0; unsigned int numFPRSources = 0; unsigned int numCrossSources = 0; unsigned int extraGPRArgs = 0; unsigned int extraPoke = 0; Arg = JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImmPtr; Args = {}; std::enable_if_t<(std::is_base_of<JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImm, Arg>::value || std::is_convertible<Arg, JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImm>::value)> = void]’ ../../Source/JavaScriptCore/jit/CCallHelpers.h:675:9: required from ‘std::enable_if_t<(! std::is_same<typename WTF::FunctionTraits<T>::ArgumentType<0>, JSC::CallFrame*>::value)> JSC::CCallHelpers::setupArguments(Args ...) [with OperationType = void(JSC::VM*); Args = {JSC::AbstractMacroAssembler<JSC::X86Assembler>::TrustedImmPtr}; std::enable_if_t<(! std::is_same<typename WTF::FunctionTraits<T>::ArgumentType<0>, JSC::CallFrame*>::value)> = void]’ ../../Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:215:106: required from here ../../Source/JavaScriptCore/jit/CCallHelpers.h:90:130: warning: parameter ‘sources’ set but not used [-Wunused-but-set-parameter] 90 | ALWAYS_INLINE void setupStubArgs(std::array<RegType, NumberOfRegisters> destinations, std::array<RegType, NumberOfRegisters> sources) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ 1653469 1 399614 lmoura 2020-05-17 19:21:36 -0700 Created attachment 399614 Patch 1653475 2 399614 mark.lam 2020-05-17 20:50:19 -0700 Comment on attachment 399614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399614&action=review > Source/JavaScriptCore/jit/CCallHelpers.h:111 > + // Silence some older compilers (GCC up to 9.X) about unused but set parameters. > + (void)sources; > + (void)destinations; We have standard idiom for this: see uses of UNUSED_PARAM in the code. 1653479 3 399619 lmoura 2020-05-17 21:05:09 -0700 Created attachment 399619 Updated patch with UNUSED_PARAM 1653490 4 ews-feeder 2020-05-17 22:15:10 -0700 Committed r261797: <https://trac.webkit.org/changeset/261797> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399619. 1653491 5 webkit-bug-importer 2020-05-17 22:16:18 -0700 <rdar://problem/63327291> 1653572 6 mcatanzaro 2020-05-18 06:19:16 -0700 Thanks for keeping the build clean. :) 399614 2020-05-17 19:21:36 -0700 2020-05-17 21:05:05 -0700 Patch bug-212006-20200517232135.patch text/plain 1600 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx OGNlYzVhMTQ1ZmM1ZTIwMjZlMWYyN2RlOGRkNzk3NTAxN2RiNDIxLi5hOGFhNDkzNWNhYzZhYmY3 ZDViNDIzNjVmOThmZDk2MWY1ODAyMzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNS0xNyAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4K KworICAgICAgICBbSlNDXSBTaWxlbmNlIHVudXNlZC1idXQtc2V0LXBhcmFtZXRlciB3YXJuaW5n cyBmb3Igb2xkZXIgY29tcGlsZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTIwMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBHQ0MgdXAgdG8gOS54IHdpbGwgZW1pdCB1bnVzZWQtYnV0LXNldC1wYXJh bWV0ZXIgZm9yIHRoZSBzb3VyY2VzCisgICAgICAgIHBhcmFtZXRlciB3aGVuIE51bWJlck9mUmVn aXN0ZXJzIGlzIHplcm8gKHRoZSBpZiBibG9jayBpcyBlbGltaW5hdGVkKQorICAgICAgICBhbmQg Zm9yIGRlc3RpbmF0aW9ucyB3aGVuIGFsc28gQVNTRVJUX0VOQUJMRUQgaXMgZmFsc2UuCisKKyAg ICAgICAgKiBqaXQvQ0NhbGxIZWxwZXJzLmg6CisgICAgICAgIChKU0M6OkNDYWxsSGVscGVyczo6 c2V0dXBTdHViQXJncyk6CisKIDIwMjAtMDUtMTYgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFw cGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBNYWtlIE91dE9mTWVtb3J5IGVycm9yIGFzIGluc3Rh bmNlIG9mIFJhbmdlRXJyb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv Q0NhbGxIZWxwZXJzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxsSGVscGVycy5o CmluZGV4IDIwYjk1ODZmZDQwYWUyYmFkMWQzYWMyMDk4OThjODAwOWY3ZWExZGUuLmVhM2ZhZWRi Mzk3YTU1MDY0ODUzNzFjMGYyYjdlYTIyODMzODUyZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9DQ2FsbEhlbHBlcnMuaApAQCAtMTA1LDYgKzEwNSwxMCBAQCBwcml2YXRlOgogICAgICAg ICAgICAgICAgIGlmIChzb3VyY2VzW2ldICE9IGRlc3RpbmF0aW9uc1tpXSkKICAgICAgICAgICAg ICAgICAgICAgcGFpcnMuYXBwZW5kKHN0ZDo6bWFrZV9wYWlyKHNvdXJjZXNbaV0sIGRlc3RpbmF0 aW9uc1tpXSkpOwogICAgICAgICAgICAgfQorICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAg Ly8gU2lsZW5jZSBzb21lIG9sZGVyIGNvbXBpbGVycyAoR0NDIHVwIHRvIDkuWCkgYWJvdXQgdW51 c2VkIGJ1dCBzZXQgcGFyYW1ldGVycy4KKyAgICAgICAgICAgICh2b2lkKXNvdXJjZXM7CisgICAg ICAgICAgICAodm9pZClkZXN0aW5hdGlvbnM7CiAgICAgICAgIH0KIAogI2lmIEFTU0VSVF9FTkFC TEVECg== 399619 2020-05-17 21:05:09 -0700 2020-05-17 22:15:11 -0700 Updated patch with UNUSED_PARAM bug-212006-20200518010508.patch text/plain 1616 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx OGNlYzVhMTQ1ZmM1ZTIwMjZlMWYyN2RlOGRkNzk3NTAxN2RiNDIxLi5hOGFhNDkzNWNhYzZhYmY3 ZDViNDIzNjVmOThmZDk2MWY1ODAyMzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNS0xNyAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4K KworICAgICAgICBbSlNDXSBTaWxlbmNlIHVudXNlZC1idXQtc2V0LXBhcmFtZXRlciB3YXJuaW5n cyBmb3Igb2xkZXIgY29tcGlsZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTIwMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBHQ0MgdXAgdG8gOS54IHdpbGwgZW1pdCB1bnVzZWQtYnV0LXNldC1wYXJh bWV0ZXIgZm9yIHRoZSBzb3VyY2VzCisgICAgICAgIHBhcmFtZXRlciB3aGVuIE51bWJlck9mUmVn aXN0ZXJzIGlzIHplcm8gKHRoZSBpZiBibG9jayBpcyBlbGltaW5hdGVkKQorICAgICAgICBhbmQg Zm9yIGRlc3RpbmF0aW9ucyB3aGVuIGFsc28gQVNTRVJUX0VOQUJMRUQgaXMgZmFsc2UuCisKKyAg ICAgICAgKiBqaXQvQ0NhbGxIZWxwZXJzLmg6CisgICAgICAgIChKU0M6OkNDYWxsSGVscGVyczo6 c2V0dXBTdHViQXJncyk6CisKIDIwMjAtMDUtMTYgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFw cGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBNYWtlIE91dE9mTWVtb3J5IGVycm9yIGFzIGluc3Rh bmNlIG9mIFJhbmdlRXJyb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv Q0NhbGxIZWxwZXJzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxsSGVscGVycy5o CmluZGV4IDIwYjk1ODZmZDQwYWUyYmFkMWQzYWMyMDk4OThjODAwOWY3ZWExZGUuLjIzNTA1MDRh OGU5OTk4OGVhMDdlZDBmMDdlZDhhMTFkMjQ0ZTg0MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9DQ2FsbEhlbHBlcnMuaApAQCAtMTA1LDYgKzEwNSwxMCBAQCBwcml2YXRlOgogICAgICAg ICAgICAgICAgIGlmIChzb3VyY2VzW2ldICE9IGRlc3RpbmF0aW9uc1tpXSkKICAgICAgICAgICAg ICAgICAgICAgcGFpcnMuYXBwZW5kKHN0ZDo6bWFrZV9wYWlyKHNvdXJjZXNbaV0sIGRlc3RpbmF0 aW9uc1tpXSkpOwogICAgICAgICAgICAgfQorICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAg Ly8gU2lsZW5jZSBzb21lIG9sZGVyIGNvbXBpbGVycyAoR0NDIHVwIHRvIDkuWCkgYWJvdXQgdW51 c2VkIGJ1dCBzZXQgcGFyYW1ldGVycy4KKyAgICAgICAgICAgIFVOVVNFRF9QQVJBTShzb3VyY2Vz KTsKKyAgICAgICAgICAgIFVOVVNFRF9QQVJBTShkZXN0aW5hdGlvbnMpOwogICAgICAgICB9CiAK ICNpZiBBU1NFUlRfRU5BQkxFRAo=