211971 2020-05-15 15:32:17 -0700 OES_texture_float internal format conversion must depend on WEBGL_color_buffer_float 2020-05-15 16:58:17 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210994 210524 1 kbr kbr dino ews-watchlist graouts jdarpinian justin_fan kondapallykalyan webkit-bug-importer oldest_to_newest 1653199 0 kbr 2020-05-15 15:32:17 -0700 In Bug 210994, WebKit's OES_texture_float WebGL 1.0 extension implementation was changed to modify the internal format of incoming GL_RGB or GL_RGBA textures of type GL_FLOAT. This conversion must be made conditional in order to not break the extension on iOS when OES_texture_float is exposed, since WEBGL_color_buffer_float will not be exposed on those devices. 1653204 1 399520 kbr 2020-05-15 15:35:29 -0700 Created attachment 399520 Patch 1653234 2 ews-feeder 2020-05-15 16:57:28 -0700 Committed r261769: <https://trac.webkit.org/changeset/261769> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399520. 1653235 3 webkit-bug-importer 2020-05-15 16:58:17 -0700 <rdar://problem/63294727> 399520 2020-05-15 15:35:29 -0700 2020-05-15 16:57:28 -0700 Patch bug-211971-20200515153529.patch text/plain 5589 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjA0ZjI0YzYwZTU3Mzk1 MjFiNTM2ZGZhMTVlNzk5MTk1ZjRmMTM5NC4uNTA1NjQ3MTU3OWZhOGI5M2NmOGE0NTVhMTExNzkw OWFlYWY5ZWQ1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTE1ICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE9FU190ZXh0dXJlX2Zs b2F0IGludGVybmFsIGZvcm1hdCBjb252ZXJzaW9uIG11c3QgZGVwZW5kIG9uIFdFQkdMX2NvbG9y X2J1ZmZlcl9mbG9hdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjExOTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgT25seSBhZGp1c3QgdGhlIGludGVybmFsIGZvcm1hdHMgb2YgdGV4dHVyZXMgY3JlYXRl ZCBmb3IgdGhlIFdlYkdMCisgICAgICAgIDEuMCBPRVNfdGV4dHVyZV9mbG9hdCBleHRlbnNpb24g aWYgdGhlIFdFQkdMX2NvbG9yX2J1ZmZlcl9mbG9hdAorICAgICAgICBleHRlbnNpb24gaGFzIGJl ZW4gZW5hYmxlZC4KKworICAgICAgICBDb3ZlcmVkIGJ5IHRoZSBXZWJHTCAxLjAgT0VTX3RleHR1 cmVfZmxvYXQgY29uZm9ybWFuY2UgdGVzdHMgd2hlbgorICAgICAgICBydW4gb24gaU9TIHdpdGgg YW5vdGhlciBmb3J0aGNvbWluZyBmaXggdG8gQU5HTEUgd2hpY2ggd2lsbCBlbmFibGUKKyAgICAg ICAgdGhlIE9FU190ZXh0dXJlX2Zsb2F0IGV4dGVuc2lvbiBvbiB0aGF0IHBsYXRmb3JtLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5zaW9uc0dMQU5HTEUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uc0dMQU5HTEU6OmVuc3VyZUVuYWJsZWQpOgorICAg ICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uc0dMQU5HTEU6OmFkanVzdFdlYkdMMVRleHR1cmVJbnRl cm5hbEZvcm1hdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5zaW9u c0dMQU5HTEUuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGljc0Nv bnRleHRHTEFOR0xFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMT3Bl bkdMOjp0ZXhJbWFnZTJERGlyZWN0KToKKwogMjAyMC0wNS0xNSAgQW50b2luZSBRdWludCAgPGdy YW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWIgQW5pbWF0aW9uc10gQW5pbWF0aW9uIHdp dGggYSBzaW5nbGUga2V5ZnJhbWUgaXMgbm90IGFjY2VsZXJhdGVkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9FeHRlbnNpb25zR0xBTkdMRS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9FeHRlbnNpb25zR0xBTkdM RS5jcHAKaW5kZXggNGNjNGUyNWY0YmJhOTNmYzg3MjUzNzQyMzg0OTNlMDFjMWIzYzVhYS4uYmJk NmZkZjdhMGJkNTVhOWU0NzBiYzcwNTY2MWQ4MDU3NjNkMGU5NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5zaW9uc0dMQU5HTEUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0V4dGVuc2lvbnNHTEFO R0xFLmNwcApAQCAtODcsNiArODcsMTEgQEAgdm9pZCBFeHRlbnNpb25zR0xBTkdMRTo6ZW5zdXJl RW5hYmxlZChjb25zdCBTdHJpbmcmIG5hbWUpCiAgICAgICAgIG1fY29udGV4dC0+bWFrZUNvbnRl eHRDdXJyZW50KCk7CiAgICAgICAgIGdsOjpSZXF1ZXN0RXh0ZW5zaW9uQU5HTEUobmFtZS5hc2Np aSgpLmRhdGEoKSk7CiAgICAgICAgIG1fZW5hYmxlZEV4dGVuc2lvbnMuYWRkKG5hbWUpOworCisg ICAgICAgIGlmIChuYW1lID09ICJHTF9DSFJPTUlVTV9jb2xvcl9idWZmZXJfZmxvYXRfcmdiYSJf cykKKyAgICAgICAgICAgIG1fd2ViZ2xDb2xvckJ1ZmZlckZsb2F0UkdCQSA9IHRydWU7CisgICAg ICAgIGVsc2UgaWYgKG5hbWUgPT0gIkdMX0NIUk9NSVVNX2NvbG9yX2J1ZmZlcl9mbG9hdF9yZ2Ii X3MpCisgICAgICAgICAgICBtX3dlYmdsQ29sb3JCdWZmZXJGbG9hdFJHQiA9IHRydWU7CiAgICAg fQogfQogCkBAIC0yNDksMTMgKzI1NCwxMSBAQCBTdHJpbmcgRXh0ZW5zaW9uc0dMQU5HTEU6Omdl dEV4dGVuc2lvbnMoKQogR0NHTGVudW0gRXh0ZW5zaW9uc0dMQU5HTEU6OmFkanVzdFdlYkdMMVRl eHR1cmVJbnRlcm5hbEZvcm1hdChHQ0dMZW51bSBpbnRlcm5hbGZvcm1hdCwgR0NHTGVudW0gZm9y bWF0LCBHQ0dMZW51bSB0eXBlKQogewogICAgIC8vIFRoZSBpbXBsZW1lbnRhdGlvbiBvZiBXRUJH TF9jb2xvcl9idWZmZXJfZmxvYXQgZm9yIFdlYkdMIDEuMCAvIEVTIDIuMCByZXF1aXJlcyBhIHNp emVkCi0gICAgLy8gaW50ZXJuYWwgZm9ybWF0LiBBZGp1c3QgaXQgaWYgbmVjZXNzYXJ5IGF0IHRo aXMgbG93ZXN0IGxldmVsLiBOb3RlIHRoYXQgaXQgZG9lcyBub3QgbWF0dGVyIGF0Ci0gICAgLy8g dGhpcyBwb2ludCB3aGV0aGVyIHRoZSBXRUJHTF9jb2xvcl9idWZmZXJfZmxvYXQgZXh0ZW5zaW9u IGhhcyBhY3R1YWxseSBiZWVuIGVuYWJsZWQgYXQgaGlnaGVyCi0gICAgLy8gbGV2ZWxzOyB0aGUg ZW51bSB3aWxsIGJlIHZhbGlkIG9yIGludmFsaWQgZWl0aGVyIHdheS4KKyAgICAvLyBpbnRlcm5h bCBmb3JtYXQuIEFkanVzdCBpdCBpZiBuZWNlc3NhcnkgYXQgdGhpcyBsb3dlc3QgbGV2ZWwuCiAg ICAgaWYgKHR5cGUgPT0gR0xfRkxPQVQpIHsKLSAgICAgICAgaWYgKGZvcm1hdCA9PSBHTF9SR0JB ICYmIGludGVybmFsZm9ybWF0ID09IEdMX1JHQkEpCisgICAgICAgIGlmIChtX3dlYmdsQ29sb3JC dWZmZXJGbG9hdFJHQkEgJiYgZm9ybWF0ID09IEdMX1JHQkEgJiYgaW50ZXJuYWxmb3JtYXQgPT0g R0xfUkdCQSkKICAgICAgICAgICAgIHJldHVybiBHTF9SR0JBMzJGOwotICAgICAgICBpZiAoZm9y bWF0ID09IEdMX1JHQiAmJiBpbnRlcm5hbGZvcm1hdCA9PSBHTF9SR0IpCisgICAgICAgIGlmICht X3dlYmdsQ29sb3JCdWZmZXJGbG9hdFJHQiAmJiBmb3JtYXQgPT0gR0xfUkdCICYmIGludGVybmFs Zm9ybWF0ID09IEdMX1JHQikKICAgICAgICAgICAgIHJldHVybiBHTF9SR0IzMkY7CiAgICAgfQog ICAgIHJldHVybiBpbnRlcm5hbGZvcm1hdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0V4dGVuc2lvbnNHTEFOR0xFLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9FeHRlbnNpb25zR0xBTkdMRS5oCmluZGV4IGUwZjM3 MmVmN2Y3MDNiMzUwZTYzZGFhNGI3NmQ2MTM5MWJjNThkMWEuLmU4YWNkMWYxYmUzZDJkMDM3ODRl NTA5MzYzZmRjYzllNTNhNjQ2ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2FuZ2xlL0V4dGVuc2lvbnNHTEFOR0xFLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5zaW9uc0dMQU5HTEUuaApAQCAtMTQ4LDcgKzE0 OCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGdldFF1ZXJ5T2JqZWN0dWk2NHZSb2J1c3RBTkdMRShH Q0dMdWludCBpZCwgR0NHTGVudW0gcG5hbWUsIEdDR0xzaXplaSBidWZTaXplLCBHQ0dMc2l6ZWkg Kmxlbmd0aCwgR0NHTHVpbnQ2NCAqcGFyYW1zKSBvdmVycmlkZTsKIAogICAgIC8vIE9ubHkgZm9y IG5vbi1XZWJHTCAyLjAgY29udGV4dHMuCi0gICAgc3RhdGljIEdDR0xlbnVtIGFkanVzdFdlYkdM MVRleHR1cmVJbnRlcm5hbEZvcm1hdChHQ0dMZW51bSBpbnRlcm5hbGZvcm1hdCwgR0NHTGVudW0g Zm9ybWF0LCBHQ0dMZW51bSB0eXBlKTsKKyAgICBHQ0dMZW51bSBhZGp1c3RXZWJHTDFUZXh0dXJl SW50ZXJuYWxGb3JtYXQoR0NHTGVudW0gaW50ZXJuYWxmb3JtYXQsIEdDR0xlbnVtIGZvcm1hdCwg R0NHTGVudW0gdHlwZSk7CiAKIHByaXZhdGU6CiAgICAgYm9vbCBzdXBwb3J0c0V4dGVuc2lvbihj b25zdCBXVEY6OlN0cmluZyYpOwpAQCAtMTc0LDYgKzE3NCwxMCBAQCBwcml2YXRlOgogCiAgICAg U3RyaW5nIG1fdmVuZG9yOwogICAgIFN0cmluZyBtX3JlbmRlcmVyOworCisgICAgLy8gV2hldGhl ciB0aGUgV2ViR0wgMS4wLXJlbGF0ZWQgZmxvYXRpbmctcG9pbnQgcmVuZGVyYWJpbGl0eSBleHRl bnNpb25zIGhhdmUgYmVlbiBlbmFibGVkLgorICAgIGJvb2wgbV93ZWJnbENvbG9yQnVmZmVyRmxv YXRSR0IgeyBmYWxzZSB9OworICAgIGJvb2wgbV93ZWJnbENvbG9yQnVmZmVyRmxvYXRSR0JBIHsg ZmFsc2UgfTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dEdMQU5HTEUu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvR3JhcGhpY3NDb250 ZXh0R0xBTkdMRS5jcHAKaW5kZXggZGVkNjk0ZTJmMDBiZDQ2NWVhMTgyYzViOGM1MjEwZDE1OGNh OTRiNC4uM2E4NDZlYjE4YzZhMDY1OGE5MjU2ZGJlOTEzMDY0YTVhMDc4ZDc5YSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvR3JhcGhpY3NDb250ZXh0 R0xBTkdMRS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUv R3JhcGhpY3NDb250ZXh0R0xBTkdMRS5jcHAKQEAgLTE4ODgsOCArMTg4OCw4IEBAIHZvaWQgR3Jh cGhpY3NDb250ZXh0R0xPcGVuR0w6OmRpc3BhdGNoQ29udGV4dENoYW5nZWROb3RpZmljYXRpb24o KQogdm9pZCBHcmFwaGljc0NvbnRleHRHTE9wZW5HTDo6dGV4SW1hZ2UyRERpcmVjdChHQ0dMZW51 bSB0YXJnZXQsIEdDR0xpbnQgbGV2ZWwsIEdDR0xlbnVtIGludGVybmFsZm9ybWF0LCBHQ0dMc2l6 ZWkgd2lkdGgsIEdDR0xzaXplaSBoZWlnaHQsIEdDR0xpbnQgYm9yZGVyLCBHQ0dMZW51bSBmb3Jt YXQsIEdDR0xlbnVtIHR5cGUsIGNvbnN0IHZvaWQqIHBpeGVscykKIHsKICAgICBtYWtlQ29udGV4 dEN1cnJlbnQoKTsKLSAgICBpZiAoIW1faXNGb3JXZWJHTDIpCi0gICAgICAgIGludGVybmFsZm9y bWF0ID0gRXh0ZW5zaW9uc0dMQU5HTEU6OmFkanVzdFdlYkdMMVRleHR1cmVJbnRlcm5hbEZvcm1h dChpbnRlcm5hbGZvcm1hdCwgZm9ybWF0LCB0eXBlKTsKKyAgICBpZiAoIW1faXNGb3JXZWJHTDIg JiYgbV9leHRlbnNpb25zKQorICAgICAgICBpbnRlcm5hbGZvcm1hdCA9IG1fZXh0ZW5zaW9ucy0+ YWRqdXN0V2ViR0wxVGV4dHVyZUludGVybmFsRm9ybWF0KGludGVybmFsZm9ybWF0LCBmb3JtYXQs IHR5cGUpOwogICAgIGdsOjpUZXhJbWFnZTJEKHRhcmdldCwgbGV2ZWwsIGludGVybmFsZm9ybWF0 LCB3aWR0aCwgaGVpZ2h0LCBib3JkZXIsIGZvcm1hdCwgdHlwZSwgcGl4ZWxzKTsKICAgICBtX3N0 YXRlLnRleHR1cmVTZWVkQ291bnQuYWRkKG1fc3RhdGUuY3VycmVudEJvdW5kVGV4dHVyZSgpKTsK IH0K