21196 2008-09-28 09:51:44 -0700 Inspector search requests not cleared when deleting to 2 characters or less 2008-09-28 12:53:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy aroben kmccullough timothy oldest_to_newest 93147 0 timothy 2008-09-28 09:51:44 -0700 The Web Inspector does not auto-search when the query is less than 3 characters. So deleting to only 2 characters leaves the previous results and does not clear them unless you delete everything or do a new search. 93148 1 23894 timothy 2008-09-28 09:57:25 -0700 Created attachment 23894 Proposed patch 93149 2 23895 timothy 2008-09-28 09:57:25 -0700 Created attachment 23895 Proposed patch 93169 3 23894 mitz 2008-09-28 12:49:42 -0700 Comment on attachment 23894 Proposed patch r=me 93170 4 timothy 2008-09-28 12:53:13 -0700 Landed in r37044. 23894 2008-09-28 09:57:25 -0700 2008-09-28 12:49:42 -0700 Proposed patch 0001--Clear-the-current-search-results-in-the-Insp.patch text/plain 2837 timothy RnJvbSA4YjFjM2FhNTQ0ZmY1MTM1ZWU3ZWY1YWE2N2VlZDE0NTFiNzM4NGRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBTdW4sIDI4IFNlcCAyMDA4IDA5OjU2OjQyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBDbGVhciB0aGUgY3VycmVudCBzZWFyY2ggcmVzdWx0cyBpbiB0aGUgSW5zcGVjdG9yIHdo ZW4KICAgICAgICAgdGhlIHNlYXJjaCBxdWVyeSBpcyBsZXNzIHRoYW4gMyBjaGFyYWN0ZXJzIGxv bmcuIEluY3JlbWVudGFsCiAgICAgICAgIHNlYXJjaGVzIG9ubHkgb2NjdXIgZm9yIDMgY2hhcmFj dGVycyBvciBsb25nZXIsIGJ1dCBkZWxldGluZwogICAgICAgICB1bmRlciB0aGlzIGxpbWl0IHdv dWxkIG5vdCBjbGVhciB0aGUgcmVzdWx0cyB1bmxlc3MgdGhlIHdob2xlCiAgICAgICAgIHF1ZXJ5 IHdhcyBkZWxldGVkLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjExOTYKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAg ICogcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzOgogICAgICAgIChXZWJJbnNwZWN0b3IucGVy Zm9ybVNlYXJjaCk6IENoZWNrIGZvciBzaG9ydCBxdWVyaWVzIGluIHRoZQogICAgICAgIGlmIHN0 YXRlbWVudCB0aGF0IHRyaWdnZXJzIHRoZSBjbGVhci4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL2lu c3BlY3Rvci9pbnNwZWN0b3IuanMgfCAgICA3ICsrLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTgg aW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDJhYmM5MjMuLjA3NTE5MzMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMDgtMDktMjggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgor CisgICAgICAgIENsZWFyIHRoZSBjdXJyZW50IHNlYXJjaCByZXN1bHRzIGluIHRoZSBJbnNwZWN0 b3Igd2hlbgorICAgICAgICB0aGUgc2VhcmNoIHF1ZXJ5IGlzIGxlc3MgdGhhbiAzIGNoYXJhY3Rl cnMgbG9uZy4gSW5jcmVtZW50YWwKKyAgICAgICAgc2VhcmNoZXMgb25seSBvY2N1ciBmb3IgMyBj aGFyYWN0ZXJzIG9yIGxvbmdlciwgYnV0IGRlbGV0aW5nCisgICAgICAgIHVuZGVyIHRoaXMgbGlt aXQgd291bGQgbm90IGNsZWFyIHRoZSByZXN1bHRzIHVubGVzcyB0aGUgd2hvbGUKKyAgICAgICAg cXVlcnkgd2FzIGRlbGV0ZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IucGVyZm9ybVNlYXJjaCk6IENoZWNrIGZvciBzaG9ydCBxdWVyaWVzIGluIHRoZQor ICAgICAgICBpZiBzdGF0ZW1lbnQgdGhhdCB0cmlnZ2VycyB0aGUgY2xlYXIuCisKIDIwMDgtMDkt MjggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcgKGV4Y2VwdCBmb3IgYSBmZXcgY29tbWVudCBhbmQgaGVhZGVyIHR3ZWFrcyku CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qcyBiL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCmluZGV4IDQyNTllNTAuLjY2M2RmZjUgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCkBAIC0xMDk5LDggKzEwOTksOSBAQCBXZWJJ bnNwZWN0b3Iuc2VhcmNoS2V5VXAgPSBmdW5jdGlvbihldmVudCkKIFdlYkluc3BlY3Rvci5wZXJm b3JtU2VhcmNoID0gZnVuY3Rpb24oZXZlbnQpCiB7CiAgICAgdmFyIHF1ZXJ5ID0gZXZlbnQudGFy Z2V0LnZhbHVlOworICAgIHZhciBmb3JjZVNlYXJjaCA9IGV2ZW50LmtleUlkZW50aWZpZXIgPT09 ICJFbnRlciI7CiAKLSAgICBpZiAoIXF1ZXJ5IHx8ICFxdWVyeS5sZW5ndGgpIHsKKyAgICBpZiAo IXF1ZXJ5IHx8ICFxdWVyeS5sZW5ndGggfHwgKCFmb3JjZVNlYXJjaCAmJiBxdWVyeS5sZW5ndGgg PCAzKSkgewogICAgICAgICBkZWxldGUgdGhpcy5jdXJyZW50UXVlcnk7CiAKICAgICAgICAgZm9y ICh2YXIgcGFuZWxOYW1lIGluIHRoaXMucGFuZWxzKSB7CkBAIC0xMTE1LDEwICsxMTE2LDYgQEAg V2ViSW5zcGVjdG9yLnBlcmZvcm1TZWFyY2ggPSBmdW5jdGlvbihldmVudCkKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAotICAgIHZhciBmb3JjZVNlYXJjaCA9IGV2ZW50LmtleUlkZW50aWZpZXIg PT09ICJFbnRlciI7Ci0gICAgaWYgKCFmb3JjZVNlYXJjaCAmJiBxdWVyeS5sZW5ndGggPCAzKQot ICAgICAgICByZXR1cm47Ci0KICAgICBpZiAocXVlcnkgPT09IHRoaXMuY3VycmVudFBhbmVsLmN1 cnJlbnRRdWVyeSAmJiB0aGlzLmN1cnJlbnRQYW5lbC5jdXJyZW50UXVlcnkgPT09IHRoaXMuY3Vy cmVudFF1ZXJ5KSB7CiAgICAgICAgIC8vIFdoZW4gdGhpcyBpcyB0aGUgc2FtZSBxdWVyeSBhbmQg YSBmb3JjZWQgc2VhcmNoLCBqdW1wIHRvIHRoZSBuZXh0CiAgICAgICAgIC8vIHNlYXJjaCByZXN1 bHQgZm9yIGEgZ29vZCB1c2VyIGV4cGVyaWVuY2UuCi0tIAoxLjYuMC4yCgo= 23895 2008-09-28 09:57:25 -0700 2008-09-28 09:57:39 -0700 Proposed patch 0001--Clear-the-current-search-results-in-the-Insp.patch text/plain 2837 timothy RnJvbSA4YjFjM2FhNTQ0ZmY1MTM1ZWU3ZWY1YWE2N2VlZDE0NTFiNzM4NGRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBTdW4sIDI4IFNlcCAyMDA4IDA5OjU2OjQyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBDbGVhciB0aGUgY3VycmVudCBzZWFyY2ggcmVzdWx0cyBpbiB0aGUgSW5zcGVjdG9yIHdo ZW4KICAgICAgICAgdGhlIHNlYXJjaCBxdWVyeSBpcyBsZXNzIHRoYW4gMyBjaGFyYWN0ZXJzIGxv bmcuIEluY3JlbWVudGFsCiAgICAgICAgIHNlYXJjaGVzIG9ubHkgb2NjdXIgZm9yIDMgY2hhcmFj dGVycyBvciBsb25nZXIsIGJ1dCBkZWxldGluZwogICAgICAgICB1bmRlciB0aGlzIGxpbWl0IHdv dWxkIG5vdCBjbGVhciB0aGUgcmVzdWx0cyB1bmxlc3MgdGhlIHdob2xlCiAgICAgICAgIHF1ZXJ5 IHdhcyBkZWxldGVkLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjExOTYKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAg ICogcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzOgogICAgICAgIChXZWJJbnNwZWN0b3IucGVy Zm9ybVNlYXJjaCk6IENoZWNrIGZvciBzaG9ydCBxdWVyaWVzIGluIHRoZQogICAgICAgIGlmIHN0 YXRlbWVudCB0aGF0IHRyaWdnZXJzIHRoZSBjbGVhci4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL2lu c3BlY3Rvci9pbnNwZWN0b3IuanMgfCAgICA3ICsrLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTgg aW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDJhYmM5MjMuLjA3NTE5MzMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMDgtMDktMjggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgor CisgICAgICAgIENsZWFyIHRoZSBjdXJyZW50IHNlYXJjaCByZXN1bHRzIGluIHRoZSBJbnNwZWN0 b3Igd2hlbgorICAgICAgICB0aGUgc2VhcmNoIHF1ZXJ5IGlzIGxlc3MgdGhhbiAzIGNoYXJhY3Rl cnMgbG9uZy4gSW5jcmVtZW50YWwKKyAgICAgICAgc2VhcmNoZXMgb25seSBvY2N1ciBmb3IgMyBj aGFyYWN0ZXJzIG9yIGxvbmdlciwgYnV0IGRlbGV0aW5nCisgICAgICAgIHVuZGVyIHRoaXMgbGlt aXQgd291bGQgbm90IGNsZWFyIHRoZSByZXN1bHRzIHVubGVzcyB0aGUgd2hvbGUKKyAgICAgICAg cXVlcnkgd2FzIGRlbGV0ZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IucGVyZm9ybVNlYXJjaCk6IENoZWNrIGZvciBzaG9ydCBxdWVyaWVzIGluIHRoZQor ICAgICAgICBpZiBzdGF0ZW1lbnQgdGhhdCB0cmlnZ2VycyB0aGUgY2xlYXIuCisKIDIwMDgtMDkt MjggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcgKGV4Y2VwdCBmb3IgYSBmZXcgY29tbWVudCBhbmQgaGVhZGVyIHR3ZWFrcyku CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qcyBiL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCmluZGV4IDQyNTllNTAuLjY2M2RmZjUgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCkBAIC0xMDk5LDggKzEwOTksOSBAQCBXZWJJ bnNwZWN0b3Iuc2VhcmNoS2V5VXAgPSBmdW5jdGlvbihldmVudCkKIFdlYkluc3BlY3Rvci5wZXJm b3JtU2VhcmNoID0gZnVuY3Rpb24oZXZlbnQpCiB7CiAgICAgdmFyIHF1ZXJ5ID0gZXZlbnQudGFy Z2V0LnZhbHVlOworICAgIHZhciBmb3JjZVNlYXJjaCA9IGV2ZW50LmtleUlkZW50aWZpZXIgPT09 ICJFbnRlciI7CiAKLSAgICBpZiAoIXF1ZXJ5IHx8ICFxdWVyeS5sZW5ndGgpIHsKKyAgICBpZiAo IXF1ZXJ5IHx8ICFxdWVyeS5sZW5ndGggfHwgKCFmb3JjZVNlYXJjaCAmJiBxdWVyeS5sZW5ndGgg PCAzKSkgewogICAgICAgICBkZWxldGUgdGhpcy5jdXJyZW50UXVlcnk7CiAKICAgICAgICAgZm9y ICh2YXIgcGFuZWxOYW1lIGluIHRoaXMucGFuZWxzKSB7CkBAIC0xMTE1LDEwICsxMTE2LDYgQEAg V2ViSW5zcGVjdG9yLnBlcmZvcm1TZWFyY2ggPSBmdW5jdGlvbihldmVudCkKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAotICAgIHZhciBmb3JjZVNlYXJjaCA9IGV2ZW50LmtleUlkZW50aWZpZXIg PT09ICJFbnRlciI7Ci0gICAgaWYgKCFmb3JjZVNlYXJjaCAmJiBxdWVyeS5sZW5ndGggPCAzKQot ICAgICAgICByZXR1cm47Ci0KICAgICBpZiAocXVlcnkgPT09IHRoaXMuY3VycmVudFBhbmVsLmN1 cnJlbnRRdWVyeSAmJiB0aGlzLmN1cnJlbnRQYW5lbC5jdXJyZW50UXVlcnkgPT09IHRoaXMuY3Vy cmVudFF1ZXJ5KSB7CiAgICAgICAgIC8vIFdoZW4gdGhpcyBpcyB0aGUgc2FtZSBxdWVyeSBhbmQg YSBmb3JjZWQgc2VhcmNoLCBqdW1wIHRvIHRoZSBuZXh0CiAgICAgICAgIC8vIHNlYXJjaCByZXN1 bHQgZm9yIGEgZ29vZCB1c2VyIGV4cGVyaWVuY2UuCi0tIAoxLjYuMC4yCgo=