211958 2020-05-15 08:54:43 -0700 REGRESSION: [ iOS wk2 Debug ] multiple fast/text/international/system-language tests are flaky crashing - WTFCrashWithInfo - WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 2020-05-26 13:38:31 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build iPhone / iPad iOS 13 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211928 https://bugs.webkit.org/show_bug.cgi?id=211929 InRadar P2 Normal --- 211929 1 Lawrence.j katherine_cheney darin katherine_cheney mmaxfield webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1653070 0 Lawrence.j 2020-05-15 08:54:43 -0700 fast/text/international/system-language/han-quotes.html fast/text/international/system-language/navigator-language/navigator-language-es-419.html fast/text/international/system-language/navigator-language/navigator-language-hi.html fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html Description: These tests are flaky crashing on iOS wk2 Debug. The earliest crash appears on 5/13/2020. History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fhan-quotes.html&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fnavigator-language%2Fnavigator-language-es-419.html&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fnavigator-language%2Fnavigator-language-hi.html&test=fast%2Ftext%2Finternational%2Fsystem-language%2Fnavigator-language%2Fnavigator-language-pt-PT.html&platform=ios&style=debug Crash log: No crash log found for com.apple.WebKit.Networking.Development:79072. stdout: stderr: ERROR: SQLite database failed to set journal_mode to WAL, error: database is locked ./platform/sql/SQLiteDatabase.cpp(208) : void WebCore::SQLiteDatabase::useWALJournalMode() ERROR: SQLite database failed to checkpoint: database is locked ./platform/sql/SQLiteDatabase.cpp(218) : void WebCore::SQLiteDatabase::useWALJournalMode() ERROR: Unable to prepare statement to fetch schema for the ObservedDomains table. /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(514) : void WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(515) : void WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 1 0x11aaf3b49 WTFCrash 2 0x108cfdc6b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10942d2bf WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 4 0x10942ce46 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 5 0x10942dd03 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 6 0x1094deb1c std::__1::__unique_if<WebKit::ResourceLoadStatisticsDatabaseStore>::__unique_single std::__1::make_unique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 7 0x1094de703 decltype(auto) WTF::makeUnique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 8 0x1094de456 WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42::operator()() const 9 0x1094de30e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42, void>::call() 10 0x108de8382 WTF::Function<void ()>::operator()() const 11 0x1094b4b5e WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'()::operator()() const 12 0x1094b4a8e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'(), void>::call() 13 0x11ab1f612 WTF::Function<void ()>::operator()() const 14 0x11ac2b1de WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0::operator()() const 15 0x11ac2b3d2 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::operator()(void*) const 16 0x11ac2b3a5 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::__invoke(void*) 17 0x107631951 _dispatch_call_block_and_release 18 0x1076328cb _dispatch_client_callout 19 0x10763860c _dispatch_lane_serial_drain 20 0x107639044 _dispatch_lane_invoke 21 0x1076430c4 _dispatch_workloop_worker_thread 22 0x107ab9a3d _pthread_wqthread 23 0x107ab8b77 start_wqthread 1653072 1 webkit-bug-importer 2020-05-15 08:55:11 -0700 <rdar://problem/63275549> 1653073 2 Lawrence.j 2020-05-15 09:05:04 -0700 I have marked these tests as flaky crashing while this issue is investigated. https://trac.webkit.org/changeset/261746/webkit 1656035 3 400244 katherine_cheney 2020-05-26 07:58:57 -0700 Created attachment 400244 Patch 1656141 4 400244 darin 2020-05-26 13:09:43 -0700 Comment on attachment 400244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400244&action=review > LayoutTests/ChangeLog:9 > + Tests no longer crashing. Would be better to explain why; although I was able to figure it out by reading your comments in the bug. 1656143 5 katherine_cheney 2020-05-26 13:12:08 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 400244 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400244&action=review > > > LayoutTests/ChangeLog:9 > > + Tests no longer crashing. > > Would be better to explain why; although I was able to figure it out by > reading your comments in the bug. Good point, I'll make it clearer next time. Thanks for the review! 1656154 6 ews-feeder 2020-05-26 13:38:30 -0700 Committed r262160: <https://trac.webkit.org/changeset/262160> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400244. 400244 2020-05-26 07:58:57 -0700 2020-05-26 13:38:30 -0700 Patch bug-211958-20200526075856.patch text/plain 2066 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMDU4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGVhNTRjM2ZkNTQyOTliNTg2MGJm NmJiMDAyNWM2MjU1YmU2Yjc4ZS4uNmJjMWY1ZTBiNmM0Nzg3YTA1NWJlNTg0NTU0YzRiNzQ5OWM3 YzMyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTI2ICBLYXRlIENoZW5leSAgPGth dGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFsgaU9TIHdr MiBEZWJ1ZyBdIG11bHRpcGxlIGZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL3N5c3RlbS1sYW5ndWFn ZSB0ZXN0cyBhcmUgZmxha3kgY3Jhc2hpbmcgLSBXVEZDcmFzaFdpdGhJbmZvIC0gV2ViS2l0OjpS ZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6b3BlbkFuZFVwZGF0ZVNjaGVtYUlm TmVjZXNzYXJ5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMTk1OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjMyNzU1NDk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgbm8gbG9uZ2VyIGNy YXNoaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zOgor CiAyMDIwLTA1LTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg UmVncmVzc2lvbihyMjU0ODU5KSBET00gc3RvcmFnZSBldmVudCBnZXRzIGZpcmVkIGF0IHRoZSBm cmFtZSB0aGF0IGNhdXNlZCB0aGUgc3RvcmFnZSBtb2RpZmljYXRpb24KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBjODg4M2MyNGRkOTI3OTVm MTIwMThhYTMxNWVhMjA0NmYyNDBhYjgzLi40ZGJkNDc2MzNhZDI1YTg5MzU4NzJjN2RiNGM4MGI1 NTJkYzI3MjU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0 YXRpb25zCkBAIC0xNzQ3LDkgKzE3NDcsNCBAQCB3ZWJraXQub3JnL2IvMjEwMDQ2IFsgUmVsZWFz ZSBdIHN0b3JhZ2UvaW5kZXhlZGRiL3ZhbHVlLWN1cnNvci1jeWNsZS5odG1sIFsgUGFzcwogCiB3 ZWJraXQub3JnL2IvMjExOTI4IGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9zdGFu ZGFsb25lLXdlYi1hcHBsaWNhdGlvbi1leGVtcHQtZnJvbS13ZWJzaXRlLWRhdGEtZGVsZXRpb24t ZGF0YWJhc2UuaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKLXdlYmtpdC5vcmcvYi8yMTE5NTggWyBE ZWJ1ZyBdIGZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL3N5c3RlbS1sYW5ndWFnZS9oYW4tcXVvdGVz Lmh0bWwgWyBQYXNzIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMTE5NTggWyBEZWJ1ZyBdIGZhc3Qv dGV4dC9pbnRlcm5hdGlvbmFsL3N5c3RlbS1sYW5ndWFnZS9uYXZpZ2F0b3ItbGFuZ3VhZ2UvbmF2 aWdhdG9yLWxhbmd1YWdlLWVzLTQxOS5odG1sIFsgUGFzcyBDcmFzaCBdCi13ZWJraXQub3JnL2Iv MjExOTU4IFsgRGVidWcgXSBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC9zeXN0ZW0tbGFuZ3VhZ2Uv bmF2aWdhdG9yLWxhbmd1YWdlL25hdmlnYXRvci1sYW5ndWFnZS1oaS5odG1sIFsgUGFzcyBDcmFz aCBdCi13ZWJraXQub3JnL2IvMjExOTU4IFsgRGVidWcgXSBmYXN0L3RleHQvaW50ZXJuYXRpb25h bC9zeXN0ZW0tbGFuZ3VhZ2UvbmF2aWdhdG9yLWxhbmd1YWdlL25hdmlnYXRvci1sYW5ndWFnZS1w dC1QVC5odG1sIFsgUGFzcyBDcmFzaCBdCi0KIHdlYmtpdC5vcmcvYi8yMTIyMTkgbWVkaWEvdHJh Y2svdHJhY2stY3VlLW1pc3NpbmcuaHRtbCBbIFBhc3MgRmFpbHVyZSBdClwgTm8gbmV3bGluZSBh dCBlbmQgb2YgZmlsZQo=