<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>211936</bug_id>
          
          <creation_ts>2020-05-14 18:23:23 -0700</creation_ts>
          <short_desc>Update the isolated tree only if isolated tree mode is enabled.</short_desc>
          <delta_ts>2020-05-15 05:41:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andres Gonzalez">andresg_22</reporter>
          <assigned_to name="Andres Gonzalez">andresg_22</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>cfleizach</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>samuel_white</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1652903</commentid>
    <comment_count>0</comment_count>
    <who name="Andres Gonzalez">andresg_22</who>
    <bug_when>2020-05-14 18:23:23 -0700</bug_when>
    <thetext>Update the isolated tree only if isolated tree mode is enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652904</commentid>
    <comment_count>1</comment_count>
      <attachid>399435</attachid>
    <who name="Andres Gonzalez">andresg_22</who>
    <bug_when>2020-05-14 18:26:15 -0700</bug_when>
    <thetext>Created attachment 399435
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652906</commentid>
    <comment_count>2</comment_count>
      <attachid>399435</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2020-05-14 18:27:36 -0700</bug_when>
    <thetext>Comment on attachment 399435
Patch

Should we just do this check in updateIsolated tree?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652909</commentid>
    <comment_count>3</comment_count>
      <attachid>399437</attachid>
    <who name="Andres Gonzalez">andresg_22</who>
    <bug_when>2020-05-14 18:41:24 -0700</bug_when>
    <thetext>Created attachment 399437
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652912</commentid>
    <comment_count>4</comment_count>
    <who name="Andres Gonzalez">andresg_22</who>
    <bug_when>2020-05-14 18:42:54 -0700</bug_when>
    <thetext>(In reply to chris fleizach from comment #2)
&gt; Comment on attachment 399435 [details]
&gt; Patch
&gt; 
&gt; Should we just do this check in updateIsolated tree?

Yes, done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1653019</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-05-15 05:40:48 -0700</bug_when>
    <thetext>Committed r261740: &lt;https://trac.webkit.org/changeset/261740&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399437.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1653020</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-05-15 05:41:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/63267809&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>399435</attachid>
            <date>2020-05-14 18:26:15 -0700</date>
            <delta_ts>2020-05-14 18:41:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-211936-20200514212614.patch</filename>
            <type>text/plain</type>
            <size>2709</size>
            <attacher name="Andres Gonzalez">andresg_22</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWZhN2FhZjUwNDUxYWUx
OTYxMWQxNTRhNDFmOGNiMWI2NWVhODkzMy4uZTRkYzI4OGQ0Yzc1YjE1MTgyYjEwZjJlNTQ0MGEy
NTEyZDc3MWI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTE0ICBBbmRy
ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgdGhl
IGlzb2xhdGVkIHRyZWUgb25seSBpZiBpc29sYXRlZCB0cmVlIG1vZGUgaXMgZW5hYmxlZC4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTkzNgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIGZvciBp
c0lzb2xhdGVkVHJlZUVuYWJsZWQgYmVmb3JlIHVwZGF0aW5nIHRoZSBpc29sYXRlZCB0cmVlLgor
CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OkFYT2JqZWN0Q2FjaGU6Om5vdGlmaWNhdGlvblBvc3RUaW1lckZpcmVkKToKKyAgICAg
ICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnBvc3ROb3RpZmljYXRpb24pOgorICAgICAgICAo
V2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6cG9zdFRleHRTdGF0ZUNoYW5nZU5vdGlmaWNhdGlvbik6
CisKIDIwMjAtMDUtMTQgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgog
CiAgICAgICAgIEFYQ29yZU9iamVjdCBmb250IGNvbXBhcmlzb24gbWV0aG9kcyBzaG91bGQgdGFr
ZSBhbm90aGVyIEFYQ29yZU9iamVjdCBpbnN0ZWFkIG9mIGEgUmVuZGVyT2JqZWN0LgpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKaW5kZXggNzllZjMw
OTQ2YjIzZjBiNTAzNjg5ZmI5NjdjZDk5MjMwNjQ4YzVkNy4uODAzMjg3MjdjNTYyZmI4MDgzYTdi
MWM0ODk2ZGNjYjI2ZTFiMDAyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp
bGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5
L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC0xMDYxLDcgKzEwNjEsOCBAQCB2b2lkIEFYT2JqZWN0Q2Fj
aGU6Om5vdGlmaWNhdGlvblBvc3RUaW1lckZpcmVkKCkKICAgICB9CiAKICNpZiBFTkFCTEUoQUND
RVNTSUJJTElUWV9JU09MQVRFRF9UUkVFKQotICAgIHVwZGF0ZUlzb2xhdGVkVHJlZShub3RpZmlj
YXRpb25zKTsKKyAgICBpZiAoaXNJc29sYXRlZFRyZWVFbmFibGVkKCkpCisgICAgICAgIHVwZGF0
ZUlzb2xhdGVkVHJlZShub3RpZmljYXRpb25zKTsKICNlbmRpZgogfQogCkBAIC0xMTQzLDcgKzEx
NDQsOCBAQCB2b2lkIEFYT2JqZWN0Q2FjaGU6OnBvc3ROb3RpZmljYXRpb24oQVhDb3JlT2JqZWN0
KiBvYmplY3QsIERvY3VtZW50KiBkb2N1bWVudCwgQQogICAgICAgICAgICAgbV9ub3RpZmljYXRp
b25Qb3N0VGltZXIuc3RhcnRPbmVTaG90KDBfcyk7CiAgICAgfSBlbHNlIHsKICNpZiBFTkFCTEUo
QUNDRVNTSUJJTElUWV9JU09MQVRFRF9UUkVFKQotICAgICAgICB1cGRhdGVJc29sYXRlZFRyZWUo
Km9iamVjdCwgbm90aWZpY2F0aW9uKTsKKyAgICAgICAgaWYgKGlzSXNvbGF0ZWRUcmVlRW5hYmxl
ZCgpKQorICAgICAgICAgICAgdXBkYXRlSXNvbGF0ZWRUcmVlKCpvYmplY3QsIG5vdGlmaWNhdGlv
bik7CiAjZW5kaWYKIAogICAgICAgICBwb3N0UGxhdGZvcm1Ob3RpZmljYXRpb24ob2JqZWN0LCBu
b3RpZmljYXRpb24pOwpAQCAtMTM3OSw3ICsxMzgxLDggQEAgdm9pZCBBWE9iamVjdENhY2hlOjpw
b3N0VGV4dFN0YXRlQ2hhbmdlTm90aWZpY2F0aW9uKGNvbnN0IFBvc2l0aW9uJiBwb3NpdGlvbiwg
Y28KICAgICB9CiAKICNpZiBFTkFCTEUoQUNDRVNTSUJJTElUWV9JU09MQVRFRF9UUkVFKQotICAg
IHVwZGF0ZUlzb2xhdGVkVHJlZSgqb2JqZWN0LCBBWFNlbGVjdGVkVGV4dENoYW5nZWQpOworICAg
IGlmIChpc0lzb2xhdGVkVHJlZUVuYWJsZWQoKSkKKyAgICAgICAgdXBkYXRlSXNvbGF0ZWRUcmVl
KCpvYmplY3QsIEFYU2VsZWN0ZWRUZXh0Q2hhbmdlZCk7CiAjZW5kaWYKIAogICAgIHBvc3RUZXh0
U3RhdGVDaGFuZ2VOb3RpZmljYXRpb24ob2JqZWN0LCBpbnRlbnQsIHNlbGVjdGlvbik7CkBAIC0x
NDI5LDcgKzE0MzIsOCBAQCB2b2lkIEFYT2JqZWN0Q2FjaGU6OnBvc3RUZXh0U3RhdGVDaGFuZ2VO
b3RpZmljYXRpb24oTm9kZSogbm9kZSwgQVhUZXh0RWRpdFR5cGUgdAogICAgIH0KIAogI2lmIEVO
QUJMRShBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUpCi0gICAgdXBkYXRlSXNvbGF0ZWRUcmVl
KCpvYmplY3QsIEFYVmFsdWVDaGFuZ2VkKTsKKyAgICBpZiAoaXNJc29sYXRlZFRyZWVFbmFibGVk
KCkpCisgICAgICAgIHVwZGF0ZUlzb2xhdGVkVHJlZSgqb2JqZWN0LCBBWFZhbHVlQ2hhbmdlZCk7
CiAjZW5kaWYKIAogICAgIHBvc3RUZXh0U3RhdGVDaGFuZ2VQbGF0Zm9ybU5vdGlmaWNhdGlvbihv
YmplY3QsIHR5cGUsIHRleHQsIHBvc2l0aW9uKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>399437</attachid>
            <date>2020-05-14 18:41:24 -0700</date>
            <delta_ts>2020-05-15 05:40:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-211936-20200514214123.patch</filename>
            <type>text/plain</type>
            <size>1894</size>
            <attacher name="Andres Gonzalez">andresg_22</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWZhN2FhZjUwNDUxYWUx
OTYxMWQxNTRhNDFmOGNiMWI2NWVhODkzMy4uNWVlYzlhYmNjZGUxMDQ1YTJjOWZlOWE0YzE5Nzky
OWEwY2E1ODJhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTE0ICBBbmRy
ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgdGhl
IGlzb2xhdGVkIHRyZWUgb25seSBpZiBpc29sYXRlZCB0cmVlIG1vZGUgaXMgZW5hYmxlZC4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTkzNgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIGZvciBp
c0lzb2xhdGVkVHJlZUVuYWJsZWQgYmVmb3JlIHVwZGF0aW5nIHRoZSBpc29sYXRlZCB0cmVlLgor
CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcDoKKyAgICAgICAgKFdl
YkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnVwZGF0ZUlzb2xhdGVkVHJlZSk6CisKIDIwMjAtMDUtMTQg
IEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIEFYQ29y
ZU9iamVjdCBmb250IGNvbXBhcmlzb24gbWV0aG9kcyBzaG91bGQgdGFrZSBhbm90aGVyIEFYQ29y
ZU9iamVjdCBpbnN0ZWFkIG9mIGEgUmVuZGVyT2JqZWN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Fj
Y2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKaW5kZXggNzllZjMwOTQ2YjIzZjBiNTAzNjg5
ZmI5NjdjZDk5MjMwNjQ4YzVkNy4uMGEyYjFiNDBmZDhhY2EyNzkyOTE0MjI0MjY2NDhlYmVlMmFk
YWE0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENh
Y2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUu
Y3BwCkBAIC0zMTE5LDYgKzMxMTksMTAgQEAgUmVmPEFYSXNvbGF0ZWRUcmVlPiBBWE9iamVjdENh
Y2hlOjpnZW5lcmF0ZUlzb2xhdGVkVHJlZShQYWdlSWRlbnRpZmllciBwYWdlSUQsIEQKIHZvaWQg
QVhPYmplY3RDYWNoZTo6dXBkYXRlSXNvbGF0ZWRUcmVlKEFYQ29yZU9iamVjdCYgb2JqZWN0LCBB
WE5vdGlmaWNhdGlvbiBub3RpZmljYXRpb24pCiB7CiAgICAgQVhUUkFDRSgiQVhPYmplY3RDYWNo
ZTo6dXBkYXRlSXNvbGF0ZWRUcmVlIik7CisKKyAgICBpZiAoIWlzSXNvbGF0ZWRUcmVlRW5hYmxl
ZCgpKQorICAgICAgICByZXR1cm47CisKICAgICBBWExPRyhzdGQ6Om1ha2VfcGFpcigmb2JqZWN0
LCBub3RpZmljYXRpb24pKTsKICAgICBBWExPRygqdGhpcyk7CiAKQEAgLTMxNTUsNiArMzE1OSwx
MCBAQCBzdGF0aWMgYm9vbCBhcHBlbmRJZk5vdENvbnRhaW5zTWF0Y2hpbmcoVmVjdG9yPFQ+JiB2
ZWN0b3IsIGNvbnN0IFQmIHZhbHVlLCBGIG1hdAogdm9pZCBBWE9iamVjdENhY2hlOjp1cGRhdGVJ
c29sYXRlZFRyZWUoY29uc3QgVmVjdG9yPHN0ZDo6cGFpcjxSZWZQdHI8QVhDb3JlT2JqZWN0Piwg
QVhOb3RpZmljYXRpb24+PiYgbm90aWZpY2F0aW9ucykKIHsKICAgICBBWFRSQUNFKCJBWE9iamVj
dENhY2hlOjp1cGRhdGVJc29sYXRlZFRyZWUiKTsKKworICAgIGlmICghaXNJc29sYXRlZFRyZWVF
bmFibGVkKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIEFYTE9HKCp0aGlzKTsKIAogICAgIGlm
ICghbV9wYWdlSUQpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>