211932 2020-05-14 16:11:14 -0700 Add a quirk to allow an embedded Twitter video to play with one tapping 2022-11-21 18:08:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 248199 1 peng.liu6 peng.liu6 cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble mjs philipj sergio webkit-bug-importer youennf oldest_to_newest 1652852 0 peng.liu6 2020-05-14 16:11:14 -0700 Add a quirk to allow an embedded Twitter video to play with one tapping 1652854 1 peng.liu6 2020-05-14 16:12:35 -0700 <rdar://problem/60604893> 1652859 2 399426 peng.liu6 2020-05-14 16:23:31 -0700 Created attachment 399426 Patch 1652954 3 399426 mjs 2020-05-14 23:01:51 -0700 Comment on attachment 399426 Patch Do we have any way to add tests for quirk? It would be better to add a test if at all possible. 1653051 4 399426 youennf 2020-05-15 07:49:26 -0700 Comment on attachment 399426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399426&action=review > Source/WebCore/html/MediaElementSession.cpp:319 > + if (topDocument.hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture()) We should probably update MediaElementSession::updateMediaUsageIfChanged as well, since it is doing document.hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture() as well. Maybe we should add a test for that document/topDocument change where the iframe did not interact but the top document (or another iframe) did. That would require Internals to be able to set the document quirks shouldAutoplayForArbitraryUserGesture() value. 1653765 5 399675 peng.liu6 2020-05-18 14:51:05 -0700 Created attachment 399675 Revise the patch based on Youenn's comment 1653768 6 peng.liu6 2020-05-18 14:57:08 -0700 (In reply to Maciej Stachowiak from comment #3) > Comment on attachment 399426 [details] > Patch > > Do we have any way to add tests for quirk? It would be better to add a test > if at all possible. We don't have the support to test quirks for now. We may need a non-trivial patch to enable it. Filed a bug for it: <webkit.org/b/212047>. 1653769 7 399426 peng.liu6 2020-05-18 15:00:00 -0700 Comment on attachment 399426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399426&action=review >> Source/WebCore/html/MediaElementSession.cpp:319 >> + if (topDocument.hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture()) > > We should probably update MediaElementSession::updateMediaUsageIfChanged as well, since it is doing document.hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture() as well. > Fixed it after confirmed with Eric. > Maybe we should add a test for that document/topDocument change where the iframe did not interact but the top document (or another iframe) did. > That would require Internals to be able to set the document quirks shouldAutoplayForArbitraryUserGesture() value. Filed a bug to add the support to test quirks <webkit.org/b/212047>. 1653771 8 399675 mjs 2020-05-18 15:10:07 -0700 Comment on attachment 399675 Revise the patch based on Youenn's comment r=me 1653810 9 ews-feeder 2020-05-18 16:40:10 -0700 Committed r261839: <https://trac.webkit.org/changeset/261839> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399675. 399426 2020-05-14 16:23:31 -0700 2020-05-18 14:51:03 -0700 Patch bug-211932-20200514162331.patch text/plain 4317 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE4MzE5YmM3Y2EyNjUw MmRjMTMzNDhjNDI2OTYwOGE5ZWJiNDFlOS4uYzNmM2IxOTg0ZjBiZjgwMWY3NDk0NGU5MDgxN2Vj NWI1MGNlMzQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA1LTE0ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgcXVpcmsgdG8gYWxs b3cgYW4gZW1iZWRkZWQgVHdpdHRlciB2aWRlbyB0byBwbGF5IHdpdGggb25lIHRhcHBpbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTkzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9NZWRp YUVsZW1lbnRTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Np b246OnBsYXliYWNrUGVybWl0dGVkIGNvbnN0KToKKyAgICAgICAgTmVlZCB0byBjaGVjayB0aGUg dG9wRG9jdW1lbnQgZm9yIHRoZSBleGlzdGVuY2Ugb2YgdXNlciBpbnRlcmFjdGlvbnMuCisKKyAg ICAgICAgKiBwYWdlL1F1aXJrcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRdWlya3M6Om5lZWRz UGVyRG9jdW1lbnRBdXRvcGxheUJlaGF2aW9yIGNvbnN0KToKKyAgICAgICAgQWRkIHRoZSBtaXNz aW5nIG5lZWRzUXVpcmtzKCkgY2hlY2tpbmcuCisgICAgICAgIChXZWJDb3JlOjpRdWlya3M6OnNo b3VsZEF1dG9wbGF5Rm9yQXJiaXRyYXJ5VXNlckdlc3R1cmUgY29uc3QpOgorICAgICAgICBBZGQg YSB0aGUgcXVpcmsgZm9yIHR3aXR0ZXIuY29tLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8v aW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNl c3Npb25NYW5hZ2VyaU9TOjpzZXNzaW9uV2lsbEJlZ2luUGxheWJhY2spOgorICAgICAgICBDbGFy aWZ5IHRoZSBsb2cgbWVzc2FnZS4KKwogMjAyMC0wNS0xMyAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBUaGUgcGVyc3BlY3RpdmUgbWF0cml4IGlzIGFm ZmVjdGVkIGJ5IG92ZXJmbG93OmhpZGRlbiBvbiBhIGJveCB3aXRoIGJvcmRlcnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCmluZGV4IDZmMTQ5NWU0YTdlMjUw MmVjZWViMDY2YTg0OTEyNDgxNDU3YjgyNmQuLjZmOTA1NzEwYTg5NzE0NTk4ODM2ZTUzNDkxYmNl MTgyMDhkZjEzMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50 U2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9u LmNwcApAQCAtMzE2LDcgKzMxNiw3IEBAIFN1Y2Nlc3NPcjxNZWRpYVBsYXliYWNrRGVuaWFsUmVh c29uPiBNZWRpYUVsZW1lbnRTZXNzaW9uOjpwbGF5YmFja1Blcm1pdHRlZCgpIGNvCiAgICAgaWYg KHRvcERvY3VtZW50Lm1lZGlhU3RhdGUoKSAmIE1lZGlhUHJvZHVjZXI6Okhhc1VzZXJJbnRlcmFj dGVkV2l0aE1lZGlhRWxlbWVudCAmJiB0b3BEb2N1bWVudC5xdWlya3MoKS5uZWVkc1BlckRvY3Vt ZW50QXV0b3BsYXlCZWhhdmlvcigpKQogICAgICAgICByZXR1cm4geyB9OwogCi0gICAgaWYgKGRv Y3VtZW50Lmhhc0hhZFVzZXJJbnRlcmFjdGlvbigpICYmIGRvY3VtZW50LnF1aXJrcygpLnNob3Vs ZEF1dG9wbGF5Rm9yQXJiaXRyYXJ5VXNlckdlc3R1cmUoKSkKKyAgICBpZiAodG9wRG9jdW1lbnQu aGFzSGFkVXNlckludGVyYWN0aW9uKCkgJiYgZG9jdW1lbnQucXVpcmtzKCkuc2hvdWxkQXV0b3Bs YXlGb3JBcmJpdHJhcnlVc2VyR2VzdHVyZSgpKQogICAgICAgICByZXR1cm4geyB9OwogCiAgICAg aWYgKG1fcmVzdHJpY3Rpb25zICYgUmVxdWlyZVVzZXJHZXN0dXJlRm9yVmlkZW9SYXRlQ2hhbmdl ICYmIG1fZWxlbWVudC5pc1ZpZGVvKCkgJiYgIWRvY3VtZW50LnByb2Nlc3NpbmdVc2VyR2VzdHVy ZUZvck1lZGlhKCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcAppbmRleCAyOGI3YmUxMGRiZTU3Y2M4 YmQxY2FiNGJkZjBlZjA0NGU0ZTdkNDY2Li4wZTk2ZWU1MWU5OTk0OTJkMWZmYTZhMzc1YTkyMzYy OTRjY2M0NzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCkBAIC0xMTAsNiArMTEwLDkgQEAgYm9v bCBRdWlya3M6Om5lZWRzUGVyRG9jdW1lbnRBdXRvcGxheUJlaGF2aW9yKCkgY29uc3QKICAgICBB U1NFUlQobV9kb2N1bWVudCA9PSAmbV9kb2N1bWVudC0+dG9wRG9jdW1lbnQoKSk7CiAgICAgcmV0 dXJuIG5lZWRzUXVpcmtzKCkgJiYgYWxsb3dlZEF1dG9wbGF5UXVpcmtzKCptX2RvY3VtZW50KS5j b250YWlucyhBdXRvcGxheVF1aXJrOjpQZXJEb2N1bWVudEF1dG9wbGF5QmVoYXZpb3IpOwogI2Vs c2UKKyAgICBpZiAoIW5lZWRzUXVpcmtzKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAg IGF1dG8gaG9zdCA9IG1fZG9jdW1lbnQtPnRvcERvY3VtZW50KCkudXJsKCkuaG9zdCgpOwogICAg IHJldHVybiBlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAibmV0ZmxpeC5jb20i KSB8fCBob3N0LmVuZHNXaXRoSWdub3JpbmdBU0NJSUNhc2UoIi5uZXRmbGl4LmNvbSIpOwogI2Vu ZGlmCkBAIC0xMjAsNyArMTIzLDExIEBAIGJvb2wgUXVpcmtzOjpzaG91bGRBdXRvcGxheUZvckFy Yml0cmFyeVVzZXJHZXN0dXJlKCkgY29uc3QKICNpZiBQTEFURk9STShNQUMpCiAgICAgcmV0dXJu IG5lZWRzUXVpcmtzKCkgJiYgYWxsb3dlZEF1dG9wbGF5UXVpcmtzKCptX2RvY3VtZW50KS5jb250 YWlucyhBdXRvcGxheVF1aXJrOjpBcmJpdHJhcnlVc2VyR2VzdHVyZXMpOwogI2Vsc2UKLSAgICBy ZXR1cm4gZmFsc2U7CisgICAgaWYgKCFuZWVkc1F1aXJrcygpKQorICAgICAgICByZXR1cm4gZmFs c2U7CisKKyAgICBhdXRvIGhvc3QgPSBtX2RvY3VtZW50LT51cmwoKS5ob3N0KCk7CisgICAgcmV0 dXJuIGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJ0d2l0dGVyLmNvbSIpIHx8 IGhvc3QuZW5kc1dpdGhJZ25vcmluZ0FTQ0lJQ2FzZSgiLnR3aXR0ZXIuY29tIik7CiAjZW5kaWYK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9zL01lZGlh U2Vzc2lvbk1hbmFnZXJJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9pb3Mv TWVkaWFTZXNzaW9uTWFuYWdlcklPUy5tbQppbmRleCA3YmJlNTk1MGY3MzNmMTNkMDA3M2ExYzE2 MGYxNDEwZjg2NGYzZDVkLi4xYWIzYTU0N2MwMDMxMGU4YzgyNmE2MzUyNGYyMTIwYzBlYTI0ZDQ5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9pb3MvTWVkaWFTZXNz aW9uTWFuYWdlcklPUy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9pb3Mv TWVkaWFTZXNzaW9uTWFuYWdlcklPUy5tbQpAQCAtMTMxLDcgKzEzMSw3IEBAIGJvb2wgTWVkaWFT ZXNzaW9uTWFuYWdlcmlPUzo6c2Vzc2lvbldpbGxCZWdpblBsYXliYWNrKFBsYXRmb3JtTWVkaWFT ZXNzaW9uJiBzZXNzCiAgICAgICAgIG1fcGxheWJhY2tUYXJnZXRTdXBwb3J0c0FpclBsYXlWaWRl byA9IG1fcGxheWJhY2tUYXJnZXQtPnN1cHBvcnRzUmVtb3RlVmlkZW9QbGF5YmFjaygpOwogICAg IH0KIAotICAgIEFMV0FZU19MT0coTE9HSURFTlRJRklFUiwgbV9wbGF5YmFja1RhcmdldFN1cHBv cnRzQWlyUGxheVZpZGVvKTsKKyAgICBBTFdBWVNfTE9HKExPR0lERU5USUZJRVIsICJQbGF5YmFj ayBUYXJnZXQgU3VwcG9ydHMgQWlyUGxheSBWaWRlbyA9ICIsIG1fcGxheWJhY2tUYXJnZXRTdXBw b3J0c0FpclBsYXlWaWRlbyk7CiAgICAgaWYgKG1fcGxheWJhY2tUYXJnZXRTdXBwb3J0c0FpclBs YXlWaWRlbykKICAgICAgICAgc2Vzc2lvbi5zZXRQbGF5YmFja1RhcmdldCgqbV9wbGF5YmFja1Rh cmdldC5jb3B5UmVmKCkpOwogICAgIHNlc3Npb24uc2V0U2hvdWxkUGxheVRvUGxheWJhY2tUYXJn ZXQobV9wbGF5YmFja1RhcmdldFN1cHBvcnRzQWlyUGxheVZpZGVvKTsK 399675 2020-05-18 14:51:05 -0700 2020-05-18 16:40:10 -0700 Revise the patch based on Youenn's comment bug-211932-20200518145104.patch text/plain 5245 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxODMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjc2YmM4MmY4OWM4YmMw ZjQzMDE5N2MwZTExODU2ZTYwZmYyZTcxMi4uYjc4N2EzZDQ4ODljMjMwYTVhOWRlMTI2ZTI5YWE4 MWM0ZDM3YjRlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTE4ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgcXVpcmsgdG8gYWxs b3cgYW4gZW1iZWRkZWQgVHdpdHRlciB2aWRlbyB0byBwbGF5IHdpdGggb25lIHRhcHBpbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTkzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9NZWRp YUVsZW1lbnRTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Np b246OnBsYXliYWNrUGVybWl0dGVkIGNvbnN0KToKKyAgICAgICAgTmVlZCB0byBjaGVjayB0aGUg dG9wRG9jdW1lbnQgZm9yIHRoZSBleGlzdGVuY2Ugb2YgdXNlciBpbnRlcmFjdGlvbnMuCisgICAg ICAgIChXZWJDb3JlOjpNZWRpYUVsZW1lbnRTZXNzaW9uOjp1cGRhdGVNZWRpYVVzYWdlSWZDaGFu Z2VkKTogRGl0dG8uCisKKyAgICAgICAgKiBwYWdlL1F1aXJrcy5jcHA6CisgICAgICAgIChXZWJD b3JlOjpRdWlya3M6Om5lZWRzUGVyRG9jdW1lbnRBdXRvcGxheUJlaGF2aW9yIGNvbnN0KToKKyAg ICAgICAgQWRkIHRoZSBtaXNzaW5nIG5lZWRzUXVpcmtzKCkgY2hlY2tpbmcuCisgICAgICAgIChX ZWJDb3JlOjpRdWlya3M6OnNob3VsZEF1dG9wbGF5Rm9yQXJiaXRyYXJ5VXNlckdlc3R1cmUgY29u c3QpOgorICAgICAgICBBZGQgYSB0aGUgcXVpcmsgZm9yIHR3aXR0ZXIuY29tLgorCisgICAgICAg ICogcGxhdGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW06CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyaU9TOjpzZXNzaW9uV2lsbEJlZ2luUGxheWJh Y2spOgorICAgICAgICBDbGFyaWZ5IHRoZSBsb2cgbWVzc2FnZS4KKwogMjAyMC0wNS0xOCAgUGlu a2kgR3lhbmNoYW5kYW5pICA8cGd5YW5jaGFuZGFuaUBhcHBsZS5jb20+CiAKICAgICAgICAgTnVs bCBQdHIgRGVyZWYgQCBXZWJDb3JlOjpDU1NWYWx1ZTo6Y2xhc3NUeXBlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcAppbmRleCA2ZjE0OTVlNGE3ZTI1MDJlY2Vl YjA2NmE4NDkxMjQ4MTQ1N2I4MjZkLi45ZThlZmFkYjIzNDVmN2Y0MDRjOGRhYTdiN2I2MzJkMDYx ZWZkOTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Np b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAK QEAgLTMxNiw3ICszMTYsNyBAQCBTdWNjZXNzT3I8TWVkaWFQbGF5YmFja0RlbmlhbFJlYXNvbj4g TWVkaWFFbGVtZW50U2Vzc2lvbjo6cGxheWJhY2tQZXJtaXR0ZWQoKSBjbwogICAgIGlmICh0b3BE b2N1bWVudC5tZWRpYVN0YXRlKCkgJiBNZWRpYVByb2R1Y2VyOjpIYXNVc2VySW50ZXJhY3RlZFdp dGhNZWRpYUVsZW1lbnQgJiYgdG9wRG9jdW1lbnQucXVpcmtzKCkubmVlZHNQZXJEb2N1bWVudEF1 dG9wbGF5QmVoYXZpb3IoKSkKICAgICAgICAgcmV0dXJuIHsgfTsKIAotICAgIGlmIChkb2N1bWVu dC5oYXNIYWRVc2VySW50ZXJhY3Rpb24oKSAmJiBkb2N1bWVudC5xdWlya3MoKS5zaG91bGRBdXRv cGxheUZvckFyYml0cmFyeVVzZXJHZXN0dXJlKCkpCisgICAgaWYgKHRvcERvY3VtZW50Lmhhc0hh ZFVzZXJJbnRlcmFjdGlvbigpICYmIGRvY3VtZW50LnF1aXJrcygpLnNob3VsZEF1dG9wbGF5Rm9y QXJiaXRyYXJ5VXNlckdlc3R1cmUoKSkKICAgICAgICAgcmV0dXJuIHsgfTsKIAogICAgIGlmICht X3Jlc3RyaWN0aW9ucyAmIFJlcXVpcmVVc2VyR2VzdHVyZUZvclZpZGVvUmF0ZUNoYW5nZSAmJiBt X2VsZW1lbnQuaXNWaWRlbygpICYmICFkb2N1bWVudC5wcm9jZXNzaW5nVXNlckdlc3R1cmVGb3JN ZWRpYSgpKSB7CkBAIC0xMDY1LDcgKzEwNjUsNyBAQCB2b2lkIE1lZGlhRWxlbWVudFNlc3Npb246 OnVwZGF0ZU1lZGlhVXNhZ2VJZkNoYW5nZWQoKQogICAgICAgICBkb2N1bWVudC5pc01lZGlhRG9j dW1lbnQoKSAmJiAhZG9jdW1lbnQub3duZXJFbGVtZW50KCksCiAgICAgICAgIHBhZ2VFeHBsaWNp dGx5QWxsb3dzRWxlbWVudFRvQXV0b3BsYXlJbmxpbmUobV9lbGVtZW50KSwKICAgICAgICAgcmVx dWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjaygpICYmICFmdWxsc2NyZWVuUGVybWl0dGVk KCksCi0gICAgICAgIGRvY3VtZW50Lmhhc0hhZFVzZXJJbnRlcmFjdGlvbigpICYmIGRvY3VtZW50 LnF1aXJrcygpLnNob3VsZEF1dG9wbGF5Rm9yQXJiaXRyYXJ5VXNlckdlc3R1cmUoKSwKKyAgICAg ICAgZG9jdW1lbnQudG9wRG9jdW1lbnQoKS5oYXNIYWRVc2VySW50ZXJhY3Rpb24oKSAmJiBkb2N1 bWVudC5xdWlya3MoKS5zaG91bGRBdXRvcGxheUZvckFyYml0cmFyeVVzZXJHZXN0dXJlKCksCiAg ICAgICAgIGlzVmlkZW8gJiYgaGFzQmVoYXZpb3JSZXN0cmljdGlvbihSZXF1aXJlVXNlckdlc3R1 cmVGb3JWaWRlb1JhdGVDaGFuZ2UpICYmICFwcm9jZXNzaW5nVXNlckdlc3R1cmUsCiAgICAgICAg IGlzQXVkaW8gJiYgaGFzQmVoYXZpb3JSZXN0cmljdGlvbihSZXF1aXJlVXNlckdlc3R1cmVGb3JB dWRpb1JhdGVDaGFuZ2UpICYmICFwcm9jZXNzaW5nVXNlckdlc3R1cmUgJiYgIW1fZWxlbWVudC5t dXRlZCgpICYmIG1fZWxlbWVudC52b2x1bWUoKSwKICAgICAgICAgaXNWaWRlbyAmJiBoYXNCZWhh dmlvclJlc3RyaWN0aW9uKFJlcXVpcmVVc2VyR2VzdHVyZUZvclZpZGVvRHVlVG9Mb3dQb3dlck1v ZGUpICYmICFwcm9jZXNzaW5nVXNlckdlc3R1cmUsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1F1aXJrcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKaW5kZXgg MjhiN2JlMTBkYmU1N2NjOGJkMWNhYjRiZGYwZWYwNDRlNGU3ZDQ2Ni4uMGU5NmVlNTFlOTk5NDky ZDFmZmE2YTM3NWE5MjM2Mjk0Y2NjNDcxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9RdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcApAQCAtMTEw LDYgKzExMCw5IEBAIGJvb2wgUXVpcmtzOjpuZWVkc1BlckRvY3VtZW50QXV0b3BsYXlCZWhhdmlv cigpIGNvbnN0CiAgICAgQVNTRVJUKG1fZG9jdW1lbnQgPT0gJm1fZG9jdW1lbnQtPnRvcERvY3Vt ZW50KCkpOwogICAgIHJldHVybiBuZWVkc1F1aXJrcygpICYmIGFsbG93ZWRBdXRvcGxheVF1aXJr cygqbV9kb2N1bWVudCkuY29udGFpbnMoQXV0b3BsYXlRdWlyazo6UGVyRG9jdW1lbnRBdXRvcGxh eUJlaGF2aW9yKTsKICNlbHNlCisgICAgaWYgKCFuZWVkc1F1aXJrcygpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKICAgICBhdXRvIGhvc3QgPSBtX2RvY3VtZW50LT50b3BEb2N1bWVudCgpLnVy bCgpLmhvc3QoKTsKICAgICByZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9z dCwgIm5ldGZsaXguY29tIikgfHwgaG9zdC5lbmRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCIubmV0 ZmxpeC5jb20iKTsKICNlbmRpZgpAQCAtMTIwLDcgKzEyMywxMSBAQCBib29sIFF1aXJrczo6c2hv dWxkQXV0b3BsYXlGb3JBcmJpdHJhcnlVc2VyR2VzdHVyZSgpIGNvbnN0CiAjaWYgUExBVEZPUk0o TUFDKQogICAgIHJldHVybiBuZWVkc1F1aXJrcygpICYmIGFsbG93ZWRBdXRvcGxheVF1aXJrcygq bV9kb2N1bWVudCkuY29udGFpbnMoQXV0b3BsYXlRdWlyazo6QXJiaXRyYXJ5VXNlckdlc3R1cmVz KTsKICNlbHNlCi0gICAgcmV0dXJuIGZhbHNlOworICAgIGlmICghbmVlZHNRdWlya3MoKSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgYXV0byBob3N0ID0gbV9kb2N1bWVudC0+dXJsKCku aG9zdCgpOworICAgIHJldHVybiBlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAi dHdpdHRlci5jb20iKSB8fCBob3N0LmVuZHNXaXRoSWdub3JpbmdBU0NJSUNhc2UoIi50d2l0dGVy LmNvbSIpOwogI2VuZGlmCiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL2lvcy9NZWRpYVNlc3Npb25NYW5hZ2VySU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KaW5kZXggN2JiZTU5NTBm NzMzZjEzZDAwNzNhMWMxNjBmMTQxMGY4NjRmM2Q1ZC4uMWFiM2E1NDdjMDAzMTBlOGM4MjZhNjM1 MjRmMjEyMGMwZWEyNGQ0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KQEAgLTEzMSw3ICsxMzEs NyBAQCBib29sIE1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OnNlc3Npb25XaWxsQmVnaW5QbGF5YmFj ayhQbGF0Zm9ybU1lZGlhU2Vzc2lvbiYgc2VzcwogICAgICAgICBtX3BsYXliYWNrVGFyZ2V0U3Vw cG9ydHNBaXJQbGF5VmlkZW8gPSBtX3BsYXliYWNrVGFyZ2V0LT5zdXBwb3J0c1JlbW90ZVZpZGVv UGxheWJhY2soKTsKICAgICB9CiAKLSAgICBBTFdBWVNfTE9HKExPR0lERU5USUZJRVIsIG1fcGxh eWJhY2tUYXJnZXRTdXBwb3J0c0FpclBsYXlWaWRlbyk7CisgICAgQUxXQVlTX0xPRyhMT0dJREVO VElGSUVSLCAiUGxheWJhY2sgVGFyZ2V0IFN1cHBvcnRzIEFpclBsYXkgVmlkZW8gPSAiLCBtX3Bs YXliYWNrVGFyZ2V0U3VwcG9ydHNBaXJQbGF5VmlkZW8pOwogICAgIGlmIChtX3BsYXliYWNrVGFy Z2V0U3VwcG9ydHNBaXJQbGF5VmlkZW8pCiAgICAgICAgIHNlc3Npb24uc2V0UGxheWJhY2tUYXJn ZXQoKm1fcGxheWJhY2tUYXJnZXQuY29weVJlZigpKTsKICAgICBzZXNzaW9uLnNldFNob3VsZFBs YXlUb1BsYXliYWNrVGFyZ2V0KG1fcGxheWJhY2tUYXJnZXRTdXBwb3J0c0FpclBsYXlWaWRlbyk7 Cg==