<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>211924</bug_id>
          
          <creation_ts>2020-05-14 14:59:55 -0700</creation_ts>
          <short_desc>Regression(r261163) Causes crashes on builds without libwebrtc.dylib</short_desc>
          <delta_ts>2020-05-14 16:18:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>211290</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>eric.carlson</cc>
    
    <cc>ggaren</cc>
    
    <cc>jer.noble</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1652805</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-14 14:59:55 -0700</bug_when>
    <thetext>r261163 Causes crashes on builds without libwebrtc.dylib:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   dyld                          	0x000000010ce8040a __abort_with_payload + 10
1   dyld                          	0x000000010cea9206 abort_with_payload + 9
2   dyld                          	0x000000010ce2bbc1 dyld::halt(char const*) + 473
3   dyld                          	0x000000010ce2bceb dyld::fastBindLazySymbol(ImageLoader**, unsigned long) + 167
4   libdyld.dylib                 	0x000000010dd6bc26 dyld_stub_binder + 282
5   com.apple.WebKit              	0x00000001076479f7 WebKit::NetworkProcessConnection::NetworkProcessConnection(IPC::Connection::Identifier, WebCore::HTTPCookieAcceptPolicy) + 161
6   com.apple.WebKit              	0x000000010712c5b5 WebKit::WebProcess::ensureNetworkProcessConnection() + 363
7   com.apple.WebKit              	0x00000001075fd695 WebKit::WebProcess::initializeWebProcess(WebKit::WebProcessCreationParameters&amp;&amp;) + 83
8   com.apple.WebKit              	0x00000001077960a5 WebKit::WebProcess::didReceiveWebProcessMessage(IPC::Connection&amp;, IPC::Decoder&amp;) + 9913
9   com.apple.WebKit              	0x000000010719f702 IPC::Connection::dispatchMessage(std::__1::unique_ptr&lt;IPC::Decoder, std::__1::default_delete&lt;IPC::Decoder&gt; &gt;) + 650
10  com.apple.WebKit              	0x00000001071a1fb4 WTF::Detail::CallableWrapper&lt;IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr&lt;IPC::Decoder, std::__1::default_delete&lt;IPC::Decoder&gt; &gt;)::$_7, void&gt;::call() + 214
11  com.apple.JavaScriptCore      	0x000000011997b68d WTF::RunLoop::performWork() + 637
12  com.apple.JavaScriptCore      	0x000000011997b87a WTF::RunLoop::performWork(void*) + 26</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652806</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-14 15:00:07 -0700</bug_when>
    <thetext>&lt;rdar://problem/63206792&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652807</commentid>
    <comment_count>2</comment_count>
      <attachid>399415</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-14 15:00:42 -0700</bug_when>
    <thetext>Created attachment 399415
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652856</commentid>
    <comment_count>3</comment_count>
      <attachid>399415</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-14 16:18:56 -0700</bug_when>
    <thetext>Comment on attachment 399415
Patch

Clearing flags on attachment: 399415

Committed r261719: &lt;https://trac.webkit.org/changeset/261719&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652857</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-05-14 16:18:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>399415</attachid>
            <date>2020-05-14 15:00:42 -0700</date>
            <delta_ts>2020-05-14 16:18:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-211924-20200514150042.patch</filename>
            <type>text/plain</type>
            <size>1590</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA4NDI2YTU5NzFhNjUwNmU0
ZGNhZGIwODEzOTc2OTU2NGNhNGMzMDMuLjM3OGMzNmQ3ZjhmZmM5N2JmZjQzNDAzNGM1MzE0NzBl
OGE2YjZjNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDUtMTQgIENocmlzIER1
bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNjExNjMpIENh
dXNlcyBjcmFzaGVzIG9uIGJ1aWxkcyB3aXRob3V0IGxpYndlYnJ0Yy5keWxpYgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExOTI0CisgICAgICAgIDxy
ZGFyOi8vcHJvYmxlbS82MzIwNjc5Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc0Nvbm5l
Y3Rpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb246Ok5l
dHdvcmtQcm9jZXNzQ29ubmVjdGlvbik6CisKIDIwMjAtMDUtMTQgIEJyYWR5IEVpZHNvbiAgPGJl
aWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGluIFBERlBsdWdpbjo6ZW5zdXJlRGF0
YUJ1ZmZlckxlbmd0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdv
cmsvTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz
cy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbi5jcHAKaW5kZXggMjI1NTYxNjdlOTE3
NTAwYzNiODQ5OGZkM2M4ZWRhYzRjOWQyNTcwYy4uNWU1NjY3Y2JjMjNjOWNjNTNlM2IwODQxNzNj
NWQwODUzZjk2ZDI1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdv
cmsvTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy
b2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwCkBAIC03Niw3ICs3Niw5
IEBAIE5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbjo6TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uKElQ
Qzo6Q29ubmVjdGlvbjo6SWRlbnRpZmllciBjCiAgICAgLCBtX2Nvb2tpZUFjY2VwdFBvbGljeShj
b29raWVBY2NlcHRQb2xpY3kpCiB7CiAgICAgbV9jb25uZWN0aW9uLT5vcGVuKCk7Ci0gICAgV2Vi
UHJvY2Vzczo6c2luZ2xldG9uKCkubGliV2ViUlRDTmV0d29yaygpLnNldENvbm5lY3Rpb24obV9j
b25uZWN0aW9uLmNvcHlSZWYoKSk7CisKKyAgICBpZiAoTGliV2ViUlRDUHJvdmlkZXI6OndlYlJU
Q0F2YWlsYWJsZSgpKQorICAgICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5saWJXZWJSVENO
ZXR3b3JrKCkuc2V0Q29ubmVjdGlvbihtX2Nvbm5lY3Rpb24uY29weVJlZigpKTsKIH0KIAogTmV0
d29ya1Byb2Nlc3NDb25uZWN0aW9uOjp+TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uKCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>