211896 2020-05-14 08:07:42 -0700 Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support 2020-05-14 10:52:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210889 https://bugs.webkit.org/show_bug.cgi?id=211906 InRadar P2 Normal --- 204907 1 cdumez cdumez achristensen beidson benjamin cmarcelo ews-watchlist ggaren mjs sihui_liu webkit-bug-importer oldest_to_newest 1652623 0 cdumez 2020-05-14 08:07:42 -0700 Family Health iOS app is broken due to lack for WebSQL support. 1652624 1 cdumez 2020-05-14 08:08:21 -0700 <rdar://problem/63025045> 1652640 2 399361 cdumez 2020-05-14 08:34:33 -0700 Created attachment 399361 Patch 1652642 3 399361 cdumez 2020-05-14 08:36:08 -0700 Comment on attachment 399361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399361&action=review > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:399 > + bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0; Note that personally, I think we should use: bool webSQLEnabled = applicationSDKVersion() < DYLD_IOS_VERSION_14_0; without any application checks. Please let me know if you agree / disagree. 1652645 4 399361 mjs 2020-05-14 08:42:08 -0700 Comment on attachment 399361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399361&action=review >> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:399 >> + bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0; > > Note that personally, I think we should use: > bool webSQLEnabled = applicationSDKVersion() < DYLD_IOS_VERSION_14_0; > > without any application checks. Please let me know if you agree / disagree. Lack of application check creates a risk we'll have to keep rolling the OS version forward into the future, which makes it harder to ever delete WebSQL. So I think limiting it to specific apps is probably better. Though perhaps if there's enough apps, we could factor it out into a function so we don't end up with an unwieldy or expression. 1652646 5 399361 mjs 2020-05-14 08:46:12 -0700 Comment on attachment 399361 Patch Do we have a way to test this type of change, via API tests for instance? Please add a test if possible. Otherwise, r=me 1652647 6 cdumez 2020-05-14 08:47:17 -0700 (In reply to Maciej Stachowiak from comment #5) > Comment on attachment 399361 [details] > Patch > > Do we have a way to test this type of change, via API tests for instance? > > Please add a test if possible. > > Otherwise, r=me As far as I know, we still have test coverage for WebSQL being enabled. 1652649 7 cdumez 2020-05-14 08:52:53 -0700 (In reply to Maciej Stachowiak from comment #4) > Comment on attachment 399361 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399361&action=review > > >> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:399 > >> + bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0; > > > > Note that personally, I think we should use: > > bool webSQLEnabled = applicationSDKVersion() < DYLD_IOS_VERSION_14_0; > > > > without any application checks. Please let me know if you agree / disagree. > > Lack of application check creates a risk we'll have to keep rolling the OS > version forward into the future, which makes it harder to ever delete > WebSQL. So I think limiting it to specific apps is probably better. Though > perhaps if there's enough apps, we could factor it out into a function so we > don't end up with an unwieldy or expression. Why would we keep rolling the IOS version forward? We drop support for WebSQL in a specific SDK, and then apps have to update if they want to build with the new SDK. Checking only for specific apps is risky because we may not notice quickly all the apps that are broken without WebSQL or the breakage may be more subtle for certain apps. Also, it is quite a waste of engineering time to investigate app breakage and bisect it to this particular WebSQL change. I wasted a day on this and don't wish this on anybody else. 1652659 8 ews-feeder 2020-05-14 09:11:30 -0700 Committed r261695: <https://trac.webkit.org/changeset/261695> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399361. 399361 2020-05-14 08:34:33 -0700 2020-05-14 09:11:31 -0700 Patch bug-211896-20200514083432.patch text/plain 5635 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJiZjhkN2FjZGViODA2Y2YyMGI3MGJk MWRlNGZkYTZhOWI5ZGJkMzIuLjZkOTg5MWIwZjYyMmQ5YzU2ZTQ4ZTFkYjRlNWRmNzhjMDg3YzM4 OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDUtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNTQ4NTYpIEZhbWlseSBIZWFsdGgg aU9TIGFwcCBpcyBicm9rZW4gZHVlIHRvIGxhY2sgZm9yIFdlYlNRTCBzdXBwb3J0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE4OTYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYzMDI1MDQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogd3RmL3NwaS9kYXJ3aW4vZHlsZFNQSS5oOgorCiAyMDIwLTA1 LTEzICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBb SVdZVV0gVHJ5IHJlbW92aW5nIHJlZHVuZGFudCBpbmNsdWRlcyBpbiBXVEYgaW1wbGVtZW50YXRp b24gZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNDc5MzEyYWJkYzk2NWQ1NmY2NDMwMTVmYWM1NjU4MmU4 ZTE4NDc2Li42ODJkNTZlNjgxZjJkN2JjZWY4ZTEzMzBmNzdjOWU4MjAzMjcwZmMyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDUtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNTQ4NTYpIEZhbWlseSBIZWFsdGggaU9T IGFwcCBpcyBicm9rZW4gZHVlIHRvIGxhY2sgZm9yIFdlYlNRTCBzdXBwb3J0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE4OTYKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzYzMDI1MDQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBSdW50aW1lQXBwbGljYXRpb25DaGVja3MgZnVuY3Rpb24gdG8g aWRlbnRpZnkgRmFtaWx5IEhlYWx0aCBhcHAgb24gaU9TLgorCisgICAgICAgICogcGxhdGZvcm0v UnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmg6CisgICAgICAgICogcGxhdGZvcm0vY29jb2EvUnVu dGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpJT1NBcHBs aWNhdGlvbjo6aXNGYW1pbHlIZWFsdGhBcHApOgorCiAyMDIwLTA1LTEzICBaYWxhbiBCdWp0YXMg IDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gbm90IGNsZWFyIHNlbGVjdGlvbi9yZXBh aW50IHdoZW4gdGhlIHJlbmRlcmVyIGdldHMgbW92ZWQgZHVyaW5nIHRyZWUgbm9ybWFsaXphdGlv bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwppbmRleCA4ZGUwM2JjN2MxMTU1MGNkNDE1NGMy NjM2Y2NmZTY1ZTdiN2UxYzU5Li43NjJjMWNhMjQwYzI1Yzk1N2Q5NGE3NTgzN2FlNjg2Y2RiOTg0 NGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAt MDUtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNz aW9uKHIyNTQ4NTYpIEZhbWlseSBIZWFsdGggaU9TIGFwcCBpcyBicm9rZW4gZHVlIHRvIGxhY2sg Zm9yIFdlYlNRTCBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTE4OTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYzMDI1MDQ1PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWVuYWJsZSBX ZWJTUUwgc3VwcG9ydCBmb3IgRmFtaWx5IEhlYWx0aCBpT1MgYXBwIHdpdGggYSBsaW5rZWQtb24t YWZ0ZXIgY2hlY2suCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tOgorICAg ICAgICAoK1tXZWJQcmVmZXJlbmNlcyBpbml0aWFsaXplXSk6CisKIDIwMjAtMDUtMTIgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBOZXV0ZXIgV0tGcmFt ZUlzRnJhbWVTZXQoKSAvIFdLUGFnZUdldEZyYW1lU2V0TGFyZ2VzdEZyYW1lKCkgQyBBUEkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3NwaS9kYXJ3aW4vZHlsZFNQSS5oIGIvU291cmNlL1dU Ri93dGYvc3BpL2Rhcndpbi9keWxkU1BJLmgKaW5kZXggYTcyYjE1MWE5ZDY0MDhkYjhmNThiN2Ew MTJmOGY0YmU1NDlkMDQ2OS4uM2U0MjYyYWQ1MWZhZGRiNjIyZWZhZjllNWFkZDhlMWQ5NmNmZGM0 ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvc3BpL2Rhcndpbi9keWxkU1BJLmgKKysrIGIv U291cmNlL1dURi93dGYvc3BpL2Rhcndpbi9keWxkU1BJLmgKQEAgLTUzLDYgKzUzLDEwIEBACiAj ZGVmaW5lIERZTERfSU9TX1ZFUlNJT05fMTNfNCAweDAwMEQwNDAwCiAjZW5kaWYKIAorI2lmbmRl ZiBEWUxEX0lPU19WRVJTSU9OXzE0XzAKKyNkZWZpbmUgRFlMRF9JT1NfVkVSU0lPTl8xNF8wIDB4 MDAwZTAwMDAKKyNlbmRpZgorCiAjaWZuZGVmIERZTERfTUFDT1NYX1ZFUlNJT05fMTBfMTMKICNk ZWZpbmUgRFlMRF9NQUNPU1hfVkVSU0lPTl8xMF8xMyAweDAwMEEwRDAwCiAjZW5kaWYKQEAgLTg5 LDYgKzkzLDcgQEAKICNkZWZpbmUgRFlMRF9JT1NfVkVSU0lPTl8xM18wIDB4MDAwRDAwMDAKICNk ZWZpbmUgRFlMRF9JT1NfVkVSU0lPTl8xM18yIDB4MDAwRDAyMDAKICNkZWZpbmUgRFlMRF9JT1Nf VkVSU0lPTl8xM180IDB4MDAwRDA0MDAKKyNkZWZpbmUgRFlMRF9JT1NfVkVSU0lPTl8xNF8wIDB4 MDAwZTAwMDAKIAogI2RlZmluZSBEWUxEX01BQ09TWF9WRVJTSU9OXzEwXzExIDB4MDAwQTBCMDAK ICNkZWZpbmUgRFlMRF9NQUNPU1hfVkVSU0lPTl8xMF8xMiAweDAwMEEwQzAwCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oCmluZGV4IGU3 MDFmN2IwMDJiNTk5NzQ3ZGU0OGZmMmY0ODc4YjM0MWM4MTk0YWQuLjBjZjQyZDZiMzNiMDM1MjA4 OTQwYmY4MWY0MjBmNWY4Nzc4NTExYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oCkBAIC04Nyw2ICs4Nyw3IEBAIFdFQkNPUkVf RVhQT1JUIGJvb2wgaXNEdW1wUmVuZGVyVHJlZSgpOwogV0VCQ09SRV9FWFBPUlQgYm9vbCBpc01p bmlCcm93c2VyKCk7CiBib29sIGlzTW9iaWxlU3RvcmUoKTsKIFdFQkNPUkVfRVhQT1JUIGJvb2wg aXNKZXN1c0NhbGxpbmcoKTsKK1dFQkNPUkVfRVhQT1JUIGJvb2wgaXNGYW1pbHlIZWFsdGhBcHAo KTsKIGJvb2wgaXNTcHJpbmdCb2FyZCgpOwogV0VCQ09SRV9FWFBPUlQgYm9vbCBpc1dlYlByb2Nl c3MoKTsKIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNJQm9va3MoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1t IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tz Q29jb2EubW0KaW5kZXggZjU4YzhiOGRlNDFjZmU0Y2VhNmI4ZjAzN2JjYjQ5NzZmNzdkYmYwMS4u Yjc1NTBhMGFiYWUxNjYxMzYzYjU0NjBiMjBiM2I2YTVlMjJhMGJhYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2Eu bW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9u Q2hlY2tzQ29jb2EubW0KQEAgLTI1NSw2ICsyNTUsMTIgQEAgYm9vbCBJT1NBcHBsaWNhdGlvbjo6 aXNKZXN1c0NhbGxpbmcoKQogICAgIHJldHVybiBpc0plc3VzQ2FsbGluZzsKIH0KIAorYm9vbCBJ T1NBcHBsaWNhdGlvbjo6aXNGYW1pbHlIZWFsdGhBcHAoKQoreworICAgIHN0YXRpYyBib29sIGlz RmFtaWx5SGVhbHRoQXBwID0gYXBwbGljYXRpb25CdW5kbGVTdGFydHNXaXRoKCJjb20ud2lsZGZs b3dlcmhlYWx0aC5Hcm93Il9zKSB8fCBhcHBsaWNhdGlvbkJ1bmRsZVN0YXJ0c1dpdGgoImNvbS53 aWxkZmxvd2VyaGVhbHRoLlVHUk9XIik7CisgICAgcmV0dXJuIGlzRmFtaWx5SGVhbHRoQXBwOwor fQorCiBib29sIElPU0FwcGxpY2F0aW9uOjppc01vYmlsZVN0b3JlKCkKIHsKICAgICBzdGF0aWMg Ym9vbCBpc01vYmlsZVN0b3JlID0gYXBwbGljYXRpb25CdW5kbGVJc0VxdWFsVG8oImNvbS5hcHBs ZS5Nb2JpbGVTdG9yZSJfcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9X ZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmll dy9XZWJQcmVmZXJlbmNlcy5tbQppbmRleCBiMmFhMTlkN2YxYmNiNzU5N2U5MTIzYWZkZjFhOGI5 ZmRiNmFjOTE3Li5hZTkwNzhiMzMyNGI0OTcxOGI4ZmFiMjc1NGUxNjM3MmY1ZGI1YTdjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1t CisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW0K QEAgLTM5Niw3ICszOTYsNyBAQCArICh2b2lkKWluaXRpYWxpemUKICAgICBib29sIGFsbG93c0lu bGluZU1lZGlhUGxheWJhY2tBZnRlckZ1bGxzY3JlZW4gPSBXZWJDb3JlOjpkZXZpY2VDbGFzcygp ICE9IE1HRGV2aWNlQ2xhc3NpUGFkOwogICAgIGJvb2wgcmVxdWlyZXNQbGF5c0lubGluZUF0dHJp YnV0ZSA9ICFhbGxvd3NJbmxpbmVNZWRpYVBsYXliYWNrOwogICAgIGJvb2wgYXR0YWNobWVudEVs ZW1lbnRFbmFibGVkID0gSU9TQXBwbGljYXRpb246OmlzTW9iaWxlTWFpbCgpOwotICAgIGJvb2wg d2ViU1FMRW5hYmxlZCA9IElPU0FwcGxpY2F0aW9uOjppc0plc3VzQ2FsbGluZygpICYmIGFwcGxp Y2F0aW9uU0RLVmVyc2lvbigpIDw9IERZTERfSU9TX1ZFUlNJT05fMTJfMjsKKyAgICBib29sIHdl YlNRTEVuYWJsZWQgPSAoSU9TQXBwbGljYXRpb246OmlzRmFtaWx5SGVhbHRoQXBwKCkgfHwgSU9T QXBwbGljYXRpb246OmlzSmVzdXNDYWxsaW5nKCkpICYmIGFwcGxpY2F0aW9uU0RLVmVyc2lvbigp IDwgRFlMRF9JT1NfVkVSU0lPTl8xNF8wOwogI2VuZGlmCiAKICAgICBOU0RpY3Rpb25hcnkgKmRp Y3QgPSBbTlNEaWN0aW9uYXJ5IGRpY3Rpb25hcnlXaXRoT2JqZWN0c0FuZEtleXM6Cg==