211876 2020-05-13 19:41:59 -0700 Incorrect location.origin in blob workers 2020-05-21 13:40:08 -0700 1 1 1 Unclassified WebKit Page Loading Safari 13 Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 naman.nehra98 youennf achristensen beidson cdumez ews-watchlist mkwst sihui_liu webkit-bug-importer youennf oldest_to_newest 1652492 0 naman.nehra98 2020-05-13 19:41:59 -0700 location.origin is set to "blob://" in web workers created from blobs. 1653142 1 webkit-bug-importer 2020-05-15 12:33:23 -0700 <rdar://problem/63284717> 1654361 2 399821 youennf 2020-05-20 02:05:40 -0700 Created attachment 399821 Patch 1654748 3 399821 sihui_liu 2020-05-20 17:28:58 -0700 Comment on attachment 399821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399821&action=review > Source/WebCore/workers/WorkerLocation.cpp:78 > - return SecurityOriginData::fromURL(m_url).toString(); > + return m_origin; Instead of keeping m_origin, you probably want SecurityOrigin::create(m_url), which seems to handle the blob case. 1654833 4 youennf 2020-05-21 01:12:22 -0700 > Instead of keeping m_origin, you probably want > SecurityOrigin::create(m_url), which seems to handle the blob case. We are trying to reduce the number of times we create origins from background threads. I believe we are creating the WorkerGlobalScope origin on the main thread for instance e. Also, by reusing the WorkerGlobalScope origin, we ensure consistency and it removes the need to allocate a new SecurityOrigin object for a very short period of time. 1655008 5 sihui_liu 2020-05-21 11:18:14 -0700 (In reply to youenn fablet from comment #4) > > Instead of keeping m_origin, you probably want > > SecurityOrigin::create(m_url), which seems to handle the blob case. > > We are trying to reduce the number of times we create origins from > background threads. > I believe we are creating the WorkerGlobalScope origin on the main thread > for instance e. > > Also, by reusing the WorkerGlobalScope origin, we ensure consistency and it > removes the need to allocate a new SecurityOrigin object for a very short > period of time. Ah Okay, the fix should work. 1655058 6 ews-feeder 2020-05-21 13:40:07 -0700 Committed r262026: <https://trac.webkit.org/changeset/262026> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399821. 399821 2020-05-20 02:05:40 -0700 2020-05-21 13:40:08 -0700 Patch bug-211876-20200520110538.patch text/plain 6207 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWFmODVhYWFmOTVmZTE5 ZTg4ZjAyYTQ3MGM5MjdjYmQ2MmE3MzAzOS4uNzMzMTFhYzEzODQ2NDY3YjFkZjRhODIzNmNjYjIz ODZkN2FhYjRhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNvcnJlY3QgbG9jYXRp b24ub3JpZ2luIGluIGJsb2Igd29ya2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjExODc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MzI4NDcx Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0 ZWFkIG9mIGNvbXB1dGluZyB0aGUgb3JpZ2luIGZyb20gdGhlIGxvY2F0aW9uIFVSTCBpbiB3b3Jr ZXIsIGdldCBpdCBkaXJlY3RseSBmcm9tIHRoZSBXb3JrZXJHbG9iYWxTY29wZSBvcmlnaW4uCisg ICAgICAgIFRoaXMgZW5zdXJlcyB3ZSB1bndyYXAgcHJvcGVybHkgYmxvYiBVUkxzLgorCisgICAg ICAgIFRlc3Q6IGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L3dvcmtl ci1ibG9iLWxvY2F0aW9uLmh0bWwKKworICAgICAgICAqIHdvcmtlcnMvV29ya2VyR2xvYmFsU2Nv cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyR2xvYmFsU2NvcGU6OmxvY2F0aW9uIGNv bnN0KToKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlckxvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OldvcmtlckxvY2F0aW9uOjpvcmlnaW4gY29uc3QpOgorICAgICAgICAqIHdvcmtlcnMv V29ya2VyTG9jYXRpb24uaDoKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlckxvY2F0aW9uOjpjcmVh dGUpOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyTG9jYXRpb246OnVybCBjb25zdCk6CisgICAg ICAgIChXZWJDb3JlOjpXb3JrZXJMb2NhdGlvbjo6V29ya2VyTG9jYXRpb24pOgorCiAyMDIwLTA1 LTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYVBs YXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6Om1fYWN0aXZlVmlkZW9UcmFjayBzaG91bGQg YmUgYSBWaWRlb1RyYWNrUHJpdmF0ZU1lZGlhU3RyZWFtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtl cnMvV29ya2VyR2xvYmFsU2NvcGUuY3BwCmluZGV4IGE2OWI2YzQyMzk1NWUwOGE5Zjk3NDRlNWMz NWJiM2M0NDJkOGE2Y2IuLmY5M2NkMTNhYTU3NjUzNjFlZjI5YzZmYTY3NTY0OWY4M2I4MTA0ODcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyR2xvYmFsU2NvcGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyR2xvYmFsU2NvcGUuY3BwCkBAIC0y MzksNyArMjM5LDcgQEAgdm9pZCBXb3JrZXJHbG9iYWxTY29wZTo6cmVzdW1lKCkKIFdvcmtlckxv Y2F0aW9uJiBXb3JrZXJHbG9iYWxTY29wZTo6bG9jYXRpb24oKSBjb25zdAogewogICAgIGlmICgh bV9sb2NhdGlvbikKLSAgICAgICAgbV9sb2NhdGlvbiA9IFdvcmtlckxvY2F0aW9uOjpjcmVhdGUo bV91cmwpOworICAgICAgICBtX2xvY2F0aW9uID0gV29ya2VyTG9jYXRpb246OmNyZWF0ZShVUkwg eyBtX3VybCB9LCBvcmlnaW4oKSk7CiAgICAgcmV0dXJuICptX2xvY2F0aW9uOwogfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckxvY2F0aW9uLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyTG9jYXRpb24uY3BwCmluZGV4IDgzNDc2ZmU3NjlkNmRi ZTA5Y2Y1NDc5MDE1NmRhNjU4OGMyZGU3ZmMuLmU5ZTQ1NWJhNWJkZmZjYzkzYmJiODNiNDkwOGI5 MjBmYWJiNDlhZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyTG9j YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyTG9jYXRpb24uY3Bw CkBAIC03NSw3ICs3NSw3IEBAIFN0cmluZyBXb3JrZXJMb2NhdGlvbjo6aGFzaCgpIGNvbnN0CiAK IFN0cmluZyBXb3JrZXJMb2NhdGlvbjo6b3JpZ2luKCkgY29uc3QKIHsKLSAgICByZXR1cm4gU2Vj dXJpdHlPcmlnaW5EYXRhOjpmcm9tVVJMKG1fdXJsKS50b1N0cmluZygpOworICAgIHJldHVybiBt X29yaWdpbjsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvd29ya2Vy cy9Xb3JrZXJMb2NhdGlvbi5oCmluZGV4IDkyY2ZjYzc3MDZmMDM0ZTU3YjlmODJlOWJhMjdiYTNh NTFhMDlmMGQuLmRmYWQzMDJlYThmYWY4ZWE4NDJkZGZhOTRlYTdjZmM0MDE3OTlhNmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyTG9jYXRpb24uaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckxvY2F0aW9uLmgKQEAgLTMzLDEzICszMyw5IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIFdvcmtlckxvY2F0aW9uIDogcHVibGljIFJl ZkNvdW50ZWQ8V29ya2VyTG9jYXRpb24+IHsKICAgICBwdWJsaWM6Ci0gICAgICAgIHN0YXRpYyBS ZWY8V29ya2VyTG9jYXRpb24+IGNyZWF0ZShjb25zdCBVUkwmIHVybCkKLSAgICAgICAgewotICAg ICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgV29ya2VyTG9jYXRpb24odXJsKSk7Ci0gICAg ICAgIH0KKyAgICAgICAgc3RhdGljIFJlZjxXb3JrZXJMb2NhdGlvbj4gY3JlYXRlKFVSTCYmIHVy bCwgU3RyaW5nJiYgb3JpZ2luKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IFdvcmtlckxvY2F0aW9u KFdURk1vdmUodXJsKSwgV1RGTW92ZShvcmlnaW4pKSk7IH0KIAogICAgICAgICBjb25zdCBVUkwm IHVybCgpIGNvbnN0IHsgcmV0dXJuIG1fdXJsOyB9Ci0KICAgICAgICAgU3RyaW5nIGhyZWYoKSBj b25zdDsKIAogICAgICAgICAvLyBVUkkgZGVjb21wb3NpdGlvbiBhdHRyaWJ1dGVzCkBAIC01Myw5 ICs0OSwxNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFN0cmluZyBvcmlnaW4oKSBj b25zdDsKIAogICAgIHByaXZhdGU6Ci0gICAgICAgIGV4cGxpY2l0IFdvcmtlckxvY2F0aW9uKGNv bnN0IFVSTCYgdXJsKSA6IG1fdXJsKHVybCkgeyB9CisgICAgICAgIFdvcmtlckxvY2F0aW9uKFVS TCYmIHVybCwgU3RyaW5nJiYgb3JpZ2luKQorICAgICAgICAgICAgOiBtX3VybChXVEZNb3ZlKHVy bCkpCisgICAgICAgICAgICAsIG1fb3JpZ2luKFdURk1vdmUob3JpZ2luKSkKKyAgICAgICAgewor ICAgICAgICB9CiAKICAgICAgICAgVVJMIG1fdXJsOworICAgICAgICBTdHJpbmcgbV9vcmlnaW47 CiAgICAgfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDRhNTNlMzUxMzgwZTky NGY1MWRmNDFlMmVmMWFlOThjZTNmZDYxYTYuLmY5OWYyNjgyOTNhN2I2NzI4N2I0NWE3YjFkZjk4 ZDk3NzE4YTZmMDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wNS0yMCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgSW5jb3JyZWN0IGxvY2F0aW9uLm9y aWdpbiBpbiBibG9iIHdvcmtlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMTg3NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjMyODQ3MTc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rl c3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS93b3JrZXItYmxvYi1sb2NhdGlvbi1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVu dFNlY3VyaXR5UG9saWN5L3dvcmtlci1ibG9iLWxvY2F0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDIw LTA1LTE5ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd W1dQRV0gVXBkYXRlIHNvbWUgZXhwZWN0YXRpb25zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS93b3JrZXItYmxvYi1sb2Nh dGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRl bnRTZWN1cml0eVBvbGljeS93b3JrZXItYmxvYi1sb2NhdGlvbi1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZjllN2Q3OGFhYWJjOWZiOTk5ZmVhNDUxMGYzYWNmZDIyM2FmMDNjMAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5 UG9saWN5L3dvcmtlci1ibG9iLWxvY2F0aW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAK KworUEFTUyBCbG9iIHdvcmtlciBsb2NhdGlvbiAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvd29ya2VyLWJsb2ItbG9j YXRpb24uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3Vy aXR5UG9saWN5L3dvcmtlci1ibG9iLWxvY2F0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYThjZGM2ZDBl YWM0NGNhZmM2ZGEwNTIyZGY3NDJlZTMwMDI3OTM4ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L3dvcmtlci1i bG9iLWxvY2F0aW9uLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxoZWFkPgorICA8c2NyaXB0IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2VzL3Rlc3RoYXJuZXNz LmpzIj48L3NjcmlwdD4KKyAgPHNjcmlwdCBzcmM9Ii9qcy10ZXN0LXJlc291cmNlcy90ZXN0aGFy bmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgPHNjcmlwdD4KKyAg YXN5bmNfdGVzdChmdW5jdGlvbiAoKSB7CisgICAgICB2YXIgYmxvYiA9IG5ldyBCbG9iKFsKKyAg ICAgICAgICAicG9zdE1lc3NhZ2UoeyBvcmlnaW46IGxvY2F0aW9uLm9yaWdpbiwgaHJlZjogbG9j YXRpb24uaHJlZiwgcHJvdG9jb2w6IGxvY2F0aW9uLnByb3RvY29sLCBob3N0OiBsb2NhdGlvbi5o b3N0LCBob3N0bmFtZTogbG9jYXRpb24uaG9zdG5hbWUsIHBhdGhuYW1lOiBsb2NhdGlvbi5wYXRo bmFtZSB9KTsiCisgICAgICBdKTsKKyAgICAgIHZhciB3b3JrZXIgPSBuZXcgV29ya2VyKHdpbmRv dy5VUkwuY3JlYXRlT2JqZWN0VVJMKGJsb2IpKTsKKyAgICAgIHdvcmtlci5vbm1lc3NhZ2UgPSB0 aGlzLnN0ZXBfZnVuYyhmdW5jdGlvbiAoZXZ0KSB7CisgICAgICAgICAgYXNzZXJ0X2VxdWFscyhl dnQuZGF0YS5vcmlnaW4sICJodHRwOi8vMTI3LjAuMC4xOjgwMDAiKTsKKyAgICAgICAgICBhc3Nl cnRfdHJ1ZShldnQuZGF0YS5ocmVmLnN0YXJ0c1dpdGgoImJsb2I6aHR0cDovLzEyNy4wLjAuMTo4 MDAwLyIpKTsKKyAgICAgICAgICBhc3NlcnRfZXF1YWxzKGV2dC5kYXRhLnByb3RvY29sLCAiYmxv YjoiKTsKKyAgICAgICAgICBhc3NlcnRfZXF1YWxzKGV2dC5kYXRhLmhvc3QsICIiKTsKKyAgICAg ICAgICBhc3NlcnRfZXF1YWxzKGV2dC5kYXRhLmhvc3RuYW1lLCAiIik7CisgICAgICAgICAgYXNz ZXJ0X3RydWUoZXZ0LmRhdGEucGF0aG5hbWUuc3RhcnRzV2l0aCgiaHR0cDovLzEyNy4wLjAuMTo4 MDAwLyIpKTsKKworICAgICAgICAgIHRoaXMuZG9uZSgpOworICAgICAgfSk7CisgIH0sICJCbG9i IHdvcmtlciBsb2NhdGlvbiIpOworICA8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K