211864 2020-05-13 14:43:44 -0700 Nullptr crash in InsertParagraphSeparatorCommand::doApply when the canonical position is uneditable 2020-05-13 17:45:51 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 shihchieh_lee webkit-unassigned bfulgham ews-feeder ggaren product-security rniwa webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1652397 0 shihchieh_lee 2020-05-13 14:43:44 -0700 <rdar://62982161> 0 com.apple.WebCore 0x00000001056e2e19 WebCore::InsertParagraphSeparatorCommand::doApply() + 9977 1 com.apple.WebCore 0x00000001056764ff WebCore::CompositeEditCommand::applyCommandToComposite(WTF::Ref<WebCore::EditCommand, WTF::DumbPtrTraits<WebCore::EditCommand> >&&) + 79 2 com.apple.WebCore 0x00000001056f36ec WebCore::ReplaceSelectionCommand::doApply() + 8076 3 com.apple.WebCore 0x00000001043e38fd WebCore::CompositeEditCommand::apply() + 397 4 com.apple.WebCore 0x00000001056d4f6a WebCore::executeInsertFragment(WebCore::Frame&, WTF::Ref<WebCore::DocumentFragment, WTF::DumbPtrTraits<WebCore::DocumentFragment> >&&) + 74 5 com.apple.WebCore 0x00000001056d50a4 WebCore::executeInsertNode(WebCore::Frame&, WTF::Ref<WebCore::Node, WTF::DumbPtrTraits<WebCore::Node> >&&) + 180 6 com.apple.WebCore 0x00000001056d05ba WebCore::executeInsertImage(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) + 74 7 com.apple.WebCore 0x000000010444a5f1 WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) + 81 8 com.apple.WebCore 0x00000001048431ca WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::JSGlobalObject*, JSC::CallFrame*) + 426 1652399 1 shihchieh_lee 2020-05-13 14:47:58 -0700 Below is the test case. Thanks to Alan for minimizing it! <video><span id=span_copy><input id=input></input></span></video><button></button><audio><hr id=hr1 contentEditable="true"><hr id=hr2></audio><textarea></textarea> <script> if (window.testRunner) testRunner.dumpAsText(); hr1.appendChild(span_copy); input.setSelectionRange(-1,67); hr2.appendChild(span_copy); document.execCommand("insertImage", "#foo"); document.body.innerText = "Tests inserting list at the end of a table. The test passes if WebKit doesn't crash or hit an ssertion."; </script> 1652409 2 shihchieh_lee 2020-05-13 15:30:44 -0700 Root cause: 1. In this test case, we are inserting a image and needs a paragraph separator at the selected position: hr1. 2. In function InsertParagraphSeparatorCommand::doApply, hr1 fails the check for being candidate at both its upstream and downstream positions. 3. However, we continute to assume hr1is a valid candidate and use it to as the insertaion positiopn for the separator. 4. Since the visible position of hr1 is start of paragraph, we need to insert a br at container of hr1. 5. The container node of hr1 is audio, and it is uneditable, so the insertion fails, leaving the br dangling. 6. Next we find the new insertion position based on the dangling br, so the position becomes empty. 7. Later the null anchor node in empty position is dereferenced and the code crashes. EndSelection() is hr1: BODY 0x28b06b920 (renderer 0x28b0697f0) VIDEO 0x28b0b8010 (renderer 0x28b0b9d00) BUTTON 0x28b0b8db0 (renderer 0x28b0b9e60) AUDIO 0x28b0b8e80 (renderer 0x0) SE HR 0x28b0b97b0 (renderer 0x0) HR 0x28b0b9840 (renderer 0x0) SPAN 0x28b0b8a70 (renderer 0x0) INPUT 0x28b0b8b00 (renderer 0x0) #document-fragment 0x28b0b8c10 (renderer 0x0) (needs style recalc) (child needs style recalc) DIV 0x28b0b8d20 (renderer 0x0) (needs style recalc) TEXTAREA 0x28b0b98d0 (renderer 0x28b0ba000) #document-fragment 0x28b0b99d0 (renderer 0x0) (needs style recalc) (child needs style recalc) DIV 0x28b0b9ae0 (renderer 0x28b0ba130) #text 0x28b0b9b70 "\n" SCRIPT 0x28b0b9bd0 (renderer 0x0) #text 0x28b0b9ca0 "\n if (window.testRunner)\n testRunner.dumpAsText();\n hr1.appendChild(span_copy);\n input.setSelectionRange(-1,67);\n hr2.appendChild(span_copy);\n document.execCommand("insertImage", "#foo");\n document.body.innerText = "Tests inserting list at the end of a table. The test passes if WebKit doesn't crash or hit an ssertion.";\n" start: offset, offset:0 end: offset, offset:0 The container node is the parent of hr1, audio. BODY 0x28b06b920 (renderer 0x28b0697f0) VIDEO 0x28b0b8010 (renderer 0x28b0b9d00) BUTTON 0x28b0b8db0 (renderer 0x28b0b9e60) AUDIO 0x28b0b8e80 (renderer 0x0) * HR 0x28b0b97b0 (renderer 0x0) HR 0x28b0b9840 (renderer 0x0) SPAN 0x28b0b8a70 (renderer 0x0) INPUT 0x28b0b8b00 (renderer 0x0) #document-fragment 0x28b0b8c10 (renderer 0x0) (needs style recalc) (child needs style recalc) DIV 0x28b0b8d20 (renderer 0x0) (needs style recalc) TEXTAREA 0x28b0b98d0 (renderer 0x28b0ba000) #document-fragment 0x28b0b99d0 (renderer 0x0) (needs style recalc) (child needs style recalc) DIV 0x28b0b9ae0 (renderer 0x28b0ba130) #text 0x28b0b9b70 "\n" SCRIPT 0x28b0b9bd0 (renderer 0x0) #text 0x28b0b9ca0 "\n if (window.testRunner)\n testRunner.dumpAsText();\n hr1.appendChild(span_copy);\n input.setSelectionRange(-1,67);\n hr2.appendChild(span_copy);\n document.execCommand("insertImage", "#foo");\n document.body.innerText = "Tests inserting list at the end of a table. The test passes if WebKit doesn't crash or hit an ssertion.";\n" before, offset:0 1652419 3 399309 shihchieh_lee 2020-05-13 15:54:53 -0700 Created attachment 399309 Patch 1652420 4 399310 shihchieh_lee 2020-05-13 15:57:40 -0700 Created attachment 399310 Patch 1652444 5 399310 ggaren 2020-05-13 16:50:12 -0700 Comment on attachment 399310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399310&action=review r=me > Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:303 > + // FIXME: <http://webkit.org/b/211864> insertionPosition is not a candidate. Needs to find an editable canonical candidate. The meaning here is a little jumbled. I think we should say something like "FIXME: <http://webkit.org/b/211864>: If insertionPosition is not editable, we should compute a position that is." 1652445 6 399310 zalan 2020-05-13 16:52:36 -0700 Comment on attachment 399310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399310&action=review > Source/WebCore/ChangeLog:9 > + Check for uneditable insertion position and return. This part of the changelog should answer the question of "why" not "what". 1652448 7 shihchieh_lee 2020-05-13 16:58:14 -0700 Thanks! I will add a short explanation. (In reply to zalan from comment #6) > Comment on attachment 399310 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399310&action=review > > > Source/WebCore/ChangeLog:9 > > + Check for uneditable insertion position and return. > > This part of the changelog should answer the question of "why" not "what". 1652450 8 399318 shihchieh_lee 2020-05-13 17:09:29 -0700 Created attachment 399318 Patch for landing 1652455 9 ews-feeder 2020-05-13 17:45:49 -0700 Committed r261666: <https://trac.webkit.org/changeset/261666> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399318. 399309 2020-05-13 15:54:53 -0700 2020-05-13 15:57:33 -0700 Patch bug-211864-20200513155452.patch text/plain 4308 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNkYzdkY2Q4MzYzY2I5 MjFjZTBkODNjNDQ0M2I0NTZhOTY3M2MzYi4uMTNjNDlmMzU3ZmRkMDllNDQxM2NjMTdiZDkxZmYy NGMzZTkyZWNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA1LTEzICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG9BcHBseSB3aGVuIHRoZSBjYW5v bmljYWwgcG9zaXRpb24gaXMgdW5lZGl0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExODY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82Mjk4 MjE2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGVjayBmb3IgdW5lZGl0YWJsZSBpbnNlcnRpb24gcG9zaXRpb24gYW5kIHJldHVybi4KKworICAg ICAgICBUZXN0OiBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaW1nLXVuZWRpdGFibGUtY2Fub25p Y2FsLXBvc2l0aW9uLWNyYXNoLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvSW5zZXJ0UGFyYWdy YXBoU2VwYXJhdG9yQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNlcnRQYXJhZ3Jh cGhTZXBhcmF0b3JDb21tYW5kOjpkb0FwcGx5KToKKwogMjAyMC0wNS0wOSAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIG1pc3NpbmcgbnVsbC1jaGVjayBvZiBw YWdlIGluIFJlc291cmNlTG9hZGVyOjpsb2FkRGF0YVVSTApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9JbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZC5jcHAKaW5k ZXggZmFmODE5Y2VlY2E5ZDMwZDIxZGJiNWM2MTM0ODFkOGZmN2VjYTQ2NC4uYjY3Y2M2NDU4NzI3 MzNmMDNmMWU0NDg5ZjM5OGFhMjcwYTBkNTE2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9JbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0luc2VydFBhcmFncmFwaFNlcGFyYXRvckNvbW1hbmQuY3BwCkBAIC0z MDAsNiArMzAwLDEwIEBAIHZvaWQgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG9B cHBseSgpCiAgICAgLy8gaXQgaWYgdmlzaWJsZVBvcyBpcyBhdCB0aGUgc3RhcnQgb2YgYSBwYXJh Z3JhcGggc28gdGhhdCB0aGUgCiAgICAgLy8gY29udGVudCB3aWxsIG1vdmUgZG93biBhIGxpbmUu CiAgICAgaWYgKGlzU3RhcnRPZlBhcmFncmFwaCh2aXNpYmxlUG9zKSkgeworICAgICAgICAvLyBG SVhNRTogPGh0dHA6Ly93ZWJraXQub3JnL2IvPiBpbnNlcnRpb25Qb3NpdGlvbiBpcyBub3QgYSBj YW5kaWRhdGUuIE5lZWRzIHRvIGZpbmQgYW4gZWRpdGFibGUgY2Fub25pY2FsIGNhbmRpZGF0ZS4K KyAgICAgICAgaWYgKCFpc0VkaXRhYmxlUG9zaXRpb24oaW5zZXJ0aW9uUG9zaXRpb24pKQorICAg ICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGF1dG8gYnIgPSBIVE1MQlJFbGVtZW50OjpjcmVh dGUoZG9jdW1lbnQoKSk7CiAgICAgICAgIGF1dG8qIGJyUHRyID0gYnIucHRyKCk7CiAgICAgICAg IGluc2VydE5vZGVBdChXVEZNb3ZlKGJyKSwgaW5zZXJ0aW9uUG9zaXRpb24pOwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDBh NWQ4YjYzNzY4Y2YzYmZlYzg3NDJkNTQ0Yjg4MGU0MmNkNDJhODYuLjM3Zjc2YmM3NDA2Y2Q1ODE3 MWFlMmZhNjFlZTNjNmFkODJlYzkwNDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wNS0x MyAgSmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRy IGNyYXNoIGluIEluc2VydFBhcmFncmFwaFNlcGFyYXRvckNvbW1hbmQ6OmRvQXBwbHkgd2hlbiB0 aGUgY2Fub25pY2FsIHBvc2l0aW9uIGlzIHVuZWRpdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTg2NAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjI5ODIxNjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QgZm9yIHRoZSBjcmFzaC4KKworICAgICAgICAq IGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRp b24tY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGlu Zy9pbnNlcnQtaW1nLXVuZWRpdGFibGUtY2Fub25pY2FsLXBvc2l0aW9uLWNyYXNoLmh0bWw6IEFk ZGVkLgorCiAyMDIwLTA1LTA5ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gR2FyZGVuaW5nLCB1cGRhdGUgdGVzdCBleHBlY3RhdGlvbnMKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0 YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWltZy11bmVkaXRhYmxlLWNhbm9uaWNhbC1wb3NpdGlv bi1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTVjZTgyZTE3NGM0NDgzNTA1MDFmOGEz MjVlOTcwM2Q3N2JmZDJjYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcv aW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2gt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1Rlc3RzIGluc2VydGluZyBwYXJhZ3JhcGggc2Vw YXJhdG9yIHdoZW4gYW4gZWRpdGFibGUgY2Fub25pY2FsIHBvc2l0aW9uIGlzIG5vdCBmb3VuZC4g VGhlIHRlc3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBhbiBzc2VydGlv bi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWct dW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Vk aXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24t Y3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NjM5NjQ0MzZmYWJhZDlhNmNjYTA2NmE3OTUxOWY3YmRl ZjYxZTJlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcv aW5zZXJ0LWltZy11bmVkaXRhYmxlLWNhbm9uaWNhbC1wb3NpdGlvbi1jcmFzaC5odG1sCkBAIC0w LDAgKzEsMTAgQEAKKzx2aWRlbz48c3BhbiBpZD1zcGFuX2NvcHk+PGlucHV0IGlkPWlucHV0Pjwv aW5wdXQ+PC9zcGFuPjwvdmlkZW8+PGJ1dHRvbj48L2J1dHRvbj48YXVkaW8+PGhyIGlkPWhyMSBj b250ZW50RWRpdGFibGU9InRydWUiPjxociBpZD1ocjI+PC9hdWRpbz48dGV4dGFyZWE+PC90ZXh0 YXJlYT4NCis8c2NyaXB0Pg0KKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpDQorICAgICAgICB0 ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsNCisgICAgaHIxLmFwcGVuZENoaWxkKHNwYW5fY29weSk7 DQorICAgIGlucHV0LnNldFNlbGVjdGlvblJhbmdlKC0xLDY3KTsNCisgICAgaHIyLmFwcGVuZENo aWxkKHNwYW5fY29weSk7DQorICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJpbnNlcnRJbWFnZSIs ICIjZm9vIik7DQorICAgIGRvY3VtZW50LmJvZHkuaW5uZXJUZXh0ID0gIlRlc3RzIGluc2VydGlu ZyBwYXJhZ3JhcGggc2VwYXJhdG9yIHdoZW4gYW4gZWRpdGFibGUgY2Fub25pY2FsIHBvc2l0aW9u IGlzIG5vdCBmb3VuZC4gVGhlIHRlc3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vzbid0IGNyYXNoIG9y IGhpdCBhbiBzc2VydGlvbi4iOw0KKzwvc2NyaXB0Pg0K 399310 2020-05-13 15:57:40 -0700 2020-05-13 17:09:26 -0700 Patch bug-211864-20200513155739.patch text/plain 4314 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNkYzdkY2Q4MzYzY2I5 MjFjZTBkODNjNDQ0M2I0NTZhOTY3M2MzYi4uMTNjNDlmMzU3ZmRkMDllNDQxM2NjMTdiZDkxZmYy NGMzZTkyZWNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA1LTEzICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG9BcHBseSB3aGVuIHRoZSBjYW5v bmljYWwgcG9zaXRpb24gaXMgdW5lZGl0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExODY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82Mjk4 MjE2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGVjayBmb3IgdW5lZGl0YWJsZSBpbnNlcnRpb24gcG9zaXRpb24gYW5kIHJldHVybi4KKworICAg ICAgICBUZXN0OiBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaW1nLXVuZWRpdGFibGUtY2Fub25p Y2FsLXBvc2l0aW9uLWNyYXNoLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvSW5zZXJ0UGFyYWdy YXBoU2VwYXJhdG9yQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNlcnRQYXJhZ3Jh cGhTZXBhcmF0b3JDb21tYW5kOjpkb0FwcGx5KToKKwogMjAyMC0wNS0wOSAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIG1pc3NpbmcgbnVsbC1jaGVjayBvZiBw YWdlIGluIFJlc291cmNlTG9hZGVyOjpsb2FkRGF0YVVSTApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9JbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZC5jcHAKaW5k ZXggZmFmODE5Y2VlY2E5ZDMwZDIxZGJiNWM2MTM0ODFkOGZmN2VjYTQ2NC4uNTFhNzgyNDI0ODVj YjRmMzcwMDVmMTEzY2Y0ZWE1MjlkOGJiN2JiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9JbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0luc2VydFBhcmFncmFwaFNlcGFyYXRvckNvbW1hbmQuY3BwCkBAIC0z MDAsNiArMzAwLDEwIEBAIHZvaWQgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG9B cHBseSgpCiAgICAgLy8gaXQgaWYgdmlzaWJsZVBvcyBpcyBhdCB0aGUgc3RhcnQgb2YgYSBwYXJh Z3JhcGggc28gdGhhdCB0aGUgCiAgICAgLy8gY29udGVudCB3aWxsIG1vdmUgZG93biBhIGxpbmUu CiAgICAgaWYgKGlzU3RhcnRPZlBhcmFncmFwaCh2aXNpYmxlUG9zKSkgeworICAgICAgICAvLyBG SVhNRTogPGh0dHA6Ly93ZWJraXQub3JnL2IvMjExODY0PiBpbnNlcnRpb25Qb3NpdGlvbiBpcyBu b3QgYSBjYW5kaWRhdGUuIE5lZWRzIHRvIGZpbmQgYW4gZWRpdGFibGUgY2Fub25pY2FsIGNhbmRp ZGF0ZS4KKyAgICAgICAgaWYgKCFpc0VkaXRhYmxlUG9zaXRpb24oaW5zZXJ0aW9uUG9zaXRpb24p KQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGF1dG8gYnIgPSBIVE1MQlJFbGVtZW50 OjpjcmVhdGUoZG9jdW1lbnQoKSk7CiAgICAgICAgIGF1dG8qIGJyUHRyID0gYnIucHRyKCk7CiAg ICAgICAgIGluc2VydE5vZGVBdChXVEZNb3ZlKGJyKSwgaW5zZXJ0aW9uUG9zaXRpb24pOwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDBhNWQ4YjYzNzY4Y2YzYmZlYzg3NDJkNTQ0Yjg4MGU0MmNkNDJhODYuLjM3Zjc2YmM3NDA2 Y2Q1ODE3MWFlMmZhNjFlZTNjNmFkODJlYzkwNDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAy MC0wNS0xMyAgSmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBO dWxscHRyIGNyYXNoIGluIEluc2VydFBhcmFncmFwaFNlcGFyYXRvckNvbW1hbmQ6OmRvQXBwbHkg d2hlbiB0aGUgY2Fub25pY2FsIHBvc2l0aW9uIGlzIHVuZWRpdGFibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTg2NAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNjI5ODIxNjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QgZm9yIHRoZSBjcmFzaC4KKworICAg ICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwt cG9zaXRpb24tY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2lu c2VydGluZy9pbnNlcnQtaW1nLXVuZWRpdGFibGUtY2Fub25pY2FsLXBvc2l0aW9uLWNyYXNoLmh0 bWw6IEFkZGVkLgorCiAyMDIwLTA1LTA5ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gR2FyZGVuaW5nLCB1cGRhdGUgdGVzdCBleHBlY3RhdGlv bnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWct dW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWltZy11bmVkaXRhYmxlLWNhbm9uaWNhbC1w b3NpdGlvbi1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTVjZTgyZTE3NGM0NDgzNTA1 MDFmOGEzMjVlOTcwM2Q3N2JmZDJjYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Vk aXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24t Y3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1Rlc3RzIGluc2VydGluZyBwYXJhZ3Jh cGggc2VwYXJhdG9yIHdoZW4gYW4gZWRpdGFibGUgY2Fub25pY2FsIHBvc2l0aW9uIGlzIG5vdCBm b3VuZC4gVGhlIHRlc3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBhbiBz c2VydGlvbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2Vy dC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2guaHRtbCBiL0xheW91dFRl c3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9z aXRpb24tY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NjM5NjQ0MzZmYWJhZDlhNmNjYTA2NmE3OTUx OWY3YmRlZjYxZTJlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNl cnRpbmcvaW5zZXJ0LWltZy11bmVkaXRhYmxlLWNhbm9uaWNhbC1wb3NpdGlvbi1jcmFzaC5odG1s CkBAIC0wLDAgKzEsMTAgQEAKKzx2aWRlbz48c3BhbiBpZD1zcGFuX2NvcHk+PGlucHV0IGlkPWlu cHV0PjwvaW5wdXQ+PC9zcGFuPjwvdmlkZW8+PGJ1dHRvbj48L2J1dHRvbj48YXVkaW8+PGhyIGlk PWhyMSBjb250ZW50RWRpdGFibGU9InRydWUiPjxociBpZD1ocjI+PC9hdWRpbz48dGV4dGFyZWE+ PC90ZXh0YXJlYT4NCis8c2NyaXB0Pg0KKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpDQorICAg ICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsNCisgICAgaHIxLmFwcGVuZENoaWxkKHNwYW5f Y29weSk7DQorICAgIGlucHV0LnNldFNlbGVjdGlvblJhbmdlKC0xLDY3KTsNCisgICAgaHIyLmFw cGVuZENoaWxkKHNwYW5fY29weSk7DQorICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJpbnNlcnRJ bWFnZSIsICIjZm9vIik7DQorICAgIGRvY3VtZW50LmJvZHkuaW5uZXJUZXh0ID0gIlRlc3RzIGlu c2VydGluZyBwYXJhZ3JhcGggc2VwYXJhdG9yIHdoZW4gYW4gZWRpdGFibGUgY2Fub25pY2FsIHBv c2l0aW9uIGlzIG5vdCBmb3VuZC4gVGhlIHRlc3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vzbid0IGNy YXNoIG9yIGhpdCBhbiBzc2VydGlvbi4iOw0KKzwvc2NyaXB0Pg0K 399318 2020-05-13 17:09:29 -0700 2020-05-13 17:45:50 -0700 Patch for landing bug-211864-20200513170929.patch text/plain 4458 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNkYzdkY2Q4MzYzY2I5 MjFjZTBkODNjNDQ0M2I0NTZhOTY3M2MzYi4uOTNmZDQ4OWY4OGNlNDgyNTMyOTc2YmQxNWU3MmUz MWY5ZGE3ZjY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA1LTEzICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG9BcHBseSB3aGVuIHRoZSBjYW5v bmljYWwgcG9zaXRpb24gaXMgdW5lZGl0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExODY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82Mjk4 MjE2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KKworICAgICAgICBU aGUgcG9zaXRpb24gcmV0dXJuZWQgYnkgcG9zaXRpb25Bdm9pZGluZ1NwZWNpYWxFbGVtZW50Qm91 bmRhcnkoKSBpcyB1bmVkaXRhYmxlIHNvIHdlIG5lZWQgdG8gCisgICAgICAgIGNoZWNrIGZvciB1 bmVkaXRhYmxlIGluc2VydGlvbiBwb3NpdGlvbiBhbmQgYmFpbCBvdXQgYmVmb3JlIGNhbGxpbmcg aW5zZXJ0Tm9kZUF0IHRvIGF2b2lkIGFzc2VydGlvbi4KKworICAgICAgICBUZXN0OiBlZGl0aW5n L2luc2VydGluZy9pbnNlcnQtaW1nLXVuZWRpdGFibGUtY2Fub25pY2FsLXBvc2l0aW9uLWNyYXNo Lmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFu ZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5k Ojpkb0FwcGx5KToKKwogMjAyMC0wNS0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIG1pc3NpbmcgbnVsbC1jaGVjayBvZiBwYWdlIGluIFJlc291cmNlTG9h ZGVyOjpsb2FkRGF0YVVSTApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNl cnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv SW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZC5jcHAKaW5kZXggZmFmODE5Y2VlY2E5ZDMw ZDIxZGJiNWM2MTM0ODFkOGZmN2VjYTQ2NC4uYWUwYTI5YjhmYTM2NzJiZTI4MmU3MjBhZDhjZDA1 MTI3NDM3MmZkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNlcnRQYXJh Z3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0lu c2VydFBhcmFncmFwaFNlcGFyYXRvckNvbW1hbmQuY3BwCkBAIC0zMDAsNiArMzAwLDEwIEBAIHZv aWQgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG9BcHBseSgpCiAgICAgLy8gaXQg aWYgdmlzaWJsZVBvcyBpcyBhdCB0aGUgc3RhcnQgb2YgYSBwYXJhZ3JhcGggc28gdGhhdCB0aGUg CiAgICAgLy8gY29udGVudCB3aWxsIG1vdmUgZG93biBhIGxpbmUuCiAgICAgaWYgKGlzU3RhcnRP ZlBhcmFncmFwaCh2aXNpYmxlUG9zKSkgeworICAgICAgICAvLyBGSVhNRTogPGh0dHA6Ly93ZWJr aXQub3JnL2IvMjExODY0PiBJZiBpbnNlcnRpb25Qb3NpdGlvbiBpcyBub3QgZWRpdGFibGUsIHdl IHNob3VsZCBjb21wdXRlIGEgcG9zaXRpb24gdGhhdCBpcy4KKyAgICAgICAgaWYgKCFpc0VkaXRh YmxlUG9zaXRpb24oaW5zZXJ0aW9uUG9zaXRpb24pKQorICAgICAgICAgICAgcmV0dXJuOworCiAg ICAgICAgIGF1dG8gYnIgPSBIVE1MQlJFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQoKSk7CiAgICAg ICAgIGF1dG8qIGJyUHRyID0gYnIucHRyKCk7CiAgICAgICAgIGluc2VydE5vZGVBdChXVEZNb3Zl KGJyKSwgaW5zZXJ0aW9uUG9zaXRpb24pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDBhNWQ4YjYzNzY4Y2YzYmZlYzg3NDJk NTQ0Yjg4MGU0MmNkNDJhODYuLjFkZWMwZDlmNWM2MmZhNzY5NmI4ZWJiMWY2ZjhmZDlhYTg2MDJh M2EgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wNS0xMyAgSmFjayBMZWUgIDxzaGloY2hp ZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRyIGNyYXNoIGluIEluc2VydFBhcmFn cmFwaFNlcGFyYXRvckNvbW1hbmQ6OmRvQXBwbHkgd2hlbiB0aGUgY2Fub25pY2FsIHBvc2l0aW9u IGlzIHVuZWRpdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMTg2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjI5ODIxNjE+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNz aW9uIHRlc3QgZm9yIHRoZSBjcmFzaC4KKworICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL2lu c2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2gtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaW1nLXVuZWRpdGFi bGUtY2Fub25pY2FsLXBvc2l0aW9uLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIwLTA1LTA5ICBE aWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gR2Fy ZGVuaW5nLCB1cGRhdGUgdGVzdCBleHBlY3RhdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRp b24tY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5z ZXJ0LWltZy11bmVkaXRhYmxlLWNhbm9uaWNhbC1wb3NpdGlvbi1jcmFzaC1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uYTVjZTgyZTE3NGM0NDgzNTA1MDFmOGEzMjVlOTcwM2Q3N2JmZDJjYQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWct dW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEgQEAKK1Rlc3RzIGluc2VydGluZyBwYXJhZ3JhcGggc2VwYXJhdG9yIHdoZW4gYW4gZWRpdGFi bGUgY2Fub25pY2FsIHBvc2l0aW9uIGlzIG5vdCBmb3VuZC4gVGhlIHRlc3QgcGFzc2VzIGlmIFdl YktpdCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBhbiBzc2VydGlvbi4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwt cG9zaXRpb24tY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2Vy dC1pbWctdW5lZGl0YWJsZS1jYW5vbmljYWwtcG9zaXRpb24tY3Jhc2guaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li43NjM5NjQ0MzZmYWJhZDlhNmNjYTA2NmE3OTUxOWY3YmRlZjYxZTJlCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWltZy11bmVkaXRhYmxl LWNhbm9uaWNhbC1wb3NpdGlvbi1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMTAgQEAKKzx2aWRlbz48 c3BhbiBpZD1zcGFuX2NvcHk+PGlucHV0IGlkPWlucHV0PjwvaW5wdXQ+PC9zcGFuPjwvdmlkZW8+ PGJ1dHRvbj48L2J1dHRvbj48YXVkaW8+PGhyIGlkPWhyMSBjb250ZW50RWRpdGFibGU9InRydWUi PjxociBpZD1ocjI+PC9hdWRpbz48dGV4dGFyZWE+PC90ZXh0YXJlYT4NCis8c2NyaXB0Pg0KKyAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpDQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQo KTsNCisgICAgaHIxLmFwcGVuZENoaWxkKHNwYW5fY29weSk7DQorICAgIGlucHV0LnNldFNlbGVj dGlvblJhbmdlKC0xLDY3KTsNCisgICAgaHIyLmFwcGVuZENoaWxkKHNwYW5fY29weSk7DQorICAg IGRvY3VtZW50LmV4ZWNDb21tYW5kKCJpbnNlcnRJbWFnZSIsICIjZm9vIik7DQorICAgIGRvY3Vt ZW50LmJvZHkuaW5uZXJUZXh0ID0gIlRlc3RzIGluc2VydGluZyBwYXJhZ3JhcGggc2VwYXJhdG9y IHdoZW4gYW4gZWRpdGFibGUgY2Fub25pY2FsIHBvc2l0aW9uIGlzIG5vdCBmb3VuZC4gVGhlIHRl c3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBhbiBzc2VydGlvbi4iOw0K Kzwvc2NyaXB0Pg0K