211857 2020-05-13 12:20:54 -0700 Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView]. 2020-05-13 13:52:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1652333 0 andresg_22 2020-05-13 12:20:54 -0700 Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView]. 1652336 1 399287 andresg_22 2020-05-13 12:25:20 -0700 Created attachment 399287 Patch 1652345 2 399287 cfleizach 2020-05-13 12:46:51 -0700 Comment on attachment 399287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399287&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560 > + auto *backingObject = protectedSelf.get().axBackingObject; I think this * is on the wrong side 1652351 3 399291 andresg_22 2020-05-13 13:12:56 -0700 Created attachment 399291 Patch 1652352 4 andresg_22 2020-05-13 13:14:25 -0700 (In reply to chris fleizach from comment #2) > Comment on attachment 399287 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399287&action=review > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560 > > + auto *backingObject = protectedSelf.get().axBackingObject; > > I think this * is on the wrong side Fixed. 1652378 5 ews-feeder 2020-05-13 13:51:56 -0700 Committed r261653: <https://trac.webkit.org/changeset/261653> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399291. 1652379 6 webkit-bug-importer 2020-05-13 13:52:13 -0700 <rdar://problem/63198631> 399287 2020-05-13 12:25:20 -0700 2020-05-13 13:12:54 -0700 Patch bug-211857-20200513152519.patch text/plain 2138 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY2OTliNjhiMDIzZWQz MmIxMTkxOGE3OTU5NTYwZjhlZWViNTFiNy4uZmM3MGI1OTE3NDUwNWMyNjZhZmJhZDY5YjQxZTcz YzYzZGEyZDVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTEzICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5u ZWNlc3NhcnkgYXNzZXJ0IGluIHtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhdHRhY2ht ZW50Vmlld10uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTE4NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGFzc2VydCBpcyB1bm5lY2Vzc2FyeSBzaW5jZSB0aGUgYmFja2luZyBvYmplY3QgdGhh dCBpcyByZWxldmFudCBpcworICAgICAgICB0aGUgb25lIG9uIHRoZSBtYWluIHRocmVhZC4gVGhp cyB3YXMgY2F1c2luZyBjcmFzaGVzIGluIExheW91dFRlc3QgaW4KKyAgICAgICAgaXNvbGF0ZWQg dHJlZSBtb2RlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyIGF0dGFjaG1lbnRWaWV3XSk6CisKIDIwMjAtMDUtMTMgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2MTAyMyk6IFtHVEtd W1dQRV0gU2V2ZXJhbCBXZWJHTCB0ZXN0cyBhcmUgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJN YWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlck1hYy5tbQppbmRleCBlODFhOWMyNDg1ZGIzYjdmODllYTMzYzFjMmM2OWE2 OWRmY2I5ZjE3Li5kZDk3ZDg0YjYxNWFkYzAxOGEyNTYzZWNjOTdmOTU0ZGJiZTdjNDk1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21h Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQpAQCAtNTU2LDEzICs1NTYsMTMg QEAgZXh0ZXJuICJDIiBBWFVJRWxlbWVudFJlZiBOU0FjY2Vzc2liaWxpdHlDcmVhdGVBWFVJRWxl bWVudFJlZihpZCBlbGVtZW50KTsKIAogLSAoaWQpYXR0YWNobWVudFZpZXcKIHsKLSAgICBBU1NF UlQoc2VsZi5heEJhY2tpbmdPYmplY3QtPmlzQXR0YWNobWVudCgpKTsKLQogICAgIHJldHVybiBB Y2Nlc3NpYmlsaXR5OjpyZXRyaWV2ZUF1dG9yZWxlYXNlZFZhbHVlRnJvbU1haW5UaHJlYWQ8aWQ+ KFtwcm90ZWN0ZWRTZWxmID0gcmV0YWluUHRyKHNlbGYpXSAoKSAtPiBSZXRhaW5QdHI8aWQ+IHsK LSAgICAgICAgYXV0byogd2lkZ2V0ID0gcHJvdGVjdGVkU2VsZi5nZXQoKS5heEJhY2tpbmdPYmpl Y3QtPndpZGdldEZvckF0dGFjaG1lbnRWaWV3KCk7Ci0gICAgICAgIGlmICghd2lkZ2V0KQorICAg ICAgICBhdXRvICpiYWNraW5nT2JqZWN0ID0gcHJvdGVjdGVkU2VsZi5nZXQoKS5heEJhY2tpbmdP YmplY3Q7CisgICAgICAgIGlmICghYmFja2luZ09iamVjdCkKICAgICAgICAgICAgIHJldHVybiBu aWw7Ci0gICAgICAgIHJldHVybiBOU0FjY2Vzc2liaWxpdHlVbmlnbm9yZWREZXNjZW5kYW50KHdp ZGdldC0+cGxhdGZvcm1XaWRnZXQoKSk7CisKKyAgICAgICAgYXV0byAqd2lkZ2V0ID0gYmFja2lu Z09iamVjdC0+d2lkZ2V0Rm9yQXR0YWNobWVudFZpZXcoKTsKKyAgICAgICAgcmV0dXJuIHdpZGdl dCA/IE5TQWNjZXNzaWJpbGl0eVVuaWdub3JlZERlc2NlbmRhbnQod2lkZ2V0LT5wbGF0Zm9ybVdp ZGdldCgpKSA6IG5pbDsKICAgICB9KTsKIH0KIAo= 399291 2020-05-13 13:12:56 -0700 2020-05-13 13:51:57 -0700 Patch bug-211857-20200513161255.patch text/plain 2138 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY2OTliNjhiMDIzZWQz MmIxMTkxOGE3OTU5NTYwZjhlZWViNTFiNy4uZmM3MGI1OTE3NDUwNWMyNjZhZmJhZDY5YjQxZTcz YzYzZGEyZDVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTEzICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5u ZWNlc3NhcnkgYXNzZXJ0IGluIHtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhdHRhY2ht ZW50Vmlld10uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTE4NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGFzc2VydCBpcyB1bm5lY2Vzc2FyeSBzaW5jZSB0aGUgYmFja2luZyBvYmplY3QgdGhh dCBpcyByZWxldmFudCBpcworICAgICAgICB0aGUgb25lIG9uIHRoZSBtYWluIHRocmVhZC4gVGhp cyB3YXMgY2F1c2luZyBjcmFzaGVzIGluIExheW91dFRlc3QgaW4KKyAgICAgICAgaXNvbGF0ZWQg dHJlZSBtb2RlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyIGF0dGFjaG1lbnRWaWV3XSk6CisKIDIwMjAtMDUtMTMgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2MTAyMyk6IFtHVEtd W1dQRV0gU2V2ZXJhbCBXZWJHTCB0ZXN0cyBhcmUgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJN YWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlck1hYy5tbQppbmRleCBlODFhOWMyNDg1ZGIzYjdmODllYTMzYzFjMmM2OWE2 OWRmY2I5ZjE3Li5hYmFhNTJmMmVhYmU3ZWFiZjgzMjYyZTY5OGI5M2U0MGIxN2I5NzdiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21h Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQpAQCAtNTU2LDEzICs1NTYsMTMg QEAgZXh0ZXJuICJDIiBBWFVJRWxlbWVudFJlZiBOU0FjY2Vzc2liaWxpdHlDcmVhdGVBWFVJRWxl bWVudFJlZihpZCBlbGVtZW50KTsKIAogLSAoaWQpYXR0YWNobWVudFZpZXcKIHsKLSAgICBBU1NF UlQoc2VsZi5heEJhY2tpbmdPYmplY3QtPmlzQXR0YWNobWVudCgpKTsKLQogICAgIHJldHVybiBB Y2Nlc3NpYmlsaXR5OjpyZXRyaWV2ZUF1dG9yZWxlYXNlZFZhbHVlRnJvbU1haW5UaHJlYWQ8aWQ+ KFtwcm90ZWN0ZWRTZWxmID0gcmV0YWluUHRyKHNlbGYpXSAoKSAtPiBSZXRhaW5QdHI8aWQ+IHsK LSAgICAgICAgYXV0byogd2lkZ2V0ID0gcHJvdGVjdGVkU2VsZi5nZXQoKS5heEJhY2tpbmdPYmpl Y3QtPndpZGdldEZvckF0dGFjaG1lbnRWaWV3KCk7Ci0gICAgICAgIGlmICghd2lkZ2V0KQorICAg ICAgICBhdXRvKiBiYWNraW5nT2JqZWN0ID0gcHJvdGVjdGVkU2VsZi5nZXQoKS5heEJhY2tpbmdP YmplY3Q7CisgICAgICAgIGlmICghYmFja2luZ09iamVjdCkKICAgICAgICAgICAgIHJldHVybiBu aWw7Ci0gICAgICAgIHJldHVybiBOU0FjY2Vzc2liaWxpdHlVbmlnbm9yZWREZXNjZW5kYW50KHdp ZGdldC0+cGxhdGZvcm1XaWRnZXQoKSk7CisKKyAgICAgICAgYXV0byogd2lkZ2V0ID0gYmFja2lu Z09iamVjdC0+d2lkZ2V0Rm9yQXR0YWNobWVudFZpZXcoKTsKKyAgICAgICAgcmV0dXJuIHdpZGdl dCA/IE5TQWNjZXNzaWJpbGl0eVVuaWdub3JlZERlc2NlbmRhbnQod2lkZ2V0LT5wbGF0Zm9ybVdp ZGdldCgpKSA6IG5pbDsKICAgICB9KTsKIH0KIAo=