<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>211847</bug_id>
          
          <creation_ts>2020-05-13 09:40:17 -0700</creation_ts>
          <short_desc>[buildbot] Increase blocksize of file transfer in UploadTestResults step</short_desc>
          <delta_ts>2020-05-15 05:33:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Diego Pino">dpino</reporter>
          <assigned_to name="Diego Pino">dpino</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1652258</commentid>
    <comment_count>0</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2020-05-13 09:40:17 -0700</bug_when>
    <thetext>[buildbot] Increase blocksize of file transfer in UploadTestResults step</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652260</commentid>
    <comment_count>1</comment_count>
      <attachid>399274</attachid>
    <who name="Diego Pino">dpino</who>
    <bug_when>2020-05-13 09:44:56 -0700</bug_when>
    <thetext>Created attachment 399274
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652264</commentid>
    <comment_count>2</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2020-05-13 09:57:05 -0700</bug_when>
    <thetext>All other steps involving file transfers set their blocksize as 256Kb (build.webkit.org-config/steps.py:UploadBuiltProduct, ews-build/steps.py:UploadBuiltProduct and ews-build/steps.py:UploadTestResults).

In the case of the GTK and WPE test bots, the UploadTestResults is particularly slow. Digging into this issue I found out a small blocksize might be a reason for slow file transfers in Buildbot, specially in the case of big files (https://github.com/buildbot/buildbot/pull/4354). In particular, Buildbot v1.6.0 fixed this issue by making the default file transfer blocksize 256Kb, and I think this might be the reason why all the other file transfer steps have set their blocksize to this value.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1652384</commentid>
    <comment_count>3</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-05-13 13:59:20 -0700</bug_when>
    <thetext>(In reply to Diego Pino from comment #2)
&gt; specially in the case of big files (https://github.com/buildbot/buildbot/pull/4354). In particular, Buildbot v1.6.0 fixed this issue by making the default file transfer blocksize 256Kb
Yup! I remember making that PR in buildbot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1653017</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-05-15 05:32:13 -0700</bug_when>
    <thetext>Committed r261739: &lt;https://trac.webkit.org/changeset/261739&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399274.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1653018</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-05-15 05:33:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/63267637&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>399274</attachid>
            <date>2020-05-13 09:44:56 -0700</date>
            <delta_ts>2020-05-15 05:32:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-211847-20200513164455.patch</filename>
            <type>text/plain</type>
            <size>1480</size>
            <attacher name="Diego Pino">dpino</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNjE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTc1NTllNjY1Y2VhYjE4YjcwMGU2Y2Y5MTk4ZWVlNjY0
NWZlYjNiNS4uMTU0MWJjZTcwMmQ2ZjY3OGViMzIwNWI1ZmZiMGU0ZTI4MGRiNmVmNSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDIwLTA1LTEzICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK
KyAgICAgICAgW2J1aWxkYm90XSBJbmNyZWFzZSBibG9ja3NpemUgb2YgZmlsZSB0cmFuc2ZlciBp
biBVcGxvYWRUZXN0UmVzdWx0cyBzdGVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0yMTE4NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBBbGwgb3RoZXIgc3RlcHMgaW52b2x2aW5nIGZpbGUgdHJhbnNmZXIg
dXBsb2FkcyB1c2UgMjU2a2IgYXMgYmxvY2sKKyAgICAgICAgc2l6ZS4gTWFrZSB0aGlzIHN0ZXAg
aW4gbGluZSB3aXRoIG90aGVycy4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxk
LndlYmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5OgorICAgICAgICAoVXBsb2FkVGVzdFJlc3VsdHMu
X19pbml0X18pOgorCiAyMDIwLTA1LTEzICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh
bGlhLmNvbT4KIAogICAgICAgICBbRmxhdHBhayBTREtdIFByb3BlciBoYW5kbGluZyBvZiBzY2Nh
Y2hlIHNjaGVkdWxlciBVUkwgY29tbWFuZC1saW5lIGFyZ3VtZW50CmRpZmYgLS1naXQgYS9Ub29s
cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVwcy5weSBiL1Rv
b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5Cmlu
ZGV4IGIyZjJjOTE4MGE2M2U1ZWZmZDRiZjg3YzBmY2QxZDMzOWVkNjUwZjkuLjQwNmU0NmY3Njdk
N2IyMWI4MDEzMGY0OWU4M2VkZWY2NjMyYmI3OTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xh
dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5CisrKyBiL1Rvb2xzL0J1
aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5CkBAIC0xMDE4
LDYgKzEwMTgsNyBAQCBjbGFzcyBVcGxvYWRUZXN0UmVzdWx0cyh0cmFuc2Zlci5GaWxlVXBsb2Fk
KToKICAgICAgICAga3dhcmdzWydzbGF2ZXNyYyddID0gc2VsZi5zbGF2ZXNyYwogICAgICAgICBr
d2FyZ3NbJ21hc3RlcmRlc3QnXSA9IHNlbGYubWFzdGVyZGVzdAogICAgICAgICBrd2FyZ3NbJ21v
ZGUnXSA9IDA2NDQKKyAgICAgICAga3dhcmdzWydibG9ja3NpemUnXSA9IDEwMjQgKiAyNTYKICAg
ICAgICAgdHJhbnNmZXIuRmlsZVVwbG9hZC5fX2luaXRfXyhzZWxmLCAqKmt3YXJncykKIAogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>