211823 2020-05-12 18:48:30 -0700 Exception check for OOM is a bit too late in JSBigInt::exponentiate. 2020-05-12 20:10:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1652074 0 rmorisset 2020-05-12 18:48:30 -0700 10n**1000000n crashes instead of throwing an exception. The cause is simple: we try to look at the result one line before verifying that the operation succeeded. rdar://problem/63084376 1652078 1 399222 rmorisset 2020-05-12 18:52:27 -0700 Created attachment 399222 Patch 1652080 2 399222 mark.lam 2020-05-12 18:55:57 -0700 Comment on attachment 399222 Patch r=me 1652102 3 ews-feeder 2020-05-12 20:09:54 -0700 Committed r261596: <https://trac.webkit.org/changeset/261596> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399222. 1652103 4 webkit-bug-importer 2020-05-12 20:10:18 -0700 <rdar://problem/63166523> 399222 2020-05-12 18:52:27 -0700 2020-05-12 20:09:55 -0700 Patch patch211823 text/plain 3675 rmorisset ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MDlkMmQyMTUyMjcuLmZkZjI1YjdhOWIxIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZwor KysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTEyICBSb2Jp biBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAgRXhjZXB0aW9uIGNo ZWNrIGZvciBPT00gaXMgYSBiaXQgdG9vIGxhdGUgaW4gSlNCaWdJbnQ6OmV4cG9uZW50aWF0ZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTgyMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEp1c3QgYWRk IG9uZSBtb3JlIGNhc2Ugc28gdGhhdCB0aGlzIHRlc3Qgbm93IGNhdGNoZXMgdGhpcyBidWcgKHRo ZSBjb250cm9sLWZsb3cgdGhyb3VnaCBKU0JpZ0ludDo6ZXhwb25lbnRpYXRlIGlzIHByZXR0eSBj b252b2x1dGVkKS4KKworICAgICAgICAqIHN0cmVzcy9iaWdpbnQtZXhwb25lbnRpYWwtb29tLmpz OgorICAgICAgICAoc2hvdWxkVGhyb3cpOgorCiAyMDIwLTA1LTExICBQYXVsbyBNYXRvcyAgPHBt YXRvc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFNraXAgb24gYXJtdjcvbGludXggc3RyZXNzL2Fy cmF5LWJ1ZmZlci12aWV3LXdhdGNocG9pbnQtY2FuLWJlLWZpcmVkLWluLXJlYWxseS1hZGQtaW4t ZGZnLmpzCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9iaWdpbnQtZXhwb25lbnRpYWwtb29t LmpzIGIvSlNUZXN0cy9zdHJlc3MvYmlnaW50LWV4cG9uZW50aWFsLW9vbS5qcwppbmRleCBiOWY5 MDZhZDhiNS4uZTdiNTVhYzMzNWIgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2JpZ2ludC1l eHBvbmVudGlhbC1vb20uanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvYmlnaW50LWV4cG9uZW50aWFs LW9vbS5qcwpAQCAtMjgsMyArMjgsNiBAQCBzaG91bGRUaHJvdygoKSA9PiB7CiBzaG91bGRUaHJv dygoKSA9PiB7CiAgICAgMm4gKiogMHhmZmZmZmZmZmZmZmZmZmZuOwogfSwgYEVycm9yOiBPdXQg b2YgbWVtb3J5OiBCaWdJbnQgZ2VuZXJhdGVkIGZyb20gdGhpcyBvcGVyYXRpb24gaXMgdG9vIGJp Z2ApOworc2hvdWxkVGhyb3coKCkgPT4geworICAgIDEwbiAqKiAxMDAwMDAwbjsKK30sIGBFcnJv cjogT3V0IG9mIG1lbW9yeTogQmlnSW50IGdlbmVyYXRlZCBmcm9tIHRoaXMgb3BlcmF0aW9uIGlz IHRvbyBiaWdgKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZkNTg5NDY4NDAxLi5lMWFj NjExZmNiNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAt MDUtMTIgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBF eGNlcHRpb24gY2hlY2sgZm9yIE9PTSBpcyBhIGJpdCB0b28gbGF0ZSBpbiBKU0JpZ0ludDo6ZXhw b25lbnRpYXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjExODIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2Ugd2VyZSBkb2luZyBtdWx0aXBseUltcGwoLi4uKS5wYXlsb2FkLmFzSGVhcEJpZ0ludCgp LCBidXQgbXVsdGlwbHlJbXBsIGNhbiByZXR1cm4gYSBudWxsIHBheWxvYWQgaWYgaXQgY2F1c2Vz IGFuIGV4Y2VwdGlvbi4KKyAgICAgICAgU28gd2UgbXVzdCBmaXJzdCBjaGVjayB3aGV0aGVyIGFu IGV4Y2VwdGlvbiB3YXMgcmFpc2VkLCBhbmQgb25seSBpZiBub3QgY2FuIHdlIGRvIGFzSGVhcEJp Z0ludC4KKworICAgICAgICAqIHJ1bnRpbWUvSlNCaWdJbnQuY3BwOgorICAgICAgICAoSlNDOjpK U0JpZ0ludDo6ZXhwb25lbnRpYXRlSW1wbCk6CisKIDIwMjAtMDUtMTEgIEtlaXRoIE1pbGxlciAg PGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBCeXRlY29k ZUtpbGxzLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQmln SW50LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQmlnSW50LmNwcAppbmRl eCA4MmI3ZmIxOWQwYy4uYWZmMTViZjZlOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTQmlnSW50LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0JpZ0ludC5jcHAKQEAgLTQ4MiwxNSArNDgyLDIxIEBAIEpTQmlnSW50OjpJbXBsUmVz dWx0IEpTQmlnSW50OjpleHBvbmVudGlhdGVJbXBsKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmpl Y3QsIEJpCiAKICAgICBuID4+PSAxOwogICAgIGZvciAoOyBuOyBuID4+PSAxKSB7Ci0gICAgICAg IEpTQmlnSW50KiBtYXliZVJlc3VsdCA9IEpTQmlnSW50OjptdWx0aXBseUltcGwoZ2xvYmFsT2Jq ZWN0LCBIZWFwQmlnSW50SW1wbCB7IHJ1bm5pbmdTcXVhcmUgfSwgSGVhcEJpZ0ludEltcGwgeyBy dW5uaW5nU3F1YXJlIH0pLnBheWxvYWQuYXNIZWFwQmlnSW50KCk7CisgICAgICAgIEltcGxSZXN1 bHQgdGVtcCA9IEpTQmlnSW50OjptdWx0aXBseUltcGwoZ2xvYmFsT2JqZWN0LCBIZWFwQmlnSW50 SW1wbCB7IHJ1bm5pbmdTcXVhcmUgfSwgSGVhcEJpZ0ludEltcGwgeyBydW5uaW5nU3F1YXJlIH0p OwogICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBudWxscHRyKTsKKyAgICAgICAg QVNTRVJUKHRlbXAucGF5bG9hZCk7CisgICAgICAgIEFTU0VSVCh0ZW1wLnBheWxvYWQuaXNIZWFw QmlnSW50KCkpOworICAgICAgICBKU0JpZ0ludCogbWF5YmVSZXN1bHQgPSB0ZW1wLnBheWxvYWQu YXNIZWFwQmlnSW50KCk7CiAgICAgICAgIHJ1bm5pbmdTcXVhcmUgPSBtYXliZVJlc3VsdDsKICAg ICAgICAgaWYgKG4gJiAxKSB7CiAgICAgICAgICAgICBpZiAoIXJlc3VsdCkKICAgICAgICAgICAg ICAgICByZXN1bHQgPSBydW5uaW5nU3F1YXJlOwogICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAg ICAgICAgICAgbWF5YmVSZXN1bHQgPSBKU0JpZ0ludDo6bXVsdGlwbHlJbXBsKGdsb2JhbE9iamVj dCwgSGVhcEJpZ0ludEltcGwgeyByZXN1bHQgfSwgSGVhcEJpZ0ludEltcGwgeyBydW5uaW5nU3F1 YXJlIH0pLnBheWxvYWQuYXNIZWFwQmlnSW50KCk7CisgICAgICAgICAgICAgICAgdGVtcCA9IEpT QmlnSW50OjptdWx0aXBseUltcGwoZ2xvYmFsT2JqZWN0LCBIZWFwQmlnSW50SW1wbCB7IHJlc3Vs dCB9LCBIZWFwQmlnSW50SW1wbCB7IHJ1bm5pbmdTcXVhcmUgfSk7CiAgICAgICAgICAgICAgICAg UkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgbnVsbHB0cik7CisgICAgICAgICAgICAgICAgQVNT RVJUKHRlbXAucGF5bG9hZCk7CisgICAgICAgICAgICAgICAgQVNTRVJUKHRlbXAucGF5bG9hZC5p c0hlYXBCaWdJbnQoKSk7CisgICAgICAgICAgICAgICAgbWF5YmVSZXN1bHQgPSB0ZW1wLnBheWxv YWQuYXNIZWFwQmlnSW50KCk7CiAgICAgICAgICAgICAgICAgcmVzdWx0ID0gbWF5YmVSZXN1bHQ7 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K