211805 2020-05-12 13:57:26 -0700 Move @isConstructor checks from fast paths of Array.from and Array.of 2020-05-13 00:09:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=144093 InRadar P2 Enhancement --- 1 ashvayka ashvayka darin ews-watchlist joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1651921 0 ashvayka 2020-05-12 13:57:26 -0700 Per Darin's comment on Slack, this change was extracted from https://bugs.webkit.org/attachment.cgi?id=399164. 1651930 1 399174 ashvayka 2020-05-12 14:09:04 -0700 Created attachment 399174 Patch 1651938 2 399174 darin 2020-05-12 14:15:53 -0700 Comment on attachment 399174 Patch Thanks it’s good to have this separately. 1652137 3 ews-feeder 2020-05-13 00:08:17 -0700 Committed r261601: <https://trac.webkit.org/changeset/261601> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399174. 1652138 4 webkit-bug-importer 2020-05-13 00:09:19 -0700 <rdar://problem/63172597> 399174 2020-05-12 14:09:04 -0700 2020-05-13 00:08:18 -0700 Patch bug-211805-20200513000902.patch text/plain 5508 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjE1NzcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTEyICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBNb3ZlIEBpc0NvbnN0cnVjdG9yIGNoZWNrcyBmcm9tIGZh c3QgcGF0aHMgb2YgQXJyYXkuZnJvbSBhbmQgQXJyYXkub2YKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTgwNQorCisgICAgICAgIFJldmlld2VkIGJ5 IEtlaXRoIE1pbGxlci4KKworICAgICAgICAqIG1pY3JvYmVuY2htYXJrcy9hcnJheS1mcm9tLWFy cmF5bGlrZS5qczogQWRkZWQuCisgICAgICAgICogbWljcm9iZW5jaG1hcmtzL2FycmF5LW9mLmpz OiBBZGRlZC4KKyAgICAgICAgKiBzdHJlc3MvbmV3LXByb21pc2UtY2FwYWJpbGl0aWVzLXJlcXVp cmVzLWNvbnN0cnVjdG9yLmpzOgorCiAyMDIwLTA1LTExICBQYXVsbyBNYXRvcyAgPHBtYXRvc0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFNraXAgb24gYXJtdjcvbGludXggc3RyZXNzL2FycmF5LWJ1 ZmZlci12aWV3LXdhdGNocG9pbnQtY2FuLWJlLWZpcmVkLWluLXJlYWxseS1hZGQtaW4tZGZnLmpz CkluZGV4OiBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9hcnJheS1mcm9tLWFycmF5bGlrZS5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9hcnJheS1mcm9tLWFycmF5bGlr ZS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9hcnJheS1mcm9t LWFycmF5bGlrZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMgQEAKK2NvbnN0IGl0ZW1z ID0gezA6MCwgMToxLCAyOjIsIDM6MywgNDo0LCBsZW5ndGg6IDV9OworZm9yIChsZXQgaSA9IDA7 IGkgPCAxZTY7ICsraSkKKyAgICBBcnJheS5mcm9tKGl0ZW1zKTsKSW5kZXg6IEpTVGVzdHMvbWlj cm9iZW5jaG1hcmtzL2FycmF5LW9mLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvbWljcm9iZW5j aG1hcmtzL2FycmF5LW9mLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvbWljcm9iZW5jaG1h cmtzL2FycmF5LW9mLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMiBAQAorZm9yIChsZXQg aSA9IDA7IGkgPCAxZTY7ICsraSkKKyAgICBBcnJheS5vZigwLCAxLCAyLCAzLCA0KTsKSW5kZXg6 IEpTVGVzdHMvc3RyZXNzL25ldy1wcm9taXNlLWNhcGFiaWxpdGllcy1yZXF1aXJlcy1jb25zdHJ1 Y3Rvci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9uZXctcHJvbWlzZS1jYXBhYmls aXRpZXMtcmVxdWlyZXMtY29uc3RydWN0b3IuanMJKHJldmlzaW9uIDI2MTU1NikKKysrIEpTVGVz dHMvc3RyZXNzL25ldy1wcm9taXNlLWNhcGFiaWxpdGllcy1yZXF1aXJlcy1jb25zdHJ1Y3Rvci5q cwkod29ya2luZyBjb3B5KQpAQCAtMTUsNCArMTUsNCBAQCBmdW5jdGlvbiBzaG91bGRUaHJvdyhm dW5jLCBlcnJvck1lc3NhZ2UpCiAKIHNob3VsZFRocm93KCgpID0+IHsKICAgICBQcm9taXNlLnJh Y2UuY2FsbCgoKSA9PiB7IH0sIFtdKTsKLX0sIGBUeXBlRXJyb3I6IHByb21pc2UgY2FwYWJpbGl0 eSByZXF1aXJlcyBhIGNvbnN0cnVjdG9yIGZ1bmN0aW9uYCk7Cit9LCBgVHlwZUVycm9yOiBmdW5j dGlvbiBpcyBub3QgYSBjb25zdHJ1Y3RvcmApOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjE1NTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDUtMTIgIEFsZXhleSBTaHZheWth ICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisgICAgICAgIE1vdmUgQGlzQ29uc3RydWN0b3Ig Y2hlY2tzIGZyb20gZmFzdCBwYXRocyBvZiBBcnJheS5mcm9tIGFuZCBBcnJheS5vZgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExODA1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgS2VpdGggTWlsbGVyLgorCisgICAgICAgIFRoaXMgc2VtYW50aWNhbGx5 IGVxdWl2YWxlbnQgY2hhbmdlIGFkdmFuY2VzIHByb3ZpZGVkIEFycmF5Lntmcm9tLG9mfSBtaWNy b2JlbmNobWFya3MgYnkgfjYwJS4gCisKKyAgICAgICAgQWxzbywgdGhpcyBwYXRjaCByZW1vdmVz IEBpc0NvbnN0cnVjdG9yIGNoZWNrIGZyb20gQG5ld1Byb21pc2VDYXBhYmlsaXR5U2xvdyAodGhh dCBpcyBoZWF2aWx5CisgICAgICAgIHVzZWQgYnkgUHJvbWlzZSBzdWJjbGFzc2VzKSBzaW5jZSBp dCBjb21lcyByaWdodCBiZWZvcmUgW1tDb25zdHJ1Y3RdXSwgaXRzIG1lc3NhZ2UgZG9lc24ndCBh ZGQKKyAgICAgICAgbW9yZSBjbGFyaXR5LCBhbmQgY29uc3RydWN0YWJpbGl0eSBvZiBpdHMgYXJn dW1lbnQgd2FzIGxpa2VseSBjaGVja2VkIGJ5IEBzcGVjaWVzQ29uc3RydWN0b3IuCisKKyAgICAg ICAgKiBidWlsdGlucy9BcnJheUNvbnN0cnVjdG9yLmpzOgorICAgICAgICAob2YpOgorICAgICAg ICAoZnJvbSk6CisgICAgICAgICogYnVpbHRpbnMvUHJvbWlzZU9wZXJhdGlvbnMuanM6CisgICAg ICAgIChnbG9iYWxQcml2YXRlLm5ld1Byb21pc2VDYXBhYmlsaXR5U2xvdyk6CisKIDIwMjAtMDUt MTIgIFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByZXZlcnRpbmcgcjI2MTU0Mi4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWls dGlucy9BcnJheUNvbnN0cnVjdG9yLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9idWlsdGlucy9BcnJheUNvbnN0cnVjdG9yLmpzCShyZXZpc2lvbiAyNjE1NTYpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlDb25zdHJ1Y3Rvci5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMjgsNyArMjgsNyBAQCBmdW5jdGlvbiBvZigvKiBpdGVtcy4uLiAqLykKICAg ICAidXNlIHN0cmljdCI7CiAKICAgICB2YXIgbGVuZ3RoID0gYXJndW1lbnRzLmxlbmd0aDsKLSAg ICB2YXIgYXJyYXkgPSBAaXNDb25zdHJ1Y3Rvcih0aGlzKSA/IG5ldyB0aGlzKGxlbmd0aCkgOiBA bmV3QXJyYXlXaXRoU2l6ZShsZW5ndGgpOworICAgIHZhciBhcnJheSA9IHRoaXMgIT09IEBBcnJh eSAmJiBAaXNDb25zdHJ1Y3Rvcih0aGlzKSA/IG5ldyB0aGlzKGxlbmd0aCkgOiBAbmV3QXJyYXlX aXRoU2l6ZShsZW5ndGgpOwogICAgIGZvciAodmFyIGsgPSAwOyBrIDwgbGVuZ3RoOyArK2spCiAg ICAgICAgIEBwdXRCeVZhbERpcmVjdChhcnJheSwgaywgYXJndW1lbnRzW2tdKTsKICAgICBhcnJh eS5sZW5ndGggPSBsZW5ndGg7CkBAIC0zOSw4ICszOSw2IEBAIGZ1bmN0aW9uIGZyb20oaXRlbXMg LyosIG1hcEZuLCB0aGlzQXJnICoKIHsKICAgICAidXNlIHN0cmljdCI7CiAKLSAgICB2YXIgdGhp c09iaiA9IHRoaXM7Ci0KICAgICB2YXIgbWFwRm4gPSBAYXJndW1lbnQoMSk7CiAKICAgICB2YXIg dGhpc0FyZzsKQEAgLTU5LDcgKzU3LDcgQEAgZnVuY3Rpb24gZnJvbShpdGVtcyAvKiwgbWFwRm4s IHRoaXNBcmcgKgogICAgICAgICBpZiAodHlwZW9mIGl0ZXJhdG9yTWV0aG9kICE9PSAiZnVuY3Rp b24iKQogICAgICAgICAgICAgQHRocm93VHlwZUVycm9yKCJBcnJheS5mcm9tIHJlcXVpcmVzIHRo YXQgdGhlIHByb3BlcnR5IG9mIHRoZSBmaXJzdCBhcmd1bWVudCwgaXRlbXNbU3ltYm9sLml0ZXJh dG9yXSwgd2hlbiBleGlzdHMsIGJlIGEgZnVuY3Rpb24iKTsKIAotICAgICAgICB2YXIgcmVzdWx0 ID0gQGlzQ29uc3RydWN0b3IodGhpc09iaikgPyBuZXcgdGhpc09iaigpIDogW107CisgICAgICAg IHZhciByZXN1bHQgPSB0aGlzICE9PSBAQXJyYXkgJiYgQGlzQ29uc3RydWN0b3IodGhpcykgPyBu ZXcgdGhpcygpIDogW107CiAKICAgICAgICAgdmFyIGsgPSAwOwogICAgICAgICB2YXIgaXRlcmF0 b3IgPSBpdGVyYXRvck1ldGhvZC5AY2FsbChpdGVtcyk7CkBAIC04NCw3ICs4Miw3IEBAIGZ1bmN0 aW9uIGZyb20oaXRlbXMgLyosIG1hcEZuLCB0aGlzQXJnICoKIAogICAgIHZhciBhcnJheUxpa2VM ZW5ndGggPSBAdG9MZW5ndGgoYXJyYXlMaWtlLmxlbmd0aCk7CiAKLSAgICB2YXIgcmVzdWx0ID0g QGlzQ29uc3RydWN0b3IodGhpc09iaikgPyBuZXcgdGhpc09iaihhcnJheUxpa2VMZW5ndGgpIDog QG5ld0FycmF5V2l0aFNpemUoYXJyYXlMaWtlTGVuZ3RoKTsKKyAgICB2YXIgcmVzdWx0ID0gdGhp cyAhPT0gQEFycmF5ICYmIEBpc0NvbnN0cnVjdG9yKHRoaXMpID8gbmV3IHRoaXMoYXJyYXlMaWtl TGVuZ3RoKSA6IEBuZXdBcnJheVdpdGhTaXplKGFycmF5TGlrZUxlbmd0aCk7CiAKICAgICB2YXIg ayA9IDA7CiAgICAgd2hpbGUgKGsgPCBhcnJheUxpa2VMZW5ndGgpIHsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9idWlsdGlucy9Qcm9taXNlT3BlcmF0aW9ucy5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUHJvbWlzZU9wZXJhdGlvbnMuanMJKHJl dmlzaW9uIDI2MTU1NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9Qcm9taXNl T3BlcmF0aW9ucy5qcwkod29ya2luZyBjb3B5KQpAQCAtNDgsOSArNDgsNiBAQCBmdW5jdGlvbiBu ZXdQcm9taXNlQ2FwYWJpbGl0eVNsb3coY29uc3RyCiAgICAgICAgIEBwcm9taXNlOiBAdW5kZWZp bmVkLAogICAgIH07CiAKLSAgICBpZiAoIUBpc0NvbnN0cnVjdG9yKGNvbnN0cnVjdG9yKSkKLSAg ICAgICAgQHRocm93VHlwZUVycm9yKCJwcm9taXNlIGNhcGFiaWxpdHkgcmVxdWlyZXMgYSBjb25z dHJ1Y3RvciBmdW5jdGlvbiIpOwotCiAgICAgdmFyIHByb21pc2UgPSBuZXcgY29uc3RydWN0b3Io ZnVuY3Rpb24gKHJlc29sdmUsIHJlamVjdCkgewogICAgICAgICBpZiAocHJvbWlzZUNhcGFiaWxp dHkuQHJlc29sdmUgIT09IEB1bmRlZmluZWQpCiAgICAgICAgICAgICBAdGhyb3dUeXBlRXJyb3Io InJlc29sdmUgZnVuY3Rpb24gaXMgYWxyZWFkeSBzZXQiKTsK