211803 2020-05-12 13:50:46 -0700 REGRESSION(r258314): 5% regression on Membuster5 2020-05-12 17:16:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble benjamin cdumez cmarcelo darin eric.carlson ews-watchlist jonlee mjs webkit-bug-importer oldest_to_newest 1651911 0 jer.noble 2020-05-12 13:50:46 -0700 REGRESSION(r258314): 5% regression on Membuster5 1651912 1 jer.noble 2020-05-12 13:53:29 -0700 <rdar://problem/60609824> 1651914 2 webkit-bug-importer 2020-05-12 13:53:40 -0700 <rdar://problem/63152408> 1651918 3 399172 jer.noble 2020-05-12 13:54:09 -0700 Created attachment 399172 Patch 1651934 4 399172 darin 2020-05-12 14:11:03 -0700 Comment on attachment 399172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399172&action=review > Source/WTF/ChangeLog:9 > + Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark. OK. I will note that doing this makes it sound like this is really USE(AVSAMPLEBUFFERVIDEOOUTPUT). 1651983 5 jer.noble 2020-05-12 15:37:15 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 399172 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399172&action=review > > > Source/WTF/ChangeLog:9 > > + Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark. > > OK. I will note that doing this makes it sound like this is really > USE(AVSAMPLEBUFFERVIDEOOUTPUT). Yep. We should probably distinguish between HAVE and USE (by just using to USE). 1652005 6 jer.noble 2020-05-12 16:05:34 -0700 <rdar://problem/60609824> 1652042 7 ews-feeder 2020-05-12 17:16:31 -0700 Committed r261590: <https://trac.webkit.org/changeset/261590> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399172. 399172 2020-05-12 13:54:09 -0700 2020-05-12 17:16:31 -0700 Patch bug-211803-20200512135408.patch text/plain 1299 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA0YzgxNzg0ZTgwZjgwZGMzOWE3ODg5 ZGQ3MTc5Y2JkOGY3ZjI1NGIuLjk3NTczZWJhZmE1ZDEzNmMxNGZkYjlmZGYxMDFlYjFjMjA0OWU5 ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDUtMTIgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU4MzE0KTogNSUgcmVncmVzc2lv biBvbiBNZW1idXN0ZXI1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTE4MDMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYwNjA5ODI0PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgSEFWRShB VlNBTVBMRUJVRkZFUlZJREVPT1VUUFVUKSwgYXMgaXQgY2F1c2VkIGEgbGFyZ2UgcmVncmVzc2lv biBpbiBvdXIgTWVtYnVzdGVyNSBiZW5jaG1hcmsuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1I YXZlLmg6CisKIDIwMjAtMDUtMTEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIEZpeCBwcm9ibGVtcyBjYXVnaHQgYnkgcmVwbGFjaW5nIFdURjo6T3B0aW9uYWwgd2l0 aCBzdGQ6Om9wdGlvbmFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUu aCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCmluZGV4IDYwZTk4ZDBlZTgyZWI3Mzhl N2IxMWRiMGZkNmU3YzYxYmM5MDk5ZWIuLjI5MTBlZmQzZWI5NWNjMTU1NGVlZDNjZmQ3OWEzNjBh NWIzNjE1MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCkBAIC01NTQsNyArNTU0LDYgQEAKIAogI2lm IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAx NjAwKSB8fCAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTQwMDAwKQogI2RlZmluZSBIQVZFX1dFQlAgMQotI2RlZmluZSBIQVZFX0FW U0FNUExFQlVGRkVSVklERU9PVVRQVVQgMQogI2VuZGlmCiAKICNpZiAoUExBVEZPUk0oTUFDKSAm JiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTYwMCkK